Re: [linux-sunxi] [PATCH 01/11] arm64: allwinner: a64: enable RSB on A64

[Chen-Yu Tsai]

On Wed, Apr 5, 2017 at 2:01 AM, Icenowy Zheng  wrote:
> Allwinner A64 have a RSB controller like the one on A23/A33 SoCs.
>
> Add it and its pinmux.
>
> Signed-off-by: Icenowy Zheng 
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 6bc606b4d74d..9a75b1c7c91a 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -420,6 +420,27 @@
> #gpio-cells = <3>;
> interrupt-controller;
> #interrupt-cells = <3>;
> +
> +   r_rsb_pins: rsb@0 {
> +   pins = "PL0", "PL1";
> +   function = "s_rsb";
> +   drive-strength = <20>;

We don't need this. The hardware default should be enough.

> +   bias-pull-up;

Boards should have external pull-ups for these pins, as the PMICs
start up in I2C mode. If any board actually doesn't have them and
needs the internal pull-ups, they should be set at the board level.

Otherwise,

Acked-by: Chen-Yu Tsai 

> +   };
> +   };
> +
> +   r_rsb: rsb@1f03400 {
> +   compatible = "allwinner,sun8i-a23-rsb";
> +   reg = <0x01f03400 0x400>;
> +   interrupts = ;
> +   clocks = <_ccu 6>;
> +   clock-frequency = <300>;
> +   resets = <_ccu 2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_rsb_pins>;
> +   status = "disabled";
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> };
> };
>  };
> --
> 2.12.2
>
> --
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH 01/11] arm64: allwinner: a64: enable RSB on A64

[Chen-Yu Tsai]

On Wed, Apr 5, 2017 at 2:01 AM, Icenowy Zheng  wrote:
> Allwinner A64 have a RSB controller like the one on A23/A33 SoCs.
>
> Add it and its pinmux.
>
> Signed-off-by: Icenowy Zheng 
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 6bc606b4d74d..9a75b1c7c91a 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -420,6 +420,27 @@
> #gpio-cells = <3>;
> interrupt-controller;
> #interrupt-cells = <3>;
> +
> +   r_rsb_pins: rsb@0 {
> +   pins = "PL0", "PL1";
> +   function = "s_rsb";
> +   drive-strength = <20>;

We don't need this. The hardware default should be enough.

> +   bias-pull-up;

Boards should have external pull-ups for these pins, as the PMICs
start up in I2C mode. If any board actually doesn't have them and
needs the internal pull-ups, they should be set at the board level.

Otherwise,

Acked-by: Chen-Yu Tsai 

> +   };
> +   };
> +
> +   r_rsb: rsb@1f03400 {
> +   compatible = "allwinner,sun8i-a23-rsb";
> +   reg = <0x01f03400 0x400>;
> +   interrupts = ;
> +   clocks = <_ccu 6>;
> +   clock-frequency = <300>;
> +   resets = <_ccu 2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_rsb_pins>;
> +   status = "disabled";
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> };
> };
>  };
> --
> 2.12.2
>
> --
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.