Re: [linux-sunxi] Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC
On Wed, Jan 11, 2017 at 11:56:32AM +0800, Icenowy Zheng wrote: > > 2017年1月11日 02:21于 Maxime Ripard写道: > > > > On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote: > > > + uart0_pins_a: uart0@0 { > > > + pins = "PB8", "PB9"; > > > + function = "uart0"; > > > + bias-pull-up; > > > > Why do you need a pullup here? > > I think TX needs one, but RX do not need. That's (at best) board specific. So it belongs in the DTS if it's truely needed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [linux-sunxi] Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC
On Wed, Jan 11, 2017 at 11:56:32AM +0800, Icenowy Zheng wrote: > > 2017年1月11日 02:21于 Maxime Ripard 写道: > > > > On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote: > > > + uart0_pins_a: uart0@0 { > > > + pins = "PB8", "PB9"; > > > + function = "uart0"; > > > + bias-pull-up; > > > > Why do you need a pullup here? > > I think TX needs one, but RX do not need. That's (at best) board specific. So it belongs in the DTS if it's truely needed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature