Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On Tue, Jun 18, 2013 at 11:34 PM, Eric Dumazet wrote: > On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: >> Since we've reduce the size of tun_struct and use flex array to allocate >> netdev >> queues, it's safe for us to increase the limit of queues in tuntap. > > Its already safe to increase max queues to 16, without your patches 1 & > 2 How about 32? Will kmem size be an issue? As others have pointed out it's best to allocate one queue per CPU (virtual or real) and > 16 CPU machines are very common. (I only asked for 16 initially out of concern for kmem size.) Thanks, Jerry > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On 06/19/2013 02:34 PM, Eric Dumazet wrote: > On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: >> Since we've reduce the size of tun_struct and use flex array to allocate >> netdev >> queues, it's safe for us to increase the limit of queues in tuntap. > Its already safe to increase max queues to 16, without your patches 1 & > 2 > > > Will send a single patch to increase it to 16. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: > Since we've reduce the size of tun_struct and use flex array to allocate > netdev > queues, it's safe for us to increase the limit of queues in tuntap. Its already safe to increase max queues to 16, without your patches 1 & 2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: Since we've reduce the size of tun_struct and use flex array to allocate netdev queues, it's safe for us to increase the limit of queues in tuntap. Its already safe to increase max queues to 16, without your patches 1 2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On 06/19/2013 02:34 PM, Eric Dumazet wrote: On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: Since we've reduce the size of tun_struct and use flex array to allocate netdev queues, it's safe for us to increase the limit of queues in tuntap. Its already safe to increase max queues to 16, without your patches 1 2 Will send a single patch to increase it to 16. Thanks -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [net-next rfc 3/3] tuntap: increase the max queues to 16
On Tue, Jun 18, 2013 at 11:34 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2013-06-19 at 13:40 +0800, Jason Wang wrote: Since we've reduce the size of tun_struct and use flex array to allocate netdev queues, it's safe for us to increase the limit of queues in tuntap. Its already safe to increase max queues to 16, without your patches 1 2 How about 32? Will kmem size be an issue? As others have pointed out it's best to allocate one queue per CPU (virtual or real) and 16 CPU machines are very common. (I only asked for 16 initially out of concern for kmem size.) Thanks, Jerry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
