Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
Hi, On Wed, 7 Feb 2007, Andrew Morton wrote: > I'm sitting on these: > > search-a-little-harder-for-mkimage.patch > make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch > add-mailmap-for-proper-git-shortlog-output.patch > qconf-immediately-update-integer-and-string-values-in-xconfig-display-take-2.patch > qconf-relocate-search-command.patch > qconf-fix-showing-help-info-on-failed-search.patch > qconf-back-button-behaviour-normalization.patch > kbuild-remove-references-to-deprecated-prepare-all-target.patch > new-toplevel-target-headers_check_all.patch > > But I'm not sure that anyone has reviewed them much. Patches look fine and most of the kconfig related patches are already the result of a review. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
On Wed, Feb 07, 2007 at 03:52:54PM -0800, Linus Torvalds wrote: > > > On Thu, 8 Feb 2007, Roman Zippel wrote: > > > > Sorry, it needs more changes, the patch simply wasn't ready. > > One problem I find very problematic with all the Kbuild setup is that > people tend to be very quiet about any build issues until they simply go > in. > > Things don't "get ready" on their own. In other areas, people comment on > why they don't like patches. In Kbuild, for some reason, we often seem to > have this situation where people don't react at all. > > Sam is great about maintaining the kernel build stuff most of the time, > but because it's clearly a "secondary" thing, there tends to be some > periods when nothing happens. Which is problematic for me.. Sorry about my silence for now three months. Been overly busy and with family now extended to three kids takes time too. I will be back in a months time - maybe a bit sooner. As for the Kbuild area I usual have patches cooking in -mm for a while before pushing to you - comments are usual few when I post patches which I take as a sign that most people do not care about Kbuild as long as it works, other are not into the makefile trickery, and also that the patches are small logical steps (which is true for all contributions and not just mine). Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
On Wed, 7 Feb 2007 15:52:54 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Thu, 8 Feb 2007, Roman Zippel wrote: > > > > Sorry, it needs more changes, the patch simply wasn't ready. > > One problem I find very problematic with all the Kbuild setup is that > people tend to be very quiet about any build issues until they simply go > in. > > Things don't "get ready" on their own. In other areas, people comment on > why they don't like patches. In Kbuild, for some reason, we often seem to > have this situation where people don't react at all. > > Sam is great about maintaining the kernel build stuff most of the time, > but because it's clearly a "secondary" thing, there tends to be some > periods when nothing happens. Which is problematic for me.. > > So I end up in a situation where I just basically will apply the patches > just becauseif I don't, nothing ever happens. The good news is that _once_ > I apply them, people will usually notice problems and send in fixes fairly > quickly. But this particular email was NOT useful, for example. "needs > more changes" is the epitome of a "not useful" comment. Yes, kbuild is a bit of a problem at present. I'm sitting on these: search-a-little-harder-for-mkimage.patch make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch add-mailmap-for-proper-git-shortlog-output.patch qconf-immediately-update-integer-and-string-values-in-xconfig-display-take-2.patch qconf-relocate-search-command.patch qconf-fix-showing-help-info-on-failed-search.patch qconf-back-button-behaviour-normalization.patch kbuild-remove-references-to-deprecated-prepare-all-target.patch new-toplevel-target-headers_check_all.patch But I'm not sure that anyone has reviewed them much. I'll probably just push 'em and see what happens. They seem to work. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
Hi, On Wed, 7 Feb 2007, Linus Torvalds wrote: > So I end up in a situation where I just basically will apply the patches > just becauseif I don't, nothing ever happens. The good news is that _once_ > I apply them, people will usually notice problems and send in fixes fairly > quickly. But this particular email was NOT useful, for example. "needs > more changes" is the epitome of a "not useful" comment. The patch was already in -mm and being worked on... > In the meantime, I've applied the fixup patch. And more specific problem > reports or patches are welcome. _Please_ revert completely and wait for Andrew to send it via -mm, when it's ready. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
Hi, On Wed, 7 Feb 2007, Randy Dunlap wrote: > > > > Linus, please revert. Thanks. > > > > > > Roman, while it went so fast to Linus, i didn't expect that, let me > > > try to fix all this with this little patch. > > > > Sorry, it needs more changes, the patch simply wasn't ready. > > Can you be more explicit? and then it should get some time > in -mm, hopefully. I did already. It needs to be splitted, lose the symlink stuff and be more careful with whitespace. It probably could use a better name than checker-shell, e.g. autoconf calls this TRY_RUN, so something like this. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
On Thu, 8 Feb 2007, Roman Zippel wrote: > > Sorry, it needs more changes, the patch simply wasn't ready. One problem I find very problematic with all the Kbuild setup is that people tend to be very quiet about any build issues until they simply go in. Things don't "get ready" on their own. In other areas, people comment on why they don't like patches. In Kbuild, for some reason, we often seem to have this situation where people don't react at all. Sam is great about maintaining the kernel build stuff most of the time, but because it's clearly a "secondary" thing, there tends to be some periods when nothing happens. Which is problematic for me.. So I end up in a situation where I just basically will apply the patches just becauseif I don't, nothing ever happens. The good news is that _once_ I apply them, people will usually notice problems and send in fixes fairly quickly. But this particular email was NOT useful, for example. "needs more changes" is the epitome of a "not useful" comment. I notice that Kai should probably have been Cc'd, and quite possibly wasn't. So I added him now. In the meantime, I've applied the fixup patch. And more specific problem reports or patches are welcome. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
On Thu, 8 Feb 2007 00:34:50 +0100 (CET) Roman Zippel wrote: > Hi, > > On Wed, 7 Feb 2007, Oleg Verych wrote: > > > > Linus, please revert. Thanks. > > > > Roman, while it went so fast to Linus, i didn't expect that, let me > > try to fix all this with this little patch. > > Sorry, it needs more changes, the patch simply wasn't ready. Can you be more explicit? and then it should get some time in -mm, hopefully. Thanks, --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments
Hi, On Wed, 7 Feb 2007, Oleg Verych wrote: > > Linus, please revert. Thanks. > > Roman, while it went so fast to Linus, i didn't expect that, let me > try to fix all this with this little patch. Sorry, it needs more changes, the patch simply wasn't ready. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
