Re: [patch] raid6: generate raid6tables.c with proper style

[H. Peter Anvin]

Ingo Molnar wrote:

* Simon Holm Thøgersen <[EMAIL PROTECTED]> wrote:


fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <[EMAIL PROTECTED]>

[snip]


Index: linux/drivers/md/mktables.c
===
--- linux.orig/drivers/md/mktables.c
+++ linux/drivers/md/mktables.c
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
 for ( j = 0 ; j < 256 ; j += 8 ) {
   printf("\t\t");
   for ( k = 0 ; k < 8 ; k++ ) {
-   printf("0x%02x, ", gfmul(i,j+k));
+if (k)
+ printf(" ");
+   printf("0x%02x,", gfmul(i,j+k));

What happened with the coding style here?


i adopted to the existing (broken) one. Yes, mktables.c could need a 
good cleanup too.




More so than the output, IMNSHO.  I'll take care of it.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] raid6: generate raid6tables.c with proper style

[Ingo Molnar]

* Simon Holm Thøgersen <[EMAIL PROTECTED]> wrote:

> fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:
> > Subject: raid6: generate raid6tables.c with proper style
> > From: Ingo Molnar <[EMAIL PROTECTED]>
> 
> [snip]
> 
> > Index: linux/drivers/md/mktables.c
> > ===
> > --- linux.orig/drivers/md/mktables.c
> > +++ linux/drivers/md/mktables.c
> > @@ -69,7 +69,9 @@ int main(int argc, char *argv[])
> >  for ( j = 0 ; j < 256 ; j += 8 ) {
> >printf("\t\t");
> >for ( k = 0 ; k < 8 ; k++ ) {
> > -   printf("0x%02x, ", gfmul(i,j+k));
> > +if (k)
> > + printf(" ");
> > +   printf("0x%02x,", gfmul(i,j+k));
> 
> What happened with the coding style here?

i adopted to the existing (broken) one. Yes, mktables.c could need a 
good cleanup too.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch] raid6: generate raid6tables.c with proper style

[Simon Holm Thøgersen]

fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:
> Subject: raid6: generate raid6tables.c with proper style
> From: Ingo Molnar <[EMAIL PROTECTED]>

[snip]

> Index: linux/drivers/md/mktables.c
> ===
> --- linux.orig/drivers/md/mktables.c
> +++ linux/drivers/md/mktables.c
> @@ -69,7 +69,9 @@ int main(int argc, char *argv[])
>  for ( j = 0 ; j < 256 ; j += 8 ) {
>printf("\t\t");
>for ( k = 0 ; k < 8 ; k++ ) {
> - printf("0x%02x, ", gfmul(i,j+k));
> +if (k)
> +   printf(" ");
> + printf("0x%02x,", gfmul(i,j+k));

What happened with the coding style here?


Simon Holm Thøgersen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/