Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: > This is my commit message for the revert - note the suggested possible > fix (but also why I didn't apply it, and why things got reverted). > > Linus > --- > commit 279e1dab949d33737557babfe9f74e0b74fbe39a > Author: Linus Torvalds <[EMAIL PROTECTED]> > Date: Thu Nov 15 08:44:36 2007 -0800 > > Revert "skge: fix ram buffer size calculation" > > This reverts commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32. > > Heikki Orsila reports that it causes a regression: > > "Doing > > nc host port < /dev/zero > >on a sending machine (not skge) to an skge machine that is receiving: > > nc -l -p port >/dev/null > >with ~60 MiB/s speed, causes the interface go malfunct. A slow >transfer doesn't cause a problem." > > See > > http://bugzilla.kernel.org/show_bug.cgi?id=9321 > > for some more information. > > There is a workaround (also reported by Heikki): > > "After some fiddling, I noticed that not changing the register write >order on patch: > >+ skge_write32(hw, RB_ADDR(q, RB_END), end); >skge_write32(hw, RB_ADDR(q, RB_WP), start); >skge_write32(hw, RB_ADDR(q, RB_RP), start); >- skge_write32(hw, RB_ADDR(q, RB_END), end); > >fixes the visible effect.. Possibly not the root cause of the >problem, but changing the order back fixes networking here." > > but that has yet to be ack'ed or tested more widely, so the whole > problem-causing commit gets reverted until this is resolved properly. > > Bisected-and-requested-by: Heikki Orsila <[EMAIL PROTECTED]> > Cc: Stephen Hemminger <[EMAIL PROTECTED]> > Cc: Jeff Garzik <[EMAIL PROTECTED]> > Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]> > > drivers/net/skge.c | 51 +++ > 1 files changed, 27 insertions(+), 24 deletions(-) Thanks. I pulled commit 8c0863403f109a43d7000b4646da4818220d501f and now the skge driver works here. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: This is my commit message for the revert - note the suggested possible fix (but also why I didn't apply it, and why things got reverted). Linus --- commit 279e1dab949d33737557babfe9f74e0b74fbe39a Author: Linus Torvalds [EMAIL PROTECTED] Date: Thu Nov 15 08:44:36 2007 -0800 Revert skge: fix ram buffer size calculation This reverts commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32. Heikki Orsila reports that it causes a regression: Doing nc host port /dev/zero on a sending machine (not skge) to an skge machine that is receiving: nc -l -p port /dev/null with ~60 MiB/s speed, causes the interface go malfunct. A slow transfer doesn't cause a problem. See http://bugzilla.kernel.org/show_bug.cgi?id=9321 for some more information. There is a workaround (also reported by Heikki): After some fiddling, I noticed that not changing the register write order on patch: + skge_write32(hw, RB_ADDR(q, RB_END), end); skge_write32(hw, RB_ADDR(q, RB_WP), start); skge_write32(hw, RB_ADDR(q, RB_RP), start); - skge_write32(hw, RB_ADDR(q, RB_END), end); fixes the visible effect.. Possibly not the root cause of the problem, but changing the order back fixes networking here. but that has yet to be ack'ed or tested more widely, so the whole problem-causing commit gets reverted until this is resolved properly. Bisected-and-requested-by: Heikki Orsila [EMAIL PROTECTED] Cc: Stephen Hemminger [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Linus Torvalds [EMAIL PROTECTED] drivers/net/skge.c | 51 +++ 1 files changed, 27 insertions(+), 24 deletions(-) Thanks. I pulled commit 8c0863403f109a43d7000b4646da4818220d501f and now the skge driver works here. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] Math is hard, let's go shopping! http://www.iki.fi/shd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:27:25AM -0800, Stephen Hemminger wrote: > I can't reproduce the users problem with the hardware I have. And > without the patch the dual > port board doesn't work. So it is a question of regression, versus > fixing pre-existing bugs. > I am okay with reverting the patch, as a temporary state, but concerned > with how > to make progress in fixing this. I can reproduce the bug in a second. I will test any version you send me. I take it you have tested the driver on gigabit ethernet by sending zero from one netcat to another (the sending machine being something, and the receiving machine being skge)? The only thing that needed to be done for the last 6 patches in the mainline was reversing the order of two register writes, meaning that the dual port stuff need not be thrown away. This was explained in my bug report (that was hard to read). I'm not suggesting this is a proper fix. In fact, I think it's not, because we can not explain the problem. It would _very_ nice to get to the bottom of this issue, so I would favor reverting the patch and trying and debugging carefully before creating quick and dirty fixes.. Thank you all.. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: > > > On Thu, 15 Nov 2007, Greg KH wrote: > > > On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > > > > > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > > > > > This one is getting reverted in mainline in about five minutes (unless I > > > find an email from Stephen to address the reported regression - I haven't > > > gone through all my emails yet), so I don't think it should make it into > > > stable. > > > > Thanks for letting me know which patch is causing the problem, I just > > got another report of the skge driver not working with all of these > > patches applied. > > I suspect that's the same report. > > > It looks like I'll just drop this one from the patch list, unless > > Stephen has a better idea. > > This is my commit message for the revert - note the suggested possible > fix (but also why I didn't apply it, and why things got reverted). Ok, I've now dropped this patch from the stable queue. Stephen, if you get something that works, and is in Linus's tree, feel free to resend it to [EMAIL PROTECTED] thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, 15 Nov 2007, Stephen Hemminger wrote: > > I can't reproduce the users problem with the hardware I have. And > without the patch the dual port board doesn't work. So it is a question > of regression, versus fixing pre-existing bugs. Yeah. Five years ago I might have said that it's important to fix pre-existing bugs, but all the ACPI and suspend etc problems have long since convinced me that regressions are *much* more important than stuff that never worked. > I am okay with reverting the patch, as a temporary state, but concerned > with how to make progress in fixing this. Well, the original bug-report did contain a suggested workaround too. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, 15 Nov 2007, Greg KH wrote: > On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > > > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > > > This one is getting reverted in mainline in about five minutes (unless I > > find an email from Stephen to address the reported regression - I haven't > > gone through all my emails yet), so I don't think it should make it into > > stable. > > Thanks for letting me know which patch is causing the problem, I just > got another report of the skge driver not working with all of these > patches applied. I suspect that's the same report. > It looks like I'll just drop this one from the patch list, unless > Stephen has a better idea. This is my commit message for the revert - note the suggested possible fix (but also why I didn't apply it, and why things got reverted). Linus --- commit 279e1dab949d33737557babfe9f74e0b74fbe39a Author: Linus Torvalds <[EMAIL PROTECTED]> Date: Thu Nov 15 08:44:36 2007 -0800 Revert "skge: fix ram buffer size calculation" This reverts commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32. Heikki Orsila reports that it causes a regression: "Doing nc host port < /dev/zero on a sending machine (not skge) to an skge machine that is receiving: nc -l -p port >/dev/null with ~60 MiB/s speed, causes the interface go malfunct. A slow transfer doesn't cause a problem." See http://bugzilla.kernel.org/show_bug.cgi?id=9321 for some more information. There is a workaround (also reported by Heikki): "After some fiddling, I noticed that not changing the register write order on patch: + skge_write32(hw, RB_ADDR(q, RB_END), end); skge_write32(hw, RB_ADDR(q, RB_WP), start); skge_write32(hw, RB_ADDR(q, RB_RP), start); - skge_write32(hw, RB_ADDR(q, RB_END), end); fixes the visible effect.. Possibly not the root cause of the problem, but changing the order back fixes networking here." but that has yet to be ack'ed or tested more widely, so the whole problem-causing commit gets reverted until this is resolved properly. Bisected-and-requested-by: Heikki Orsila <[EMAIL PROTECTED]> Cc: Stephen Hemminger <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]> drivers/net/skge.c | 51 +++ 1 files changed, 27 insertions(+), 24 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > On Wed, 14 Nov 2007, Greg KH wrote: > > > > -stable review patch. If anyone has any objections, please let us know. > > > > -- > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > > > This fixes problems with transmit hangs on older fiber based SysKonnect > > boards. > > > > Adjust ram buffer sizing calculation to make it correct on all boards > > and make it like the code in sky2 driver. > > This one is getting reverted in mainline in about five minutes (unless I > find an email from Stephen to address the reported regression - I haven't > gone through all my emails yet), so I don't think it should make it into > stable. Thanks for letting me know which patch is causing the problem, I just got another report of the skge driver not working with all of these patches applied. It looks like I'll just drop this one from the patch list, unless Stephen has a better idea. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger <[EMAIL PROTECTED]> patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit hangs on older fiber based SysKonnect boards. Adjust ram buffer sizing calculation to make it correct on all boards and make it like the code in sky2 driver. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Linus I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. I am okay with reverting the patch, as a temporary state, but concerned with how to make progress in fixing this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Wed, 14 Nov 2007, Greg KH wrote: > > -stable review patch. If anyone has any objections, please let us know. > > -- > From: Stephen Hemminger <[EMAIL PROTECTED]> > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > This fixes problems with transmit hangs on older fiber based SysKonnect > boards. > > Adjust ram buffer sizing calculation to make it correct on all boards > and make it like the code in sky2 driver. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, 15 Nov 2007, Greg KH wrote: On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Thanks for letting me know which patch is causing the problem, I just got another report of the skge driver not working with all of these patches applied. I suspect that's the same report. It looks like I'll just drop this one from the patch list, unless Stephen has a better idea. This is my commit message for the revert - note the suggested possible fix (but also why I didn't apply it, and why things got reverted). Linus --- commit 279e1dab949d33737557babfe9f74e0b74fbe39a Author: Linus Torvalds [EMAIL PROTECTED] Date: Thu Nov 15 08:44:36 2007 -0800 Revert skge: fix ram buffer size calculation This reverts commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32. Heikki Orsila reports that it causes a regression: Doing nc host port /dev/zero on a sending machine (not skge) to an skge machine that is receiving: nc -l -p port /dev/null with ~60 MiB/s speed, causes the interface go malfunct. A slow transfer doesn't cause a problem. See http://bugzilla.kernel.org/show_bug.cgi?id=9321 for some more information. There is a workaround (also reported by Heikki): After some fiddling, I noticed that not changing the register write order on patch: + skge_write32(hw, RB_ADDR(q, RB_END), end); skge_write32(hw, RB_ADDR(q, RB_WP), start); skge_write32(hw, RB_ADDR(q, RB_RP), start); - skge_write32(hw, RB_ADDR(q, RB_END), end); fixes the visible effect.. Possibly not the root cause of the problem, but changing the order back fixes networking here. but that has yet to be ack'ed or tested more widely, so the whole problem-causing commit gets reverted until this is resolved properly. Bisected-and-requested-by: Heikki Orsila [EMAIL PROTECTED] Cc: Stephen Hemminger [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Linus Torvalds [EMAIL PROTECTED] drivers/net/skge.c | 51 +++ 1 files changed, 27 insertions(+), 24 deletions(-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit hangs on older fiber based SysKonnect boards. Adjust ram buffer sizing calculation to make it correct on all boards and make it like the code in sky2 driver. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Linus I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. I am okay with reverting the patch, as a temporary state, but concerned with how to make progress in fixing this. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit hangs on older fiber based SysKonnect boards. Adjust ram buffer sizing calculation to make it correct on all boards and make it like the code in sky2 driver. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Linus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit hangs on older fiber based SysKonnect boards. Adjust ram buffer sizing calculation to make it correct on all boards and make it like the code in sky2 driver. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Thanks for letting me know which patch is causing the problem, I just got another report of the skge driver not working with all of these patches applied. It looks like I'll just drop this one from the patch list, unless Stephen has a better idea. thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, 15 Nov 2007, Stephen Hemminger wrote: I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. Yeah. Five years ago I might have said that it's important to fix pre-existing bugs, but all the ACPI and suspend etc problems have long since convinced me that regressions are *much* more important than stuff that never worked. I am okay with reverting the patch, as a temporary state, but concerned with how to make progress in fixing this. Well, the original bug-report did contain a suggested workaround too. Linus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: On Thu, 15 Nov 2007, Greg KH wrote: On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the reported regression - I haven't gone through all my emails yet), so I don't think it should make it into stable. Thanks for letting me know which patch is causing the problem, I just got another report of the skge driver not working with all of these patches applied. I suspect that's the same report. It looks like I'll just drop this one from the patch list, unless Stephen has a better idea. This is my commit message for the revert - note the suggested possible fix (but also why I didn't apply it, and why things got reverted). Ok, I've now dropped this patch from the stable queue. Stephen, if you get something that works, and is in Linus's tree, feel free to resend it to [EMAIL PROTECTED] thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 08/16] skge: fix ram buffer size calculation
On Thu, Nov 15, 2007 at 08:27:25AM -0800, Stephen Hemminger wrote: I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. I am okay with reverting the patch, as a temporary state, but concerned with how to make progress in fixing this. I can reproduce the bug in a second. I will test any version you send me. I take it you have tested the driver on gigabit ethernet by sending zero from one netcat to another (the sending machine being something, and the receiving machine being skge)? The only thing that needed to be done for the last 6 patches in the mainline was reversing the order of two register writes, meaning that the dual port stuff need not be thrown away. This was explained in my bug report (that was hard to read). I'm not suggesting this is a proper fix. In fact, I think it's not, because we can not explain the problem. It would _very_ nice to get to the bottom of this issue, so I would favor reverting the patch and trying and debugging carefully before creating quick and dirty fixes.. Thank you all.. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] Math is hard, let's go shopping! http://www.iki.fi/shd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
