Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Fri, Sep 28, 2012 at 01:10:33AM +0400, Cyrill Gorcunov wrote: > Since this ioctl is for pty devices only move it to pty.c. > > v2: > - drop PTY_TYPE_MASTER test since it's master peer >ioctl anyway (by jslaby@) This patch adds the compiler warning: drivers/tty/tty_ioctl.c: In function ‘n_tty_ioctl_helper’: drivers/tty/tty_ioctl.c:1121:16: warning: unused variable ‘flags’ [-Wunused-variable] Care to fix it up and resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Fri, Sep 28, 2012 at 01:10:33AM +0400, Cyrill Gorcunov wrote: Since this ioctl is for pty devices only move it to pty.c. v2: - drop PTY_TYPE_MASTER test since it's master peer ioctl anyway (by jslaby@) This patch adds the compiler warning: drivers/tty/tty_ioctl.c: In function ‘n_tty_ioctl_helper’: drivers/tty/tty_ioctl.c:1121:16: warning: unused variable ‘flags’ [-Wunused-variable] Care to fix it up and resend? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Tue, Oct 16, 2012 at 09:58:22AM +0100, Alan Cox wrote: > > Greg, Alan, what about this series? Is there anything else I should do? > > Other than resending it now the merge window is closed - I can't think of > anything. OK, thanks, I'll resend. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
> Greg, Alan, what about this series? Is there anything else I should do? Other than resending it now the merge window is closed - I can't think of anything. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Fri, Sep 28, 2012 at 01:10:33AM +0400, Cyrill Gorcunov wrote: > Since this ioctl is for pty devices only move it to pty.c. > > v2: > - drop PTY_TYPE_MASTER test since it's master peer >ioctl anyway (by jslaby@) > > Suggested-by: Alan Cox > Signed-off-by: Cyrill Gorcunov > CC: "H. Peter Anvin" > CC: Greg Kroah-Hartman > CC: Pavel Emelyanov > CC: Jiri Slaby Greg, Alan, what about this series? Is there anything else I should do? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Fri, Sep 28, 2012 at 01:10:33AM +0400, Cyrill Gorcunov wrote: Since this ioctl is for pty devices only move it to pty.c. v2: - drop PTY_TYPE_MASTER test since it's master peer ioctl anyway (by jslaby@) Suggested-by: Alan Cox a...@lxorguk.ukuu.org.uk Signed-off-by: Cyrill Gorcunov gorcu...@openvz.org CC: H. Peter Anvin h...@zytor.com CC: Greg Kroah-Hartman gre...@linuxfoundation.org CC: Pavel Emelyanov xe...@parallels.com CC: Jiri Slaby jsl...@suse.cz Greg, Alan, what about this series? Is there anything else I should do? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
Greg, Alan, what about this series? Is there anything else I should do? Other than resending it now the merge window is closed - I can't think of anything. Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 1/3] tty: pty - Move TIOCPKT handling into pty.c
On Tue, Oct 16, 2012 at 09:58:22AM +0100, Alan Cox wrote: Greg, Alan, what about this series? Is there anything else I should do? Other than resending it now the merge window is closed - I can't think of anything. OK, thanks, I'll resend. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
