Re: [v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
On Tue, May 26, 2020 at 05:24:03PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > On 2020/5/26 17:01, Markus Elfring wrote: > … Thus release specific resources before > >>> > >>> Is there a need to improve also this information another bit? > >>> > >> You mean the last two paragraph is redundant ? > > > > No. > > > > I became curious if you would like to choose a more helpful information > > according to the wording “specific resources”. > > > > Regards, > > Markus > > > Hi Markus, > > I respect your work, but please let us to focus on the code itself. I think > experts in this area know what these patches want to solve after look at the > code. > > I hope experts in the thread could review the code when you free, thanks :) Please note that you are responding to someone who is known to be a pain in patch reviews and has been blocked by many kernel developers/maintainers because they just waste people's time. I suggest you all do the same here, and just ignore them, like I do :) thanks, greg k-h
Re: [v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
> I respect your work, but please let us to focus on the code itself. I think > experts in this area know what these patches want to solve after look at the > code. I suggest to reconsider such a view. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n102 Regards, Markus
Re: [v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
On 2020/5/26 17:01, Markus Elfring wrote: … Thus release specific resources before >>> >>> Is there a need to improve also this information another bit? >>> >> You mean the last two paragraph is redundant ? > > No. > > I became curious if you would like to choose a more helpful information > according to the wording “specific resources”. > > Regards, > Markus > Hi Markus, I respect your work, but please let us to focus on the code itself. I think experts in this area know what these patches want to solve after look at the code. I hope experts in the thread could review the code when you free, thanks :) --- Regards, Longpeng(Mike)
Re: [v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
>>> … Thus release specific resources before >> >> Is there a need to improve also this information another bit? >> > You mean the last two paragraph is redundant ? No. I became curious if you would like to choose a more helpful information according to the wording “specific resources”. Regards, Markus
