Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-06 Thread Laurent Riffard
Le 06.02.2005 09:18, Peter Osterlund a écrit :
[snip]
Anyway, the problem is that the add-struct-request-end_io-callback
patch forgot to update pktcdvd.c. This patch fixes it. It should
probably be merged into the add-struct-request-end_io-callback patch,
because that patch already fixes up other struct request users.
Signed-off-by: Peter Osterlund <[EMAIL PROTECTED]>
---
 linux-petero/drivers/block/pktcdvd.c |1 +
 1 files changed, 1 insertion(+)
diff -puN drivers/block/pktcdvd.c~pktcdvd-endio-fix drivers/block/pktcdvd.c
--- linux/drivers/block/pktcdvd.c~pktcdvd-endio-fix 2005-02-06 
08:59:16.0 +0100
+++ linux-petero/drivers/block/pktcdvd.c2005-02-06 09:01:22.0 
+0100
@@ -375,6 +375,7 @@ static int pkt_generic_packet(struct pkt
rq->ref_count++;
rq->flags |= REQ_NOMERGE;
rq->waiting = 
+   rq->end_io = blk_end_sync_rq;
elv_add_request(q, rq, ELEVATOR_INSERT_BACK, 1);
generic_unplug_device(q);
wait_for_completion();
_
Ok, this patch fixed the problem. I'm able to mount the CDRW and write some 
data.
Thank you.
--
laurent


signature.asc
Description: OpenPGP digital signature


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-06 Thread Peter Osterlund
Andrew Morton <[EMAIL PROTECTED]> writes:

> Peter Osterlund <[EMAIL PROTECTED]> wrote:
> >
> > Peter Osterlund <[EMAIL PROTECTED]> writes:
> > 
> > > Laurent Riffard <[EMAIL PROTECTED]> writes:
> > > 
> > > > This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
> > > > in packet-writing mode. Mount process gets stuck in D state.
> > > > 
> > > > Mounting and writing this media in packet-writing mode works fine
> > > > with kernel 2.6.11-rc2-mm2.
> 
> > Anyway, mount hangs for me too if I use an IDE drive, both with native
> > ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
> > verified that 2.6.11-rc3 does not have this problem. Reverting
> > bk-ide-dev does *not* fix the problem.
> 
> Bah.  sysrq-T output would be helpful.

I was wrong about USB, it doesn't work either. The IDE drive failed
with a non-packet formatted disc, so I didn't bother to check what was
inserted in the USB drive. It turned out it was empty and in that case
the driver doesn't hang.

Anyway, the problem is that the add-struct-request-end_io-callback
patch forgot to update pktcdvd.c. This patch fixes it. It should
probably be merged into the add-struct-request-end_io-callback patch,
because that patch already fixes up other struct request users.

Signed-off-by: Peter Osterlund <[EMAIL PROTECTED]>
---

 linux-petero/drivers/block/pktcdvd.c |1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/block/pktcdvd.c~pktcdvd-endio-fix drivers/block/pktcdvd.c
--- linux/drivers/block/pktcdvd.c~pktcdvd-endio-fix 2005-02-06 
08:59:16.0 +0100
+++ linux-petero/drivers/block/pktcdvd.c2005-02-06 09:01:22.0 
+0100
@@ -375,6 +375,7 @@ static int pkt_generic_packet(struct pkt
rq->ref_count++;
rq->flags |= REQ_NOMERGE;
rq->waiting = 
+   rq->end_io = blk_end_sync_rq;
elv_add_request(q, rq, ELEVATOR_INSERT_BACK, 1);
generic_unplug_device(q);
wait_for_completion();
_

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-06 Thread Peter Osterlund
Andrew Morton [EMAIL PROTECTED] writes:

 Peter Osterlund [EMAIL PROTECTED] wrote:
 
  Peter Osterlund [EMAIL PROTECTED] writes:
  
   Laurent Riffard [EMAIL PROTECTED] writes:
   
This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
in packet-writing mode. Mount process gets stuck in D state.

Mounting and writing this media in packet-writing mode works fine
with kernel 2.6.11-rc2-mm2.
 
  Anyway, mount hangs for me too if I use an IDE drive, both with native
  ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
  verified that 2.6.11-rc3 does not have this problem. Reverting
  bk-ide-dev does *not* fix the problem.
 
 Bah.  sysrq-T output would be helpful.

I was wrong about USB, it doesn't work either. The IDE drive failed
with a non-packet formatted disc, so I didn't bother to check what was
inserted in the USB drive. It turned out it was empty and in that case
the driver doesn't hang.

Anyway, the problem is that the add-struct-request-end_io-callback
patch forgot to update pktcdvd.c. This patch fixes it. It should
probably be merged into the add-struct-request-end_io-callback patch,
because that patch already fixes up other struct request users.

Signed-off-by: Peter Osterlund [EMAIL PROTECTED]
---

 linux-petero/drivers/block/pktcdvd.c |1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/block/pktcdvd.c~pktcdvd-endio-fix drivers/block/pktcdvd.c
--- linux/drivers/block/pktcdvd.c~pktcdvd-endio-fix 2005-02-06 
08:59:16.0 +0100
+++ linux-petero/drivers/block/pktcdvd.c2005-02-06 09:01:22.0 
+0100
@@ -375,6 +375,7 @@ static int pkt_generic_packet(struct pkt
rq-ref_count++;
rq-flags |= REQ_NOMERGE;
rq-waiting = wait;
+   rq-end_io = blk_end_sync_rq;
elv_add_request(q, rq, ELEVATOR_INSERT_BACK, 1);
generic_unplug_device(q);
wait_for_completion(wait);
_

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-06 Thread Laurent Riffard
Le 06.02.2005 09:18, Peter Osterlund a écrit :
[snip]
Anyway, the problem is that the add-struct-request-end_io-callback
patch forgot to update pktcdvd.c. This patch fixes it. It should
probably be merged into the add-struct-request-end_io-callback patch,
because that patch already fixes up other struct request users.
Signed-off-by: Peter Osterlund [EMAIL PROTECTED]
---
 linux-petero/drivers/block/pktcdvd.c |1 +
 1 files changed, 1 insertion(+)
diff -puN drivers/block/pktcdvd.c~pktcdvd-endio-fix drivers/block/pktcdvd.c
--- linux/drivers/block/pktcdvd.c~pktcdvd-endio-fix 2005-02-06 
08:59:16.0 +0100
+++ linux-petero/drivers/block/pktcdvd.c2005-02-06 09:01:22.0 
+0100
@@ -375,6 +375,7 @@ static int pkt_generic_packet(struct pkt
rq-ref_count++;
rq-flags |= REQ_NOMERGE;
rq-waiting = wait;
+   rq-end_io = blk_end_sync_rq;
elv_add_request(q, rq, ELEVATOR_INSERT_BACK, 1);
generic_unplug_device(q);
wait_for_completion(wait);
_
Ok, this patch fixed the problem. I'm able to mount the CDRW and write some 
data.
Thank you.
--
laurent


signature.asc
Description: OpenPGP digital signature


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Andrew Morton
Peter Osterlund <[EMAIL PROTECTED]> wrote:
>
> Peter Osterlund <[EMAIL PROTECTED]> writes:
> 
> > Laurent Riffard <[EMAIL PROTECTED]> writes:
> > 
> > > This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
> > > in packet-writing mode. Mount process gets stuck in D state.
> > > 
> > > Mounting and writing this media in packet-writing mode works fine
> > > with kernel 2.6.11-rc2-mm2.
> > 
> > I tried to repeat the problem, but I didn't get far, because I get a
> > kernel panic right after init is started:
> 
> I got around that by disabling preempt, radeon framebuffer, HPET
> timer, APIC. Don't know which one caused the panic, will track it down
> later.

Please do - the above combo works for me (as usual).  I don't recall anyone
else reporting it.

> Anyway, mount hangs for me too if I use an IDE drive, both with native
> ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
> verified that 2.6.11-rc3 does not have this problem. Reverting
> bk-ide-dev does *not* fix the problem.

Bah.  sysrq-T output would be helpful.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Peter Osterlund
Peter Osterlund <[EMAIL PROTECTED]> writes:

> Laurent Riffard <[EMAIL PROTECTED]> writes:
> 
> > This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
> > in packet-writing mode. Mount process gets stuck in D state.
> > 
> > Mounting and writing this media in packet-writing mode works fine
> > with kernel 2.6.11-rc2-mm2.
> 
> I tried to repeat the problem, but I didn't get far, because I get a
> kernel panic right after init is started:

I got around that by disabling preempt, radeon framebuffer, HPET
timer, APIC. Don't know which one caused the panic, will track it down
later.

Anyway, mount hangs for me too if I use an IDE drive, both with native
ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
verified that 2.6.11-rc3 does not have this problem. Reverting
bk-ide-dev does *not* fix the problem.

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Peter Osterlund
Laurent Riffard <[EMAIL PROTECTED]> writes:

> This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
> in packet-writing mode. Mount process gets stuck in D state.
> 
> Mounting and writing this media in packet-writing mode works fine
> with kernel 2.6.11-rc2-mm2.

I tried to repeat the problem, but I didn't get far, because I get a
kernel panic right after init is started:

Unable to handle kernel NULL pointer dereference at virtual address 
...
PREEMPT
...
EIP is a strncpy_from_user+0x33/0x47
...
Call Trace:
 getname+0x69/0xa5
 sys_open+0x12/0xc6
 sysenter_past_esp+0x52/0x75
...
Kernel panic - not syncing: Attempted to kill init!

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Peter Osterlund
Laurent Riffard [EMAIL PROTECTED] writes:

 This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
 in packet-writing mode. Mount process gets stuck in D state.
 
 Mounting and writing this media in packet-writing mode works fine
 with kernel 2.6.11-rc2-mm2.

I tried to repeat the problem, but I didn't get far, because I get a
kernel panic right after init is started:

Unable to handle kernel NULL pointer dereference at virtual address 
...
PREEMPT
...
EIP is a strncpy_from_user+0x33/0x47
...
Call Trace:
 getname+0x69/0xa5
 sys_open+0x12/0xc6
 sysenter_past_esp+0x52/0x75
...
Kernel panic - not syncing: Attempted to kill init!

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Peter Osterlund
Peter Osterlund [EMAIL PROTECTED] writes:

 Laurent Riffard [EMAIL PROTECTED] writes:
 
  This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
  in packet-writing mode. Mount process gets stuck in D state.
  
  Mounting and writing this media in packet-writing mode works fine
  with kernel 2.6.11-rc2-mm2.
 
 I tried to repeat the problem, but I didn't get far, because I get a
 kernel panic right after init is started:

I got around that by disabling preempt, radeon framebuffer, HPET
timer, APIC. Don't know which one caused the panic, will track it down
later.

Anyway, mount hangs for me too if I use an IDE drive, both with native
ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
verified that 2.6.11-rc3 does not have this problem. Reverting
bk-ide-dev does *not* fix the problem.

-- 
Peter Osterlund - [EMAIL PROTECTED]
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: 2.6.11-rc3-mm1 : mount UDF CDRW stuck in D state

2005-02-05 Thread Andrew Morton
Peter Osterlund [EMAIL PROTECTED] wrote:

 Peter Osterlund [EMAIL PROTECTED] writes:
 
  Laurent Riffard [EMAIL PROTECTED] writes:
  
   This is kernel 2.6.11-rc3-mm1. I can't mount an UDF-formatted cdrw
   in packet-writing mode. Mount process gets stuck in D state.
   
   Mounting and writing this media in packet-writing mode works fine
   with kernel 2.6.11-rc2-mm2.
  
  I tried to repeat the problem, but I didn't get far, because I get a
  kernel panic right after init is started:
 
 I got around that by disabling preempt, radeon framebuffer, HPET
 timer, APIC. Don't know which one caused the panic, will track it down
 later.

Please do - the above combo works for me (as usual).  I don't recall anyone
else reporting it.

 Anyway, mount hangs for me too if I use an IDE drive, both with native
 ide and ide-scsi emulation. It doesn't hang with a USB drive though. I
 verified that 2.6.11-rc3 does not have this problem. Reverting
 bk-ide-dev does *not* fix the problem.

Bah.  sysrq-T output would be helpful.

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/