Re: FIX MES in init.c

2014-09-23 Thread John David Anglin

On 9/23/2014 4:48 PM, Helge Deller wrote:
The FIXME: is misleading. It should maybe better read "HINT:" or 
something like that.

Trivially it's basically just casting the symbol so that the compiler
will produce the correct code later on.
There is nothing you could try to "fix".

Why not just remove "FIXME: " from these comments?

Dave

--
John David Anglindave.ang...@bell.net

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: FIX MES in init.c

2014-09-23 Thread Helge Deller

Hi Nick,

On 09/22/2014 09:24 PM, nick wrote:

Greetings James and Other Maintainers of the Parisc Architecture,
I am wondering about two fix mes in init.c and how to fix them
for being const declared into actual variables.
...
/* FIXME: This is 'const' in order to trick the compiler
   into not treating it as DP-relative data. */
extern void * const linux_gateway_page;


The FIXME: is misleading. It should maybe better read "HINT:" or something like 
that.
Trivially it's basically just casting the symbol so that the compiler
will produce the correct code later on.
There is nothing you could try to "fix".

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/