Re: Fix up befs compile.

2005-08-20 Thread Dave Jones 
On Sat, Aug 20, 2005 at 08:58:07PM +0100, Al Viro wrote:
 > On Sat, Aug 20, 2005 at 03:48:40PM -0400, Dave Jones wrote:
 > > fs/befs/linuxvfs.c:466: error: conflicting types for 'befs_follow_link'
 > > fs/befs/linuxvfs.c:44: error: previous declaration of 'befs_follow_link' 
 > > was here
 > > fs/befs/linuxvfs.c: In function 'befs_follow_link':
 > > fs/befs/linuxvfs.c:490: warning: return makes integer from pointer without 
 > > a cast
 > 
 > It should be void *, not void.

Duh. Yes. of course.

Signed-off-by: Dave Jones <[EMAIL PROTECTED]>

--- linux-2.6.12/fs/befs/linuxvfs.c~2005-08-20 15:46:30.0 -0400
+++ linux-2.6.12/fs/befs/linuxvfs.c 2005-08-20 15:47:25.0 -0400
@@ -461,7 +461,7 @@ befs_destroy_inodecache(void)
  * The data stream become link name. Unless the LONG_SYMLINK
  * flag is set.
  */
-static int
+static void *
 befs_follow_link(struct dentry *dentry, struct nameidata *nd)
 {
befs_inode_info *befs_ino = BEFS_I(dentry->d_inode);

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Fix up befs compile.

2005-08-20 Thread Al Viro 
On Sat, Aug 20, 2005 at 03:48:40PM -0400, Dave Jones wrote:
> fs/befs/linuxvfs.c:466: error: conflicting types for 'befs_follow_link'
> fs/befs/linuxvfs.c:44: error: previous declaration of 'befs_follow_link' was 
> here
> fs/befs/linuxvfs.c: In function 'befs_follow_link':
> fs/befs/linuxvfs.c:490: warning: return makes integer from pointer without a 
> cast
> 
> Signed-off-by: Dave Jones <[EMAIL PROTECTED]>
> 

It should be void *, not void.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Fix up befs compile.

2005-08-20 Thread Al Viro 
On Sat, Aug 20, 2005 at 03:48:40PM -0400, Dave Jones wrote:
 fs/befs/linuxvfs.c:466: error: conflicting types for 'befs_follow_link'
 fs/befs/linuxvfs.c:44: error: previous declaration of 'befs_follow_link' was 
 here
 fs/befs/linuxvfs.c: In function 'befs_follow_link':
 fs/befs/linuxvfs.c:490: warning: return makes integer from pointer without a 
 cast
 
 Signed-off-by: Dave Jones [EMAIL PROTECTED]
 

It should be void *, not void.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Fix up befs compile.

2005-08-20 Thread Dave Jones 
On Sat, Aug 20, 2005 at 08:58:07PM +0100, Al Viro wrote:
  On Sat, Aug 20, 2005 at 03:48:40PM -0400, Dave Jones wrote:
   fs/befs/linuxvfs.c:466: error: conflicting types for 'befs_follow_link'
   fs/befs/linuxvfs.c:44: error: previous declaration of 'befs_follow_link' 
   was here
   fs/befs/linuxvfs.c: In function 'befs_follow_link':
   fs/befs/linuxvfs.c:490: warning: return makes integer from pointer without 
   a cast
  
  It should be void *, not void.

Duh. Yes. of course.

Signed-off-by: Dave Jones [EMAIL PROTECTED]

--- linux-2.6.12/fs/befs/linuxvfs.c~2005-08-20 15:46:30.0 -0400
+++ linux-2.6.12/fs/befs/linuxvfs.c 2005-08-20 15:47:25.0 -0400
@@ -461,7 +461,7 @@ befs_destroy_inodecache(void)
  * The data stream become link name. Unless the LONG_SYMLINK
  * flag is set.
  */
-static int
+static void *
 befs_follow_link(struct dentry *dentry, struct nameidata *nd)
 {
befs_inode_info *befs_ino = BEFS_I(dentry-d_inode);

Dave

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/