Re: KMSAN: uninit-value in __inet6_bind
syzbot has found a reproducer for the following crash on: HEAD commit:0a602458c72c kmsan: random: another take at unpoisoning CR.. git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=129e103540 kernel config: https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 dashboard link: https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 compiler: clang version 8.0.0 (trunk 348261) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10a97b2b40 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=108ec72b40 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com audit: type=1800 audit(1545030606.944:30): pid=6407 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="startpar" name="rmnologin" dev="sda1" ino=2423 res=0 Started in network mode Own node identity fe8000bb, cluster identity 4711 == BUG: KMSAN: uninit-value in __inet6_bind+0xb35/0x1a30 net/ipv6/af_inet6.c:340 CPU: 1 PID: 6557 Comm: syz-executor447 Not tainted 4.20.0-rc5+ #2 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1c9/0x220 lib/dump_stack.c:113 kmsan_report+0x12d/0x290 mm/kmsan/kmsan.c:682 __msan_warning+0x76/0xc0 mm/kmsan/kmsan_instr.c:316 __inet6_bind+0xb35/0x1a30 net/ipv6/af_inet6.c:340 inet6_bind+0x206/0x300 net/ipv6/af_inet6.c:441 kernel_bind+0xc6/0xf0 net/socket.c:3230 udp_sock_create6+0x2ee/0x890 net/ipv6/ip6_udp_tunnel.c:39 udp_sock_create include/net/udp_tunnel.h:61 [inline] tipc_udp_enable+0x166f/0x1d70 net/tipc/udp_media.c:742 tipc_enable_bearer net/tipc/bearer.c:302 [inline] __tipc_nl_bearer_enable+0x1213/0x1da0 net/tipc/bearer.c:897 tipc_nl_bearer_enable+0x6c/0xb0 net/tipc/bearer.c:905 genl_family_rcv_msg net/netlink/genetlink.c:601 [inline] genl_rcv_msg+0x185f/0x1a60 net/netlink/genetlink.c:626 netlink_rcv_skb+0x444/0x640 net/netlink/af_netlink.c:2477 genl_rcv+0x63/0x80 net/netlink/genetlink.c:637 netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline] netlink_unicast+0xf80/0x1060 net/netlink/af_netlink.c:1336 netlink_sendmsg+0x129d/0x1310 net/netlink/af_netlink.c:1917 sock_sendmsg_nosec net/socket.c:621 [inline] sock_sendmsg net/socket.c:631 [inline] ___sys_sendmsg+0xdbc/0x11d0 net/socket.c:2116 __sys_sendmsg net/socket.c:2154 [inline] __do_sys_sendmsg net/socket.c:2163 [inline] __se_sys_sendmsg+0x305/0x460 net/socket.c:2161 __x64_sys_sendmsg+0x4a/0x70 net/socket.c:2161 do_syscall_64+0xcd/0x110 arch/x86/entry/common.c:291 entry_SYSCALL_64_after_hwframe+0x63/0xe7 RIP: 0033:0x444199 Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 1b d8 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:7ffe96b1eb28 EFLAGS: 0213 ORIG_RAX: 002e RAX: ffda RBX: 004002e0 RCX: 00444199 RDX: RSI: 28c0 RDI: 0003 RBP: 006ce018 R08: R09: 004002e0 R10: R11: 0213 R12: 00401e40 R13: 00401ed0 R14: R15: Local variable description: udp6_addr@udp_sock_create6 Variable was created at: udp_sock_create6+0x80/0x890 net/ipv6/ip6_udp_tunnel.c:17 udp_sock_create include/net/udp_tunnel.h:61 [inline] tipc_udp_enable+0x166f/0x1d70 net/tipc/udp_media.c:742 ==
RE: KMSAN: uninit-value in __inet6_bind
> -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of Eric Dumazet > Sent: 14-Dec-18 10:15 > To: Jon Maloy ; Cong Wang > ; Dmitry Vyukov > Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Ying Xue > ; tipc-discuss...@lists.sourceforge.net; David > Miller ; Alexey Kuznetsov ; > LKML ; Linux Kernel Network Developers > ; syzkaller-b...@googlegroups.com; Hideaki > YOSHIFUJI > Subject: Re: KMSAN: uninit-value in __inet6_bind > > > > On 12/14/2018 07:04 AM, Jon Maloy wrote: > > > > > >> -Original Message- > >> From: Cong Wang > >> Sent: 12-Dec-18 01:17 > >> To: Dmitry Vyukov > >> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon > Maloy > >> ; Ying Xue ; tipc- > >> discuss...@lists.sourceforge.net; David Miller ; > >> Alexey Kuznetsov ; LKML >> ker...@vger.kernel.org>; Linux Kernel Network Developers > >> ; syzkaller-b...@googlegroups.com; Hideaki > >> YOSHIFUJI > >> Subject: Re: KMSAN: uninit-value in __inet6_bind > >> > >> On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov > >> wrote: > >>> > >>> On Tue, Dec 11, 2018 at 1:41 AM syzbot > >>> wrote: > >>>> > >>>> Hello, > >>>> > >>>> syzbot found the following crash on: > >>>> > >>>> HEAD commit:3f06bda61398 kmsan: remove excessive KMSAN > >> wrappers from a.. > >>>> git tree: https://github.com/google/kmsan.git/master > >>>> console output: > >>>> https://syzkaller.appspot.com/x/log.txt?x=13ca6b0540 > >>>> kernel config: > >>>> https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 > >>>> dashboard link: > >> https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 > >>>> compiler: clang version 8.0.0 (trunk 348261) > >>>> > >>>> Unfortunately, I don't have any reproducer for this crash yet. > >>>> > >>>> IMPORTANT: if you fix the bug, please add the following tag to the > >> commit: > >>>> Reported-by: > syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com > >>> > >>> This looks like a bug in TIPC, +TIPC maintainers. > >>> > >> > >> It looks more like udp_sock_create6() doesn't initialize > >> udp6_addr.sin6_scope_id. > > > > Unfortunately udp_sock_create6() has no way of knowing this value, > because struct udp_port_cfg is missing a field sin6_scope_id. > > So this has to be fixed first by adding this field to the struct, and then > setting it correctly in all current users. > > > > Do we reasons to believe values other than 0 are needed ? > For TIPC it is ok with 0. ///jon
Re: KMSAN: uninit-value in __inet6_bind
On 12/14/2018 07:04 AM, Jon Maloy wrote: > > >> -Original Message- >> From: Cong Wang >> Sent: 12-Dec-18 01:17 >> To: Dmitry Vyukov >> Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon Maloy >> ; Ying Xue ; tipc- >> discuss...@lists.sourceforge.net; David Miller ; >> Alexey Kuznetsov ; LKML > ker...@vger.kernel.org>; Linux Kernel Network Developers >> ; syzkaller-b...@googlegroups.com; Hideaki >> YOSHIFUJI >> Subject: Re: KMSAN: uninit-value in __inet6_bind >> >> On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov >> wrote: >>> >>> On Tue, Dec 11, 2018 at 1:41 AM syzbot >>> wrote: >>>> >>>> Hello, >>>> >>>> syzbot found the following crash on: >>>> >>>> HEAD commit:3f06bda61398 kmsan: remove excessive KMSAN >> wrappers from a.. >>>> git tree: https://github.com/google/kmsan.git/master >>>> console output: >>>> https://syzkaller.appspot.com/x/log.txt?x=13ca6b0540 >>>> kernel config: >>>> https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 >>>> dashboard link: >> https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 >>>> compiler: clang version 8.0.0 (trunk 348261) >>>> >>>> Unfortunately, I don't have any reproducer for this crash yet. >>>> >>>> IMPORTANT: if you fix the bug, please add the following tag to the >> commit: >>>> Reported-by: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com >>> >>> This looks like a bug in TIPC, +TIPC maintainers. >>> >> >> It looks more like udp_sock_create6() doesn't initialize >> udp6_addr.sin6_scope_id. > > Unfortunately udp_sock_create6() has no way of knowing this value, because > struct udp_port_cfg is missing a field sin6_scope_id. > So this has to be fixed first by adding this field to the struct, and then > setting it correctly in all current users. > Do we reasons to believe values other than 0 are needed ?
RE: KMSAN: uninit-value in __inet6_bind
> -Original Message- > From: Cong Wang > Sent: 12-Dec-18 01:17 > To: Dmitry Vyukov > Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon Maloy > ; Ying Xue ; tipc- > discuss...@lists.sourceforge.net; David Miller ; > Alexey Kuznetsov ; LKML ker...@vger.kernel.org>; Linux Kernel Network Developers > ; syzkaller-b...@googlegroups.com; Hideaki > YOSHIFUJI > Subject: Re: KMSAN: uninit-value in __inet6_bind > > On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov > wrote: > > > > On Tue, Dec 11, 2018 at 1:41 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:3f06bda61398 kmsan: remove excessive KMSAN > wrappers from a.. > > > git tree: https://github.com/google/kmsan.git/master > > > console output: > > > https://syzkaller.appspot.com/x/log.txt?x=13ca6b0540 > > > kernel config: > > > https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 > > > dashboard link: > https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 > > > compiler: clang version 8.0.0 (trunk 348261) > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the > commit: > > > Reported-by: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com > > > > This looks like a bug in TIPC, +TIPC maintainers. > > > > It looks more like udp_sock_create6() doesn't initialize > udp6_addr.sin6_scope_id. Unfortunately udp_sock_create6() has no way of knowing this value, because struct udp_port_cfg is missing a field sin6_scope_id. So this has to be fixed first by adding this field to the struct, and then setting it correctly in all current users. ///jon
Re: KMSAN: uninit-value in __inet6_bind
On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov wrote: > > On Tue, Dec 11, 2018 at 1:41 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:3f06bda61398 kmsan: remove excessive KMSAN wrappers from a.. > > git tree: https://github.com/google/kmsan.git/master > > console output: https://syzkaller.appspot.com/x/log.txt?x=13ca6b0540 > > kernel config: https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 > > dashboard link: https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 > > compiler: clang version 8.0.0 (trunk 348261) > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com > > This looks like a bug in TIPC, +TIPC maintainers. > It looks more like udp_sock_create6() doesn't initialize udp6_addr.sin6_scope_id.
Re: KMSAN: uninit-value in __inet6_bind
On Tue, Dec 11, 2018 at 1:41 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:3f06bda61398 kmsan: remove excessive KMSAN wrappers from a.. > git tree: https://github.com/google/kmsan.git/master > console output: https://syzkaller.appspot.com/x/log.txt?x=13ca6b0540 > kernel config: https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 > dashboard link: https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30 > compiler: clang version 8.0.0 (trunk 348261) > > Unfortunately, I don't have any reproducer for this crash yet. > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com This looks like a bug in TIPC, +TIPC maintainers. > Started in network mode > Own node identity fe8000bb, cluster identity 4711 > == > BUG: KMSAN: uninit-value in __inet6_bind+0xb72/0x1ad0 > net/ipv6/af_inet6.c:340 > CPU: 0 PID: 8376 Comm: syz-executor3 Not tainted 4.20.0-rc5+ #111 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0x284/0x3b0 lib/dump_stack.c:113 > kmsan_report+0x12d/0x290 mm/kmsan/kmsan.c:684 > __msan_warning+0x76/0xc0 mm/kmsan/kmsan_instr.c:316 > __inet6_bind+0xb72/0x1ad0 net/ipv6/af_inet6.c:340 > inet6_bind+0x27f/0x390 net/ipv6/af_inet6.c:441 > kernel_bind+0xc6/0xf0 net/socket.c:3230 > udp_sock_create6+0x2ee/0x890 net/ipv6/ip6_udp_tunnel.c:39 > udp_sock_create include/net/udp_tunnel.h:61 [inline] > tipc_udp_enable+0x166f/0x1d70 net/tipc/udp_media.c:742 > tipc_enable_bearer net/tipc/bearer.c:302 [inline] > __tipc_nl_bearer_enable+0x1213/0x1da0 net/tipc/bearer.c:897 > tipc_nl_bearer_enable+0x6c/0xb0 net/tipc/bearer.c:905 > genl_family_rcv_msg net/netlink/genetlink.c:601 [inline] > genl_rcv_msg+0x185f/0x1a60 net/netlink/genetlink.c:626 > netlink_rcv_skb+0x444/0x640 net/netlink/af_netlink.c:2477 > genl_rcv+0x63/0x80 net/netlink/genetlink.c:637 > netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline] > netlink_unicast+0xfc5/0x10a0 net/netlink/af_netlink.c:1336 > netlink_sendmsg+0x1298/0x13e0 net/netlink/af_netlink.c:1917 > sock_sendmsg_nosec net/socket.c:621 [inline] > sock_sendmsg net/socket.c:631 [inline] > ___sys_sendmsg+0xdbc/0x11d0 net/socket.c:2116 > __sys_sendmsg net/socket.c:2154 [inline] > __do_sys_sendmsg net/socket.c:2163 [inline] > __se_sys_sendmsg+0x305/0x460 net/socket.c:2161 > __x64_sys_sendmsg+0x4a/0x70 net/socket.c:2161 > do_syscall_64+0xcd/0x110 arch/x86/entry/common.c:291 > entry_SYSCALL_64_after_hwframe+0x63/0xe7 > RIP: 0033:0x457659 > Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 > 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff > ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 > RSP: 002b:7f82ebc52c78 EFLAGS: 0246 ORIG_RAX: 002e > RAX: ffda RBX: 0003 RCX: 00457659 > RDX: RSI: 28c0 RDI: 0003 > RBP: 0072bf00 R08: R09: > R10: R11: 0246 R12: 7f82ebc536d4 > R13: 004c421b R14: 004d7160 R15: > > Local variable description: udp6_addr@udp_sock_create6 > Variable was created at: > udp_sock_create6+0x80/0x890 net/ipv6/ip6_udp_tunnel.c:17 > udp_sock_create include/net/udp_tunnel.h:61 [inline] > tipc_udp_enable+0x166f/0x1d70 net/tipc/udp_media.c:742 > == > > > --- > This bug is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkal...@googlegroups.com. > > syzbot will keep track of this bug report. See: > https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with > syzbot. > > -- > You received this message because you are subscribed to the Google Groups > "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to syzkaller-bugs+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/syzkaller-bugs/1568af057cb456a8%40google.com. > For more options, visit https://groups.google.com/d/optout.
