Re: WARNING: refcount bug in kobject_add_internal

2019-07-01 Thread Muchun Song 
Hi Ben,

Benjamin Herrenschmidt  于2019年7月2日周二 上午10:44写道：
>
> Munchun, is this what your patch fixes ?
>
 Yes, this is what my patch fixes.

The patchs can reference to:
[PATCH v1 OPT1] driver core: Fix use-after-free and double
free on glue directory
[PATCH v4 OPT2] driver core: Fix use-after-free and double
free on glue directory

And waiting for Greg chose which solution he prefered.

Yours,
Muchun

Re: WARNING: refcount bug in kobject_add_internal

2019-07-01 Thread Benjamin Herrenschmidt 
Munchun, is this what your patch fixes ?


On Mon, 2019-07-01 at 16:27 -0700, syzbot wrote:
> syzbot has bisected this bug to:
> 
> commit 726e41097920a73e4c7c33385dcc0debb1281e18
> Author: Benjamin Herrenschmidt 
> Date:   Tue Jul 10 00:29:10 2018 +
> 
>  drivers: core: Remove glue dirs from sysfs earlier
> 
> bisection log:  
> https://syzkaller.appspot.com/x/bisect.txt?x=140d6739a0
> start commit:   6fbc7275 Linux 5.2-rc7
> git tree:   upstream
> final crash:
> https://syzkaller.appspot.com/x/report.txt?x=160d6739a0
> console output: 
> https://syzkaller.appspot.com/x/log.txt?x=120d6739a0
> kernel config:  
> https://syzkaller.appspot.com/x/.config?x=bff6583efcfaed3f
> dashboard link: 
> https://syzkaller.appspot.com/bug?extid=32259bb9bc1a487ad206
> syz repro:  
> https://syzkaller.appspot.com/x/repro.syz?x=115bad39a0
> C reproducer:   
> https://syzkaller.appspot.com/x/repro.c?x=1241bdd5a0
> 
> Reported-by: syzbot+32259bb9bc1a487ad...@syzkaller.appspotmail.com
> Fixes: 726e41097920 ("drivers: core: Remove glue dirs from sysfs
> earlier")
> 
> For information about bisection process see: 
> https://goo.gl/tpsmEJ#bisection

Re: WARNING: refcount bug in kobject_add_internal

2019-07-01 Thread syzbot 

syzbot has bisected this bug to:

commit 726e41097920a73e4c7c33385dcc0debb1281e18
Author: Benjamin Herrenschmidt 
Date:   Tue Jul 10 00:29:10 2018 +

drivers: core: Remove glue dirs from sysfs earlier

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=140d6739a0
start commit:   6fbc7275 Linux 5.2-rc7
git tree:   upstream
final crash:https://syzkaller.appspot.com/x/report.txt?x=160d6739a0
console output: https://syzkaller.appspot.com/x/log.txt?x=120d6739a0
kernel config:  https://syzkaller.appspot.com/x/.config?x=bff6583efcfaed3f
dashboard link: https://syzkaller.appspot.com/bug?extid=32259bb9bc1a487ad206
syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=115bad39a0
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1241bdd5a0

Reported-by: syzbot+32259bb9bc1a487ad...@syzkaller.appspotmail.com
Fixes: 726e41097920 ("drivers: core: Remove glue dirs from sysfs earlier")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection