Re: e2b2rom_init_one(): Unable to register resource
On Mon, Feb 19, 2007 at 11:16:13PM +0200, Dan Aloni wrote: | Cyrill Gorcunov wrote: | >Hi, Dan | > | >did you try setup forsed 8MB value on window->phys? | > | > | Actually, I tried to force it at 4MB starting at 0xff80 since it | made much sense looking at the e820 map. Or maybe I misunderstood | something. It crashed with this: | | <7>[ 9237.432181] esb2rom: esb2rom_init_one(): Unable to register | resource 0xff80-0xffbf - kernel bug? | <1>[ 9237.432262] Unable to handle kernel paging request at | c2001050 RIP: | <1>[ 9237.436910] [] cfi_probe_chip+0x14a/0x10e0 | <4>[ 9237.445246] PGD 12fc20067 PUD 12fc21067 PMD 12fcf6067 PTE 0 | <0>[ 9237.451057] Oops: 0002 [1] SMP | <0>[ 9237.454346] do_IRQ: 1.251 No irq handler for vector | | I can dump here the disassembly of cfi_probe_chip if it's interesting... | | -- | Dan Aloni | XIV LTD, http://www.xivstorage.com | da-x (at) monatomic.org, dan (at) xiv.co.il | Hi Dan, what's new with the problem? Did you get any solution? Btw, I've read the comments in esb2rom.c and because it's grown from ichxrom.c it seems esb2rom.c has a bug in esb2rom_init_one(). Actually I think you should receive a message like this: "Rom window is closed" as it's done in ichxrom.c because you've got pci_read_config_byte : 4 and that's not the number esb2rom_init_one is expecting to process with... Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
Btw, Dan did it work on 32-bit compiled kernel? Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Mon, Feb 19, 2007 at 11:16:13PM +0200, Dan Aloni wrote: | Cyrill Gorcunov wrote: | >Hi, Dan | > | >did you try setup forsed 8MB value on window->phys? | > | > | Actually, I tried to force it at 4MB starting at 0xff80 since it | made much sense looking at the e820 map. Or maybe I misunderstood | something. It crashed with this: | | <7>[ 9237.432181] esb2rom: esb2rom_init_one(): Unable to register | resource 0xff80-0xffbf - kernel bug? | <1>[ 9237.432262] Unable to handle kernel paging request at | c2001050 RIP: | <1>[ 9237.436910] [] cfi_probe_chip+0x14a/0x10e0 | <4>[ 9237.445246] PGD 12fc20067 PUD 12fc21067 PMD 12fcf6067 PTE 0 | <0>[ 9237.451057] Oops: 0002 [1] SMP | <0>[ 9237.454346] do_IRQ: 1.251 No irq handler for vector | | I can dump here the disassembly of cfi_probe_chip if it's interesting... | | -- | Dan Aloni | XIV LTD, http://www.xivstorage.com | da-x (at) monatomic.org, dan (at) xiv.co.il | Hi, send me the dump. I'll try to resolve the problem. To be fair I should say that I'm not very familiar with a such hardware related stuff but we could try anyway ;) Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
Cyrill Gorcunov wrote: Hi, Dan did you try setup forsed 8MB value on window->phys? Actually, I tried to force it at 4MB starting at 0xff80 since it made much sense looking at the e820 map. Or maybe I misunderstood something. It crashed with this: <7>[ 9237.432181] esb2rom: esb2rom_init_one(): Unable to register resource 0xff80-0xffbf - kernel bug? <1>[ 9237.432262] Unable to handle kernel paging request at c2001050 RIP: <1>[ 9237.436910] [] cfi_probe_chip+0x14a/0x10e0 <4>[ 9237.445246] PGD 12fc20067 PUD 12fc21067 PMD 12fcf6067 PTE 0 <0>[ 9237.451057] Oops: 0002 [1] SMP <0>[ 9237.454346] do_IRQ: 1.251 No irq handler for vector I can dump here the disassembly of cfi_probe_chip if it's interesting... -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
Hi, Dan did you try setup forsed 8MB value on window->phys? Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sun, Feb 18, 2007 at 07:49:34PM +0200, Dan Aloni wrote: | On Sun, Feb 18, 2007 at 06:13:38PM +0100, Andi Kleen wrote: | > [adding mtd maintainer] | > | > On Sunday 18 February 2007 11:42, Cyrill Gorcunov wrote: | > > On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote: | > > | Hello, | > > | | > > | I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2 | > > | board and I got this during boot: | > > | | > > | [248660.950695] device id = 2440 | > > | [248660.950699] device id = 2480 | > > | [248660.950703] device id = 24c0 | > > | [248660.950706] device id = 24d0 | > > | [248660.950709] matched device = 24d0 | > > | [248660.950712] matched device id 24d0 | > > | [248660.950716] pci_read_config_byte : 4 | > > | [248660.950723] esb2rom: esb2rom_init_one(): Unable to register resource | > > | 0xffc0-0x - kernel bug? | > > | [248660.950729] esb2rom: ioremap(ffc0, 10040) failed | > > | [248660.956859] retVal = -19 | > > | | > > | Looks like some kind of a 64-bit portability bug... | [...] | > | > Making window->phys u32 seems like a cleaner fix. | > (untested) | | With this fix it still looks somewhat broken: | | [889227.698252] device id = 2440 | [889227.698261] device id = 2480 | [889227.698264] device id = 24c0 | [889227.698268] device id = 24d0 | [889227.698271] matched device = 24d0 | [889227.698274] matched device id 24d0 | [889227.698280] pci_read_config_byte : 4 | [889227.698289] esb2rom: esb2rom_init_one(): Unable to register resource 0xffc0-0x - kernel bug? | [889227.700676] CFI: Found no esb2rom @ffc0 device at location zero | [889227.717995] JEDEC: Found no esb2rom @ffc0 device at location zero | [889227.720811] CFI: Found no esb2rom @ffc0 device at location zero | [889227.747009] JEDEC: Found no esb2rom @ffc0 device at location zero | [889227.748692] CFI: Found no esb2rom @ffc0 device at location zero | [889227.763736] JEDEC: Found no esb2rom @ffc0 device at location zero | [889227.765438] CFI: Found no esb2rom @ffc1 device at location zero | [889227.782755] JEDEC: Found no esb2rom @ffc1 device at location zero | [889227.785566] CFI: Found no esb2rom @ffc1 device at location zero | [889227.810647] JEDEC: Found no esb2rom @ffc1 device at location zero | [889227.812330] CFI: Found no esb2rom @ffc1 device at location zero | [889227.827378] JEDEC: Found no esb2rom @ffc1 device at location zero | [889227.829081] CFI: Found no esb2rom @ffc2 device at location zero | [889227.846390] JEDEC: Found no esb2rom @ffc2 device at location zero | [889227.849202] CFI: Found no esb2rom @ffc2 device at location zero | [889227.874279] JEDEC: Found no esb2rom @ffc2 device at location zero | [889227.875961] CFI: Found no esb2rom @ffc2 device at location zero | [889227.891005] JEDEC: Found no esb2rom @ffc2 device at location zero | [889227.892710] CFI: Found no esb2rom @ffc3 device at location zero | [889227.910022] JEDEC: Found no esb2rom @ffc3 device at location zero | [889227.912835] CFI: Found no esb2rom @ffc3 device at location zero | [889227.937915] JEDEC: Found no esb2rom @ffc3 device at location zero | [889227.939594] CFI: Found no esb2rom @ffc3 device at location zero | [889227.954636] JEDEC: Found no esb2rom @ffc3 device at location zero | [889227.956339] CFI: Found no esb2rom @ffc4 device at location zero | [889227.973647] JEDEC: Found no esb2rom @ffc4 device at location zero | [889227.976461] CFI: Found no esb2rom @ffc4 device at location zero | [889228.001560] JEDEC: Found no esb2rom @ffc4 device at location zero | [889228.003243] CFI: Found no esb2rom @ffc4 device at location zero | [889228.018296] JEDEC: Found no esb2rom @ffc4 device at location zero | [889228.02] CFI: Found no esb2rom @ffc5 device at location zero | [889228.037315] JEDEC: Found no esb2rom @ffc5 device at location zero | [889228.040129] CFI: Found no esb2rom @ffc5 device at location zero | [889228.065218] JEDEC: Found no esb2rom @ffc5 device at location zero | [889228.066899] CFI: Found no esb2rom @ffc5 device at location zero | [889228.081943] JEDEC: Found no esb2rom @ffc5 device at location zero | [889228.083640] CFI: Found no esb2rom @ffc6 device at location zero | [889228.100949] JEDEC: Found no esb2rom @ffc6 device at location zero | [889228.103760] CFI: Found no esb2rom @ffc6 device at location zero | [889228.128850] JEDEC: Found no esb2rom @ffc6 device at location zero | [889228.130529] CFI: Found no esb2rom @ffc6 device at location zero | [889228.145575] JEDEC: Found no esb2rom @ffc6 device at location zero | [889228.147275] CFI: Found no esb2rom @ffc7 device at location zero | [889228.164593] JEDEC: Found no esb2rom @ffc7 device at location zero | [889228.167398] CFI: Found no esb2rom @ffc7 device at location zero | [889228.192491] JEDEC: Found no esb2rom @ffc7 de
Re: e2b2rom_init_one(): Unable to register resource
On Sun, Feb 18, 2007 at 07:49:34PM +0200, Dan Aloni wrote: | > Making window->phys u32 seems like a cleaner fix. | > (untested) | | With this fix it still looks somewhat broken: | Actually, Dan, I even don't know to do :( May be Andi know... I think the problem is 'cause pci_read_config_word returns 0x4 and window->phys remains on 0. Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sun, Feb 18, 2007 at 06:13:38PM +0100, Andi Kleen wrote: > [adding mtd maintainer] > > On Sunday 18 February 2007 11:42, Cyrill Gorcunov wrote: > > On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote: > > | Hello, > > | > > | I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2 > > | board and I got this during boot: > > | > > | [248660.950695] device id = 2440 > > | [248660.950699] device id = 2480 > > | [248660.950703] device id = 24c0 > > | [248660.950706] device id = 24d0 > > | [248660.950709] matched device = 24d0 > > | [248660.950712] matched device id 24d0 > > | [248660.950716] pci_read_config_byte : 4 > > | [248660.950723] esb2rom: esb2rom_init_one(): Unable to register resource > > | 0xffc0-0x - kernel bug? > > | [248660.950729] esb2rom: ioremap(ffc0, 10040) failed > > | [248660.956859] retVal = -19 > > | > > | Looks like some kind of a 64-bit portability bug... [...] > > Making window->phys u32 seems like a cleaner fix. > (untested) With this fix it still looks somewhat broken: [889227.698252] device id = 2440 [889227.698261] device id = 2480 [889227.698264] device id = 24c0 [889227.698268] device id = 24d0 [889227.698271] matched device = 24d0 [889227.698274] matched device id 24d0 [889227.698280] pci_read_config_byte : 4 [889227.698289] esb2rom: esb2rom_init_one(): Unable to register resource 0xffc0-0x - kernel bug? [889227.700676] CFI: Found no esb2rom @ffc0 device at location zero [889227.717995] JEDEC: Found no esb2rom @ffc0 device at location zero [889227.720811] CFI: Found no esb2rom @ffc0 device at location zero [889227.747009] JEDEC: Found no esb2rom @ffc0 device at location zero [889227.748692] CFI: Found no esb2rom @ffc0 device at location zero [889227.763736] JEDEC: Found no esb2rom @ffc0 device at location zero [889227.765438] CFI: Found no esb2rom @ffc1 device at location zero [889227.782755] JEDEC: Found no esb2rom @ffc1 device at location zero [889227.785566] CFI: Found no esb2rom @ffc1 device at location zero [889227.810647] JEDEC: Found no esb2rom @ffc1 device at location zero [889227.812330] CFI: Found no esb2rom @ffc1 device at location zero [889227.827378] JEDEC: Found no esb2rom @ffc1 device at location zero [889227.829081] CFI: Found no esb2rom @ffc2 device at location zero [889227.846390] JEDEC: Found no esb2rom @ffc2 device at location zero [889227.849202] CFI: Found no esb2rom @ffc2 device at location zero [889227.874279] JEDEC: Found no esb2rom @ffc2 device at location zero [889227.875961] CFI: Found no esb2rom @ffc2 device at location zero [889227.891005] JEDEC: Found no esb2rom @ffc2 device at location zero [889227.892710] CFI: Found no esb2rom @ffc3 device at location zero [889227.910022] JEDEC: Found no esb2rom @ffc3 device at location zero [889227.912835] CFI: Found no esb2rom @ffc3 device at location zero [889227.937915] JEDEC: Found no esb2rom @ffc3 device at location zero [889227.939594] CFI: Found no esb2rom @ffc3 device at location zero [889227.954636] JEDEC: Found no esb2rom @ffc3 device at location zero [889227.956339] CFI: Found no esb2rom @ffc4 device at location zero [889227.973647] JEDEC: Found no esb2rom @ffc4 device at location zero [889227.976461] CFI: Found no esb2rom @ffc4 device at location zero [889228.001560] JEDEC: Found no esb2rom @ffc4 device at location zero [889228.003243] CFI: Found no esb2rom @ffc4 device at location zero [889228.018296] JEDEC: Found no esb2rom @ffc4 device at location zero [889228.02] CFI: Found no esb2rom @ffc5 device at location zero [889228.037315] JEDEC: Found no esb2rom @ffc5 device at location zero [889228.040129] CFI: Found no esb2rom @ffc5 device at location zero [889228.065218] JEDEC: Found no esb2rom @ffc5 device at location zero [889228.066899] CFI: Found no esb2rom @ffc5 device at location zero [889228.081943] JEDEC: Found no esb2rom @ffc5 device at location zero [889228.083640] CFI: Found no esb2rom @ffc6 device at location zero [889228.100949] JEDEC: Found no esb2rom @ffc6 device at location zero [889228.103760] CFI: Found no esb2rom @ffc6 device at location zero [889228.128850] JEDEC: Found no esb2rom @ffc6 device at location zero [889228.130529] CFI: Found no esb2rom @ffc6 device at location zero [889228.145575] JEDEC: Found no esb2rom @ffc6 device at location zero [889228.147275] CFI: Found no esb2rom @ffc7 device at location zero [889228.164593] JEDEC: Found no esb2rom @ffc7 device at location zero [889228.167398] CFI: Found no esb2rom @ffc7 device at location zero [889228.192491] JEDEC: Found no esb2rom @ffc7 device at location zero [889228.194173] CFI: Found no esb2rom @ffc7 device at location zero [889228.209767] JEDEC: Found no esb2rom @ffc7 device at location zero [889228.211466] CFI: Found no esb2rom @ffc8 device at lo
Re: e2b2rom_init_one(): Unable to register resource
[adding mtd maintainer]
On Sunday 18 February 2007 11:42, Cyrill Gorcunov wrote:
> On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote:
> | Hello,
> |
> | I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2
> | board and I got this during boot:
> |
> | [248660.950695] device id = 2440
> | [248660.950699] device id = 2480
> | [248660.950703] device id = 24c0
> | [248660.950706] device id = 24d0
> | [248660.950709] matched device = 24d0
> | [248660.950712] matched device id 24d0
> | [248660.950716] pci_read_config_byte : 4
> | [248660.950723] esb2rom: esb2rom_init_one(): Unable to register resource
> | 0xffc0-0x - kernel bug?
> | [248660.950729] esb2rom: ioremap(ffc0, 10040) failed
> | [248660.956859] retVal = -19
> |
> | Looks like some kind of a 64-bit portability bug...
> |
> | --
> | Dan Aloni
> | XIV LTD, http://www.xivstorage.com
> | da-x (at) monatomic.org, dan (at) xiv.co.il
> | -
> | To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> | the body of a message to [EMAIL PROTECTED]
> | More majordomo info at http://vger.kernel.org/majordomo-info.html
> | Please read the FAQ at http://www.tux.org/lkml/
> |
>
> Hi,
>
> here is a patch attached to the mail. You may test it. Actually
> I have no 64bit machine to test it and I'm worried about the
> patch accuracy. So be carefull testing it. I sent a copy of the
> message to Andi Kleen (who is a maintainer of X86-64 port) may be
> we should wait for its answer ;)
Making window->phys u32 seems like a cleaner fix.
(untested)
-Andi
Fix 64bit arithmetic bug in esb2rom.c
Index: linux/drivers/mtd/maps/esb2rom.c
===
--- linux.orig/drivers/mtd/maps/esb2rom.c
+++ linux/drivers/mtd/maps/esb2rom.c
@@ -95,8 +95,8 @@
struct esb2rom_window {
void __iomem* virt;
- unsigned long phys;
- unsigned long size;
+ u32 phys;
+ u32 size;
struct list_head maps;
struct resource rsrc;
struct pci_dev *pdev;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sun, Feb 18, 2007 at 01:29:03PM +0200, Dan Aloni wrote: | On Sun, Feb 18, 2007 at 01:42:22PM +0300, Cyrill Gorcunov wrote: | > Hi, | > | > here is a patch attached to the mail. You may test it. Actually | > I have no 64bit machine to test it and I'm worried about the | > patch accuracy. So be carefull testing it. I sent a copy of the | > message to Andi Kleen (who is a maintainer of X86-64 port) may be | > we should wait for its answer ;) | | Thanks, I'll give it a try soon. | | BTW, wouldn't it be better just to change the type of phys and size | to u32? | | > diff --git a/drivers/mtd/maps/esb2rom.c b/drivers/mtd/maps/esb2rom.c | > index a9d808a..d63c060 100644 | > --- a/drivers/mtd/maps/esb2rom.c | > +++ b/drivers/mtd/maps/esb2rom.c | > @@ -214,6 +214,9 @@ static int __devinit esb2rom_init_one(struct pci_dev *pdev, | > | > /* reserved 0x0020 and 0x0010 */ | > window->phys -= 0x40UL; | > +#ifdef CONFIG_64BIT | > + window->phys &= 0xUL; | > +#endif | > window->size = (0xUL - window->phys) + 1UL; | > | > /* Enable writes through the rom window */ | | | -- | Dan Aloni | XIV LTD, http://www.xivstorage.com | da-x (at) monatomic.org, dan (at) xiv.co.il | Hi, actually - I don't know... I think this could be done by kernel developer specialist only (as Andi Kleen is). So lets wait until his answer ;) Nevertheless, write me if the patch resolve the problem. -- Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sun, Feb 18, 2007 at 01:42:22PM +0300, Cyrill Gorcunov wrote: > Hi, > > here is a patch attached to the mail. You may test it. Actually > I have no 64bit machine to test it and I'm worried about the > patch accuracy. So be carefull testing it. I sent a copy of the > message to Andi Kleen (who is a maintainer of X86-64 port) may be > we should wait for its answer ;) Thanks, I'll give it a try soon. BTW, wouldn't it be better just to change the type of phys and size to u32? > diff --git a/drivers/mtd/maps/esb2rom.c b/drivers/mtd/maps/esb2rom.c > index a9d808a..d63c060 100644 > --- a/drivers/mtd/maps/esb2rom.c > +++ b/drivers/mtd/maps/esb2rom.c > @@ -214,6 +214,9 @@ static int __devinit esb2rom_init_one(struct pci_dev > *pdev, > > /* reserved 0x0020 and 0x0010 */ > window->phys -= 0x40UL; > +#ifdef CONFIG_64BIT > + window->phys &= 0xUL; > +#endif > window->size = (0xUL - window->phys) + 1UL; > > /* Enable writes through the rom window */ -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote: | Hello, | | I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2 | board and I got this during boot: | | [248660.950695] device id = 2440 | [248660.950699] device id = 2480 | [248660.950703] device id = 24c0 | [248660.950706] device id = 24d0 | [248660.950709] matched device = 24d0 | [248660.950712] matched device id 24d0 | [248660.950716] pci_read_config_byte : 4 | [248660.950723] esb2rom: esb2rom_init_one(): Unable to register resource | 0xffc0-0x - kernel bug? | [248660.950729] esb2rom: ioremap(ffc0, 10040) failed | [248660.956859] retVal = -19 | | Looks like some kind of a 64-bit portability bug... | | -- | Dan Aloni | XIV LTD, http://www.xivstorage.com | da-x (at) monatomic.org, dan (at) xiv.co.il | - | To unsubscribe from this list: send the line "unsubscribe linux-kernel" in | the body of a message to [EMAIL PROTECTED] | More majordomo info at http://vger.kernel.org/majordomo-info.html | Please read the FAQ at http://www.tux.org/lkml/ | Hi, here is a patch attached to the mail. You may test it. Actually I have no 64bit machine to test it and I'm worried about the patch accuracy. So be carefull testing it. I sent a copy of the message to Andi Kleen (who is a maintainer of X86-64 port) may be we should wait for its answer ;) Cyrill diff --git a/drivers/mtd/maps/esb2rom.c b/drivers/mtd/maps/esb2rom.c index a9d808a..d63c060 100644 --- a/drivers/mtd/maps/esb2rom.c +++ b/drivers/mtd/maps/esb2rom.c @@ -214,6 +214,9 @@ static int __devinit esb2rom_init_one(struct pci_dev *pdev, /* reserved 0x0020 and 0x0010 */ window->phys -= 0x40UL; +#ifdef CONFIG_64BIT + window->phys &= 0xUL; +#endif window->size = (0xUL - window->phys) + 1UL; /* Enable writes through the rom window */
Re: e2b2rom_init_one(): Unable to register resource
No, that's portability bug... Need time for review ;) Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: e2b2rom_init_one(): Unable to register resource
On Sat, Feb 17, 2007 at 11:29:19PM +0200, Dan Aloni wrote: | Hello, | | I'm running the x86_64 arch of Linux 2.6.20 on a Supermicro X6DH8-XG2 | board and I got this during boot: | | [248660.950695] device id = 2440 | [248660.950699] device id = 2480 | [248660.950703] device id = 24c0 | [248660.950706] device id = 24d0 | [248660.950709] matched device = 24d0 | [248660.950712] matched device id 24d0 | [248660.950716] pci_read_config_byte : 4 | [248660.950723] esb2rom: esb2rom_init_one(): Unable to register resource | 0xffc0-0x - kernel bug? | [248660.950729] esb2rom: ioremap(ffc0, 10040) failed | [248660.956859] retVal = -19 | | Looks like some kind of a 64-bit portability bug... | | -- | Dan Aloni | XIV LTD, http://www.xivstorage.com | da-x (at) monatomic.org, dan (at) xiv.co.il | - | To unsubscribe from this list: send the line "unsubscribe linux-kernel" in | the body of a message to [EMAIL PROTECTED] | More majordomo info at http://vger.kernel.org/majordomo-info.html | Please read the FAQ at http://www.tux.org/lkml/ | Hi Dan, I think that is not 64-bit portability bug and the code should be reviewed by Lew Glendenning (who wrote it). I'm sending a copy of the message to Lew and hope he'll check the code ;) P.S. (for Lew) Lew, I think window->phys in esb2rom_init_one() remains in zero and then sets it to 0xffc0 after window->phys -= 0x40UL May be something wrong with word returned at pci_read_config_word()? Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
