Re: linux-next: Fixes tag needs some work in the pinctrl tree
On 4/12/21 2:00 AM, Stephen Rothwell wrote:
> Hi all,
>
Hi!
> In commit
>
> 2cfebcb2a22f ("pinctrl: at91-pio4: Fix slew rate disablement")
>
> Fixes tag
>
> Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate")
>
> has these problem(s):
>
> - Target SHA1 does not exist
oh, yes.
>
> Maybe you meant
>
> Fixes: c709135e576b ("pinctrl: at91-pio4: add support for slew-rate")
You're correct. It seems that I used a vendor branch when looking for the
fixes tag, sorry. I'll be more careful next time.
Cheers,
ta
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Mon, Dec 7, 2020 at 12:39 AM Andrew Jeffery wrote:
> On Mon, 7 Dec 2020, at 06:46, Stephen Rothwell wrote:
> > Maybe you meant
> >
> > Fixes: 9b92f5c51e9a ("pinctrl: aspeed: Fix GPI only function problem.")
>
> Right, looks like I accidentally grabbed 6726fbff19bf from the 5.9 stable
> tree.
OK I fixed it!
Yours,
Linus Walleij
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Mon, 7 Dec 2020, at 06:46, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> c3c882898d07 ("pinctrl: aspeed: Fix GPIO requests on pass-through banks")
>
> Fixes tag
>
> Fixes: 6726fbff19bf ("pinctrl: aspeed: Fix GPI only function problem.")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 9b92f5c51e9a ("pinctrl: aspeed: Fix GPI only function problem.")
Right, looks like I accidentally grabbed 6726fbff19bf from the 5.9 stable tree.
Thanks for picking that up.
Andrew
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi all,
On Wed, 30 Sep 2020 23:01:19 +1000 Stephen Rothwell
wrote:
>
> Just use
>
> git log -1 --format='Fixes: %h ("%s") '
git log -1 --format='Fixes: %h ("%s")'
sorry :-)
--
Cheers,
Stephen Rothwell
pgpj6QKnhcavB.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Linus,
I just sent version2 of this patch with correct fixes tag. please pick
it up.
Thanks,
Siva
On 6/16/2020 4:42 PM, Stephen Rothwell wrote:
Hi all,
In commit
912f25eca000 ("pinctrl: qcom: ipq6018 Add missing pins in qpic pin group")
Fixes tag
Fixes: ef1ea54 (pinctrl: qcom: Add ipq6018 pinctrl driver)
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Nicolas, On Thu, 27 Jun 2019 09:57:13 +0800 Nicolas Boichat wrote: > > I'm not that smart, I count the digits manually ,-( Anyway, TIL `git > log --pretty=fixes` and I'll use that in the future, thanks. And my > "auto" setting uses 16 digits, it's ok to use longer ids, right? Yeah, more is ok (but not too many more :-)). > BTW Documentation/process/submitting-patches.rst on linux-next/master > still says to hardcode to 12. Rats! -- Cheers, Stephen Rothwell pgp0W_DLsipQH.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Thu, Jun 27, 2019 at 9:48 AM Stephen Rothwell wrote: > > Hi Nicolas, > > On Thu, 27 Jun 2019 08:32:34 +0800 Nicolas Boichat > wrote: > > > > Ouch, sorry, for some reasons I thought it was 10, not 12... > > It used to be 10, but will slowly grow over time. That's why setting > core.abbrev to "auto" is best (or leaving it unset). I'm not that smart, I count the digits manually ,-( Anyway, TIL `git log --pretty=fixes` and I'll use that in the future, thanks. And my "auto" setting uses 16 digits, it's ok to use longer ids, right? BTW Documentation/process/submitting-patches.rst on linux-next/master still says to hardcode to 12. Thanks, > > -- > Cheers, > Stephen Rothwell
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Nicolas, On Thu, 27 Jun 2019 08:32:34 +0800 Nicolas Boichat wrote: > > Ouch, sorry, for some reasons I thought it was 10, not 12... It used to be 10, but will slowly grow over time. That's why setting core.abbrev to "auto" is best (or leaving it unset). -- Cheers, Stephen Rothwell pgpdPK1T45LRJ.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Wed, Jun 26, 2019 at 10:11 PM Linus Walleij wrote:
>
> On Wed, Jun 26, 2019 at 3:50 PM Stephen Rothwell
> wrote:
>
> > In commit
> >
> > 99fd24aa4a45 ("pinctrl: mediatek: Ignore interrupts that are wake only
> > during resume")
> >
> > Fixes tag
> >
> > Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function
> > calls")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
>
> Thanks Stephen, fixed this.
Ouch, sorry, for some reasons I thought it was 10, not 12...
>
> Yours,
> Linus Walleij
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Wed, Jun 26, 2019 at 3:50 PM Stephen Rothwell wrote:
> In commit
>
> 99fd24aa4a45 ("pinctrl: mediatek: Ignore interrupts that are wake only
> during resume")
>
> Fixes tag
>
> Fixes: bf22ff45bed ("genirq: Avoid unnecessary low level irq function
> calls")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Thanks Stephen, fixed this.
Yours,
Linus Walleij
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Thu, Jun 20, 2019 at 1:08 PM Stephen Rothwell wrote:
> In commit
>
> 905dade66268 ("pinctrl: mcp23s08: Fix add_data and irqchip_add_nested call
> order")
>
> Fixes tag
>
> Fixes: 02e389e63 ("pinctrl: mcp23s08: fix irq setup order")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Thanks Stephen.
I fixed it up!
Yours,
Linus Walleij
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi all,
On Mon, 18 Feb 2019 09:25:36 +1100 Stephen Rothwell
wrote:
>
> Hi Linus,
>
> In commit
>
> a5a0bbca16cd ("pinctrl: meson: meson8b: fix the sdxc_a data 1..3 pins")
>
> Fixes tag
>
> Fixes: 0fefcb6 ("pinctrl: Add support for Meson8b")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Ignore this, I am still half asleep :-)
--
Cheers,
Stephen Rothwell
pgpCtA_GkHY9l.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Stephen,
On Sun, Feb 17, 2019 at 11:25 PM Stephen Rothwell wrote:
>
> Hi Linus,
>
> In commit
>
> a5a0bbca16cd ("pinctrl: meson: meson8b: fix the sdxc_a data 1..3 pins")
>
> Fixes tag
>
> Fixes: 0fefcb6 ("pinctrl: Add support for Meson8b")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Linus fixed this one hour ago in the linux-pinctrl tree
so this should be gone with your next run
Regards
Martin
Re: linux-next: Fixes tag needs some work in the pinctrl tree
On Thu, Feb 14, 2019 at 12:55 PM Martin Blumenstingl
wrote:
> Hi Stephen, Hi Linus,
>
> On Thu, Feb 14, 2019 at 12:03 PM Stephen Rothwell
> wrote:
> >
> > Hi Linus,
> >
> > In commit
> >
> > a5a0bbca16cd ("pinctrl: meson: meson8b: fix the sdxc_a data 1..3 pins")
> >
> > Fixes tag
> >
> > Fixes: 0fefcb6 ("pinctrl: Add support for Meson8b")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
> this is my fault - sorry about that.
>
> Linus, do you want me to re-send the patch or do you want to change
> the referenced SHA1 to 0fefcb6876d0d6 ?
> I'm fine either way, please let me know what's easiest for you.
I fixed it up, no big deal.
Thanks Stephen, Martin!
Linus Walleij
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Stephen, Hi Linus,
On Thu, Feb 14, 2019 at 12:03 PM Stephen Rothwell wrote:
>
> Hi Linus,
>
> In commit
>
> a5a0bbca16cd ("pinctrl: meson: meson8b: fix the sdxc_a data 1..3 pins")
>
> Fixes tag
>
> Fixes: 0fefcb6 ("pinctrl: Add support for Meson8b")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
this is my fault - sorry about that.
Linus, do you want me to re-send the patch or do you want to change
the referenced SHA1 to 0fefcb6876d0d6 ?
I'm fine either way, please let me know what's easiest for you.
Regards
Martin
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi Chen-Yu, On Tue, 22 Jan 2019 10:20:28 +0800 Chen-Yu Tsai wrote: > > Sorry about that. I've been doing for some time now. > Should none of the tags be wrapped? Generally they should be single lines (in my opinion) ... it makes grepping for things a lot harder if they are split. -- Cheers, Stephen Rothwell pgpaq5gJGpKQT.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the pinctrl tree
Hi,
On Tue, Jan 22, 2019 at 6:42 AM Stephen Rothwell wrote:
>
> Hi Linus,
>
> In commit
>
> 15d90c339a7f ("pinctrl: sunxi: Correct number of IRQ banks on H6 main pin
> controller")
>
> Fixes tag
>
> Fixes: c8a830904991 ("pinctrl: sunxi: add support for the Allwinner H6
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes: tags over more than 1 line.
Sorry about that. I've been doing for some time now.
Should none of the tags be wrapped?
ChenYu
