Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Sun, Nov 08, 2020 at 04:29:36PM -0500, J. Bruce Fields wrote:
> On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
> >
> > is missing a Signed-off-by from its author.
>
> I split the original patch in 2 and fixed a bug in this second patch,
> but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
> staying on both
Yep. Thanks!
Signed-off-by: Dan Carpenter
regards,
dan carpenter
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
>
> is missing a Signed-off-by from its author.
I split the original patch in 2 and fixed a bug in this second patch,
but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
staying on both
--b.
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Fri, Feb 23, 2018 at 12:41:05PM +, James Ettle wrote: > I'm OK with that. (This is the first time I've ventured into kernel space so > I thought it better to at least sketch a solution and let the experts do it > correctly ;) Glad it's passed the review!) OK, thanks!--b.
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
Hello,
I'm OK with that. (This is the first time I've ventured into kernel space so I
thought it better to at least sketch a solution and let the experts do it
correctly ;) Glad it's passed the review!)
Thanks,
James.
On 23 February 2018 01:05:45 GMT+00:00, "J. Bruce Fields"
wrote:
>On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote:
>> I only really posted this as a demo of a fix. I was hoping someone
>who actually knows what they're doing in the kernel would pick it up
>and make it proper.
>
>Whoops, sorry, I didn't realize that.
>
>But I don't see a problem with the patch as it is. Are you OK with me
>adding your signed-off-by?
>
>--b.
>
>>
>> Thanks,
>> James.
>>
>>
>> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell
> wrote:
>> >Hi,
>> >
>> >Commit
>> >
>> > 35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
>> >
>> >is missing a Signed-off-by from its author.
>> >
>> >--
>> >Cheers,
>> >Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote:
> I only really posted this as a demo of a fix. I was hoping someone who
> actually knows what they're doing in the kernel would pick it up and make it
> proper.
Whoops, sorry, I didn't realize that.
But I don't see a problem with the patch as it is. Are you OK with me
adding your signed-off-by?
--b.
>
> Thanks,
> James.
>
>
> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell
> wrote:
> >Hi,
> >
> >Commit
> >
> > 35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
> >
> >is missing a Signed-off-by from its author.
> >
> >--
> >Cheers,
> >Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
Hi Bruce, On Mon, 27 Nov 2017 20:38:40 -0500 "J. Bruce Fields" wrote: > > I rebased (probably unnecessarily, sorry), so your scripts probably > caught this as a new commit. Ah, OK, sorry for the noise. -- Cheers, Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
>
> Commit
>
> 64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from
> nfs4_laundromat")
>
> is missing a Signed-off-by from its author.
Previously:
http://lkml.kernel.org/r/20171109200609.gm8...@fieldses.org
It fixes a typo in two lines in pretty much the only way
possible, so there should not be copyright concerns.
Naofumi Honda is as far as I know a one-time contributor, and
I'd prefer not to burden such folks with unnecessary
bureaucracy.
I rebased (probably unnecessarily, sorry), so your scripts probably
caught this as a new commit.
--b.
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote:
> Hi,
>
> Commit
>
> 988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from
> nfs4_laundromat")
>
> is missing a Signed-off-by from its author.
It fixes a typo in two lines in pretty much the only way possible, so
there should not be copyright concerns.
Naofumi Honda is as far as I know a one-time contributor, and I'd prefer
not to burden such folks with unnecessary bureaucracy.
--b.
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Thu, Aug 24, 2017 at 10:21:41PM -0400, J. Bruce Fields wrote:
> On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> > Hi Bruce,
> >
> > Commit
> >
> > 1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> >
> > is missing a Signed-off-by from its author and committer.
>
> Fixed, thanks.--b.
And, sorry, somehow I lost your other message, but: the compiler errors
should also have been fixed. (As should be the testing error that let
them slip through--I thought I had CONFIG_NFSD_PNFS turned on in my
testing, but I didn't.)
--b.
Re: linux-next: Signed-off-by missing for commit in the nfsd tree
On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> Hi Bruce,
>
> Commit
>
> 1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
>
> is missing a Signed-off-by from its author and committer.
Fixed, thanks.--b.
