Re: linux-next: build warning after merge of the pm tree
On Wednesday, March 31, 2021 8:22:54 AM CEST Vitaly Kuznetsov wrote: > Stephen Rothwell writes: > > > Hi all, > > > > After merging the pm tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > drivers/acpi/processor_idle.c: In function 'acpi_idle_play_dead': > > drivers/acpi/processor_idle.c:542:15: warning: extra tokens at end of > > #ifdef directive > > 542 | #ifdef defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU) > > | ^ > > > > Sigh, smaller the patch, more iterations it will take to make it > right > > Rafael, > > something went wrong when you folded in my "[PATCH] ACPI: processor: Fix > build when !CONFIG_HOTPLUG_CPU" here. This line should be: > > #if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU) Right, my mistake, sorry. Fixed yesterday. Thanks!
Re: linux-next: build warning after merge of the pm tree
Stephen Rothwell writes:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/acpi/processor_idle.c: In function 'acpi_idle_play_dead':
> drivers/acpi/processor_idle.c:542:15: warning: extra tokens at end of #ifdef
> directive
> 542 | #ifdef defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU)
> | ^
>
Sigh, smaller the patch, more iterations it will take to make it
right
Rafael,
something went wrong when you folded in my "[PATCH] ACPI: processor: Fix
build when !CONFIG_HOTPLUG_CPU" here. This line should be:
#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU)
(not #ifdef defined ...)
> Introduced by commit
>
> bc5706eaeae0 ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
--
Vitaly
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Mon, 15 Feb 2021 11:39:39 +1100 Stephen Rothwell
wrote:
>
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> In file included from drivers/gpu/drm/gma500/mdfld_output.c:28:
> arch/x86/include/asm/intel_scu_ipc.h:23:12: warning: 'struct module' declared
> inside parameter list will not be visible outside of this definition or
> declaration
>23 | struct module *owner);
> |^~
> arch/x86/include/asm/intel_scu_ipc.h:33:17: warning: 'struct module' declared
> inside parameter list will not be visible outside of this definition or
> declaration
>33 | struct module *owner);
> | ^~
>
> Introduced by commit
>
> bfc838f8598e ("drm/gma500: Convert to use new SCU IPC API")
>
> OK, these will go away when the drm-misc tree removes this file in commit
>
> e1da811218d2 ("drm/gma500: Remove Medfield support")
>
> So, if you don't want to see these warnings in Linus' build testing,
> you need to make sure that the drm-misc tree is merged before the pm
> tree (or the drivers-x86 tree). Or you need to include module.h in
> mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
The above drm-misc commit is now in Linus' tree.
--
Cheers,
Stephen Rothwell
pgpnc5sEbl2s2.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
+Cc: Patrik (JFYI).
On Mon, Feb 15, 2021 at 12:23 PM Andy Shevchenko
wrote:
>
> On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > In file included from drivers/gpu/drm/gma500/mdfld_output.c:28:
> > arch/x86/include/asm/intel_scu_ipc.h:23:12: warning: 'struct module'
> > declared inside parameter list will not be visible outside of this
> > definition or declaration
> >23 | struct module *owner);
> > |^~
> > arch/x86/include/asm/intel_scu_ipc.h:33:17: warning: 'struct module'
> > declared inside parameter list will not be visible outside of this
> > definition or declaration
> >33 | struct module *owner);
> > | ^~
> >
> > Introduced by commit
> >
> > bfc838f8598e ("drm/gma500: Convert to use new SCU IPC API")
> >
> > OK, these will go away when the drm-misc tree removes this file in commit
> >
> > e1da811218d2 ("drm/gma500: Remove Medfield support")
> >
> > So, if you don't want to see these warnings in Linus' build testing,
> > you need to make sure that the drm-misc tree is merged before the pm
> > tree (or the drivers-x86 tree). Or you need to include module.h in
> > mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
>
> Thanks for the report.
> I guess the DRM tree should carry this burden, or they can merge the
> immutable tag themselves.
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
Re: linux-next: build warning after merge of the pm tree
On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> In file included from drivers/gpu/drm/gma500/mdfld_output.c:28:
> arch/x86/include/asm/intel_scu_ipc.h:23:12: warning: 'struct module' declared
> inside parameter list will not be visible outside of this definition or
> declaration
>23 | struct module *owner);
> |^~
> arch/x86/include/asm/intel_scu_ipc.h:33:17: warning: 'struct module' declared
> inside parameter list will not be visible outside of this definition or
> declaration
>33 | struct module *owner);
> | ^~
>
> Introduced by commit
>
> bfc838f8598e ("drm/gma500: Convert to use new SCU IPC API")
>
> OK, these will go away when the drm-misc tree removes this file in commit
>
> e1da811218d2 ("drm/gma500: Remove Medfield support")
>
> So, if you don't want to see these warnings in Linus' build testing,
> you need to make sure that the drm-misc tree is merged before the pm
> tree (or the drivers-x86 tree). Or you need to include module.h in
> mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
Thanks for the report.
I guess the DRM tree should carry this burden, or they can merge the
immutable tag themselves.
--
With Best Regards,
Andy Shevchenko
Re: linux-next: build warning after merge of the pm tree
Hi, Stephen,
Sorry that I missed this build warning in the first place, thanks for
reporting.
The patch below fixes it.
BTW, Rafael, I think acpi_fpdt_init() also needs to be fixed to have
proper return value.
Do you prefer an incremental patch or a V2 of 208757d71098 ("ACPI:
tables: introduce support for FPDT table"), which includes all these
fixes?
thanks,
rui
>From 2b8ed148351875b4bf227602a97edba12d08af7e Mon Sep 17 00:00:00 2001
From: Zhang Rui
Date: Wed, 27 Jan 2021 11:33:33 +0800
Subject: [PATCH] ACPI: FPDT: fix build warning
Fix a build warning,
In file included from ./include/linux/printk.h:7:0,
from ./include/linux/kernel.h:16,
from ./include/linux/list.h:9,
from ./include/linux/kobject.h:19,
from ./include/linux/of.h:17,
from ./include/linux/irqdomain.h:35,
from ./include/linux/acpi.h:13,
from drivers/acpi/acpi_fpdt.c:11:
drivers/acpi/acpi_fpdt.c: In function ‘acpi_init_fpdt’:
./include/linux/kern_levels.h:5:18: warning: too many arguments for format
[-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
./include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~
./include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro ‘pr_info’
pr_info(FW_BUG, "Invalid subtable type %d found.\n",
^~~
Signed-off-by: Zhang Rui
---
drivers/acpi/acpi_fpdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
index b8108117262a..64d5733dca0b 100644
--- a/drivers/acpi/acpi_fpdt.c
+++ b/drivers/acpi/acpi_fpdt.c
@@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
subtable->type);
break;
default:
- pr_info(FW_BUG, "Invalid subtable type %d found.\n",
+ pr_info(FW_BUG "Invalid subtable type %d found.\n",
subtable->type);
return;
}
--
2.17.1
On Wed, 2021-01-27 at 12:43 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64
> allmodconfig)
> produced this warning:
>
> In file included from include/linux/printk.h:7,
> from include/linux/kernel.h:16,
> from include/linux/list.h:9,
> from include/linux/kobject.h:19,
> from include/linux/of.h:17,
> from include/linux/irqdomain.h:35,
> from include/linux/acpi.h:13,
> from drivers/acpi/acpi_fpdt.c:11:
> drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> include/linux/kern_levels.h:5:18: warning: too many arguments for
> format [-Wformat-extra-args]
> 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> | ^~
> include/linux/kern_levels.h:14:19: note: in expansion of macro
> 'KERN_SOH'
>14 | #define KERN_INFO KERN_SOH "6" /* informational */
> | ^~~~
> include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO'
> 373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> | ^
> drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
> 255 |pr_info(FW_BUG, "Invalid subtable type %d found.\n",
> |^~~
>
> Introduced by commit
>
> 208757d71098 ("ACPI: tables: introduce support for FPDT table")
>
Re: linux-next: build warning after merge of the pm tree
On Thu, Nov 19, 2020 at 11:09:01AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in kernel/resource_kunit.o
>
> Introduced by commit
>
> 5df38ca6afec ("resource: Add test cases for new resource API")
I have sent a fix, thanks.
The cause was the same as for previous similar issue, i.e. KUnit silently
compiled and run tests even if the build process had warnings. I have been
told that it's now fixed in their tree and soon should be propagated further.
--
With Best Regards,
Andy Shevchenko
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Thu, 8 Oct 2020 20:35:59 +1100 Stephen Rothwell
wrote:
>
> On Thu, 1 Oct 2020 19:43:37 +1000 Stephen Rothwell
> wrote:
> >
> > On Tue, 22 Sep 2020 18:11:26 +1000 Stephen Rothwell
> > wrote:
> > >
> > > After merging the pm tree, today's linux-next build (i386 defconfig)
> > > produced this warning:
> > >
> > > In file included from include/acpi/acpi.h:24,
> > > from drivers/acpi/acpica/hwgpe.c:10:
> > > drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_read':
> > > include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> > > different size [-Wint-to-pointer-cast]
> > > 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t)
> > > (p))
> > > |^
> > > drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> > > 'ACPI_CAST_PTR'
> > >18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> > > | ^
> > > drivers/acpi/acpica/acmacros.h:22:43: note: in expansion of macro
> > > 'ACPI_CAST8'
> > >22 | #define ACPI_GET8(ptr) (*ACPI_CAST8 (ptr))
> > > | ^~
> > > drivers/acpi/acpica/hwgpe.c:50:17: note: in expansion of macro 'ACPI_GET8'
> > >50 | *value = (u64)ACPI_GET8(reg->address);
> > > | ^
> > > drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_write':
> > > include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> > > different size [-Wint-to-pointer-cast]
> > > 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t)
> > > (p))
> > > |^
> > > drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> > > 'ACPI_CAST_PTR'
> > >18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> > > | ^
> > > drivers/acpi/acpica/acmacros.h:26:43: note: in expansion of macro
> > > 'ACPI_CAST8'
> > >26 | #define ACPI_SET8(ptr, val) (*ACPI_CAST8 (ptr) = (u8)
> > > (val))
> > > | ^~
> > > drivers/acpi/acpica/hwgpe.c:85:3: note: in expansion of macro 'ACPI_SET8'
> > >85 | ACPI_SET8(reg->address, value);
> > > | ^
> > >
> > > Introduced by commit
> > >
> > > 7a8379eb41a4 ("ACPICA: Add support for using logical addresses of GPE
> > > blocks")
> >
> > I am still getting these warnings ...
>
> Still there :-(
This is now in Linus' tree :-(
--
Cheers,
Stephen Rothwell
pgpJZk8aVcmki.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Thu, 1 Oct 2020 19:43:37 +1000 Stephen Rothwell
wrote:
>
> On Tue, 22 Sep 2020 18:11:26 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the pm tree, today's linux-next build (i386 defconfig)
> > produced this warning:
> >
> > In file included from include/acpi/acpi.h:24,
> > from drivers/acpi/acpica/hwgpe.c:10:
> > drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_read':
> > include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> > different size [-Wint-to-pointer-cast]
> > 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p))
> > |^
> > drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> > 'ACPI_CAST_PTR'
> >18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> > | ^
> > drivers/acpi/acpica/acmacros.h:22:43: note: in expansion of macro
> > 'ACPI_CAST8'
> >22 | #define ACPI_GET8(ptr) (*ACPI_CAST8 (ptr))
> > | ^~
> > drivers/acpi/acpica/hwgpe.c:50:17: note: in expansion of macro 'ACPI_GET8'
> >50 | *value = (u64)ACPI_GET8(reg->address);
> > | ^
> > drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_write':
> > include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> > different size [-Wint-to-pointer-cast]
> > 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p))
> > |^
> > drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> > 'ACPI_CAST_PTR'
> >18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> > | ^
> > drivers/acpi/acpica/acmacros.h:26:43: note: in expansion of macro
> > 'ACPI_CAST8'
> >26 | #define ACPI_SET8(ptr, val) (*ACPI_CAST8 (ptr) = (u8)
> > (val))
> > | ^~
> > drivers/acpi/acpica/hwgpe.c:85:3: note: in expansion of macro 'ACPI_SET8'
> >85 | ACPI_SET8(reg->address, value);
> > | ^
> >
> > Introduced by commit
> >
> > 7a8379eb41a4 ("ACPICA: Add support for using logical addresses of GPE
> > blocks")
>
> I am still getting these warnings ...
Still there :-(
--
Cheers,
Stephen Rothwell
pgpasDyjUVceQ.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Tue, 22 Sep 2020 18:11:26 +1000 Stephen Rothwell
wrote:
>
> After merging the pm tree, today's linux-next build (i386 defconfig)
> produced this warning:
>
> In file included from include/acpi/acpi.h:24,
> from drivers/acpi/acpica/hwgpe.c:10:
> drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_read':
> include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
> 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p))
> |^
> drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> 'ACPI_CAST_PTR'
>18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> | ^
> drivers/acpi/acpica/acmacros.h:22:43: note: in expansion of macro 'ACPI_CAST8'
>22 | #define ACPI_GET8(ptr) (*ACPI_CAST8 (ptr))
> | ^~
> drivers/acpi/acpica/hwgpe.c:50:17: note: in expansion of macro 'ACPI_GET8'
>50 | *value = (u64)ACPI_GET8(reg->address);
> | ^
> drivers/acpi/acpica/hwgpe.c: In function 'acpi_hw_gpe_write':
> include/acpi/actypes.h:501:48: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
> 501 | #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p))
> |^
> drivers/acpi/acpica/acmacros.h:18:41: note: in expansion of macro
> 'ACPI_CAST_PTR'
>18 | #define ACPI_CAST8(ptr) ACPI_CAST_PTR (u8, (ptr))
> | ^
> drivers/acpi/acpica/acmacros.h:26:43: note: in expansion of macro 'ACPI_CAST8'
>26 | #define ACPI_SET8(ptr, val) (*ACPI_CAST8 (ptr) = (u8)
> (val))
> | ^~
> drivers/acpi/acpica/hwgpe.c:85:3: note: in expansion of macro 'ACPI_SET8'
>85 | ACPI_SET8(reg->address, value);
> | ^
>
> Introduced by commit
>
> 7a8379eb41a4 ("ACPICA: Add support for using logical addresses of GPE
> blocks")
I am still getting these warnings ...
--
Cheers,
Stephen Rothwell
pgph6K26zGLZc.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
This warning should be fixed also.
Should I send another patch?
Thanks !
On Thu, 2020-07-30 at 12:55 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/acpi/processor_idle.c: In function 'acpi_idle_enter_s2idle':
> drivers/acpi/processor_idle.c:666:4: warning: 'return' with no value, in
> function returning non-void [-Wreturn-type]
> 666 |return;
> |^~
> drivers/acpi/processor_idle.c:657:12: note: declared here
> 657 | static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
> |^~
> drivers/acpi/processor_idle.c:670:4: warning: 'return' with no value, in
> function returning non-void [-Wreturn-type]
> 670 |return;
> |^~
> drivers/acpi/processor_idle.c:657:12: note: declared here
> 657 | static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
> |^~
>
> Introduced by commit
>
> efe9711214e6 ("cpuidle: change enter_s2idle() prototype")
>
Re: linux-next: build warning after merge of the pm tree
On Tuesday, October 15, 2019 10:23:33 AM CEST Andy Shevchenko wrote:
> On Tue, Oct 15, 2019 at 10:08:55AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > In file included from include/linux/irqchip.h:14,
> > from arch/arm/kernel/irq.c:26:
> > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside
> > parameter list will not be visible outside of this definition or declaration
> > 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2,
> > const char *uid2)
> > | ^~~
> >
> > and many more.
> >
> > Introduced by commit
> >
> > d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> >
> > CONFIG_ACPI is not set for this build.
>
> I'm puzzled. Why it builds before?
>
> Another function has struct acpi_device *adev in its prototype and it was
> before above mentioned commit.
Right.
The very next acpi_dev_get_first_match_dev() returns a pointer to
struct acpi_device too and it is not modified by the commit in question.
There may be a bug in there, but commit d1748b57dc88 doesn't look like the
source of it.
Re: linux-next: build warning after merge of the pm tree
On Tue, Oct 15, 2019 at 10:08:55AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/irqchip.h:14,
> from arch/arm/kernel/irq.c:26:
> include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside
> parameter list will not be visible outside of this definition or declaration
> 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2,
> const char *uid2)
> | ^~~
>
> and many more.
>
> Introduced by commit
>
> d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
>
> CONFIG_ACPI is not set for this build.
I'm puzzled. Why it builds before?
Another function has struct acpi_device *adev in its prototype and it was
before above mentioned commit.
--
With Best Regards,
Andy Shevchenko
Re: linux-next: build warning after merge of the pm tree
On Thursday, July 11, 2019 7:46:29 AM CEST wen.yan...@zte.com.cn wrote:
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/cpufreq/pasemi-cpufreq.c: In function 'pas_cpufreq_cpu_init':
> > drivers/cpufreq/pasemi-cpufreq.c:199:1: warning: label 'out_unmap_sdcpwr'
> > defined but not used [-Wunused-label]
> > out_unmap_sdcpwr:
> > ^~~~
> >
> > Introduced by commit
> >
> > f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in
> > pas_cpufreq_cpu_init()")
>
> Thank you very much.
>
> We need to delete the useless code here:
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c
> b/drivers/cpufreq/pasemi-cpufreq.c
> index 1f0beb7..624c34a 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -195,9 +195,6 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy
> *policy)
>
> return cpufreq_generic_init(policy, pas_freqs, get_gizmo_latency());
>
> -out_unmap_sdcpwr:
> - iounmap(sdcpwr_mapbase);
> -
> out_unmap_sdcasr:
> iounmap(sdcasr_mapbase);
> out:
I'm dropping commit f43e075f7252 from my linux-next branch, so please send a
new version
of that patch with the issue fixed.
If you consider alternatives to the patch, please describe them in the message
section between
the patch and the changelog.
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Mon, 30 Jul 2018 10:24:45 +0300 Sakari Ailus
wrote:
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > unsigned int idx;
> >^~~
> >
> > Introduced by commit
> >
> > aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> >
> > Looks like a false positive, but not something that gcc can easily see.
>
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.
Yeah, sorry, process failure. This should have been reported against
the v4l-dvb tree.
--
Cheers,
Stephen Rothwell
pgpBlGF4sQD14.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
Hi all,
On Mon, 30 Jul 2018 10:24:45 +0300 Sakari Ailus
wrote:
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > unsigned int idx;
> >^~~
> >
> > Introduced by commit
> >
> > aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> >
> > Looks like a false positive, but not something that gcc can easily see.
>
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.
Yeah, sorry, process failure. This should have been reported against
the v4l-dvb tree.
--
Cheers,
Stephen Rothwell
pgpBlGF4sQD14.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the pm tree
Hi,
On Mon, Jul 30, 2018 at 10:24:45AM +0300, Sakari Ailus wrote:
> Hi folks,
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > unsigned int idx;
> >^~~
> >
> > Introduced by commit
> >
> > aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> >
> > Looks like a false positive, but not something that gcc can easily see.
>
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.
>
Yes, my bad, it is a false positive and I ignored it,
sorry about that. There is already a patch sent to linux-media to fix
this on top of the driver.
https://patchwork.kernel.org/patch/10547983/
Thanks
j
> --
> Regards,
>
> Sakari Ailus
> sakari.ai...@linux.intel.com
signature.asc
Description: PGP signature
Re: linux-next: build warning after merge of the pm tree
Hi,
On Mon, Jul 30, 2018 at 10:24:45AM +0300, Sakari Ailus wrote:
> Hi folks,
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> > drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > unsigned int idx;
> >^~~
> >
> > Introduced by commit
> >
> > aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
> >
> > Looks like a false positive, but not something that gcc can easily see.
>
> This must be coming from a new driver merged to media tree recently. Thanks
> for reporting this.
>
Yes, my bad, it is a false positive and I ignored it,
sorry about that. There is already a patch sent to linux-media to fix
this on top of the driver.
https://patchwork.kernel.org/patch/10547983/
Thanks
j
> --
> Regards,
>
> Sakari Ailus
> sakari.ai...@linux.intel.com
signature.asc
Description: PGP signature
Re: linux-next: build warning after merge of the pm tree
Hi folks,
On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized
> in this function [-Wmaybe-uninitialized]
> unsigned int idx;
>^~~
>
> Introduced by commit
>
> aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
>
> Looks like a false positive, but not something that gcc can easily see.
This must be coming from a new driver merged to media tree recently. Thanks
for reporting this.
--
Regards,
Sakari Ailus
sakari.ai...@linux.intel.com
Re: linux-next: build warning after merge of the pm tree
Hi folks,
On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
> drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized
> in this function [-Wmaybe-uninitialized]
> unsigned int idx;
>^~~
>
> Introduced by commit
>
> aab7ed1c3927 ("media: i2c: Add driver for Aptina MT9V111")
>
> Looks like a false positive, but not something that gcc can easily see.
This must be coming from a new driver merged to media tree recently. Thanks
for reporting this.
--
Regards,
Sakari Ailus
sakari.ai...@linux.intel.com
Re: linux-next: build warning after merge of the pm tree
On Friday, June 8, 2018 2:30:35 AM CEST Stephen Rothwell wrote:
>
> --Sig_/ncqmE76IGCiWNItKgM.lURc
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
>
> Hi all,
Hi,
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: vmlinux.o(.text+0xc5b83a): Section mismatch in reference from the =
> function __intel_pstate_cpu_init() to the variable .init.rodata:intel_pstat=
> e_hwp_boost_ids
> The function __intel_pstate_cpu_init() references
> the variable __initconst intel_pstate_hwp_boost_ids.
> This is often because __intel_pstate_cpu_init lacks a __initconst=20
> annotation or the annotation of intel_pstate_hwp_boost_ids is wrong.
>
> Introduced by commit
>
> f50f70793d78 ("cpufreq: intel_pstate: enable boost for Skylake Xeon")
Thanks for the report!
I've dropped the __initconst annotation from intel_pstate_hwp_boost_ids[].
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
On Friday, June 8, 2018 2:30:35 AM CEST Stephen Rothwell wrote:
>
> --Sig_/ncqmE76IGCiWNItKgM.lURc
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
>
> Hi all,
Hi,
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> WARNING: vmlinux.o(.text+0xc5b83a): Section mismatch in reference from the =
> function __intel_pstate_cpu_init() to the variable .init.rodata:intel_pstat=
> e_hwp_boost_ids
> The function __intel_pstate_cpu_init() references
> the variable __initconst intel_pstate_hwp_boost_ids.
> This is often because __intel_pstate_cpu_init lacks a __initconst=20
> annotation or the annotation of intel_pstate_hwp_boost_ids is wrong.
>
> Introduced by commit
>
> f50f70793d78 ("cpufreq: intel_pstate: enable boost for Skylake Xeon")
Thanks for the report!
I've dropped the __initconst annotation from intel_pstate_hwp_boost_ids[].
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
On Monday, April 9, 2018 3:24:38 AM CEST Stephen Rothwell wrote: > > --Sig_/QL=OZEguM./+7xhHdQruHaV > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > After merging the pm tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': > kernel/time/tick-sched.c:1162:3: warning: 'now' may be used uninitialized i= > n this function [-Wmaybe-uninitialized] >__tick_nohz_idle_restart_tick(ts, now); >^~ > kernel/time/tick-sched.c:1146:10: note: 'now' was declared here > ktime_t now; > ^~~ > > This appears to be a false positive. > > And another in the x86_64 allmodconfig build: > > kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': > kernel/time/tick-sched.c:538:2: warning: 'now' may be used uninitialized in= > this function [-Wmaybe-uninitialized] > update_ts_time_stats(smp_processor_id(), ts, now, NULL); > ^~~ > kernel/time/tick-sched.c:1146:10: note: 'now' was declared here > ktime_t now; > ^~~ > > also looks like a false positive. Yes, they are false positives AFAICS. Cheers, Rafael
Re: linux-next: build warning after merge of the pm tree
On Monday, April 9, 2018 3:24:38 AM CEST Stephen Rothwell wrote: > > --Sig_/QL=OZEguM./+7xhHdQruHaV > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > After merging the pm tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': > kernel/time/tick-sched.c:1162:3: warning: 'now' may be used uninitialized i= > n this function [-Wmaybe-uninitialized] >__tick_nohz_idle_restart_tick(ts, now); >^~ > kernel/time/tick-sched.c:1146:10: note: 'now' was declared here > ktime_t now; > ^~~ > > This appears to be a false positive. > > And another in the x86_64 allmodconfig build: > > kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': > kernel/time/tick-sched.c:538:2: warning: 'now' may be used uninitialized in= > this function [-Wmaybe-uninitialized] > update_ts_time_stats(smp_processor_id(), ts, now, NULL); > ^~~ > kernel/time/tick-sched.c:1146:10: note: 'now' was declared here > ktime_t now; > ^~~ > > also looks like a false positive. Yes, they are false positives AFAICS. Cheers, Rafael
Re: linux-next: build warning after merge of the pm tree
Hi Rafeal,
Good catch, I need to set lpstate_idx = gpstate_idx.
I will send a patch which fixes this commit.
Thanks Stephen for reporting it. :)
Regards
Akshay Adiga
On 11/14/2016 05:33 AM, Rafael J. Wysocki wrote:
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Rafael,
Hi Stephen,
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may
be used uninitialized in this function [-Wmaybe-uninitialized]
> if (gpstate_idx != gpstates->last_lpstate_idx)
> ^
>
> Introduced by commit
>
> 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and
local pstate")
Thanks for the notice!
Akshay, any thoughts?
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
Hi Rafeal,
Good catch, I need to set lpstate_idx = gpstate_idx.
I will send a patch which fixes this commit.
Thanks Stephen for reporting it. :)
Regards
Akshay Adiga
On 11/14/2016 05:33 AM, Rafael J. Wysocki wrote:
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Rafael,
Hi Stephen,
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may
be used uninitialized in this function [-Wmaybe-uninitialized]
> if (gpstate_idx != gpstates->last_lpstate_idx)
> ^
>
> Introduced by commit
>
> 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and
local pstate")
Thanks for the notice!
Akshay, any thoughts?
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Rafael,
Hi Stephen,
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> if (gpstate_idx != gpstates->last_lpstate_idx)
> ^
>
> Introduced by commit
>
> 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and local
> pstate")
Thanks for the notice!
Akshay, any thoughts?
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Rafael,
Hi Stephen,
> After merging the pm tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/cpufreq/powernv-cpufreq.c: In function 'gpstate_timer_handler':
> drivers/cpufreq/powernv-cpufreq.c:642:5: warning: 'lpstate_idx' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> if (gpstate_idx != gpstates->last_lpstate_idx)
> ^
>
> Introduced by commit
>
> 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and local
> pstate")
Thanks for the notice!
Akshay, any thoughts?
Thanks,
Rafael
Re: linux-next: build warning after merge of the pm tree
On Tuesday, November 18, 2014 12:45:09 AM Paul Bolle wrote: > On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote: > > I'll drop the commit for now, but this looks strange. > > > > Had you cleaned up the kernel configuration after dropping the PM_RUNTIME > > select > > from ARCH_EXYNOS? > > I retested this again: > > [linux * (next-20141117)]$ git status > HEAD detached at next-20141117 > nothing to commit (use -u to show untracked files) > [linux * (next-20141117)]$ make clean > [linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config > [linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24: > [linux * (next-20141117)]$ git diff > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index e4a00bafffc1..02ff8534238b 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PINCTRL_EXYNOS > - select PM_GENERIC_DOMAINS if PM_RUNTIME > select S5P_DEV_MFC > select SRAM > select MFD_SYSCON > [linux * (next-20141117)]$ yes "" | make ARCH=arm oldconfig >/dev/null > kernel/power/Kconfig:145:error: recursive dependency detected! > kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME > kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by > PM_GENERIC_DOMAINS > kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM > > Can you reproduce the above? I can't personally. Anyway, I'm going to drop the commit as I said. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote: > I'll drop the commit for now, but this looks strange. > > Had you cleaned up the kernel configuration after dropping the PM_RUNTIME > select > from ARCH_EXYNOS? I retested this again: [linux * (next-20141117)]$ git status HEAD detached at next-20141117 nothing to commit (use -u to show untracked files) [linux * (next-20141117)]$ make clean [linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config [linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24: [linux * (next-20141117)]$ git diff diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index e4a00bafffc1..02ff8534238b 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS select HAVE_S3C_RTC if RTC_CLASS select PINCTRL select PINCTRL_EXYNOS - select PM_GENERIC_DOMAINS if PM_RUNTIME select S5P_DEV_MFC select SRAM select MFD_SYSCON [linux * (next-20141117)]$ yes "" | make ARCH=arm oldconfig >/dev/null kernel/power/Kconfig:145:error: recursive dependency detected! kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM Can you reproduce the above? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Monday, November 17, 2014 12:31:43 PM Paul Bolle wrote:
> On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (arm multi_v7_defconfig)
> > produced this warning:
> >
> > kernel/power/Kconfig:132:error: recursive dependency detected!
> > kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by
> > PM_GENERIC_DOMAINS
> > kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by
> > PM_RUNTIME
> >
> > Caused by commit 9cdd5fd742e6 ("PM / domains: Kconfig: always enable
> > PM_RUNTIME when genpd enabled").
>
> This error also popped up when I fiddled with omap2plus_defconfig on top
> of next-20141117. Note that I ended up with a .config which has
> CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the
> Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It
> contains
> select PM_GENERIC_DOMAINS if PM_RUNTIME
>
> (Perhaps the :272: line needs rephrasing in the error Stephen quoted. It
> confused me quite a bit.)
>
> Naively dropping that select statement from ARCH_EXYNOS triggered yet
> another error:
> kernel/power/Kconfig:145:error: recursive dependency detected!
> kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME
> kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by
> PM_GENERIC_DOMAINS
> kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM
>
> After that I admitted defeat.
I'll drop the commit for now, but this looks strange.
Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select
from ARCH_EXYNOS?
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (arm multi_v7_defconfig)
> produced this warning:
>
> kernel/power/Kconfig:132:error: recursive dependency detected!
> kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by
> PM_GENERIC_DOMAINS
> kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by
> PM_RUNTIME
>
> Caused by commit 9cdd5fd742e6 ("PM / domains: Kconfig: always enable
> PM_RUNTIME when genpd enabled").
This error also popped up when I fiddled with omap2plus_defconfig on top
of next-20141117. Note that I ended up with a .config which has
CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the
Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It
contains
select PM_GENERIC_DOMAINS if PM_RUNTIME
(Perhaps the :272: line needs rephrasing in the error Stephen quoted. It
confused me quite a bit.)
Naively dropping that select statement from ARCH_EXYNOS triggered yet
another error:
kernel/power/Kconfig:145:error: recursive dependency detected!
kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME
kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by
PM_GENERIC_DOMAINS
kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM
After that I admitted defeat.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote: Hi Rafael, After merging the pm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: kernel/power/Kconfig:132:error: recursive dependency detected! kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME Caused by commit 9cdd5fd742e6 (PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled). This error also popped up when I fiddled with omap2plus_defconfig on top of next-20141117. Note that I ended up with a .config which has CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It contains select PM_GENERIC_DOMAINS if PM_RUNTIME (Perhaps the :272: line needs rephrasing in the error Stephen quoted. It confused me quite a bit.) Naively dropping that select statement from ARCH_EXYNOS triggered yet another error: kernel/power/Kconfig:145:error: recursive dependency detected! kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM After that I admitted defeat. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Monday, November 17, 2014 12:31:43 PM Paul Bolle wrote: On Mon, 2014-11-17 at 13:44 +1100, Stephen Rothwell wrote: Hi Rafael, After merging the pm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: kernel/power/Kconfig:132:error: recursive dependency detected! kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM_RUNTIME Caused by commit 9cdd5fd742e6 (PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled). This error also popped up when I fiddled with omap2plus_defconfig on top of next-20141117. Note that I ended up with a .config which has CONFIG_ARCH_MULTI_V7 set. The error appears to be triggered by the Kconfig entry for ARCH_EXYNOS (in arch/arm/mach-exynos/Kconfig). It contains select PM_GENERIC_DOMAINS if PM_RUNTIME (Perhaps the :272: line needs rephrasing in the error Stephen quoted. It confused me quite a bit.) Naively dropping that select statement from ARCH_EXYNOS triggered yet another error: kernel/power/Kconfig:145:error: recursive dependency detected! kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM After that I admitted defeat. I'll drop the commit for now, but this looks strange. Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select from ARCH_EXYNOS? Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote: I'll drop the commit for now, but this looks strange. Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select from ARCH_EXYNOS? I retested this again: [linux * (next-20141117)]$ git status HEAD detached at next-20141117 nothing to commit (use -u to show untracked files) [linux * (next-20141117)]$ make clean [linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config [linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24: [linux * (next-20141117)]$ git diff diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index e4a00bafffc1..02ff8534238b 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS select HAVE_S3C_RTC if RTC_CLASS select PINCTRL select PINCTRL_EXYNOS - select PM_GENERIC_DOMAINS if PM_RUNTIME select S5P_DEV_MFC select SRAM select MFD_SYSCON [linux * (next-20141117)]$ yes | make ARCH=arm oldconfig /dev/null kernel/power/Kconfig:145:error: recursive dependency detected! kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM Can you reproduce the above? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Tuesday, November 18, 2014 12:45:09 AM Paul Bolle wrote: On Tue, 2014-11-18 at 00:14 +0100, Rafael J. Wysocki wrote: I'll drop the commit for now, but this looks strange. Had you cleaned up the kernel configuration after dropping the PM_RUNTIME select from ARCH_EXYNOS? I retested this again: [linux * (next-20141117)]$ git status HEAD detached at next-20141117 nothing to commit (use -u to show untracked files) [linux * (next-20141117)]$ make clean [linux * (next-20141117)]$ cp arch/arm/configs/omap2plus_defconfig .config [linux * (next-20141117)]$ vim arch/arm/mach-exynos/Kconfig:24: [linux * (next-20141117)]$ git diff diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index e4a00bafffc1..02ff8534238b 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -21,7 +21,6 @@ menuconfig ARCH_EXYNOS select HAVE_S3C_RTC if RTC_CLASS select PINCTRL select PINCTRL_EXYNOS - select PM_GENERIC_DOMAINS if PM_RUNTIME select S5P_DEV_MFC select SRAM select MFD_SYSCON [linux * (next-20141117)]$ yes | make ARCH=arm oldconfig /dev/null kernel/power/Kconfig:145:error: recursive dependency detected! kernel/power/Kconfig:145: symbol PM depends on PM_RUNTIME kernel/power/Kconfig:132: symbol PM_RUNTIME is selected by PM_GENERIC_DOMAINS kernel/power/Kconfig:272: symbol PM_GENERIC_DOMAINS is selected by PM Can you reproduce the above? I can't personally. Anyway, I'm going to drop the commit as I said. Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Wednesday, October 29, 2014 11:23:38 PM Fengguang Wu wrote:
> On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> >
> > Hi,
> >
> > > After merging the pm tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > >
> > > drivers/of/base.c: In function 'of_property_read_string_array':
> > > drivers/of/base.c:1472:1: warning: control reaches end of non-void
> > > function [-Wreturn-type]
> > > }
> > > ^
> > >
> > > Introduced by commit ef23586751cd ("Driver core: Unified device
> > > properties interface for platform firmware").
> >
> > Thanks for reporting this!
> >
> > > Please don't ignore new warnings ...
> >
> > I don't as a rule. I'm not sure why I haven't seen that before (and the
> > kbuild
> > robot reports BUILD SUCCESS for that branch).
>
> I do find the build error id:
>
> -rw-rw-r-- 1 kbuild kbuild 272 2014-10-29 23:11
> /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
>
> However there happens to be an old one half year ago. Since I never
> delete old warnings, it prevents the reporting of the new warning on
> your tree..
>
> % cat
> /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
> drivers/of/base.c:1147:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>
> 2014-04-17 02:59:49 lkp-ib04
> socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b
> i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a
> 304933361c
>
> The easiest way to fix it is to delete any old error/warnings that
> have been *inactive* for more than 2 months (which means they are
> likely fixed).
That could be done more aggressively even in my view. If something is inactive
for two weeks, then it probably has been fixed (this way or another).
Kind regards,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> > Hi Rafael,
>
> Hi,
>
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/of/base.c: In function 'of_property_read_string_array':
> > drivers/of/base.c:1472:1: warning: control reaches end of non-void function
> > [-Wreturn-type]
> > }
> > ^
> >
> > Introduced by commit ef23586751cd ("Driver core: Unified device
> > properties interface for platform firmware").
>
> Thanks for reporting this!
>
> > Please don't ignore new warnings ...
>
> I don't as a rule. I'm not sure why I haven't seen that before (and the
> kbuild
> robot reports BUILD SUCCESS for that branch).
I do find the build error id:
-rw-rw-r-- 1 kbuild kbuild 272 2014-10-29 23:11
/kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
However there happens to be an old one half year ago. Since I never
delete old warnings, it prevents the reporting of the new warning on
your tree..
% cat
/kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
drivers/of/base.c:1147:1: warning: control reaches end of non-void function
[-Wreturn-type]
2014-04-17 02:59:49 lkp-ib04
socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b
i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a
304933361c
The easiest way to fix it is to delete any old error/warnings that
have been *inactive* for more than 2 months (which means they are
likely fixed).
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> Hi Rafael,
Hi,
> After merging the pm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/of/base.c: In function 'of_property_read_string_array':
> drivers/of/base.c:1472:1: warning: control reaches end of non-void function
> [-Wreturn-type]
> }
> ^
>
> Introduced by commit ef23586751cd ("Driver core: Unified device
> properties interface for platform firmware").
Thanks for reporting this!
> Please don't ignore new warnings ...
I don't as a rule. I'm not sure why I haven't seen that before (and the kbuild
robot reports BUILD SUCCESS for that branch).
Rafael
signature.asc
Description: This is a digitally signed message part.
Re: linux-next: build warning after merge of the pm tree
On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote: Hi Rafael, Hi, After merging the pm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/of/base.c: In function 'of_property_read_string_array': drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Introduced by commit ef23586751cd (Driver core: Unified device properties interface for platform firmware). Thanks for reporting this! Please don't ignore new warnings ... I don't as a rule. I'm not sure why I haven't seen that before (and the kbuild robot reports BUILD SUCCESS for that branch). Rafael signature.asc Description: This is a digitally signed message part.
Re: linux-next: build warning after merge of the pm tree
On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote: On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote: Hi Rafael, Hi, After merging the pm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/of/base.c: In function 'of_property_read_string_array': drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Introduced by commit ef23586751cd (Driver core: Unified device properties interface for platform firmware). Thanks for reporting this! Please don't ignore new warnings ... I don't as a rule. I'm not sure why I haven't seen that before (and the kbuild robot reports BUILD SUCCESS for that branch). I do find the build error id: -rw-rw-r-- 1 kbuild kbuild 272 2014-10-29 23:11 /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function However there happens to be an old one half year ago. Since I never delete old warnings, it prevents the reporting of the new warning on your tree.. % cat /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function drivers/of/base.c:1147:1: warning: control reaches end of non-void function [-Wreturn-type] 2014-04-17 02:59:49 lkp-ib04 socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a 304933361c The easiest way to fix it is to delete any old error/warnings that have been *inactive* for more than 2 months (which means they are likely fixed). Thanks, Fengguang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build warning after merge of the pm tree
On Wednesday, October 29, 2014 11:23:38 PM Fengguang Wu wrote: On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote: On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote: Hi Rafael, Hi, After merging the pm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/of/base.c: In function 'of_property_read_string_array': drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Introduced by commit ef23586751cd (Driver core: Unified device properties interface for platform firmware). Thanks for reporting this! Please don't ignore new warnings ... I don't as a rule. I'm not sure why I haven't seen that before (and the kbuild robot reports BUILD SUCCESS for that branch). I do find the build error id: -rw-rw-r-- 1 kbuild kbuild 272 2014-10-29 23:11 /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function However there happens to be an old one half year ago. Since I never delete old warnings, it prevents the reporting of the new warning on your tree.. % cat /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function drivers/of/base.c:1147:1: warning: control reaches end of non-void function [-Wreturn-type] 2014-04-17 02:59:49 lkp-ib04 socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a 304933361c The easiest way to fix it is to delete any old error/warnings that have been *inactive* for more than 2 months (which means they are likely fixed). That could be done more aggressively even in my view. If something is inactive for two weeks, then it probably has been fixed (this way or another). Kind regards, Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
