Re: linux-next: build warning after merge of the vfs tree
On Mon, Apr 12, 2021 at 03:07:56PM +0200, Miklos Szeredi wrote: > Hi Al, > > Fixed fileattr branch pushed to: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git fileattr_v6 Merged and pushed out...
Re: linux-next: build warning after merge of the vfs tree
Hi Al, Fixed fileattr branch pushed to: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git fileattr_v6 Thanks, Miklos On Mon, Apr 12, 2021 at 1:47 PM Stephen Rothwell wrote: > > Hi all, > > After merging the vfs tree, today's linux-next build (htmldocs) produced > this warning: > > Documentation/filesystems/locking.rst:113: WARNING: Malformed table. > Text in column margin in table line 24. > > = > ops i_rwsem(inode) > = > lookup: shared > create: exclusive > link: exclusive (both) > mknod: exclusive > symlink:exclusive > mkdir: exclusive > unlink: exclusive (both) > rmdir: exclusive (both)(see below) > rename: exclusive (all) (see below) > readlink: no > get_link: no > setattr:exclusive > permission: no (may not block if called in rcu-walk mode) > get_acl:no > getattr:no > listxattr: no > fiemap: no > update_time:no > atomic_open:shared (exclusive if O_CREAT is set in open flags) > tmpfile:no > fileattr_get: no or exclusive > fileattr_set: exclusive > = > > Introduced by commit > > 10a489bbff3e ("vfs: add fileattr ops") > > -- > Cheers, > Stephen Rothwell
Re: linux-next: build warning after merge of the vfs tree
On Thu, Jan 07, 2021 at 10:15:44AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from fs/erofs/xattr.h:10, > from fs/erofs/namei.c:7: > fs/erofs/namei.c: In function 'erofs_lookup': > fs/erofs/internal.h:23:21: warning: format '%s' expects argument of type > 'char *', but argument 4 has type 'struct dentry *' [-Wformat=] >23 | #define pr_fmt(fmt) "erofs: " fmt > | ^ > include/linux/dynamic_debug.h:129:15: note: in expansion of macro 'pr_fmt' > 129 | func(&id, ##__VA_ARGS__); \ > | ^~~ > include/linux/dynamic_debug.h:147:2: note: in expansion of macro > '__dynamic_func_call' > 147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) > | ^~~ > include/linux/dynamic_debug.h:157:2: note: in expansion of macro > '_dynamic_func_call' > 157 | _dynamic_func_call(fmt, __dynamic_pr_debug, \ > | ^~ > include/linux/printk.h:424:2: note: in expansion of macro 'dynamic_pr_debug' > 424 | dynamic_pr_debug(fmt, ##__VA_ARGS__) > | ^~~~ > fs/erofs/internal.h:34:33: note: in expansion of macro 'pr_debug' >34 | #define erofs_dbg(x, ...) pr_debug(x "\n", ##__VA_ARGS__) > | ^~~~ > fs/erofs/namei.c:237:3: note: in expansion of macro 'erofs_dbg' > 237 | erofs_dbg("%pd, %s (nid %llu) found, d_type %u", __func__, > | ^ > > Introduced by commit > > 879d4376533c ("erofs: use %pd instead of messing with ->d_name") Gyah... "%s, %pd", not "%pd, %s". Sorry, fixed and pushed.
Re: linux-next: build warning after merge of the vfs tree
Hi Al, On Thu, Jan 07, 2021 at 10:15:44AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from fs/erofs/xattr.h:10, > from fs/erofs/namei.c:7: > fs/erofs/namei.c: In function 'erofs_lookup': > fs/erofs/internal.h:23:21: warning: format '%s' expects argument of type > 'char *', but argument 4 has type 'struct dentry *' [-Wformat=] >23 | #define pr_fmt(fmt) "erofs: " fmt > | ^ > include/linux/dynamic_debug.h:129:15: note: in expansion of macro 'pr_fmt' > 129 | func(&id, ##__VA_ARGS__); \ > | ^~~ > include/linux/dynamic_debug.h:147:2: note: in expansion of macro > '__dynamic_func_call' > 147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) > | ^~~ > include/linux/dynamic_debug.h:157:2: note: in expansion of macro > '_dynamic_func_call' > 157 | _dynamic_func_call(fmt, __dynamic_pr_debug, \ > | ^~ > include/linux/printk.h:424:2: note: in expansion of macro 'dynamic_pr_debug' > 424 | dynamic_pr_debug(fmt, ##__VA_ARGS__) > | ^~~~ > fs/erofs/internal.h:34:33: note: in expansion of macro 'pr_debug' >34 | #define erofs_dbg(x, ...) pr_debug(x "\n", ##__VA_ARGS__) > | ^~~~ > fs/erofs/namei.c:237:3: note: in expansion of macro 'erofs_dbg' > 237 | erofs_dbg("%pd, %s (nid %llu) found, d_type %u", __func__, > | ^ Thanks for modifying this. Use %pd is more reasonable than using d_name... It might be fixed as "%s, %pd (nid %llu) ...", thanks for this! Thanks, Gao Xiang > > Introduced by commit > > 879d4376533c ("erofs: use %pd instead of messing with ->d_name") > > -- > Cheers, > Stephen Rothwell
Re: linux-next: build warning after merge of the vfs tree
On Thu, Sep 24, 2020 at 11:40:50AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > lib/strnlen_user.o: warning: objtool: strnlen_user()+0xf3: call to > do_strnlen_user() with UACCESS enabled > lib/strncpy_from_user.o: warning: objtool: strncpy_from_user()+0x188: call to > do_strncpy_from_user() with UACCESS enabled s/inline/__always_inline/ in those two... Will be there tonight; they should've been inlined anyway on any sane config...
Re: linux-next: build warning after merge of the vfs tree
Hi all, On Mon, 18 Mar 2019 11:00:50 +1100 Stephen Rothwell wrote: > > On Mon, 4 Feb 2019 09:33:34 +1100 Stephen Rothwell > wrote: > > > > After merging the vfs tree, today's linux-next build (arm > > multi_v7_defconfig) produced this warning: > > > > In file included from include/linux/printk.h:7, > > from include/linux/kernel.h:14, > > from include/linux/fs_context.h:15, > > from fs/fs_parser.c:13: > > fs/fs_parser.c: In function 'fs_validate_description': > > include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of > > type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] > > #define KERN_SOH "\001" /* ASCII Start Of Header */ > > ^~ > > include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' > > #define KERN_ERR KERN_SOH "3" /* error conditions */ > > ^~~~ > > include/linux/printk.h:303:9: note: in expansion of macro 'KERN_ERR' > > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > > ^~~~ > > fs/fs_parser.c:413:6: note: in expansion of macro 'pr_err' > > pr_err("VALIDATE %s: e[%lu] enum val for %s\n", > > ^~ > > fs/fs_parser.c:413:31: note: format string is defined here > > pr_err("VALIDATE %s: e[%lu] enum val for %s\n", > > ~~^ > > %u > > > > Introduced by commit > > > > f512b838c104 ("vfs: Add configuration parser helpers") > > We are now seeing that warning in Linus' tree :-( I am still getting the above warning ... -- Cheers, Stephen Rothwell pgpQYNZzk7g_x.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the vfs tree
Hi all, On Mon, 4 Feb 2019 09:33:34 +1100 Stephen Rothwell wrote: > > After merging the vfs tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > In file included from include/linux/printk.h:7, > from include/linux/kernel.h:14, > from include/linux/fs_context.h:15, > from fs/fs_parser.c:13: > fs/fs_parser.c: In function 'fs_validate_description': > include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of > type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] > #define KERN_SOH "\001" /* ASCII Start Of Header */ > ^~ > include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' > #define KERN_ERR KERN_SOH "3" /* error conditions */ > ^~~~ > include/linux/printk.h:303:9: note: in expansion of macro 'KERN_ERR' > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > ^~~~ > fs/fs_parser.c:413:6: note: in expansion of macro 'pr_err' > pr_err("VALIDATE %s: e[%lu] enum val for %s\n", > ^~ > fs/fs_parser.c:413:31: note: format string is defined here > pr_err("VALIDATE %s: e[%lu] enum val for %s\n", > ~~^ > %u > > Introduced by commit > > f512b838c104 ("vfs: Add configuration parser helpers") We are now seeing that warning in Linus' tree :-( -- Cheers, Stephen Rothwell pgpPHoIC8Pk04.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the vfs tree
Stephen Rothwell wrote: > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > security/selinux/hooks.c:2835:12: warning: 'selinux_sb_remount' defined but > not used [-Wunused-function] > static int selinux_sb_remount(struct super_block *sb, void *data, size_t > data_size) > ^~ > > Introduced by commit > > dfcf373eab92 ("vfs: Remove unused code after filesystem context changes") Sorry, I forgot to remove the function. It's no longer used, with the checks being done in selinux_validate_for_sb_reconfigure() now, called indirectly from the ->fs_context_validate() hook. David
Re: linux-next: build warning after merge of the vfs tree
On Thu, May 17, 2018 at 10:39:32AM +1000, Stephen Rothwell wrote: > Hi Al, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/isdn/gigaset/capi.c:2344:14: warning: 'gigaset_procinfo' defined but > not used [-Wunused-function] > static char *gigaset_procinfo(struct capi_ctr *ctr) The assignment for it was incorrectly removed. I'll send a set of fixes to Al.
Re: linux-next: build warning after merge of the vfs tree
Hi Al, On Fri, 8 Sep 2017 09:25:45 +1000 Stephen Rothwell wrote: > > After merging the vfs tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > kernel/signal.c: In function 'C_SYSC_rt_sigaction': > kernel/signal.c:3405:19: warning: unused variable 'mask' [-Wunused-variable] >compat_sigset_t mask; >^ > > Introduced by commit > > fc271087ebcb ("signal: replace sigset_to_compat() with put_compat_sigset()") I am still getting this warning ... -- Cheers, Stephen Rothwell
Re: linux-next: build warning after merge of the vfs tree
Hi, On Fri, Sep 08, 2017 at 09:25:45AM +1000, Stephen Rothwell wrote: > Hi Al, > > After merging the vfs tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > kernel/signal.c: In function 'C_SYSC_rt_sigaction': > kernel/signal.c:3405:19: warning: unused variable 'mask' [-Wunused-variable] >compat_sigset_t mask; >^ > > Introduced by commit > > fc271087ebcb ("signal: replace sigset_to_compat() with put_compat_sigset()") Thanks. The commit that made this variable unused is 9b24ec57688a ("get_compat_sigset()") -- ldv signature.asc Description: PGP signature
Re: linux-next: build warning after merge of the vfs tree
Hi Al, On Mon, 3 Jul 2017 10:53:47 +1000 Stephen Rothwell wrote: > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function > 'kiblnd_send': > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1643:2: warning: > ignoring return value of 'copy_from_iter', declared with attribute > warn_unused_result [-Wunused-result] > copy_from_iter(&ibmsg->ibm_u.immediate.ibim_payload, IBLND_MSG_SIZE, > ^ > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function > 'kiblnd_recv': > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1744:3: warning: > ignoring return value of 'copy_to_iter', declared with attribute > warn_unused_result [-Wunused-result] >copy_to_iter(&rxmsg->ibm_u.immediate.ibim_payload, >^ > > Introduced by commit > > aa28de275a24 ("iov_iter/hardening: move object size checks to inlined part") These are now in Linus' tree ... -- Cheers, Stephen Rothwell