Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Madhuparna Bhowmik
On Sat, May 09, 2020 at 12:59:37PM +0530, Amol Grover wrote:
> On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote:
> > 
> > 
> > > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik 
> > >  wrote:
> > > 
> > > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> > >> 
> > >> 
> > >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
> >  net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> > >> 
> > >> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> > >> 
> > >> Never been picked up for a few months due to some reasons. You could 
> > >> probably
> > >> need to convince David, Paul, Steven or Linus to unblock the bot or 
> > >> carry patches
> > >> on your own?
> > >> 
> >  net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> > >> 
> > >> Not sure about this if anyone is working on it. Adding a few people...
> > >> 
> > > I will have a look at this one.
> > > 
> >  
> >  other info that might help us debug this:
> >  
> >  
> >  rcu_scheduler_active = 2, debug_locks = 1
> >  1 lock held by swapper/0/1:
> >  #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
> >  register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
> >  
> >  stack backtrace:
> >  CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> >  5.7.0-rc3-next-20200428-syzkaller #0
> >  Hardware name: Google Google Compute Engine/Google Compute Engine, 
> >  BIOS Google 01/01/2011
> >  Call Trace:
> >  __dump_stack lib/dump_stack.c:77 [inline]
> >  dump_stack+0x18f/0x20d lib/dump_stack.c:118
> >  ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
> >  ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
> >  ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
> >  ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
> >  ops_init+0xaf/0x420 net/core/net_namespace.c:151
> >  __register_pernet_operations net/core/net_namespace.c:1140 [inline]
> >  register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
> >  register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
> >  ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
> >  inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
> >  do_one_initcall+0x10a/0x7d0 init/main.c:1159
> >  do_initcall_level init/main.c:1232 [inline]
> >  do_initcalls init/main.c:1248 [inline]
> >  do_basic_setup init/main.c:1268 [inline]
> >  kernel_init_freeable+0x501/0x5ae init/main.c:1454
> >  kernel_init+0xd/0x1bb init/main.c:1359
> >  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
> >  
> >  =
> >  WARNING: suspicious RCU usage
> >  5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
> >  -
> >  security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
> >  section!!
> > >> 
> > >> Ditto.
> > >> 
> > > I am working on this one(evm_main.c). I am in touch with the maintaners
> > > and I will fix this one soon.
> > 
> > It would be great if you guys could test under KVM as well. Here are
> > quite a few false positives that I personally may never found enough
> > time to silence them.
> > 
> 
> Hey Madhuparna,
> 
> Do you want me to take a look at these if you're not already working
> on them?
>
Yes, you can have a look at the 1st one i.e. ip6mr.c

I have already sent a patch for the second one (emv_main.c)

thank you,
Madhuparna

> Thanks
> Amol
> 
> > [ 9403.765413][T61744] =
> > [ 9403.786541][T61744] WARNING: suspicious RCU usage
> > [ 9403.807865][T61744] 5.7.0-rc1-next-20200417 #4 Tainted: G L  
> >  
> > [ 9403.838945][T61744] -
> > [ 9403.860099][T61744] arch/x86/kvm/mmu/page_track.c:257 RCU-list traversed 
> > in non-reader section!!
> > [ 9403.901270][T61744] 
> > [ 9403.901270][T61744] other info that might help us debug this:
> > [ 9403.901270][T61744] 
> > [ 9403.951032][T61744] 
> > [ 9403.951032][T61744] rcu_scheduler_active = 2, debug_locks = 1
> > [ 9403.986890][T61744] 2 locks held by qemu-kvm/61744:
> > [ 9404.008862][T61744]  #0: c90008a390a8 
> > (>slots_lock){+.+.}-{3:3}, at: kvm_set_memory_region+0x22/0x60 [kvm]
> > [ 9404.055627][T61744]  #1: c90008a429e8 
> > (>track_srcu){}-{0:0}, at: kvm_page_track_flush_slot+0x46/0x149 
> > [kvm]
> > [ 9404.104997][T61744] 
> > [ 9404.104997][T61744] stack backtrace:
> > [ 9404.130894][T61744] CPU: 24 PID: 61744 Comm: qemu-kvm Tainted: G 
> > L5.7.0-rc1-next-20200417 #4
> > [ 9404.176174][T61744] Hardware name: HP ProLiant DL380 Gen9/ProLiant DL380 
> > Gen9, BIOS P89 04/12/2017
> > [ 9404.216664][T61744] Call Trace:
> > [ 9404.230769][T61744]  dump_stack+0xa0/0xea
> > [ 9404.248749][T61744]  lockdep_rcu_suspicious+0x102/0x10b
> > [ 9404.272384][T61744]  kvm_page_track_flush_slot+0x140/0x149 [kvm]
> > [ 9404.299456][T61744]  kvm_arch_flush_shadow_memslot+0xe/0x10 

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Amol Grover
On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote:
> 
> 
> > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik 
> >  wrote:
> > 
> > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> >> 
> >> 
> >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
>  net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> >> 
> >> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> >> 
> >> Never been picked up for a few months due to some reasons. You could 
> >> probably
> >> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> >> patches
> >> on your own?
> >> 
>  net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> >> 
> >> Not sure about this if anyone is working on it. Adding a few people...
> >> 
> > I will have a look at this one.
> > 
>  
>  other info that might help us debug this:
>  
>  
>  rcu_scheduler_active = 2, debug_locks = 1
>  1 lock held by swapper/0/1:
>  #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
>  register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
>  
>  stack backtrace:
>  CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
>  5.7.0-rc3-next-20200428-syzkaller #0
>  Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>  Google 01/01/2011
>  Call Trace:
>  __dump_stack lib/dump_stack.c:77 [inline]
>  dump_stack+0x18f/0x20d lib/dump_stack.c:118
>  ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
>  ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
>  ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
>  ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
>  ops_init+0xaf/0x420 net/core/net_namespace.c:151
>  __register_pernet_operations net/core/net_namespace.c:1140 [inline]
>  register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
>  register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
>  ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
>  inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
>  do_one_initcall+0x10a/0x7d0 init/main.c:1159
>  do_initcall_level init/main.c:1232 [inline]
>  do_initcalls init/main.c:1248 [inline]
>  do_basic_setup init/main.c:1268 [inline]
>  kernel_init_freeable+0x501/0x5ae init/main.c:1454
>  kernel_init+0xd/0x1bb init/main.c:1359
>  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
>  
>  =
>  WARNING: suspicious RCU usage
>  5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
>  -
>  security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
>  section!!
> >> 
> >> Ditto.
> >> 
> > I am working on this one(evm_main.c). I am in touch with the maintaners
> > and I will fix this one soon.
> 
> It would be great if you guys could test under KVM as well. Here are
> quite a few false positives that I personally may never found enough
> time to silence them.
> 

Hey Madhuparna,

Do you want me to take a look at these if you're not already working
on them?

Thanks
Amol

> [ 9403.765413][T61744] =
> [ 9403.786541][T61744] WARNING: suspicious RCU usage
> [ 9403.807865][T61744] 5.7.0-rc1-next-20200417 #4 Tainted: G L   
> [ 9403.838945][T61744] -
> [ 9403.860099][T61744] arch/x86/kvm/mmu/page_track.c:257 RCU-list traversed 
> in non-reader section!!
> [ 9403.901270][T61744] 
> [ 9403.901270][T61744] other info that might help us debug this:
> [ 9403.901270][T61744] 
> [ 9403.951032][T61744] 
> [ 9403.951032][T61744] rcu_scheduler_active = 2, debug_locks = 1
> [ 9403.986890][T61744] 2 locks held by qemu-kvm/61744:
> [ 9404.008862][T61744]  #0: c90008a390a8 (>slots_lock){+.+.}-{3:3}, 
> at: kvm_set_memory_region+0x22/0x60 [kvm]
> [ 9404.055627][T61744]  #1: c90008a429e8 (>track_srcu){}-{0:0}, 
> at: kvm_page_track_flush_slot+0x46/0x149 [kvm]
> [ 9404.104997][T61744] 
> [ 9404.104997][T61744] stack backtrace:
> [ 9404.130894][T61744] CPU: 24 PID: 61744 Comm: qemu-kvm Tainted: G   
>   L5.7.0-rc1-next-20200417 #4
> [ 9404.176174][T61744] Hardware name: HP ProLiant DL380 Gen9/ProLiant DL380 
> Gen9, BIOS P89 04/12/2017
> [ 9404.216664][T61744] Call Trace:
> [ 9404.230769][T61744]  dump_stack+0xa0/0xea
> [ 9404.248749][T61744]  lockdep_rcu_suspicious+0x102/0x10b
> [ 9404.272384][T61744]  kvm_page_track_flush_slot+0x140/0x149 [kvm]
> [ 9404.299456][T61744]  kvm_arch_flush_shadow_memslot+0xe/0x10 [kvm]
> [ 9404.326870][T61744]  kvm_set_memslot+0x197/0xbb0 [kvm]
> [ 9404.350017][T61744]  kvm_delete_memslot+0xdb/0x1a0 [kvm]
> [ 9404.374077][T61744]  ? kvm_set_memslot+0xbb0/0xbb0 [kvm]
> [ 9404.398321][T61744]  __kvm_set_memory_region+0x9ce/0xbe0 [kvm]
> [ 9404.427779][T61744]  ? kvm_vcpu_ioctl+0x960/0x960 [kvm]
> [ 9404.454327][T61744]  ? check_flags.part.28+0x220/0x220
> [ 9404.477673][T61744]  kvm_set_memory_region+0x2d/0x60 

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Amol Grover
On Thu, May 07, 2020 at 06:26:01AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 7 May 2020 06:16:35 +1000 Stephen Rothwell  
> wrote:
> >
> > Hi Qian,
> > 
> > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai  wrote:
> > >  
> > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:  
> > > >   
> > > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> > > 
> > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> > > 
> > > Never been picked up for a few months due to some reasons. You could 
> > > probably
> > > need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> > > patches
> > > on your own?  
> > 
> > Did you resubmit the patch series as Dave Miller asked you to (now that
> > net-next is based on v5.7-rc1+)?
> 
> In any case, I have added the 2 commits in this series to my fixes tree
> from today - I will remove them when some other tree has a solution
> applied.
> 

Hi Stephen

I'll follow up with David regarding this patch series.

Thanks
Amol

> -- 
> Cheers,
> Stephen Rothwell




Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi Qian,

On Wed, 6 May 2020 16:21:05 -0400 Qian Cai  wrote:
>
> > On May 6, 2020, at 4:16 PM, Stephen Rothwell  wrote:
> > 
> > Hi Qian,
> > 
> > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai  wrote:  
> >>   
> >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
>  net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> >> 
> >> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> >> 
> >> Never been picked up for a few months due to some reasons. You could 
> >> probably
> >> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> >> patches
> >> on your own?  
> > 
> > Did you resubmit the patch series as Dave Miller asked you to (now that
> > net-next is based on v5.7-rc1+)?  
> 
> Actually, it was Amol not me who submit the patch, so let him to answer that.

Oops, sorry.
-- 
Cheers,
Stephen Rothwell


pgph1zpRz9F8K.pgp
Description: OpenPGP digital signature


Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi all,

On Wed, 6 May 2020 21:09:41 +0530 Amol Grover  wrote:
>
> On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> > 
> > >> =
> > >> WARNING: suspicious RCU usage
> > >> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
> > >> -
> > >> security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
> > >> section!!  
> > 
> > Ditto.
> >   
> > >> 
> > >> other info that might help us debug this:
> > >> 
> > >> 
> > >> rcu_scheduler_active = 2, debug_locks = 1
> > >> 2 locks held by systemd/1:
> > >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: sb_start_write 
> > >> include/linux/fs.h:1659 [inline]
> > >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: 
> > >> mnt_want_write+0x3a/0xb0 fs/namespace.c:354
> > >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> > >> inode_lock include/linux/fs.h:799 [inline]
> > >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> > >> vfs_setxattr+0x92/0xf0 fs/xattr.c:219
> > >> 
> > >> stack backtrace:
> > >> CPU: 0 PID: 1 Comm: systemd Not tainted 
> > >> 5.7.0-rc3-next-20200428-syzkaller #0
> > >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> > >> Google 01/01/2011
> > >> Call Trace:
> > >> __dump_stack lib/dump_stack.c:77 [inline]
> > >> dump_stack+0x18f/0x20d lib/dump_stack.c:118
> > >> evm_protected_xattr+0x1c2/0x210 security/integrity/evm/evm_main.c:231
> > >> evm_protect_xattr.isra.0+0xb6/0x3d0 security/integrity/evm/evm_main.c:318
> > >> evm_inode_setxattr+0xc4/0xf0 security/integrity/evm/evm_main.c:387
> > >> security_inode_setxattr+0x18f/0x200 security/security.c:1297
> > >> vfs_setxattr+0xa7/0xf0 fs/xattr.c:220
> > >> setxattr+0x23d/0x330 fs/xattr.c:451
> > >> path_setxattr+0x170/0x190 fs/xattr.c:470
> > >> __do_sys_setxattr fs/xattr.c:485 [inline]
> > >> __se_sys_setxattr fs/xattr.c:481 [inline]
> > >> __x64_sys_setxattr+0xc0/0x160 fs/xattr.c:481
> > >> do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
> > >> entry_SYSCALL_64_after_hwframe+0x49/0xb3
> > >> RIP: 0033:0x7fe46005e67a
> > >> Code: 48 8b 0d 21 18 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 
> > >> 00 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 bc 00 00 00 0f 05 <48> 3d 01 
> > >> f0 ff ff 73 01 c3 48 8b 0d ee 17 2b 00 f7 d8 64 89 01 48
> > >> RSP: 002b:7fffef423568 EFLAGS: 0246 ORIG_RAX: 00bc
> > >> RAX: ffda RBX:  RCX: 7fe46005e67a
> > >> RDX: 7fffef4235e0 RSI: 556ea53ddf9b RDI: 556ea6766760
> > >> RBP: 556ea53ddf9b R08:  R09: 0030
> > >> R10: 0020 R11: 0246 R12: 7fffef4235e0
> > >> R13: 0020 R14:  R15: 556ea6751700
> > >> 
> > >> security/device_cgroup.c:357 RCU-list traversed in non-reader section!!  
> > 
> > https://lore.kernel.org/lkml/20200406105950.GA2285@workstation-kernel-dev/
> > 
> > The same story. The patch had been ignored for a while.
> >   
> 
> Thank you for reminding! I will resend the patches and try to get them
> merged ASAP.

I have also applied the above patch to by fixes tree from today and
will remove it when a solution is applied to some other tree.

-- 
Cheers,
Stephen Rothwell


pgpQq9tbe2OVK.pgp
Description: OpenPGP digital signature


Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi all,

On Thu, 7 May 2020 06:16:35 +1000 Stephen Rothwell  
wrote:
>
> Hi Qian,
> 
> On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai  wrote:
> >  
> > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
> > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> > 
> > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> > 
> > Never been picked up for a few months due to some reasons. You could 
> > probably
> > need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> > patches
> > on your own?  
> 
> Did you resubmit the patch series as Dave Miller asked you to (now that
> net-next is based on v5.7-rc1+)?

In any case, I have added the 2 commits in this series to my fixes tree
from today - I will remove them when some other tree has a solution
applied.

-- 
Cheers,
Stephen Rothwell


pgpab8QD1XFAg.pgp
Description: OpenPGP digital signature


Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Qian Cai



> On May 6, 2020, at 4:16 PM, Stephen Rothwell  wrote:
> 
> Hi Qian,
> 
> On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai  wrote:
>> 
>>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:  
 net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!  
>> 
>> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
>> 
>> Never been picked up for a few months due to some reasons. You could probably
>> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
>> patches
>> on your own?
> 
> Did you resubmit the patch series as Dave Miller asked you to (now that
> net-next is based on v5.7-rc1+)?

Actually, it was Amol not me who submit the patch, so let him to answer that.

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Stephen Rothwell
Hi Qian,

On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai  wrote:
>
> > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:  
> >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!  
> 
> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> 
> Never been picked up for a few months due to some reasons. You could probably
> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> patches
> on your own?

Did you resubmit the patch series as Dave Miller asked you to (now that
net-next is based on v5.7-rc1+)?

-- 
Cheers,
Stephen Rothwell


pgpPYSIATsO_f.pgp
Description: OpenPGP digital signature


Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Amol Grover
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> 
> 
> > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
> >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> 
> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> 
> Never been picked up for a few months due to some reasons. You could probably
> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> patches
> on your own?
> 
> >> net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> 
> Not sure about this if anyone is working on it. Adding a few people...
> 
> >> 
> >> other info that might help us debug this:
> >> 
> >> 
> >> rcu_scheduler_active = 2, debug_locks = 1
> >> 1 lock held by swapper/0/1:
> >> #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
> >> register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
> >> 
> >> stack backtrace:
> >> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> >> 5.7.0-rc3-next-20200428-syzkaller #0
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> >> Google 01/01/2011
> >> Call Trace:
> >> __dump_stack lib/dump_stack.c:77 [inline]
> >> dump_stack+0x18f/0x20d lib/dump_stack.c:118
> >> ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
> >> ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
> >> ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
> >> ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
> >> ops_init+0xaf/0x420 net/core/net_namespace.c:151
> >> __register_pernet_operations net/core/net_namespace.c:1140 [inline]
> >> register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
> >> register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
> >> ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
> >> inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
> >> do_one_initcall+0x10a/0x7d0 init/main.c:1159
> >> do_initcall_level init/main.c:1232 [inline]
> >> do_initcalls init/main.c:1248 [inline]
> >> do_basic_setup init/main.c:1268 [inline]
> >> kernel_init_freeable+0x501/0x5ae init/main.c:1454
> >> kernel_init+0xd/0x1bb init/main.c:1359
> >> ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
> >> 
> >> =
> >> WARNING: suspicious RCU usage
> >> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
> >> -
> >> security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
> >> section!!
> 
> Ditto.
> 
> >> 
> >> other info that might help us debug this:
> >> 
> >> 
> >> rcu_scheduler_active = 2, debug_locks = 1
> >> 2 locks held by systemd/1:
> >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: sb_start_write 
> >> include/linux/fs.h:1659 [inline]
> >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: 
> >> mnt_want_write+0x3a/0xb0 fs/namespace.c:354
> >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> >> inode_lock include/linux/fs.h:799 [inline]
> >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> >> vfs_setxattr+0x92/0xf0 fs/xattr.c:219
> >> 
> >> stack backtrace:
> >> CPU: 0 PID: 1 Comm: systemd Not tainted 5.7.0-rc3-next-20200428-syzkaller 
> >> #0
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> >> Google 01/01/2011
> >> Call Trace:
> >> __dump_stack lib/dump_stack.c:77 [inline]
> >> dump_stack+0x18f/0x20d lib/dump_stack.c:118
> >> evm_protected_xattr+0x1c2/0x210 security/integrity/evm/evm_main.c:231
> >> evm_protect_xattr.isra.0+0xb6/0x3d0 security/integrity/evm/evm_main.c:318
> >> evm_inode_setxattr+0xc4/0xf0 security/integrity/evm/evm_main.c:387
> >> security_inode_setxattr+0x18f/0x200 security/security.c:1297
> >> vfs_setxattr+0xa7/0xf0 fs/xattr.c:220
> >> setxattr+0x23d/0x330 fs/xattr.c:451
> >> path_setxattr+0x170/0x190 fs/xattr.c:470
> >> __do_sys_setxattr fs/xattr.c:485 [inline]
> >> __se_sys_setxattr fs/xattr.c:481 [inline]
> >> __x64_sys_setxattr+0xc0/0x160 fs/xattr.c:481
> >> do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
> >> entry_SYSCALL_64_after_hwframe+0x49/0xb3
> >> RIP: 0033:0x7fe46005e67a
> >> Code: 48 8b 0d 21 18 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 
> >> 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 bc 00 00 00 0f 05 <48> 3d 01 f0 ff 
> >> ff 73 01 c3 48 8b 0d ee 17 2b 00 f7 d8 64 89 01 48
> >> RSP: 002b:7fffef423568 EFLAGS: 0246 ORIG_RAX: 00bc
> >> RAX: ffda RBX:  RCX: 7fe46005e67a
> >> RDX: 7fffef4235e0 RSI: 556ea53ddf9b RDI: 556ea6766760
> >> RBP: 556ea53ddf9b R08:  R09: 0030
> >> R10: 0020 R11: 0246 R12: 7fffef4235e0
> >> R13: 0020 R14:  R15: 556ea6751700
> >> 
> >> security/device_cgroup.c:357 RCU-list traversed in non-reader section!!
> 
> https://lore.kernel.org/lkml/20200406105950.GA2285@workstation-kernel-dev/
> 
> The same story. The patch had been ignored for a while.
> 

Thank you for reminding! I will resend the patches and try to get them
merged ASAP.

> 
> 


Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Madhuparna Bhowmik
On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote:
> 
> 
> > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik 
> >  wrote:
> > 
> > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> >> 
> >> 
> >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
>  net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> >> 
> >> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> >> 
> >> Never been picked up for a few months due to some reasons. You could 
> >> probably
> >> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> >> patches
> >> on your own?
> >> 
>  net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> >> 
> >> Not sure about this if anyone is working on it. Adding a few people...
> >> 
> > I will have a look at this one.
> > 
>  
>  other info that might help us debug this:
>  
>  
>  rcu_scheduler_active = 2, debug_locks = 1
>  1 lock held by swapper/0/1:
>  #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
>  register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
>  
>  stack backtrace:
>  CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
>  5.7.0-rc3-next-20200428-syzkaller #0
>  Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>  Google 01/01/2011
>  Call Trace:
>  __dump_stack lib/dump_stack.c:77 [inline]
>  dump_stack+0x18f/0x20d lib/dump_stack.c:118
>  ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
>  ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
>  ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
>  ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
>  ops_init+0xaf/0x420 net/core/net_namespace.c:151
>  __register_pernet_operations net/core/net_namespace.c:1140 [inline]
>  register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
>  register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
>  ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
>  inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
>  do_one_initcall+0x10a/0x7d0 init/main.c:1159
>  do_initcall_level init/main.c:1232 [inline]
>  do_initcalls init/main.c:1248 [inline]
>  do_basic_setup init/main.c:1268 [inline]
>  kernel_init_freeable+0x501/0x5ae init/main.c:1454
>  kernel_init+0xd/0x1bb init/main.c:1359
>  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
>  
>  =
>  WARNING: suspicious RCU usage
>  5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
>  -
>  security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
>  section!!
> >> 
> >> Ditto.
> >> 
> > I am working on this one(evm_main.c). I am in touch with the maintaners
> > and I will fix this one soon.
> 
> It would be great if you guys could test under KVM as well. Here are
> quite a few false positives that I personally may never found enough
> time to silence them.
>
Sure, I am going through these. We will fix these soon.

Thank you,
Madhuparna

> [ 9403.765413][T61744] =
> [ 9403.786541][T61744] WARNING: suspicious RCU usage
> [ 9403.807865][T61744] 5.7.0-rc1-next-20200417 #4 Tainted: G L   
> [ 9403.838945][T61744] -
> [ 9403.860099][T61744] arch/x86/kvm/mmu/page_track.c:257 RCU-list traversed 
> in non-reader section!!
> [ 9403.901270][T61744] 
> [ 9403.901270][T61744] other info that might help us debug this:
> [ 9403.901270][T61744] 
> [ 9403.951032][T61744] 
> [ 9403.951032][T61744] rcu_scheduler_active = 2, debug_locks = 1
> [ 9403.986890][T61744] 2 locks held by qemu-kvm/61744:
> [ 9404.008862][T61744]  #0: c90008a390a8 (>slots_lock){+.+.}-{3:3}, 
> at: kvm_set_memory_region+0x22/0x60 [kvm]
> [ 9404.055627][T61744]  #1: c90008a429e8 (>track_srcu){}-{0:0}, 
> at: kvm_page_track_flush_slot+0x46/0x149 [kvm]
> [ 9404.104997][T61744] 
> [ 9404.104997][T61744] stack backtrace:
> [ 9404.130894][T61744] CPU: 24 PID: 61744 Comm: qemu-kvm Tainted: G   
>   L5.7.0-rc1-next-20200417 #4
> [ 9404.176174][T61744] Hardware name: HP ProLiant DL380 Gen9/ProLiant DL380 
> Gen9, BIOS P89 04/12/2017
> [ 9404.216664][T61744] Call Trace:
> [ 9404.230769][T61744]  dump_stack+0xa0/0xea
> [ 9404.248749][T61744]  lockdep_rcu_suspicious+0x102/0x10b
> [ 9404.272384][T61744]  kvm_page_track_flush_slot+0x140/0x149 [kvm]
> [ 9404.299456][T61744]  kvm_arch_flush_shadow_memslot+0xe/0x10 [kvm]
> [ 9404.326870][T61744]  kvm_set_memslot+0x197/0xbb0 [kvm]
> [ 9404.350017][T61744]  kvm_delete_memslot+0xdb/0x1a0 [kvm]
> [ 9404.374077][T61744]  ? kvm_set_memslot+0xbb0/0xbb0 [kvm]
> [ 9404.398321][T61744]  __kvm_set_memory_region+0x9ce/0xbe0 [kvm]
> [ 9404.427779][T61744]  ? kvm_vcpu_ioctl+0x960/0x960 [kvm]
> [ 9404.454327][T61744]  ? check_flags.part.28+0x220/0x220
> [ 9404.477673][T61744]  kvm_set_memory_region+0x2d/0x60 [kvm]
> [ 9404.502368][T61744] 

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Qian Cai



> On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik 
>  wrote:
> 
> On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
>> 
>> 
>>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
 net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
>> 
>> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
>> 
>> Never been picked up for a few months due to some reasons. You could probably
>> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
>> patches
>> on your own?
>> 
 net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
>> 
>> Not sure about this if anyone is working on it. Adding a few people...
>> 
> I will have a look at this one.
> 
 
 other info that might help us debug this:
 
 
 rcu_scheduler_active = 2, debug_locks = 1
 1 lock held by swapper/0/1:
 #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
 register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
 
 stack backtrace:
 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
 5.7.0-rc3-next-20200428-syzkaller #0
 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
 Google 01/01/2011
 Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
 ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
 ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
 ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
 ops_init+0xaf/0x420 net/core/net_namespace.c:151
 __register_pernet_operations net/core/net_namespace.c:1140 [inline]
 register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
 register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
 ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
 inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
 do_one_initcall+0x10a/0x7d0 init/main.c:1159
 do_initcall_level init/main.c:1232 [inline]
 do_initcalls init/main.c:1248 [inline]
 do_basic_setup init/main.c:1268 [inline]
 kernel_init_freeable+0x501/0x5ae init/main.c:1454
 kernel_init+0xd/0x1bb init/main.c:1359
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
 
 =
 WARNING: suspicious RCU usage
 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
 -
 security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
 section!!
>> 
>> Ditto.
>> 
> I am working on this one(evm_main.c). I am in touch with the maintaners
> and I will fix this one soon.

It would be great if you guys could test under KVM as well. Here are
quite a few false positives that I personally may never found enough
time to silence them.

[ 9403.765413][T61744] =
[ 9403.786541][T61744] WARNING: suspicious RCU usage
[ 9403.807865][T61744] 5.7.0-rc1-next-20200417 #4 Tainted: G L   
[ 9403.838945][T61744] -
[ 9403.860099][T61744] arch/x86/kvm/mmu/page_track.c:257 RCU-list traversed in 
non-reader section!!
[ 9403.901270][T61744] 
[ 9403.901270][T61744] other info that might help us debug this:
[ 9403.901270][T61744] 
[ 9403.951032][T61744] 
[ 9403.951032][T61744] rcu_scheduler_active = 2, debug_locks = 1
[ 9403.986890][T61744] 2 locks held by qemu-kvm/61744:
[ 9404.008862][T61744]  #0: c90008a390a8 (>slots_lock){+.+.}-{3:3}, 
at: kvm_set_memory_region+0x22/0x60 [kvm]
[ 9404.055627][T61744]  #1: c90008a429e8 (>track_srcu){}-{0:0}, 
at: kvm_page_track_flush_slot+0x46/0x149 [kvm]
[ 9404.104997][T61744] 
[ 9404.104997][T61744] stack backtrace:
[ 9404.130894][T61744] CPU: 24 PID: 61744 Comm: qemu-kvm Tainted: G 
L5.7.0-rc1-next-20200417 #4
[ 9404.176174][T61744] Hardware name: HP ProLiant DL380 Gen9/ProLiant DL380 
Gen9, BIOS P89 04/12/2017
[ 9404.216664][T61744] Call Trace:
[ 9404.230769][T61744]  dump_stack+0xa0/0xea
[ 9404.248749][T61744]  lockdep_rcu_suspicious+0x102/0x10b
[ 9404.272384][T61744]  kvm_page_track_flush_slot+0x140/0x149 [kvm]
[ 9404.299456][T61744]  kvm_arch_flush_shadow_memslot+0xe/0x10 [kvm]
[ 9404.326870][T61744]  kvm_set_memslot+0x197/0xbb0 [kvm]
[ 9404.350017][T61744]  kvm_delete_memslot+0xdb/0x1a0 [kvm]
[ 9404.374077][T61744]  ? kvm_set_memslot+0xbb0/0xbb0 [kvm]
[ 9404.398321][T61744]  __kvm_set_memory_region+0x9ce/0xbe0 [kvm]
[ 9404.427779][T61744]  ? kvm_vcpu_ioctl+0x960/0x960 [kvm]
[ 9404.454327][T61744]  ? check_flags.part.28+0x220/0x220
[ 9404.477673][T61744]  kvm_set_memory_region+0x2d/0x60 [kvm]
[ 9404.502368][T61744]  kvm_vm_ioctl+0xc11/0x1ad0 [kvm]
[ 9404.524760][T61744]  ? kvm_unregister_device_ops+0xd0/0xd0 [kvm]
[ 9404.551776][T61744]  ? check_chain_key+0x1df/0x2e0
[ 9404.573575][T61744]  ? register_lock_class+0xb90/0xb90
[ 9404.596638][T61744]  ? __lock_acquire+0xa18/0x3260
[ 9404.618201][T61744]  ? match_held_lock+0x20/0x270
[ 9404.639379][T61744]  ? 

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Madhuparna Bhowmik
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote:
> 
> 
> > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
> >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
> 
> https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/
> 
> Never been picked up for a few months due to some reasons. You could probably
> need to convince David, Paul, Steven or Linus to unblock the bot or carry 
> patches
> on your own?
> 
> >> net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
> 
> Not sure about this if anyone is working on it. Adding a few people...
>
I will have a look at this one.

> >> 
> >> other info that might help us debug this:
> >> 
> >> 
> >> rcu_scheduler_active = 2, debug_locks = 1
> >> 1 lock held by swapper/0/1:
> >> #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
> >> register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
> >> 
> >> stack backtrace:
> >> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 
> >> 5.7.0-rc3-next-20200428-syzkaller #0
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> >> Google 01/01/2011
> >> Call Trace:
> >> __dump_stack lib/dump_stack.c:77 [inline]
> >> dump_stack+0x18f/0x20d lib/dump_stack.c:118
> >> ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
> >> ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
> >> ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
> >> ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
> >> ops_init+0xaf/0x420 net/core/net_namespace.c:151
> >> __register_pernet_operations net/core/net_namespace.c:1140 [inline]
> >> register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
> >> register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
> >> ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
> >> inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
> >> do_one_initcall+0x10a/0x7d0 init/main.c:1159
> >> do_initcall_level init/main.c:1232 [inline]
> >> do_initcalls init/main.c:1248 [inline]
> >> do_basic_setup init/main.c:1268 [inline]
> >> kernel_init_freeable+0x501/0x5ae init/main.c:1454
> >> kernel_init+0xd/0x1bb init/main.c:1359
> >> ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
> >> 
> >> =
> >> WARNING: suspicious RCU usage
> >> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
> >> -
> >> security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
> >> section!!
> 
> Ditto.
>
I am working on this one(evm_main.c). I am in touch with the maintaners
and I will fix this one soon.

Thank you,
Madhuparna
> >> 
> >> other info that might help us debug this:
> >> 
> >> 
> >> rcu_scheduler_active = 2, debug_locks = 1
> >> 2 locks held by systemd/1:
> >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: sb_start_write 
> >> include/linux/fs.h:1659 [inline]
> >> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: 
> >> mnt_want_write+0x3a/0xb0 fs/namespace.c:354
> >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> >> inode_lock include/linux/fs.h:799 [inline]
> >> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
> >> vfs_setxattr+0x92/0xf0 fs/xattr.c:219
> >> 
> >> stack backtrace:
> >> CPU: 0 PID: 1 Comm: systemd Not tainted 5.7.0-rc3-next-20200428-syzkaller 
> >> #0
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> >> Google 01/01/2011
> >> Call Trace:
> >> __dump_stack lib/dump_stack.c:77 [inline]
> >> dump_stack+0x18f/0x20d lib/dump_stack.c:118
> >> evm_protected_xattr+0x1c2/0x210 security/integrity/evm/evm_main.c:231
> >> evm_protect_xattr.isra.0+0xb6/0x3d0 security/integrity/evm/evm_main.c:318
> >> evm_inode_setxattr+0xc4/0xf0 security/integrity/evm/evm_main.c:387
> >> security_inode_setxattr+0x18f/0x200 security/security.c:1297
> >> vfs_setxattr+0xa7/0xf0 fs/xattr.c:220
> >> setxattr+0x23d/0x330 fs/xattr.c:451
> >> path_setxattr+0x170/0x190 fs/xattr.c:470
> >> __do_sys_setxattr fs/xattr.c:485 [inline]
> >> __se_sys_setxattr fs/xattr.c:481 [inline]
> >> __x64_sys_setxattr+0xc0/0x160 fs/xattr.c:481
> >> do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
> >> entry_SYSCALL_64_after_hwframe+0x49/0xb3
> >> RIP: 0033:0x7fe46005e67a
> >> Code: 48 8b 0d 21 18 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 
> >> 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 bc 00 00 00 0f 05 <48> 3d 01 f0 ff 
> >> ff 73 01 c3 48 8b 0d ee 17 2b 00 f7 d8 64 89 01 48
> >> RSP: 002b:7fffef423568 EFLAGS: 0246 ORIG_RAX: 00bc
> >> RAX: ffda RBX:  RCX: 7fe46005e67a
> >> RDX: 7fffef4235e0 RSI: 556ea53ddf9b RDI: 556ea6766760
> >> RBP: 556ea53ddf9b R08:  R09: 0030
> >> R10: 0020 R11: 0246 R12: 7fffef4235e0
> >> R13: 0020 R14:  R15: 556ea6751700
> >> 
> >> security/device_cgroup.c:357 RCU-list traversed in non-reader section!!
> 
> https://lore.kernel.org/lkml/20200406105950.GA2285@workstation-kernel-dev/
> 

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Qian Cai



> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov  wrote:
>> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!

https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/

Never been picked up for a few months due to some reasons. You could probably
need to convince David, Paul, Steven or Linus to unblock the bot or carry 
patches
on your own?

>> net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!

Not sure about this if anyone is working on it. Adding a few people...

>> 
>> other info that might help us debug this:
>> 
>> 
>> rcu_scheduler_active = 2, debug_locks = 1
>> 1 lock held by swapper/0/1:
>> #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
>> register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
>> 
>> stack backtrace:
>> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.7.0-rc3-next-20200428-syzkaller 
>> #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>> Google 01/01/2011
>> Call Trace:
>> __dump_stack lib/dump_stack.c:77 [inline]
>> dump_stack+0x18f/0x20d lib/dump_stack.c:118
>> ip6mr_get_table+0x153/0x180 net/ipv6/ip6mr.c:124
>> ip6mr_new_table+0x1b/0x70 net/ipv6/ip6mr.c:382
>> ip6mr_rules_init net/ipv6/ip6mr.c:236 [inline]
>> ip6mr_net_init+0x133/0x3f0 net/ipv6/ip6mr.c:1310
>> ops_init+0xaf/0x420 net/core/net_namespace.c:151
>> __register_pernet_operations net/core/net_namespace.c:1140 [inline]
>> register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
>> register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
>> ip6_mr_init+0x49/0x152 net/ipv6/ip6mr.c:1363
>> inet6_init+0x1d7/0x6dc net/ipv6/af_inet6.c:1032
>> do_one_initcall+0x10a/0x7d0 init/main.c:1159
>> do_initcall_level init/main.c:1232 [inline]
>> do_initcalls init/main.c:1248 [inline]
>> do_basic_setup init/main.c:1268 [inline]
>> kernel_init_freeable+0x501/0x5ae init/main.c:1454
>> kernel_init+0xd/0x1bb init/main.c:1359
>> ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
>> 
>> =
>> WARNING: suspicious RCU usage
>> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
>> -
>> security/integrity/evm/evm_main.c:231 RCU-list traversed in non-reader 
>> section!!

Ditto.

>> 
>> other info that might help us debug this:
>> 
>> 
>> rcu_scheduler_active = 2, debug_locks = 1
>> 2 locks held by systemd/1:
>> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: sb_start_write 
>> include/linux/fs.h:1659 [inline]
>> #0: 888098dfa450 (sb_writers#8){.+.+}-{0:0}, at: 
>> mnt_want_write+0x3a/0xb0 fs/namespace.c:354
>> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: inode_lock 
>> include/linux/fs.h:799 [inline]
>> #1: 8880988e8310 (>i_mutex_dir_key#6){}-{3:3}, at: 
>> vfs_setxattr+0x92/0xf0 fs/xattr.c:219
>> 
>> stack backtrace:
>> CPU: 0 PID: 1 Comm: systemd Not tainted 5.7.0-rc3-next-20200428-syzkaller #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>> Google 01/01/2011
>> Call Trace:
>> __dump_stack lib/dump_stack.c:77 [inline]
>> dump_stack+0x18f/0x20d lib/dump_stack.c:118
>> evm_protected_xattr+0x1c2/0x210 security/integrity/evm/evm_main.c:231
>> evm_protect_xattr.isra.0+0xb6/0x3d0 security/integrity/evm/evm_main.c:318
>> evm_inode_setxattr+0xc4/0xf0 security/integrity/evm/evm_main.c:387
>> security_inode_setxattr+0x18f/0x200 security/security.c:1297
>> vfs_setxattr+0xa7/0xf0 fs/xattr.c:220
>> setxattr+0x23d/0x330 fs/xattr.c:451
>> path_setxattr+0x170/0x190 fs/xattr.c:470
>> __do_sys_setxattr fs/xattr.c:485 [inline]
>> __se_sys_setxattr fs/xattr.c:481 [inline]
>> __x64_sys_setxattr+0xc0/0x160 fs/xattr.c:481
>> do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
>> entry_SYSCALL_64_after_hwframe+0x49/0xb3
>> RIP: 0033:0x7fe46005e67a
>> Code: 48 8b 0d 21 18 2b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 
>> 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 bc 00 00 00 0f 05 <48> 3d 01 f0 ff ff 
>> 73 01 c3 48 8b 0d ee 17 2b 00 f7 d8 64 89 01 48
>> RSP: 002b:7fffef423568 EFLAGS: 0246 ORIG_RAX: 00bc
>> RAX: ffda RBX:  RCX: 7fe46005e67a
>> RDX: 7fffef4235e0 RSI: 556ea53ddf9b RDI: 556ea6766760
>> RBP: 556ea53ddf9b R08:  R09: 0030
>> R10: 0020 R11: 0246 R12: 7fffef4235e0
>> R13: 0020 R14:  R15: 556ea6751700
>> 
>> security/device_cgroup.c:357 RCU-list traversed in non-reader section!!

https://lore.kernel.org/lkml/20200406105950.GA2285@workstation-kernel-dev/

The same story. The patch had been ignored for a while.





Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-04-28 Thread Dmitry Vyukov
On Tue, Apr 28, 2020, 10:47 syzbot
 wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:0fd02a5d Add linux-next specific files for 20200428
> git tree:   linux-next

+linux-next for boot breakage

> console output: https://syzkaller.appspot.com/x/log.txt?x=1696e5d810
> kernel config:  https://syzkaller.appspot.com/x/.config?x=9748c3e397b4529
> dashboard link: https://syzkaller.appspot.com/bug?extid=1519f497f2f9f08183c6
> compiler:   gcc (GCC) 9.0.0 20181231 (experimental)
>
> Unfortunately, I don't have any reproducer for this crash yet.
>
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+1519f497f2f9f0818...@syzkaller.appspotmail.com
>
> SCSI subsystem initialized
> ACPI: bus type USB registered
> usbcore: registered new interface driver usbfs
> usbcore: registered new interface driver hub
> usbcore: registered new device driver usb
> mc: Linux media interface: v0.10
> videodev: Linux video capture interface: v2.00
> pps_core: LinuxPPS API ver. 1 registered
> pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti 
> 
> PTP clock support registered
> EDAC MC: Ver: 3.0.0
> Advanced Linux Sound Architecture Driver Initialized.
> PCI: Using ACPI for IRQ routing
> Bluetooth: Core ver 2.22
> NET: Registered protocol family 31
> Bluetooth: HCI device and connection manager initialized
> Bluetooth: HCI socket layer initialized
> Bluetooth: L2CAP socket layer initialized
> Bluetooth: SCO socket layer initialized
> NET: Registered protocol family 8
> NET: Registered protocol family 20
> NetLabel: Initializing
> NetLabel:  domain hash size = 128
> NetLabel:  protocols = UNLABELED CIPSOv4 CALIPSO
> NetLabel:  unlabeled traffic allowed by default
> nfc: nfc_init: NFC Core ver 0.1
> NET: Registered protocol family 39
> clocksource: Switched to clocksource kvm-clock
> VFS: Disk quotas dquot_6.6.0
> VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
> FS-Cache: Loaded
> CacheFiles: Loaded
> TOMOYO: 2.6.0
> Mandatory Access Control activated.
> AppArmor: AppArmor Filesystem Enabled
> pnp: PnP ACPI init
> pnp: PnP ACPI: found 7 devices
> clocksource: acpi_pm: mask: 0xff max_cycles: 0xff, max_idle_ns: 
> 2085701024 ns
> pci_bus :00: resource 4 [io  0x-0x0cf7 window]
> pci_bus :00: resource 5 [io  0x0d00-0x window]
> pci_bus :00: resource 6 [mem 0x000a-0x000b window]
> pci_bus :00: resource 7 [mem 0xc000-0xfebf window]
> NET: Registered protocol family 2
> tcp_listen_portaddr_hash hash table entries: 4096 (order: 6, 327680 bytes, 
> vmalloc)
> TCP established hash table entries: 65536 (order: 7, 524288 bytes, vmalloc)
> TCP bind hash table entries: 65536 (order: 10, 4718592 bytes, vmalloc)
> TCP: Hash tables configured (established 65536 bind 65536)
> UDP hash table entries: 4096 (order: 7, 655360 bytes, vmalloc)
> UDP-Lite hash table entries: 4096 (order: 7, 655360 bytes, vmalloc)
> =
> WARNING: suspicious RCU usage
> 5.7.0-rc3-next-20200428-syzkaller #0 Not tainted
> -
> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!!
>
> other info that might help us debug this:
>
>
> rcu_scheduler_active = 2, debug_locks = 1
> 1 lock held by swapper/0/1:
>  #0: 8a5a6330 (pernet_ops_rwsem){+.+.}-{3:3}, at: 
> register_pernet_subsys+0x16/0x40 net/core/net_namespace.c:1257
>
> stack backtrace:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.7.0-rc3-next-20200428-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> Google 01/01/2011
> Call Trace:
>  __dump_stack lib/dump_stack.c:77 [inline]
>  dump_stack+0x18f/0x20d lib/dump_stack.c:118
>  ipmr_get_table+0x130/0x160 net/ipv4/ipmr.c:136
>  ipmr_new_table net/ipv4/ipmr.c:403 [inline]
>  ipmr_rules_init net/ipv4/ipmr.c:248 [inline]
>  ipmr_net_init+0x133/0x430 net/ipv4/ipmr.c:3089
>  ops_init+0xaf/0x420 net/core/net_namespace.c:151
>  __register_pernet_operations net/core/net_namespace.c:1140 [inline]
>  register_pernet_operations+0x346/0x840 net/core/net_namespace.c:1217
>  register_pernet_subsys+0x25/0x40 net/core/net_namespace.c:1258
>  ip_mr_init+0x36/0x168 net/ipv4/ipmr.c:3140
>  inet_init+0x298/0x424 net/ipv4/af_inet.c:2005
>  do_one_initcall+0x10a/0x7d0 init/main.c:1159
>  do_initcall_level init/main.c:1232 [inline]
>  do_initcalls init/main.c:1248 [inline]
>  do_basic_setup init/main.c:1268 [inline]
>  kernel_init_freeable+0x501/0x5ae init/main.c:1454
>  kernel_init+0xd/0x1bb init/main.c:1359
>  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:351
> NET: Registered protocol family 1
> RPC: Registered named UNIX socket transport module.
> RPC: Registered udp transport module.
> RPC: Registered tcp transport module.
> RPC: Registered tcp NFSv4.1 backchannel transport module.
> NET: Registered protocol family 44
> pci :00:00.0: Limiting direct PCI/PCI transfers
> PCI: CLS 0 bytes, default 64
> PCI-DMA: Using