Re: taint/module: Fix problems when out-of-kernel driver defines true or false

2017-01-18 Thread Sid Boyce 

Latest pull of 4.10-rc4 includes the fix.
Kernel builds and so does modules for VirtualBox-5.1-5.1.14_112924.
# lsmod|grep vbox
vboxpci24576  0
vboxnetadp 28672  0
vboxnetflt 28672  0
vboxdrv   417792  3 vboxnetadp,vboxnetflt,vboxpci

git show
-
commit 0aa0313f9d576affd7747cc3f179feb097d28990
Merge: 4b19a9e20bf9 5eb7c0d04f04
Author: Linus Torvalds 
Date:   Tue Jan 17 14:49:21 2017 -0800

Merge tag 'modules-for-v4.10-rc5' of 
git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux


Pull modules fix from Jessica Yu:

 - fix out-of-tree module breakage when it supplies its own definitions
   of true and false

* tag 'modules-for-v4.10-rc5' of 
git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux:
  taint/module: Fix problems when out-of-kernel driver defines true 
or false

Regards
Sid.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Senior Staff Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

Re: taint/module: Fix problems when out-of-kernel driver defines true or false

2017-01-17 Thread Jessica Yu 

+++ Larry Finger [17/01/17 10:08 -0600]:

Jessica,

What is the status of the patch? VirtualBox has converted to the hotplug
state manager, thus their drivers now build, but only if this patch has
been applied.

Thanks,

Larry


This fix has already been sitting on modules-next for some time,
queued up for the next merge window. But since it was actually one of
the patches from the last merge window that caused the OOT module
breakage, this should have be an -rc fix instead, my mistake. I will
send a pull request for -rc5. Thanks for pinging.

Jessica

Re: taint/module: Fix problems when out-of-kernel driver defines true or false

2017-01-15 Thread Sid Boyce 
http://lkml.iu.edu//hypermail/linux/kernel/1701.0/01592.html says 
Larry's patch was applied Jan. 3 2017.


So far it hasn't showed in pull updates.
Regards
Sid.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Senior Staff Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

Re: taint/module: Fix problems when out-of-kernel driver defines true or false

2017-01-03 Thread Jessica Yu 

+++ Larry Finger [01/01/17 20:25 -0600]:

Commit 7fd8329ba502 ("taint/module: Clean up global and module taint
flags handling") used the key words true and false as character members
of a new struct. These names cause problems when out-of-kernel modules
such as VirtualBox include their own definitions of true and false.

Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags 
handling")
Signed-off-by: Larry Finger 
Cc: Petr Mladek 
Cc: Jessica Yu 
Cc: Rusty Russell 


Applied, thanks.

Jessica