Re: vfat problems in 2.4.0-test10-pre2
On 13 Oct 00 at 20:01, Andris Pavenis wrote: > On Friday 13 October 2000 19:55, Petr Vandrovec wrote: > > > > If it works for you, either forward it to Linus, or tell me and I'll > > send it - but I do not send patches during weekend ;-) . I do not use > > VFAT to much personally, so more eyes... > > Thanks. I verified that the problem is present in 2.4.0-test9, after tested > that patch fixes the problem (I wrote the same files in the same directory > on VFAT32 partition). Now testing disk didn't show any problems (earlier > it reported LFN problems) > > Andris > > PS. I haven't sent patch to Linus OK. Sent for test10-pre3. Petr - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
On Friday 13 October 2000 19:55, Petr Vandrovec wrote: > I missed original problem, but what about this one? Fixes extension > in MSDOS namespace when filename is longer than 12 chars... Someone > familiar with VFAT should look whether VFAT multibyte code cannot be > cleaned up a bit... When I was fixing 'break out of now nested loop' > for pre7, I missed this one. Sorry. > > If it works for you, either forward it to Linus, or tell me and I'll > send it - but I do not send patches during weekend ;-) . I do not use > VFAT to much personally, so more eyes... Thanks. I verified that the problem is present in 2.4.0-test9, after tested that patch fixes the problem (I wrote the same files in the same directory on VFAT32 partition). Now testing disk didn't show any problems (earlier it reported LFN problems) Andris PS. I haven't sent patch to Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
> I have the same problem.
>
> As far as I remeber it appeared most likely beginning with 2.4.0-test7
> (or maybe test6)
I missed original problem, but what about this one? Fixes extension
in MSDOS namespace when filename is longer than 12 chars... Someone
familiar with VFAT should look whether VFAT multibyte code cannot be
cleaned up a bit... When I was fixing 'break out of now nested loop'
for pre7, I missed this one. Sorry.
If it works for you, either forward it to Linus, or tell me and I'll
send it - but I do not send patches during weekend ;-) . I do not use
VFAT to much personally, so more eyes...
Best regards,
Petr Vandrovec
[EMAIL PROTECTED]
diff -urN linux/fs/vfat/namei.c linux/fs/vfat/namei.c
--- linux/fs/vfat/namei.c Tue Sep 5 23:07:29 2000
+++ linux/fs/vfat/namei.c Fri Oct 13 17:35:43 2000
@@ -618,12 +618,11 @@
sz = len;
ext_start = NULL;
}
- break;
+ goto stop0;
}
}
- if (charbuf[chi] == '.')
- break;
}
+stop0:;
if (ext_start == name - 1) {
sz = len;
ext_start = NULL;
@@ -640,10 +639,12 @@
if (chl == 0)
break;
for (chi = 0; chi < chl; chi++)
- if (!strchr(skip_chars, charbuf[chi]))
- break;
+ if (!strchr(skip_chars, charbuf[chi])) {
+ goto stop1;
+ }
name_start++;
}
+stop1:;
if (name_start != ext_start) {
sz = ext_start - name;
ext_start++;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
I have the same problem. As far as I remeber it appeared most likely beginning with 2.4.0-test7 (or maybe test6) Andris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
I have the same problem. As far as I remeber it appeared most likely beginning with 2.4.0-test7 (or maybe test6) Andris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
I have the same problem.
As far as I remeber it appeared most likely beginning with 2.4.0-test7
(or maybe test6)
I missed original problem, but what about this one? Fixes extension
in MSDOS namespace when filename is longer than 12 chars... Someone
familiar with VFAT should look whether VFAT multibyte code cannot be
cleaned up a bit... When I was fixing 'break out of now nested loop'
for pre7, I missed this one. Sorry.
If it works for you, either forward it to Linus, or tell me and I'll
send it - but I do not send patches during weekend ;-) . I do not use
VFAT to much personally, so more eyes...
Best regards,
Petr Vandrovec
[EMAIL PROTECTED]
diff -urN linux/fs/vfat/namei.c linux/fs/vfat/namei.c
--- linux/fs/vfat/namei.c Tue Sep 5 23:07:29 2000
+++ linux/fs/vfat/namei.c Fri Oct 13 17:35:43 2000
@@ -618,12 +618,11 @@
sz = len;
ext_start = NULL;
}
- break;
+ goto stop0;
}
}
- if (charbuf[chi] == '.')
- break;
}
+stop0:;
if (ext_start == name - 1) {
sz = len;
ext_start = NULL;
@@ -640,10 +639,12 @@
if (chl == 0)
break;
for (chi = 0; chi chl; chi++)
- if (!strchr(skip_chars, charbuf[chi]))
- break;
+ if (!strchr(skip_chars, charbuf[chi])) {
+ goto stop1;
+ }
name_start++;
}
+stop1:;
if (name_start != ext_start) {
sz = ext_start - name;
ext_start++;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: vfat problems in 2.4.0-test10-pre2
On Friday 13 October 2000 19:55, Petr Vandrovec wrote: I missed original problem, but what about this one? Fixes extension in MSDOS namespace when filename is longer than 12 chars... Someone familiar with VFAT should look whether VFAT multibyte code cannot be cleaned up a bit... When I was fixing 'break out of now nested loop' for pre7, I missed this one. Sorry. If it works for you, either forward it to Linus, or tell me and I'll send it - but I do not send patches during weekend ;-) . I do not use VFAT to much personally, so more eyes... Thanks. I verified that the problem is present in 2.4.0-test9, after tested that patch fixes the problem (I wrote the same files in the same directory on VFAT32 partition). Now testing disk didn't show any problems (earlier it reported LFN problems) Andris PS. I haven't sent patch to Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
