Re: [PATCH v2] ARM: socfpga_defconfig: enable support for large block devices
On Thu, Mar 28, 2019 at 5:07 PM Dinh Nguyen wrote: > On 3/7/19 1:43 AM, Andrey Zhizhikin wrote: > > Hello Dinh, > > > > Just a short ping on this patch - do yo think you can accept this > > patch and have it merged? I'd like to know whether it is planned to be > > integrated, as it might be beneficial for a lot of socfpga users... > > > > Thanks a lot! > > > > Sorry I missed this. I've applied this. No problem, thanks a lot! > > Thanks, > Dinh -- Regards, Andrey.
Re: [PATCH v2] ARM: socfpga_defconfig: enable support for large block devices
On 3/7/19 1:43 AM, Andrey Zhizhikin wrote: > Hello Dinh, > > Just a short ping on this patch - do yo think you can accept this > patch and have it merged? I'd like to know whether it is planned to be > integrated, as it might be beneficial for a lot of socfpga users... > > Thanks a lot! > Sorry I missed this. I've applied this. Thanks, Dinh
Re: [PATCH v2] ARM: socfpga_defconfig: enable support for large block devices
Hello Dinh, Just a short ping on this patch - do yo think you can accept this patch and have it merged? I'd like to know whether it is planned to be integrated, as it might be beneficial for a lot of socfpga users... Thanks a lot! -- Regards, Andrey. On Wed, Feb 27, 2019 at 5:50 PM Andrey Zhizhikin wrote: > > Enable CONFIG_LBDAF, which is required by ext4 fs. This option could > handle both ext3 and ext4, with ext4 requires this option to be enabled, > otherwise the filesystem is mounted RO mode. > > Since the LBDAF is enabled by default for 32-bit systems, simply > removing the current "not set" entry enables the support. > > Signed-off-by: Andrey Zhizhikin > --- > arch/arm/configs/socfpga_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/configs/socfpga_defconfig > b/arch/arm/configs/socfpga_defconfig > index 08d1b3e11d68..c96d93fb68c6 100644 > --- a/arch/arm/configs/socfpga_defconfig > +++ b/arch/arm/configs/socfpga_defconfig > @@ -21,7 +21,6 @@ CONFIG_NEON=y > CONFIG_OPROFILE=y > CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > -# CONFIG_LBDAF is not set > # CONFIG_BLK_DEV_BSG is not set > CONFIG_NET=y > CONFIG_PACKET=y > -- > 2.17.1 >
[PATCH v2] ARM: socfpga_defconfig: enable support for large block devices
Enable CONFIG_LBDAF, which is required by ext4 fs. This option could handle both ext3 and ext4, with ext4 requires this option to be enabled, otherwise the filesystem is mounted RO mode. Since the LBDAF is enabled by default for 32-bit systems, simply removing the current "not set" entry enables the support. Signed-off-by: Andrey Zhizhikin --- arch/arm/configs/socfpga_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig index 08d1b3e11d68..c96d93fb68c6 100644 --- a/arch/arm/configs/socfpga_defconfig +++ b/arch/arm/configs/socfpga_defconfig @@ -21,7 +21,6 @@ CONFIG_NEON=y CONFIG_OPROFILE=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y -# CONFIG_LBDAF is not set # CONFIG_BLK_DEV_BSG is not set CONFIG_NET=y CONFIG_PACKET=y -- 2.17.1
Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices
On 2/25/19 12:55 PM, Andrey Zhizhikin wrote: > Hello Dinh, > > On Mon, Feb 25, 2019 at 5:35 PM Dinh Nguyen wrote: >> >> Hi Andrey, >> >> On 2/22/19 6:21 AM, Andrey Zhizhikin wrote: >>> Enable CONFIG_LBDAF, which is required by ext4 fs. This option could >>> hanle both ext3 and ext4, and ex4 requires this option to be enabled, >>> otherwise the filesystem is mounted RO mode. >>> >>> Signed-off-by: Andrey Zhizhikin >>> --- >>> arch/arm/configs/socfpga_defconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/configs/socfpga_defconfig >>> b/arch/arm/configs/socfpga_defconfig >>> index 08d1b3e11d68..b4b387486cd9 100644 >>> --- a/arch/arm/configs/socfpga_defconfig >>> +++ b/arch/arm/configs/socfpga_defconfig >>> @@ -21,7 +21,7 @@ CONFIG_NEON=y >>> CONFIG_OPROFILE=y >>> CONFIG_MODULES=y >>> CONFIG_MODULE_UNLOAD=y >>> -# CONFIG_LBDAF is not set >> >> CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do >> is remove this line. > > Thanks a lot for clarifications here! I suspected that it was the > case, just needed a confirmation here. > Is it possible we would have this config option enabled for > socfpga_defconfig? If you would agree, then I prepare a separate patch > to have the "CONFIG_LBDAF is not set" removed. Yes, that's what I was alluding to. Dinh
Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices
Hello Dinh, On Mon, Feb 25, 2019 at 5:35 PM Dinh Nguyen wrote: > > Hi Andrey, > > On 2/22/19 6:21 AM, Andrey Zhizhikin wrote: > > Enable CONFIG_LBDAF, which is required by ext4 fs. This option could > > hanle both ext3 and ext4, and ex4 requires this option to be enabled, > > otherwise the filesystem is mounted RO mode. > > > > Signed-off-by: Andrey Zhizhikin > > --- > > arch/arm/configs/socfpga_defconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/configs/socfpga_defconfig > > b/arch/arm/configs/socfpga_defconfig > > index 08d1b3e11d68..b4b387486cd9 100644 > > --- a/arch/arm/configs/socfpga_defconfig > > +++ b/arch/arm/configs/socfpga_defconfig > > @@ -21,7 +21,7 @@ CONFIG_NEON=y > > CONFIG_OPROFILE=y > > CONFIG_MODULES=y > > CONFIG_MODULE_UNLOAD=y > > -# CONFIG_LBDAF is not set > > CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do > is remove this line. Thanks a lot for clarifications here! I suspected that it was the case, just needed a confirmation here. Is it possible we would have this config option enabled for socfpga_defconfig? If you would agree, then I prepare a separate patch to have the "CONFIG_LBDAF is not set" removed. > > Thanks, > Dinh Thanks a lot! -- Andrey.
Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices
Hi Andrey, On 2/22/19 6:21 AM, Andrey Zhizhikin wrote: > Enable CONFIG_LBDAF, which is required by ext4 fs. This option could > hanle both ext3 and ext4, and ex4 requires this option to be enabled, > otherwise the filesystem is mounted RO mode. > > Signed-off-by: Andrey Zhizhikin > --- > arch/arm/configs/socfpga_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/configs/socfpga_defconfig > b/arch/arm/configs/socfpga_defconfig > index 08d1b3e11d68..b4b387486cd9 100644 > --- a/arch/arm/configs/socfpga_defconfig > +++ b/arch/arm/configs/socfpga_defconfig > @@ -21,7 +21,7 @@ CONFIG_NEON=y > CONFIG_OPROFILE=y > CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > -# CONFIG_LBDAF is not set CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do is remove this line. Thanks, Dinh
[PATCH] ARM: socfpga_defconfig: enable support for large block devices
Enable CONFIG_LBDAF, which is required by ext4 fs. This option could hanle both ext3 and ext4, and ex4 requires this option to be enabled, otherwise the filesystem is mounted RO mode. Signed-off-by: Andrey Zhizhikin --- arch/arm/configs/socfpga_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig index 08d1b3e11d68..b4b387486cd9 100644 --- a/arch/arm/configs/socfpga_defconfig +++ b/arch/arm/configs/socfpga_defconfig @@ -21,7 +21,7 @@ CONFIG_NEON=y CONFIG_OPROFILE=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y -# CONFIG_LBDAF is not set +CONFIG_LBDAF=y # CONFIG_BLK_DEV_BSG is not set CONFIG_NET=y CONFIG_PACKET=y -- 2.17.1
Re: Support for Large Block Devices
>>>>> "Maciej" == Maciej Soltysiak <[EMAIL PROTECTED]> writes: Maciej> Hi, I was wondering... Why is "Support for Large Block Maciej> Devices" still an option? Maciej> Shouldn't it be compiled in always? Or maybe there are some Maciej> cons like incompatibility or something? It's not compiled in always on 32-bit platforms, because 1. Most people don't have more than 2TB in a single block device 2. 64-bit sizes mean increased size of various structures (i.e., less cache-friendly), and slightly slower operations. On 64-bit platforms it *is* always enabled. -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au The technical we do immediately, the political takes *forever* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Support for Large Block Devices
Maciej == Maciej Soltysiak [EMAIL PROTECTED] writes: Maciej Hi, I was wondering... Why is Support for Large Block Maciej Devices still an option? Maciej Shouldn't it be compiled in always? Or maybe there are some Maciej cons like incompatibility or something? It's not compiled in always on 32-bit platforms, because 1. Most people don't have more than 2TB in a single block device 2. 64-bit sizes mean increased size of various structures (i.e., less cache-friendly), and slightly slower operations. On 64-bit platforms it *is* always enabled. -- Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au The technical we do immediately, the political takes *forever* - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Support for Large Block Devices
Hi, I was wondering... Why is "Support for Large Block Devices" still an option? Shouldn't it be compiled in always? Or maybe there are some cons like incompatibility or something? Regards, Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Support for Large Block Devices
Hi, I was wondering... Why is Support for Large Block Devices still an option? Shouldn't it be compiled in always? Or maybe there are some cons like incompatibility or something? Regards, Maciej - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
