Re: WARNING: at kernel/cpuset.c:1139
On 2014/7/29 3:20, Tejun Heo wrote: > On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote: >> On 2014/7/23 23:12, Tejun Heo wrote: >>> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: >>>> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config >>>> changes") introduce the below warning in my server. >>>> >>>> [ 35.652137] ----[ cut here ] >>>> [ 35.652141] WARNING: at kernel/cpuset.c:1139 >>> >>> Hah, can you reproduce it? If so, can you detail how? >>> >> >> It's a typo. >> >> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && >> nodes_equal(cp->mems_allowed, cp->effective_mems)); >> >> should be >> >> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && >> !nodes_equal(cp->mems_allowed, cp->effective_mems)); > > Care to post a patch? > Sorry for the delay. I had been off office for the last two weeks. I'll do this tomorrow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On 2014/7/29 3:20, Tejun Heo wrote: On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? It's a typo. WARN_ON(!cgroup_on_dfl(cp-css.cgroup) nodes_equal(cp-mems_allowed, cp-effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp-css.cgroup) !nodes_equal(cp-mems_allowed, cp-effective_mems)); Care to post a patch? Sorry for the delay. I had been off office for the last two weeks. I'll do this tomorrow. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote: > On 2014/7/23 23:12, Tejun Heo wrote: > > On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: > >> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config > >> changes") introduce the below warning in my server. > >> > >> [ 35.652137] ----[ cut here ]---- > >> [ 35.652141] WARNING: at kernel/cpuset.c:1139 > > > > Hah, can you reproduce it? If so, can you detail how? > > > > It's a typo. > > WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && > nodes_equal(cp->mems_allowed, cp->effective_mems)); > > should be > > WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && > !nodes_equal(cp->mems_allowed, cp->effective_mems)); Care to post a patch? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? It's a typo. WARN_ON(!cgroup_on_dfl(cp-css.cgroup) nodes_equal(cp-mems_allowed, cp-effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp-css.cgroup) !nodes_equal(cp-mems_allowed, cp-effective_mems)); Care to post a patch? Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On 07/24/2014 08:27 AM, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config changes") introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? It's a typo. WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && nodes_equal(cp->mems_allowed, cp->effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && !nodes_equal(cp->mems_allowed, cp->effective_mems)); Yes, it is. This warning disappeared after this patch. Reported-and-Tested-by: Mike Qiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On 2014/7/23 23:12, Tejun Heo wrote: > On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: >> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config >> changes") introduce the below warning in my server. >> >> [ 35.652137] [ cut here ]-------- >> [ 35.652141] WARNING: at kernel/cpuset.c:1139 > > Hah, can you reproduce it? If so, can you detail how? > It's a typo. WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && nodes_equal(cp->mems_allowed, cp->effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp->css.cgroup) && !nodes_equal(cp->mems_allowed, cp->effective_mems)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: > commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config > changes") introduce the below warning in my server. > > [ 35.652137] [ cut here ]---- > [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? It's a typo. WARN_ON(!cgroup_on_dfl(cp-css.cgroup) nodes_equal(cp-mems_allowed, cp-effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp-css.cgroup) !nodes_equal(cp-mems_allowed, cp-effective_mems)); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/cpuset.c:1139
On 07/24/2014 08:27 AM, Li Zefan wrote: On 2014/7/23 23:12, Tejun Heo wrote: On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote: commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 Hah, can you reproduce it? If so, can you detail how? It's a typo. WARN_ON(!cgroup_on_dfl(cp-css.cgroup) nodes_equal(cp-mems_allowed, cp-effective_mems)); should be WARN_ON(!cgroup_on_dfl(cp-css.cgroup) !nodes_equal(cp-mems_allowed, cp-effective_mems)); Yes, it is. This warning disappeared after this patch. Reported-and-Tested-by: Mike Qiu qiud...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
WARNING: at kernel/cpuset.c:1139
commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config changes") introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 [ 35.652142] Modules linked in: ebtable_nat xt_CHECKSUM bridge stp llc be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i cxgb4 cxgb3i cxgb3 mdio libcxgbi ib_iser iptable_mangle nf_conntrack_ipv4 rdma_cm nf_defrag_ipv4 xt_conntrack iw_cm nf_conntrack ib_cm ib_sa ib_mad ebtable_filter ib_core ebtables ip6_tables ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi e1000e ses ptp enclosure pps_core be2net shpchp vhost_net tun macvtap macvlan vhost kvm binfmt_misc uinput lpfc scsi_transport_fc ipr [ 35.652185] CPU: 36 PID: 1363 Comm: libvirtd Not tainted 3.16.0-rc5-next-20140721+ #93 [ 35.652187] task: c003b3443a00 ti: c003bb008000 task.ti: c003bb008000 [ 35.652189] NIP: c015ff38 LR: c015ff2c CTR: [ 35.652190] REGS: c003bb00b850 TRAP: 0700 Not tainted (3.16.0-rc5-next-20140721+) [ 35.652191] MSR: 90029032 CR: 24004824 XER: [ 35.652196] CFAR: c045f6cc SOFTE: 1 GPR00: c015ff04 c003bb00bad0 c145acf8 0001 GPR04: c003b3dae5d0 0100 GPR08: c003b3dae548 0004 0004 GPR12: 0001 cfeea200 008066727bd8 008066727a30 GPR16: 0080667dfa08 008066727a68 0080667279f8 0080667279d0 GPR20: c166acf8 c003b3dae530 c1311990 c003b3dae5d0 GPR24: c003b3dae530 c003b3dadc00 c003b3dae400 0001 GPR28: c1311968 c003b1873100 c003b3dae400 [ 35.652219] NIP [c015ff38] .cpuset_write_resmask+0x438/0x8c0 [ 35.652221] LR [c015ff2c] .cpuset_write_resmask+0x42c/0x8c0 [ 35.65] Call Trace: [ 35.652224] [c003bb00bad0] [c015ff04] .cpuset_write_resmask+0x404/0x8c0 (unreliable) [ 35.652227] [c003bb00bba0] [c0156f08] .cgroup_file_write+0x78/0x190 [ 35.652230] [c003bb00bc50] [c030c490] .kernfs_fop_write+0x150/0x1e0 [ 35.652233] [c003bb00bcf0] [c026b6d0] .vfs_write+0xe0/0x270 [ 35.652235] [c003bb00bd90] [c026be24] .SyS_write+0x64/0x110 [ 35.652238] [c003bb00be30] [c000a158] syscall_exit+0x0/0x98 [ 35.652239] Instruction dump: [ 35.652240] e93a 39549528 e9290118 7fa95000 419e0024 7ea3ab78 7ee4bb78 38a00100 [ 35.652243] 482ff719 6000 2fa3 419e0008 <0fe0> 7f43d378 4bfffa71 813a006c [ 35.652247] ---[ end trace f91b0c3aadfe71a6 ]--- Thanks, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
WARNING: at kernel/cpuset.c:1139
commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config changes) introduce the below warning in my server. [ 35.652137] [ cut here ] [ 35.652141] WARNING: at kernel/cpuset.c:1139 [ 35.652142] Modules linked in: ebtable_nat xt_CHECKSUM bridge stp llc be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i cxgb4 cxgb3i cxgb3 mdio libcxgbi ib_iser iptable_mangle nf_conntrack_ipv4 rdma_cm nf_defrag_ipv4 xt_conntrack iw_cm nf_conntrack ib_cm ib_sa ib_mad ebtable_filter ib_core ebtables ip6_tables ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi e1000e ses ptp enclosure pps_core be2net shpchp vhost_net tun macvtap macvlan vhost kvm binfmt_misc uinput lpfc scsi_transport_fc ipr [ 35.652185] CPU: 36 PID: 1363 Comm: libvirtd Not tainted 3.16.0-rc5-next-20140721+ #93 [ 35.652187] task: c003b3443a00 ti: c003bb008000 task.ti: c003bb008000 [ 35.652189] NIP: c015ff38 LR: c015ff2c CTR: [ 35.652190] REGS: c003bb00b850 TRAP: 0700 Not tainted (3.16.0-rc5-next-20140721+) [ 35.652191] MSR: 90029032 SF,HV,EE,ME,IR,DR,RI CR: 24004824 XER: [ 35.652196] CFAR: c045f6cc SOFTE: 1 GPR00: c015ff04 c003bb00bad0 c145acf8 0001 GPR04: c003b3dae5d0 0100 GPR08: c003b3dae548 0004 0004 GPR12: 0001 cfeea200 008066727bd8 008066727a30 GPR16: 0080667dfa08 008066727a68 0080667279f8 0080667279d0 GPR20: c166acf8 c003b3dae530 c1311990 c003b3dae5d0 GPR24: c003b3dae530 c003b3dadc00 c003b3dae400 0001 GPR28: c1311968 c003b1873100 c003b3dae400 [ 35.652219] NIP [c015ff38] .cpuset_write_resmask+0x438/0x8c0 [ 35.652221] LR [c015ff2c] .cpuset_write_resmask+0x42c/0x8c0 [ 35.65] Call Trace: [ 35.652224] [c003bb00bad0] [c015ff04] .cpuset_write_resmask+0x404/0x8c0 (unreliable) [ 35.652227] [c003bb00bba0] [c0156f08] .cgroup_file_write+0x78/0x190 [ 35.652230] [c003bb00bc50] [c030c490] .kernfs_fop_write+0x150/0x1e0 [ 35.652233] [c003bb00bcf0] [c026b6d0] .vfs_write+0xe0/0x270 [ 35.652235] [c003bb00bd90] [c026be24] .SyS_write+0x64/0x110 [ 35.652238] [c003bb00be30] [c000a158] syscall_exit+0x0/0x98 [ 35.652239] Instruction dump: [ 35.652240] e93a 39549528 e9290118 7fa95000 419e0024 7ea3ab78 7ee4bb78 38a00100 [ 35.652243] 482ff719 6000 2fa3 419e0008 0fe0 7f43d378 4bfffa71 813a006c [ 35.652247] ---[ end trace f91b0c3aadfe71a6 ]--- Thanks, Mike -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/