Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 29 Nov 2007 16:40:37 -0700 Bjorn Helgaas <[EMAIL PROTECTED]> wrote: > > The corresponding PCI code in pci_device_suspend() does not do > any generic device disable or resource release. I don't know > why PNP disables the device on suspend. I glanced through the > ACPI spec but didn't see a requirement for it. Maybe Pierre [1] > remembers. > Afraid not. There was a reason for it, but my mind draws a blank as to what that was... I have a slight recollection of bad BIOS interaction during STR, but I'm not sure it was related to this specific patch. Rgds Pierre signature.asc Description: PGP signature
Re: WARNING: at kernel/resource.c:189 __release_resource
On 12/01/2007 09:12 AM, Jiri Slaby wrote:
> On 11/30/2007 11:58 PM, Bjorn Helgaas wrote:
>> On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
>>> On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
> On Thu, 29 Nov 2007 16:40:37 -0700
>> Maybe we could either remove the pnp_{stop,start}_dev() calls
>> from the suspend/resume path, or move the PNP resource management
>> out of pnp_{start,stop}_dev().
>>
>> Bjorn
>>
>> [1] http://lkml.org/lkml/2005/11/30/39
> So was this particular problem caused/exposed by
> pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch,
> or is
> it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30
13:58:25.0 -0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0
-0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev->protocol && pnp_dev->protocol->suspend)
pnp_dev->protocol->suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev->protocol && pnp_dev->protocol->resume)
pnp_dev->protocol->resume(pnp_dev);
- if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv->resume)
return pnp_drv->resume(pnp_dev);
>>> No, it breaks suspend.
>> Thanks for trying it. What are the symptoms? I'd like to understand
>> why we need to stop the devices before suspend.
>
> Ho hum, it's not so easy, it's kind of nondeterministic now. Maybe
> some other
> issue. If I remove 8250* modules from the kernel, it works. Otherwise
> it locks
> in the middle of suspend after disks and graphics go down no matter if
> the patch
> has been applied or not. Trying to investigate this further...
I didn't get it. Maybe some trolls poking around or something (maybe the
ext3 breakage which fsck fixed). It works after recompilation of the
whole tree. And the important part -- the warning has gone. Just a note,
fold this -fix into it:
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index f5b64ee..b0fc3ee 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -170,7 +170,6 @@ static int pnp_bus_resume(struct device *dev)
{
struct pnp_dev *pnp_dev = to_pnp_dev(dev);
struct pnp_driver *pnp_drv = pnp_dev->driver;
- int error;
if (!pnp_drv)
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On 11/30/2007 11:58 PM, Bjorn Helgaas wrote:
> On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
>> On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
>>> On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
> Maybe we could either remove the pnp_{stop,start}_dev() calls
> from the suspend/resume path, or move the PNP resource management
> out of pnp_{start,stop}_dev().
>
> Bjorn
>
> [1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
>>> I'm pretty sure this problem is caused by that patch, so we
>>> we shouldn't see this in mainline.
>>>
>>> Jiri, can you try the additional patch below, please?
>>>
>>> Index: linux-mm/drivers/pnp/driver.c
>>> ===
>>> --- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0
>>> -0700
>>> +++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
>>> @@ -161,13 +161,6 @@
>>> return error;
>>> }
>>>
>>> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
>>> - pnp_can_disable(pnp_dev)) {
>>> - error = pnp_stop_dev(pnp_dev);
>>> - if (error)
>>> - return error;
>>> - }
>>> -
>>> if (pnp_dev->protocol && pnp_dev->protocol->suspend)
>>> pnp_dev->protocol->suspend(pnp_dev, state);
>>> return 0;
>>> @@ -185,12 +178,6 @@
>>> if (pnp_dev->protocol && pnp_dev->protocol->resume)
>>> pnp_dev->protocol->resume(pnp_dev);
>>>
>>> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
>>> - error = pnp_start_dev(pnp_dev);
>>> - if (error)
>>> - return error;
>>> - }
>>> -
>>> if (pnp_drv->resume)
>>> return pnp_drv->resume(pnp_dev);
>>>
>> No, it breaks suspend.
>
> Thanks for trying it. What are the symptoms? I'd like to understand
> why we need to stop the devices before suspend.
Ho hum, it's not so easy, it's kind of nondeterministic now. Maybe some other
issue. If I remove 8250* modules from the kernel, it works. Otherwise it locks
in the middle of suspend after disks and graphics go down no matter if the patch
has been applied or not. Trying to investigate this further...
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On 11/30/2007 11:58 PM, Bjorn Helgaas wrote:
On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0
-0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev-protocol pnp_dev-protocol-suspend)
pnp_dev-protocol-suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev-protocol pnp_dev-protocol-resume)
pnp_dev-protocol-resume(pnp_dev);
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv-resume)
return pnp_drv-resume(pnp_dev);
No, it breaks suspend.
Thanks for trying it. What are the symptoms? I'd like to understand
why we need to stop the devices before suspend.
Ho hum, it's not so easy, it's kind of nondeterministic now. Maybe some other
issue. If I remove 8250* modules from the kernel, it works. Otherwise it locks
in the middle of suspend after disks and graphics go down no matter if the patch
has been applied or not. Trying to investigate this further...
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On 12/01/2007 09:12 AM, Jiri Slaby wrote:
On 11/30/2007 11:58 PM, Bjorn Helgaas wrote:
On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch,
or is
it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30
13:58:25.0 -0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0
-0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev-protocol pnp_dev-protocol-suspend)
pnp_dev-protocol-suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev-protocol pnp_dev-protocol-resume)
pnp_dev-protocol-resume(pnp_dev);
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv-resume)
return pnp_drv-resume(pnp_dev);
No, it breaks suspend.
Thanks for trying it. What are the symptoms? I'd like to understand
why we need to stop the devices before suspend.
Ho hum, it's not so easy, it's kind of nondeterministic now. Maybe
some other
issue. If I remove 8250* modules from the kernel, it works. Otherwise
it locks
in the middle of suspend after disks and graphics go down no matter if
the patch
has been applied or not. Trying to investigate this further...
I didn't get it. Maybe some trolls poking around or something (maybe the
ext3 breakage which fsck fixed). It works after recompilation of the
whole tree. And the important part -- the warning has gone. Just a note,
fold this -fix into it:
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index f5b64ee..b0fc3ee 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -170,7 +170,6 @@ static int pnp_bus_resume(struct device *dev)
{
struct pnp_dev *pnp_dev = to_pnp_dev(dev);
struct pnp_driver *pnp_drv = pnp_dev-driver;
- int error;
if (!pnp_drv)
return 0;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 29 Nov 2007 16:40:37 -0700 Bjorn Helgaas [EMAIL PROTECTED] wrote: The corresponding PCI code in pci_device_suspend() does not do any generic device disable or resource release. I don't know why PNP disables the device on suspend. I glanced through the ACPI spec but didn't see a requirement for it. Maybe Pierre [1] remembers. Afraid not. There was a reason for it, but my mind draws a blank as to what that was... I have a slight recollection of bad BIOS interaction during STR, but I'm not sure it was related to this specific patch. Rgds Pierre signature.asc Description: PGP signature
Re: WARNING: at kernel/resource.c:189 __release_resource
On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
> On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
> > On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
> >> On Thu, 29 Nov 2007 16:40:37 -0700
> >>> Maybe we could either remove the pnp_{stop,start}_dev() calls
> >>> from the suspend/resume path, or move the PNP resource management
> >>> out of pnp_{start,stop}_dev().
> >>>
> >>> Bjorn
> >>>
> >>> [1] http://lkml.org/lkml/2005/11/30/39
> >> So was this particular problem caused/exposed by
> >> pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
> >> it in mainline?
> >
> > I'm pretty sure this problem is caused by that patch, so we
> > we shouldn't see this in mainline.
> >
> > Jiri, can you try the additional patch below, please?
> >
> > Index: linux-mm/drivers/pnp/driver.c
> > ===
> > --- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0
> > -0700
> > +++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
> > @@ -161,13 +161,6 @@
> > return error;
> > }
> >
> > - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
> > - pnp_can_disable(pnp_dev)) {
> > - error = pnp_stop_dev(pnp_dev);
> > - if (error)
> > - return error;
> > - }
> > -
> > if (pnp_dev->protocol && pnp_dev->protocol->suspend)
> > pnp_dev->protocol->suspend(pnp_dev, state);
> > return 0;
> > @@ -185,12 +178,6 @@
> > if (pnp_dev->protocol && pnp_dev->protocol->resume)
> > pnp_dev->protocol->resume(pnp_dev);
> >
> > - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
> > - error = pnp_start_dev(pnp_dev);
> > - if (error)
> > - return error;
> > - }
> > -
> > if (pnp_drv->resume)
> > return pnp_drv->resume(pnp_dev);
> >
>
> No, it breaks suspend.
Thanks for trying it. What are the symptoms? I'd like to understand
why we need to stop the devices before suspend.
Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
> On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
>> On Thu, 29 Nov 2007 16:40:37 -0700
>>> Maybe we could either remove the pnp_{stop,start}_dev() calls
>>> from the suspend/resume path, or move the PNP resource management
>>> out of pnp_{start,stop}_dev().
>>>
>>> Bjorn
>>>
>>> [1] http://lkml.org/lkml/2005/11/30/39
>> So was this particular problem caused/exposed by
>> pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
>> it in mainline?
>
> I'm pretty sure this problem is caused by that patch, so we
> we shouldn't see this in mainline.
>
> Jiri, can you try the additional patch below, please?
>
> Index: linux-mm/drivers/pnp/driver.c
> ===
> --- linux-mm.orig/drivers/pnp/driver.c2007-11-30 13:58:25.0
> -0700
> +++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
> @@ -161,13 +161,6 @@
> return error;
> }
>
> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
> - pnp_can_disable(pnp_dev)) {
> - error = pnp_stop_dev(pnp_dev);
> - if (error)
> - return error;
> - }
> -
> if (pnp_dev->protocol && pnp_dev->protocol->suspend)
> pnp_dev->protocol->suspend(pnp_dev, state);
> return 0;
> @@ -185,12 +178,6 @@
> if (pnp_dev->protocol && pnp_dev->protocol->resume)
> pnp_dev->protocol->resume(pnp_dev);
>
> - if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
> - error = pnp_start_dev(pnp_dev);
> - if (error)
> - return error;
> - }
> -
> if (pnp_drv->resume)
> return pnp_drv->resume(pnp_dev);
>
No, it breaks suspend.
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
> On Thu, 29 Nov 2007 16:40:37 -0700
> Bjorn Helgaas <[EMAIL PROTECTED]> wrote:
>
> > On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
> > > On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote:
> > > > Ok, I hit the bug, suspend of 00:06 device complains about it:
> > > > WARNING: at .../kernel/resource.c:185 __release_resource()
> > > >
> > > > Call Trace:
> > > > [] release_resource+0xb5/0xf0
> > > > [] pnp_release_resources+0x70/0x130
> > > > [] pnp_stop_dev+0x45/0x90
> > > > [] pnp_bus_suspend+0x92/0xb0
> > > > [] suspend_device+0x113/0x180
> > > > [] device_suspend+0x200/0x320
> > > > [] suspend_devices_and_enter+0xa5/0x170
> > > > [] enter_state+0x209/0x270
> > > > [] state_store+0xaf/0xf0
> > > > [] kobj_attr_store+0x17/0x20
> > > > [] sysfs_write_file+0xce/0x140
> > > > [] vfs_write+0xc7/0x170
> > > > [] sys_write+0x50/0x90
> > > > [] system_call+0x7e/0x83
> > > >
> > > > # LANG=en ll /sys/devices/pnp0/00:06/
> > > > total 0
> > > > lrwxrwxrwx 1 root root0 Nov 22 22:35 driver ->
> > > > ../../../bus/pnp/drivers/serial
> > > > -r--r--r-- 1 root root 4096 Nov 22 22:35 id
> > > > -r--r--r-- 1 root root 4096 Nov 22 22:35 options
> > > > drwxr-xr-x 2 root root0 Nov 22 22:35 power
> > > > -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
> > > > lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem -> ../../../bus/pnp
> > > > drwxr-xr-x 3 root root0 Nov 22 22:35 tty
> > > > -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
> > >
> > > I suppose that's a genuine leak, presumably in 8250_pnp.
> >
> > We used to have only the serial driver resource reservation. We now
> > have an additional 00:06 resource that is the parent of the serial
> > resource, e.g.,
> >
> > 03f8-03ff : 00:06
> > 03f8-03ff : serial
> >
> > I think this problem happens because pnp_bus_suspend() calls
> > serial_pnp_suspend(), which suspends the driver but does nothing
> > with the resources. Then it calls pnp_stop_dev(), which releases
> > the 00:06 resource, which still has a serial child resource.
> >
> > The corresponding PCI code in pci_device_suspend() does not do
> > any generic device disable or resource release. I don't know
> > why PNP disables the device on suspend. I glanced through the
> > ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
> > remembers.
> >
> > Maybe we could either remove the pnp_{stop,start}_dev() calls
> > from the suspend/resume path, or move the PNP resource management
> > out of pnp_{start,stop}_dev().
> >
> > Bjorn
> >
> > [1] http://lkml.org/lkml/2005/11/30/39
>
> So was this particular problem caused/exposed by
> pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
> it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0 -0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE) &&
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev->protocol && pnp_dev->protocol->suspend)
pnp_dev->protocol->suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev->protocol && pnp_dev->protocol->resume)
pnp_dev->protocol->resume(pnp_dev);
- if (!(pnp_drv->flags & PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv->resume)
return pnp_drv->resume(pnp_dev);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
Bjorn Helgaas [EMAIL PROTECTED] wrote:
On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby [EMAIL PROTECTED] wrote:
Ok, I hit the bug, suspend of 00:06 device complains about it:
WARNING: at .../kernel/resource.c:185 __release_resource()
Call Trace:
[8023f7b5] release_resource+0xb5/0xf0
[8036cda0] pnp_release_resources+0x70/0x130
[8036db85] pnp_stop_dev+0x45/0x90
[8036c942] pnp_bus_suspend+0x92/0xb0
[803b9f73] suspend_device+0x113/0x180
[803ba330] device_suspend+0x200/0x320
[80266905] suspend_devices_and_enter+0xa5/0x170
[80266bd9] enter_state+0x209/0x270
[80266cef] state_store+0xaf/0xf0
[8032ca67] kobj_attr_store+0x17/0x20
[802e459e] sysfs_write_file+0xce/0x140
[80299cc7] vfs_write+0xc7/0x170
[8029a360] sys_write+0x50/0x90
[8020bcde] system_call+0x7e/0x83
# LANG=en ll /sys/devices/pnp0/00:06/
total 0
lrwxrwxrwx 1 root root0 Nov 22 22:35 driver -
../../../bus/pnp/drivers/serial
-r--r--r-- 1 root root 4096 Nov 22 22:35 id
-r--r--r-- 1 root root 4096 Nov 22 22:35 options
drwxr-xr-x 2 root root0 Nov 22 22:35 power
-rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem - ../../../bus/pnp
drwxr-xr-x 3 root root0 Nov 22 22:35 tty
-rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
I suppose that's a genuine leak, presumably in 8250_pnp.
We used to have only the serial driver resource reservation. We now
have an additional 00:06 resource that is the parent of the serial
resource, e.g.,
03f8-03ff : 00:06
03f8-03ff : serial
I think this problem happens because pnp_bus_suspend() calls
serial_pnp_suspend(), which suspends the driver but does nothing
with the resources. Then it calls pnp_stop_dev(), which releases
the 00:06 resource, which still has a serial child resource.
The corresponding PCI code in pci_device_suspend() does not do
any generic device disable or resource release. I don't know
why PNP disables the device on suspend. I glanced through the
ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
remembers.
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0 -0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev-protocol pnp_dev-protocol-suspend)
pnp_dev-protocol-suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev-protocol pnp_dev-protocol-resume)
pnp_dev-protocol-resume(pnp_dev);
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv-resume)
return pnp_drv-resume(pnp_dev);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Friday 30 November 2007 03:49:55 pm Jiri Slaby wrote:
On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c 2007-11-30 13:58:25.0
-0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev-protocol pnp_dev-protocol-suspend)
pnp_dev-protocol-suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev-protocol pnp_dev-protocol-resume)
pnp_dev-protocol-resume(pnp_dev);
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv-resume)
return pnp_drv-resume(pnp_dev);
No, it breaks suspend.
Thanks for trying it. What are the symptoms? I'd like to understand
why we need to stop the devices before suspend.
Bjorn
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On 11/30/2007 10:08 PM, Bjorn Helgaas wrote:
On Thursday 29 November 2007 05:42:07 pm Andrew Morton wrote:
On Thu, 29 Nov 2007 16:40:37 -0700
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
I'm pretty sure this problem is caused by that patch, so we
we shouldn't see this in mainline.
Jiri, can you try the additional patch below, please?
Index: linux-mm/drivers/pnp/driver.c
===
--- linux-mm.orig/drivers/pnp/driver.c2007-11-30 13:58:25.0
-0700
+++ linux-mm/drivers/pnp/driver.c 2007-11-30 13:59:37.0 -0700
@@ -161,13 +161,6 @@
return error;
}
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)
- pnp_can_disable(pnp_dev)) {
- error = pnp_stop_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_dev-protocol pnp_dev-protocol-suspend)
pnp_dev-protocol-suspend(pnp_dev, state);
return 0;
@@ -185,12 +178,6 @@
if (pnp_dev-protocol pnp_dev-protocol-resume)
pnp_dev-protocol-resume(pnp_dev);
- if (!(pnp_drv-flags PNP_DRIVER_RES_DO_NOT_CHANGE)) {
- error = pnp_start_dev(pnp_dev);
- if (error)
- return error;
- }
-
if (pnp_drv-resume)
return pnp_drv-resume(pnp_dev);
No, it breaks suspend.
regards,
--
Jiri Slaby ([EMAIL PROTECTED])
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 29 Nov 2007 16:40:37 -0700
Bjorn Helgaas <[EMAIL PROTECTED]> wrote:
> On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
> > On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote:
> > > Ok, I hit the bug, suspend of 00:06 device complains about it:
> > > WARNING: at .../kernel/resource.c:185 __release_resource()
> > >
> > > Call Trace:
> > > [] release_resource+0xb5/0xf0
> > > [] pnp_release_resources+0x70/0x130
> > > [] pnp_stop_dev+0x45/0x90
> > > [] pnp_bus_suspend+0x92/0xb0
> > > [] suspend_device+0x113/0x180
> > > [] device_suspend+0x200/0x320
> > > [] suspend_devices_and_enter+0xa5/0x170
> > > [] enter_state+0x209/0x270
> > > [] state_store+0xaf/0xf0
> > > [] kobj_attr_store+0x17/0x20
> > > [] sysfs_write_file+0xce/0x140
> > > [] vfs_write+0xc7/0x170
> > > [] sys_write+0x50/0x90
> > > [] system_call+0x7e/0x83
> > >
> > > # LANG=en ll /sys/devices/pnp0/00:06/
> > > total 0
> > > lrwxrwxrwx 1 root root0 Nov 22 22:35 driver ->
> > > ../../../bus/pnp/drivers/serial
> > > -r--r--r-- 1 root root 4096 Nov 22 22:35 id
> > > -r--r--r-- 1 root root 4096 Nov 22 22:35 options
> > > drwxr-xr-x 2 root root0 Nov 22 22:35 power
> > > -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
> > > lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem -> ../../../bus/pnp
> > > drwxr-xr-x 3 root root0 Nov 22 22:35 tty
> > > -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
> >
> > I suppose that's a genuine leak, presumably in 8250_pnp.
>
> We used to have only the serial driver resource reservation. We now
> have an additional 00:06 resource that is the parent of the serial
> resource, e.g.,
>
> 03f8-03ff : 00:06
> 03f8-03ff : serial
>
> I think this problem happens because pnp_bus_suspend() calls
> serial_pnp_suspend(), which suspends the driver but does nothing
> with the resources. Then it calls pnp_stop_dev(), which releases
> the 00:06 resource, which still has a serial child resource.
>
> The corresponding PCI code in pci_device_suspend() does not do
> any generic device disable or resource release. I don't know
> why PNP disables the device on suspend. I glanced through the
> ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
> remembers.
>
> Maybe we could either remove the pnp_{stop,start}_dev() calls
> from the suspend/resume path, or move the PNP resource management
> out of pnp_{start,stop}_dev().
>
> Bjorn
>
> [1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
> On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote:
> > Ok, I hit the bug, suspend of 00:06 device complains about it:
> > WARNING: at .../kernel/resource.c:185 __release_resource()
> >
> > Call Trace:
> > [] release_resource+0xb5/0xf0
> > [] pnp_release_resources+0x70/0x130
> > [] pnp_stop_dev+0x45/0x90
> > [] pnp_bus_suspend+0x92/0xb0
> > [] suspend_device+0x113/0x180
> > [] device_suspend+0x200/0x320
> > [] suspend_devices_and_enter+0xa5/0x170
> > [] enter_state+0x209/0x270
> > [] state_store+0xaf/0xf0
> > [] kobj_attr_store+0x17/0x20
> > [] sysfs_write_file+0xce/0x140
> > [] vfs_write+0xc7/0x170
> > [] sys_write+0x50/0x90
> > [] system_call+0x7e/0x83
> >
> > # LANG=en ll /sys/devices/pnp0/00:06/
> > total 0
> > lrwxrwxrwx 1 root root0 Nov 22 22:35 driver ->
> > ../../../bus/pnp/drivers/serial
> > -r--r--r-- 1 root root 4096 Nov 22 22:35 id
> > -r--r--r-- 1 root root 4096 Nov 22 22:35 options
> > drwxr-xr-x 2 root root0 Nov 22 22:35 power
> > -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
> > lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem -> ../../../bus/pnp
> > drwxr-xr-x 3 root root0 Nov 22 22:35 tty
> > -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
>
> I suppose that's a genuine leak, presumably in 8250_pnp.
We used to have only the serial driver resource reservation. We now
have an additional 00:06 resource that is the parent of the serial
resource, e.g.,
03f8-03ff : 00:06
03f8-03ff : serial
I think this problem happens because pnp_bus_suspend() calls
serial_pnp_suspend(), which suspends the driver but does nothing
with the resources. Then it calls pnp_stop_dev(), which releases
the 00:06 resource, which still has a serial child resource.
The corresponding PCI code in pci_device_suspend() does not do
any generic device disable or resource release. I don't know
why PNP disables the device on suspend. I glanced through the
ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
remembers.
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby [EMAIL PROTECTED] wrote:
Ok, I hit the bug, suspend of 00:06 device complains about it:
WARNING: at .../kernel/resource.c:185 __release_resource()
Call Trace:
[8023f7b5] release_resource+0xb5/0xf0
[8036cda0] pnp_release_resources+0x70/0x130
[8036db85] pnp_stop_dev+0x45/0x90
[8036c942] pnp_bus_suspend+0x92/0xb0
[803b9f73] suspend_device+0x113/0x180
[803ba330] device_suspend+0x200/0x320
[80266905] suspend_devices_and_enter+0xa5/0x170
[80266bd9] enter_state+0x209/0x270
[80266cef] state_store+0xaf/0xf0
[8032ca67] kobj_attr_store+0x17/0x20
[802e459e] sysfs_write_file+0xce/0x140
[80299cc7] vfs_write+0xc7/0x170
[8029a360] sys_write+0x50/0x90
[8020bcde] system_call+0x7e/0x83
# LANG=en ll /sys/devices/pnp0/00:06/
total 0
lrwxrwxrwx 1 root root0 Nov 22 22:35 driver -
../../../bus/pnp/drivers/serial
-r--r--r-- 1 root root 4096 Nov 22 22:35 id
-r--r--r-- 1 root root 4096 Nov 22 22:35 options
drwxr-xr-x 2 root root0 Nov 22 22:35 power
-rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem - ../../../bus/pnp
drwxr-xr-x 3 root root0 Nov 22 22:35 tty
-rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
I suppose that's a genuine leak, presumably in 8250_pnp.
We used to have only the serial driver resource reservation. We now
have an additional 00:06 resource that is the parent of the serial
resource, e.g.,
03f8-03ff : 00:06
03f8-03ff : serial
I think this problem happens because pnp_bus_suspend() calls
serial_pnp_suspend(), which suspends the driver but does nothing
with the resources. Then it calls pnp_stop_dev(), which releases
the 00:06 resource, which still has a serial child resource.
The corresponding PCI code in pci_device_suspend() does not do
any generic device disable or resource release. I don't know
why PNP disables the device on suspend. I glanced through the
ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
remembers.
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 29 Nov 2007 16:40:37 -0700
Bjorn Helgaas [EMAIL PROTECTED] wrote:
On Monday 26 November 2007 11:05:38 pm Andrew Morton wrote:
On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby [EMAIL PROTECTED] wrote:
Ok, I hit the bug, suspend of 00:06 device complains about it:
WARNING: at .../kernel/resource.c:185 __release_resource()
Call Trace:
[8023f7b5] release_resource+0xb5/0xf0
[8036cda0] pnp_release_resources+0x70/0x130
[8036db85] pnp_stop_dev+0x45/0x90
[8036c942] pnp_bus_suspend+0x92/0xb0
[803b9f73] suspend_device+0x113/0x180
[803ba330] device_suspend+0x200/0x320
[80266905] suspend_devices_and_enter+0xa5/0x170
[80266bd9] enter_state+0x209/0x270
[80266cef] state_store+0xaf/0xf0
[8032ca67] kobj_attr_store+0x17/0x20
[802e459e] sysfs_write_file+0xce/0x140
[80299cc7] vfs_write+0xc7/0x170
[8029a360] sys_write+0x50/0x90
[8020bcde] system_call+0x7e/0x83
# LANG=en ll /sys/devices/pnp0/00:06/
total 0
lrwxrwxrwx 1 root root0 Nov 22 22:35 driver -
../../../bus/pnp/drivers/serial
-r--r--r-- 1 root root 4096 Nov 22 22:35 id
-r--r--r-- 1 root root 4096 Nov 22 22:35 options
drwxr-xr-x 2 root root0 Nov 22 22:35 power
-rw-r--r-- 1 root root 4096 Nov 22 22:35 resources
lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem - ../../../bus/pnp
drwxr-xr-x 3 root root0 Nov 22 22:35 tty
-rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent
I suppose that's a genuine leak, presumably in 8250_pnp.
We used to have only the serial driver resource reservation. We now
have an additional 00:06 resource that is the parent of the serial
resource, e.g.,
03f8-03ff : 00:06
03f8-03ff : serial
I think this problem happens because pnp_bus_suspend() calls
serial_pnp_suspend(), which suspends the driver but does nothing
with the resources. Then it calls pnp_stop_dev(), which releases
the 00:06 resource, which still has a serial child resource.
The corresponding PCI code in pci_device_suspend() does not do
any generic device disable or resource release. I don't know
why PNP disables the device on suspend. I glanced through the
ACPI spec but didn't see a requirement for it. Maybe Pierre [1]
remembers.
Maybe we could either remove the pnp_{stop,start}_dev() calls
from the suspend/resume path, or move the PNP resource management
out of pnp_{start,stop}_dev().
Bjorn
[1] http://lkml.org/lkml/2005/11/30/39
So was this particular problem caused/exposed by
pnp-request-ioport-and-iomem-resources-used-by-active-devices.patch, or is
it in mainline?
Thanks.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Mon, Nov 26, 2007 at 10:05:38PM -0800, Andrew Morton wrote: > On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > > Step aside. What's the purpose of having two similar patches for one issue, > > it then warns about the same thing twice: > > make-sure-nobodys-leaking-resources.patch > > releasing-resources-with-children.patch > > Oh well. It's better than having none. Matthew, could you have think > about something for mainline please? I submitted it for mainline. I was never quite sure why you only took it into -mm. I'll take a look at what you have in -mm these days. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Mon, Nov 26, 2007 at 10:05:38PM -0800, Andrew Morton wrote: On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby [EMAIL PROTECTED] wrote: Step aside. What's the purpose of having two similar patches for one issue, it then warns about the same thing twice: make-sure-nobodys-leaking-resources.patch releasing-resources-with-children.patch Oh well. It's better than having none. Matthew, could you have think about something for mainline please? I submitted it for mainline. I was never quite sure why you only took it into -mm. I'll take a look at what you have in -mm these days. -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote: > Hi, > > Step aside. What's the purpose of having two similar patches for one issue, > it then warns about the same thing twice: > make-sure-nobodys-leaking-resources.patch > releasing-resources-with-children.patch Oh well. It's better than having none. Matthew, could you have think about something for mainline please? > Ok, I hit the bug, suspend of 00:06 device complains about it: > WARNING: at .../kernel/resource.c:185 __release_resource() > > Call Trace: > [] release_resource+0xb5/0xf0 > [] pnp_release_resources+0x70/0x130 > [] pnp_stop_dev+0x45/0x90 > [] pnp_bus_suspend+0x92/0xb0 > [] suspend_device+0x113/0x180 > [] device_suspend+0x200/0x320 > [] suspend_devices_and_enter+0xa5/0x170 > [] enter_state+0x209/0x270 > [] state_store+0xaf/0xf0 > [] kobj_attr_store+0x17/0x20 > [] sysfs_write_file+0xce/0x140 > [] vfs_write+0xc7/0x170 > [] sys_write+0x50/0x90 > [] system_call+0x7e/0x83 > > # LANG=en ll /sys/devices/pnp0/00:06/ > total 0 > lrwxrwxrwx 1 root root0 Nov 22 22:35 driver -> > ../../../bus/pnp/drivers/serial > -r--r--r-- 1 root root 4096 Nov 22 22:35 id > -r--r--r-- 1 root root 4096 Nov 22 22:35 options > drwxr-xr-x 2 root root0 Nov 22 22:35 power > -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources > lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem -> ../../../bus/pnp > drwxr-xr-x 3 root root0 Nov 22 22:35 tty > -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent > I suppose that's a genuine leak, presumably in 8250_pnp. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: WARNING: at kernel/resource.c:189 __release_resource
On Thu, 22 Nov 2007 22:41:16 +0100 Jiri Slaby [EMAIL PROTECTED] wrote: Hi, Step aside. What's the purpose of having two similar patches for one issue, it then warns about the same thing twice: make-sure-nobodys-leaking-resources.patch releasing-resources-with-children.patch Oh well. It's better than having none. Matthew, could you have think about something for mainline please? Ok, I hit the bug, suspend of 00:06 device complains about it: WARNING: at .../kernel/resource.c:185 __release_resource() Call Trace: [8023f7b5] release_resource+0xb5/0xf0 [8036cda0] pnp_release_resources+0x70/0x130 [8036db85] pnp_stop_dev+0x45/0x90 [8036c942] pnp_bus_suspend+0x92/0xb0 [803b9f73] suspend_device+0x113/0x180 [803ba330] device_suspend+0x200/0x320 [80266905] suspend_devices_and_enter+0xa5/0x170 [80266bd9] enter_state+0x209/0x270 [80266cef] state_store+0xaf/0xf0 [8032ca67] kobj_attr_store+0x17/0x20 [802e459e] sysfs_write_file+0xce/0x140 [80299cc7] vfs_write+0xc7/0x170 [8029a360] sys_write+0x50/0x90 [8020bcde] system_call+0x7e/0x83 # LANG=en ll /sys/devices/pnp0/00:06/ total 0 lrwxrwxrwx 1 root root0 Nov 22 22:35 driver - ../../../bus/pnp/drivers/serial -r--r--r-- 1 root root 4096 Nov 22 22:35 id -r--r--r-- 1 root root 4096 Nov 22 22:35 options drwxr-xr-x 2 root root0 Nov 22 22:35 power -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem - ../../../bus/pnp drwxr-xr-x 3 root root0 Nov 22 22:35 tty -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent I suppose that's a genuine leak, presumably in 8250_pnp. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
WARNING: at kernel/resource.c:189 __release_resource
Hi, Step aside. What's the purpose of having two similar patches for one issue, it then warns about the same thing twice: make-sure-nobodys-leaking-resources.patch releasing-resources-with-children.patch Ok, I hit the bug, suspend of 00:06 device complains about it: WARNING: at .../kernel/resource.c:185 __release_resource() Call Trace: [] release_resource+0xb5/0xf0 [] pnp_release_resources+0x70/0x130 [] pnp_stop_dev+0x45/0x90 [] pnp_bus_suspend+0x92/0xb0 [] suspend_device+0x113/0x180 [] device_suspend+0x200/0x320 [] suspend_devices_and_enter+0xa5/0x170 [] enter_state+0x209/0x270 [] state_store+0xaf/0xf0 [] kobj_attr_store+0x17/0x20 [] sysfs_write_file+0xce/0x140 [] vfs_write+0xc7/0x170 [] sys_write+0x50/0x90 [] system_call+0x7e/0x83 # LANG=en ll /sys/devices/pnp0/00:06/ total 0 lrwxrwxrwx 1 root root0 Nov 22 22:35 driver -> ../../../bus/pnp/drivers/serial -r--r--r-- 1 root root 4096 Nov 22 22:35 id -r--r--r-- 1 root root 4096 Nov 22 22:35 options drwxr-xr-x 2 root root0 Nov 22 22:35 power -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem -> ../../../bus/pnp drwxr-xr-x 3 root root0 Nov 22 22:35 tty -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent regards, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
WARNING: at kernel/resource.c:189 __release_resource
Hi, Step aside. What's the purpose of having two similar patches for one issue, it then warns about the same thing twice: make-sure-nobodys-leaking-resources.patch releasing-resources-with-children.patch Ok, I hit the bug, suspend of 00:06 device complains about it: WARNING: at .../kernel/resource.c:185 __release_resource() Call Trace: [8023f7b5] release_resource+0xb5/0xf0 [8036cda0] pnp_release_resources+0x70/0x130 [8036db85] pnp_stop_dev+0x45/0x90 [8036c942] pnp_bus_suspend+0x92/0xb0 [803b9f73] suspend_device+0x113/0x180 [803ba330] device_suspend+0x200/0x320 [80266905] suspend_devices_and_enter+0xa5/0x170 [80266bd9] enter_state+0x209/0x270 [80266cef] state_store+0xaf/0xf0 [8032ca67] kobj_attr_store+0x17/0x20 [802e459e] sysfs_write_file+0xce/0x140 [80299cc7] vfs_write+0xc7/0x170 [8029a360] sys_write+0x50/0x90 [8020bcde] system_call+0x7e/0x83 # LANG=en ll /sys/devices/pnp0/00:06/ total 0 lrwxrwxrwx 1 root root0 Nov 22 22:35 driver - ../../../bus/pnp/drivers/serial -r--r--r-- 1 root root 4096 Nov 22 22:35 id -r--r--r-- 1 root root 4096 Nov 22 22:35 options drwxr-xr-x 2 root root0 Nov 22 22:35 power -rw-r--r-- 1 root root 4096 Nov 22 22:35 resources lrwxrwxrwx 1 root root0 Nov 22 22:35 subsystem - ../../../bus/pnp drwxr-xr-x 3 root root0 Nov 22 22:35 tty -rw-r--r-- 1 root root 4096 Nov 22 22:35 uevent regards, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
