Re: crypto: rsa - select on undefined AKCIPHER
On Thu, Jun 18, 2015 at 07:55:05AM -0700, Tadeusz Struk wrote: > > Yes it should have been CRYPTO_AKCIPHER. > Thanks for reporting this. Please resend your patch with a cc to linux-crypto. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: crypto: rsa - select on undefined AKCIPHER
On Thu, Jun 18, 2015 at 07:55:05AM -0700, Tadeusz Struk wrote: Yes it should have been CRYPTO_AKCIPHER. Thanks for reporting this. Please resend your patch with a cc to linux-crypto. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: crypto: rsa - select on undefined AKCIPHER
On 06/18/2015 01:26 AM, Andreas Ruprecht wrote:
> Hi Tadeusz,
>
> your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
> implementation") was merged into linux-next today (i.e., next-20150618).
> It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
>
> +config CRYPTO_RSA
> + tristate "RSA algorithm"
> + select AKCIPHER
> [...]
>
> The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
> mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
> akcipher - add PKE API")?
>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
> automated, daily analysis of the most recent linux-next tree.
> There is also a tool in the Linux tree itself that can detect such
> issues (scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.
--- >8 ---
This patch fixes invalid config selection for AKCIPHER
Reported-by: Andreas Ruprecht
Signed-off-by: Tadeusz Struk
---
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 6c79ef0..b4cfc57 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER
config CRYPTO_RSA
tristate "RSA algorithm"
- select AKCIPHER
+ select CRYPTO_AKCIPHER
select MPILIB
select ASN1
help
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
crypto: rsa - select on undefined AKCIPHER
Hi Tadeusz,
your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic
implementation") was merged into linux-next today (i.e., next-20150618).
It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
+config CRYPTO_RSA
+ tristate "RSA algorithm"
+ select AKCIPHER
[...]
The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe
mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
akcipher - add PKE API")?
I detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (https://undertaker.cs.fau.de) as part of an
automated, daily analysis of the most recent linux-next tree.
There is also a tool in the Linux tree itself that can detect such
issues (scripts/checkkconfigsymbols.py).
Regards,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: crypto: rsa - select on undefined AKCIPHER
On 06/18/2015 01:26 AM, Andreas Ruprecht wrote: Hi Tadeusz, your commit cfc2bb32b313 (crypto: rsa - add a new rsa generic implementation) was merged into linux-next today (i.e., next-20150618). It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option: +config CRYPTO_RSA + tristate RSA algorithm + select AKCIPHER [...] The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 (crypto: akcipher - add PKE API)? I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de) as part of an automated, daily analysis of the most recent linux-next tree. There is also a tool in the Linux tree itself that can detect such issues (scripts/checkkconfigsymbols.py). Hi Andreas, Yes it should have been CRYPTO_AKCIPHER. Thanks for reporting this. --- 8 --- This patch fixes invalid config selection for AKCIPHER Reported-by: Andreas Ruprecht andreas.rupre...@fau.de Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- diff --git a/crypto/Kconfig b/crypto/Kconfig index 6c79ef0..b4cfc57 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER config CRYPTO_RSA tristate RSA algorithm - select AKCIPHER + select CRYPTO_AKCIPHER select MPILIB select ASN1 help -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
crypto: rsa - select on undefined AKCIPHER
Hi Tadeusz, your commit cfc2bb32b313 (crypto: rsa - add a new rsa generic implementation) was merged into linux-next today (i.e., next-20150618). It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option: +config CRYPTO_RSA + tristate RSA algorithm + select AKCIPHER [...] The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 (crypto: akcipher - add PKE API)? I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de) as part of an automated, daily analysis of the most recent linux-next tree. There is also a tool in the Linux tree itself that can detect such issues (scripts/checkkconfigsymbols.py). Regards, Andreas -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
