[PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping

[Ard Biesheuvel]

From: Pan Bian 

The remapping result of memremap should be freed with memunmap, not
kfree.

Signed-off-by: Pan Bian 
Cc: Matt Fleming 
Cc: 
Signed-off-by: Ard Biesheuvel 
---
 drivers/firmware/efi/esrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 7aae2483fcb9..c47e0c6ec00f 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -428,7 +428,7 @@ static int __init esrt_sysfs_init(void)
 err_remove_esrt:
kobject_put(esrt_kobj);
 err:
-   kfree(esrt);
+   memunmap(esrt);
esrt = NULL;
return error;
 }
-- 
2.11.0

[PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping

[Ard Biesheuvel]

From: Pan Bian 

The remapping result of memremap should be freed with memunmap, not
kfree.

Signed-off-by: Pan Bian 
Cc: Matt Fleming 
Cc: 
Signed-off-by: Ard Biesheuvel 
---
 drivers/firmware/efi/esrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 7aae2483fcb9..c47e0c6ec00f 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -428,7 +428,7 @@ static int __init esrt_sysfs_init(void)
 err_remove_esrt:
kobject_put(esrt_kobj);
 err:
-   kfree(esrt);
+   memunmap(esrt);
esrt = NULL;
return error;
 }
-- 
2.11.0

Re: efi/esrt: use memunmap rather kfree to free the remapping

[Ard Biesheuvel]

On 29 October 2017 at 14:51, Pan Bian  wrote:
> The remapping result of memremap should be freed with memunmap, not
> kfree.
>
> Signed-off-by: Pan Bian 
> ---
>  drivers/firmware/efi/esrt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index bd7ed3c..3ef7001 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
>  err_remove_esrt:
> kobject_put(esrt_kobj);
>  err:
> -   kfree(esrt);
> +   memunmap(esrt);
> esrt = NULL;
> return error;
>  }
> --
> 1.9.1
>

Queued in efi/urgent. Thanks.

Re: efi/esrt: use memunmap rather kfree to free the remapping

[Ard Biesheuvel]

On 29 October 2017 at 14:51, Pan Bian  wrote:
> The remapping result of memremap should be freed with memunmap, not
> kfree.
>
> Signed-off-by: Pan Bian 
> ---
>  drivers/firmware/efi/esrt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index bd7ed3c..3ef7001 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
>  err_remove_esrt:
> kobject_put(esrt_kobj);
>  err:
> -   kfree(esrt);
> +   memunmap(esrt);
> esrt = NULL;
> return error;
>  }
> --
> 1.9.1
>

Queued in efi/urgent. Thanks.

efi/esrt: use memunmap rather kfree to free the remapping

[Pan Bian]

The remapping result of memremap should be freed with memunmap, not
kfree.

Signed-off-by: Pan Bian 
---
 drivers/firmware/efi/esrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index bd7ed3c..3ef7001 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
 err_remove_esrt:
kobject_put(esrt_kobj);
 err:
-   kfree(esrt);
+   memunmap(esrt);
esrt = NULL;
return error;
 }
-- 
1.9.1

efi/esrt: use memunmap rather kfree to free the remapping

[Pan Bian]

The remapping result of memremap should be freed with memunmap, not
kfree.

Signed-off-by: Pan Bian 
---
 drivers/firmware/efi/esrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index bd7ed3c..3ef7001 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
 err_remove_esrt:
kobject_put(esrt_kobj);
 err:
-   kfree(esrt);
+   memunmap(esrt);
esrt = NULL;
return error;
 }
-- 
1.9.1