Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Antonino A. Daplas


> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
>> +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.

Agree with this too.

Tony



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Dave Jones
On Wed, Feb 28, 2007 at 10:13:24PM +0100, Michael Hanselmann wrote:
 > On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
 > > +#ifdef __powerpc__
 > 
 > Is __powerpc__ defined when cross compiling? I'd rather use
 > CONFIG_PMAC_BACKLIGHT instead of it.

Sounds ok to me.

Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Michael Hanselmann
On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> +#ifdef __powerpc__

Is __powerpc__ defined when cross compiling? I'd rather use
CONFIG_PMAC_BACKLIGHT instead of it.

Greets,
Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


fix implicit declaration in nv_backlight.

2007-02-28 Thread Dave Jones
drivers/video/nvidia/nv_backlight.c: In function 'nvidia_bl_init':
drivers/video/nvidia/nv_backlight.c:103: error: implicit declaration of 
function 'pmac_has_backlight_type'

Signed-off-by: Dave Jones <[EMAIL PROTECTED]>

--- linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c~2007-02-20 
22:25:15.0 -0500
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c 2007-02-20 
22:25:31.0 -0500
@@ -12,6 +12,9 @@
 #include 
 #include 
 #include 
+#ifdef __powerpc__
+#include 
+#endif
 #include "nv_local.h"
 #include "nv_type.h"
 #include "nv_proto.h"

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


fix implicit declaration in nv_backlight.

2007-02-28 Thread Dave Jones
drivers/video/nvidia/nv_backlight.c: In function 'nvidia_bl_init':
drivers/video/nvidia/nv_backlight.c:103: error: implicit declaration of 
function 'pmac_has_backlight_type'

Signed-off-by: Dave Jones [EMAIL PROTECTED]

--- linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c~2007-02-20 
22:25:15.0 -0500
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c 2007-02-20 
22:25:31.0 -0500
@@ -12,6 +12,9 @@
 #include linux/backlight.h
 #include linux/fb.h
 #include linux/pci.h
+#ifdef __powerpc__
+#include asm/backlight.h
+#endif
 #include nv_local.h
 #include nv_type.h
 #include nv_proto.h

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Michael Hanselmann
On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
 +#ifdef __powerpc__

Is __powerpc__ defined when cross compiling? I'd rather use
CONFIG_PMAC_BACKLIGHT instead of it.

Greets,
Michael
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Dave Jones
On Wed, Feb 28, 2007 at 10:13:24PM +0100, Michael Hanselmann wrote:
  On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
   +#ifdef __powerpc__
  
  Is __powerpc__ defined when cross compiling? I'd rather use
  CONFIG_PMAC_BACKLIGHT instead of it.

Sounds ok to me.

Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: fix implicit declaration in nv_backlight.

2007-02-28 Thread Antonino A. Daplas


 On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
 +#ifdef __powerpc__

 Is __powerpc__ defined when cross compiling? I'd rather use
 CONFIG_PMAC_BACKLIGHT instead of it.

Agree with this too.

Tony



-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/