Re: irqdesc porting help

2007-02-20 Thread Thomas Gleixner
On Tue, 2007-02-20 at 12:33 +0530, Maximus wrote:
> Hi,
>   Sorry for the late response, attached is the code im trying to port
> to linux - 2.6.20.

Why does this need to use a kernel thread in the first place ? Usually
chained handlers demultiplex the primary interrupt and invoke the
demultiplexed interrupts.

There are tons of working examples in arch/arm/mach-

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-20 Thread Komal Shah

On 2/20/07, Komal Shah <[EMAIL PROTECTED]> wrote:

Maximus,

On 2/20/07, Maximus <[EMAIL PROTECTED]> wrote:
> Hi,
>   Sorry for the late response, attached is the code im trying to port
> to linux - 2.6.20.
>
>

Have you checked http://source.mvista.com/git linux-omap-2.6 git tree.
Syed Khasim has already submitted this OMAP2430 TWL4030 chip core
driver there, which is already synced with 2.6.20.



I just checked that code, and there is a line like:

393 /*
394 * Earlier this was desc->triggered = 1;
395 */
396 desc->status = IRQ_INPROGRESS;

So, I hope this helps, but still need to check its correctness.

--
---Komal Shah
http://komalshah.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-20 Thread Komal Shah

Maximus,

On 2/20/07, Maximus <[EMAIL PROTECTED]> wrote:

Hi,
  Sorry for the late response, attached is the code im trying to port
to linux - 2.6.20.




Have you checked http://source.mvista.com/git linux-omap-2.6 git tree.
Syed Khasim has already submitted this OMAP2430 TWL4030 chip core
driver there, which is already synced with 2.6.20.

--
---Komal Shah
http://komalshah.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-20 Thread Komal Shah

Maximus,

On 2/20/07, Maximus [EMAIL PROTECTED] wrote:

Hi,
  Sorry for the late response, attached is the code im trying to port
to linux - 2.6.20.




Have you checked http://source.mvista.com/git linux-omap-2.6 git tree.
Syed Khasim has already submitted this OMAP2430 TWL4030 chip core
driver there, which is already synced with 2.6.20.

--
---Komal Shah
http://komalshah.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-20 Thread Komal Shah

On 2/20/07, Komal Shah [EMAIL PROTECTED] wrote:

Maximus,

On 2/20/07, Maximus [EMAIL PROTECTED] wrote:
 Hi,
   Sorry for the late response, attached is the code im trying to port
 to linux - 2.6.20.



Have you checked http://source.mvista.com/git linux-omap-2.6 git tree.
Syed Khasim has already submitted this OMAP2430 TWL4030 chip core
driver there, which is already synced with 2.6.20.



I just checked that code, and there is a line like:

393 /*
394 * Earlier this was desc-triggered = 1;
395 */
396 desc-status = IRQ_INPROGRESS;

So, I hope this helps, but still need to check its correctness.

--
---Komal Shah
http://komalshah.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-20 Thread Thomas Gleixner
On Tue, 2007-02-20 at 12:33 +0530, Maximus wrote:
 Hi,
   Sorry for the late response, attached is the code im trying to port
 to linux - 2.6.20.

Why does this need to use a kernel thread in the first place ? Usually
chained handlers demultiplex the primary interrupt and invoke the
demultiplexed interrupts.

There are tons of working examples in arch/arm/mach-

tglx


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-19 Thread Maximus

Hi,
 Sorry for the late response, attached is the code im trying to port
to linux - 2.6.20.


Regards,
Jo




On 2/15/07, Paul Mundt <[EMAIL PROTECTED]> wrote:

On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
> Im trying to port some drivers between 2.6.14 and 2.6.19
>
> I find that irqdesc has changed completely. how do i port
> the drivers between 2.6.14 and 2.6.19?
>
> is there a porting guide available to port the drivers
> which use irqdesc?.
>
> my drivers use variables triggered, ... which dont exist in 2.6.19
> irqdesc strcuture.
>
Presumably you're talking about the struct hw_interrupt_type and the lack
of an irq_desc[irq].handler? There's some migration helper glue in
include/linux/irq.h that you can use, but you're better off converting
completely. You can at least get it building again by changing to
irq_desc[irq].chip, but you really want a proper irq_chip implementation
to go along with this, rather than munging in the hw_interrupt_type.

You can easily compare before-and-after versions of most of the IRQ
controllers to identify the minimal changes required.

/*
 * linux/drivers/i2c/chips/twl4030_core.c
 *
 * Copyright (C) 2005-2006 Texas Instruments, Inc.
 *
 * Modifications to defer interrupt handling to a kernel thread:
 * Copyright (C) 2006 MontaVista Software, Inc.
 *
 * Based on tlv320aic23.c:
 * Copyright (c) by Kai Svahn <[EMAIL PROTECTED]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 *
 */

/*** Includes */
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 

#include 
#include 

#include 
#include 
#include 
#include 
#include 
#include 
//#include 
#include 
#include 

#include 
#include 

#define CONFIG_TWL4030_IRQ_PRIO 26

/ Macro Definitions */
#define TWL_CLIENT_STRING"TWL4030-ID"
#define TWL_CLIENT_USED  1
#define TWL_CLIENT_FREE  0

/* IRQ Flags */
#define FREE 0
#define USED 1

/** Primary Interrupt Handler on TWL4030 Registers */

/ Register Definitions */

#define REG_PIH_ISR_P1   (0x1)
#define REG_PIH_ISR_P2   (0x2)
#define REG_PIH_SIR  (0x3)

/ BitField Definitions */

/* PIH_ISR_P1 Fields */
#define BIT_PIH_ISR_P1_PIH_ISR0  (0x000)
#define BIT_PIH_ISR_P1_PIH_ISR0_M(0x0001)
#define BIT_PIH_ISR_P1_PIH_ISR1  (0x001)
#define BIT_PIH_ISR_P1_PIH_ISR1_M(0x0002)
#define BIT_PIH_ISR_P1_PIH_ISR2  (0x002)
#define BIT_PIH_ISR_P1_PIH_ISR2_M(0x0004)
#define BIT_PIH_ISR_P1_PIH_ISR3  (0x003)
#define BIT_PIH_ISR_P1_PIH_ISR3_M(0x0008)
#define BIT_PIH_ISR_P1_PIH_ISR4  (0x004)
#define BIT_PIH_ISR_P1_PIH_ISR4_M(0x0010)
#define BIT_PIH_ISR_P1_PIH_ISR5  (0x005)
#define BIT_PIH_ISR_P1_PIH_ISR5_M(0x0020)
#define BIT_PIH_ISR_P1_PIH_ISR6  (0x006)
#define BIT_PIH_ISR_P1_PIH_ISR6_M(0x0040)
#define BIT_PIH_ISR_P1_PIH_ISR7  (0x007)
#define BIT_PIH_ISR_P1_PIH_ISR7_M(0x0080)
/* PIH_ISR_P2 Fields */
#define BIT_PIH_ISR_P2_PIH_ISR0  (0x000)
#define BIT_PIH_ISR_P2_PIH_ISR0_M(0x0001)
#define BIT_PIH_ISR_P2_PIH_ISR1  (0x001)
#define BIT_PIH_ISR_P2_PIH_ISR1_M(0x0002)
#define BIT_PIH_ISR_P2_PIH_ISR2  (0x002)
#define BIT_PIH_ISR_P2_PIH_ISR2_M(0x0004)
#define BIT_PIH_ISR_P2_PIH_ISR3  (0x003)
#define BIT_PIH_ISR_P2_PIH_ISR3_M(0x0008)
#define BIT_PIH_ISR_P2_PIH_ISR4  (0x004)
#define BIT_PIH_ISR_P2_PIH_ISR4_M(0x0010)
#define BIT_PIH_ISR_P2_PIH_ISR5  (0x005)
#define BIT_PIH_ISR_P2_PIH_ISR5_M(0x0020)
#define BIT_PIH_ISR_P2_PIH_ISR6  (0x006)
#define BIT_PIH_ISR_P2_PIH_ISR6_M(0x0040)
#define BIT_PIH_ISR_P2_PIH_ISR7  (0x007)
#define BIT_PIH_ISR_P2_PIH_ISR7_M(0x0080)
/* PIH_SIR Fields */
#define BIT_PIH_SIR_PIH1SIR

Re: irqdesc porting help

2007-02-19 Thread Maximus

Hi,
 Sorry for the late response, attached is the code im trying to port
to linux - 2.6.20.


Regards,
Jo




On 2/15/07, Paul Mundt [EMAIL PROTECTED] wrote:

On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
 Im trying to port some drivers between 2.6.14 and 2.6.19

 I find that irqdesc has changed completely. how do i port
 the drivers between 2.6.14 and 2.6.19?

 is there a porting guide available to port the drivers
 which use irqdesc?.

 my drivers use variables triggered, ... which dont exist in 2.6.19
 irqdesc strcuture.

Presumably you're talking about the struct hw_interrupt_type and the lack
of an irq_desc[irq].handler? There's some migration helper glue in
include/linux/irq.h that you can use, but you're better off converting
completely. You can at least get it building again by changing to
irq_desc[irq].chip, but you really want a proper irq_chip implementation
to go along with this, rather than munging in the hw_interrupt_type.

You can easily compare before-and-after versions of most of the IRQ
controllers to identify the minimal changes required.

/*
 * linux/drivers/i2c/chips/twl4030_core.c
 *
 * Copyright (C) 2005-2006 Texas Instruments, Inc.
 *
 * Modifications to defer interrupt handling to a kernel thread:
 * Copyright (C) 2006 MontaVista Software, Inc.
 *
 * Based on tlv320aic23.c:
 * Copyright (c) by Kai Svahn [EMAIL PROTECTED]
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 *
 */

/*** Includes */
#include linux/config.h
#include linux/module.h
#include linux/kernel_stat.h
#include linux/init.h
#include linux/time.h
#include linux/interrupt.h
#include linux/random.h
#include linux/syscalls.h
#include linux/kthread.h

#include linux/i2c.h
#include linux/slab.h

#include asm/arch/twl4030.h
#include asm/arch/irqs.h
#include asm/irq.h
#include asm/arch/irq.h
#include asm/mach/irq.h
#include asm/arch/gpio.h
//#include asm/arch/platform.h
#include asm/arch/mux.h
#include asm/arch/power_companion.h

#include linux/device.h
#include asm/arch/bus.h

#define CONFIG_TWL4030_IRQ_PRIO 26

/ Macro Definitions */
#define TWL_CLIENT_STRINGTWL4030-ID
#define TWL_CLIENT_USED  1
#define TWL_CLIENT_FREE  0

/* IRQ Flags */
#define FREE 0
#define USED 1

/** Primary Interrupt Handler on TWL4030 Registers */

/ Register Definitions */

#define REG_PIH_ISR_P1   (0x1)
#define REG_PIH_ISR_P2   (0x2)
#define REG_PIH_SIR  (0x3)

/ BitField Definitions */

/* PIH_ISR_P1 Fields */
#define BIT_PIH_ISR_P1_PIH_ISR0  (0x000)
#define BIT_PIH_ISR_P1_PIH_ISR0_M(0x0001)
#define BIT_PIH_ISR_P1_PIH_ISR1  (0x001)
#define BIT_PIH_ISR_P1_PIH_ISR1_M(0x0002)
#define BIT_PIH_ISR_P1_PIH_ISR2  (0x002)
#define BIT_PIH_ISR_P1_PIH_ISR2_M(0x0004)
#define BIT_PIH_ISR_P1_PIH_ISR3  (0x003)
#define BIT_PIH_ISR_P1_PIH_ISR3_M(0x0008)
#define BIT_PIH_ISR_P1_PIH_ISR4  (0x004)
#define BIT_PIH_ISR_P1_PIH_ISR4_M(0x0010)
#define BIT_PIH_ISR_P1_PIH_ISR5  (0x005)
#define BIT_PIH_ISR_P1_PIH_ISR5_M(0x0020)
#define BIT_PIH_ISR_P1_PIH_ISR6  (0x006)
#define BIT_PIH_ISR_P1_PIH_ISR6_M(0x0040)
#define BIT_PIH_ISR_P1_PIH_ISR7  (0x007)
#define BIT_PIH_ISR_P1_PIH_ISR7_M(0x0080)
/* PIH_ISR_P2 Fields */
#define BIT_PIH_ISR_P2_PIH_ISR0  (0x000)
#define BIT_PIH_ISR_P2_PIH_ISR0_M(0x0001)
#define BIT_PIH_ISR_P2_PIH_ISR1  (0x001)
#define BIT_PIH_ISR_P2_PIH_ISR1_M(0x0002)
#define BIT_PIH_ISR_P2_PIH_ISR2  (0x002)
#define BIT_PIH_ISR_P2_PIH_ISR2_M(0x0004)
#define BIT_PIH_ISR_P2_PIH_ISR3  (0x003)
#define BIT_PIH_ISR_P2_PIH_ISR3_M(0x0008)
#define BIT_PIH_ISR_P2_PIH_ISR4  (0x004)
#define BIT_PIH_ISR_P2_PIH_ISR4_M(0x0010)
#define BIT_PIH_ISR_P2_PIH_ISR5  (0x005)
#define BIT_PIH_ISR_P2_PIH_ISR5_M

Re: irqdesc porting help

2007-02-15 Thread Arjan van de Ven
On Thu, 2007-02-15 at 18:41 +0530, Maximus wrote:
> Hi,
>My drivers in 2.6.14 use statements like
>  desc->triggered = 1;
>And desc also points to some members of irqdesc which arent in
> 2.6.19 but in 2.6.14.
> 
>Im a newbie, What changes am i supposed to make to make it work in 2.6.19.
>Im not sure what changes are exactly needed.
> 


can you just post your driver so that the people here see what you are
actually doing ?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Russell King
On Thu, Feb 15, 2007 at 06:41:25PM +0530, Maximus wrote:
> Hi,
>   My drivers in 2.6.14 use statements like
> desc->triggered = 1;
>   And desc also points to some members of irqdesc which arent in
> 2.6.19 but in 2.6.14.

But why do you have code which accesses these members?  Can you show
your code?

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Maximus

Hi,
  My drivers in 2.6.14 use statements like
desc->triggered = 1;
  And desc also points to some members of irqdesc which arent in
2.6.19 but in 2.6.14.

  Im a newbie, What changes am i supposed to make to make it work in 2.6.19.
  Im not sure what changes are exactly needed.


 Please Advice,

 Regards,
  Jo



On 2/15/07, Russell King <[EMAIL PROTECTED]> wrote:

On Thu, Feb 15, 2007 at 07:33:47PM +0900, Paul Mundt wrote:
> On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
> > Im trying to port some drivers between 2.6.14 and 2.6.19
> >
> > I find that irqdesc has changed completely. how do i port
> > the drivers between 2.6.14 and 2.6.19?
> >
> > is there a porting guide available to port the drivers
> > which use irqdesc?.
> >
> > my drivers use variables triggered, ... which dont exist in 2.6.19
> > irqdesc strcuture.
> >
> Presumably you're talking about the struct hw_interrupt_type and the lack
> of an irq_desc[irq].handler? There's some migration helper glue in
> include/linux/irq.h that you can use, but you're better off converting
> completely. You can at least get it building again by changing to
> irq_desc[irq].chip, but you really want a proper irq_chip implementation
> to go along with this, rather than munging in the hw_interrupt_type.

It should be asked - why are drivers poking about in the irqdesc
structure?

--
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Russell King
On Thu, Feb 15, 2007 at 07:33:47PM +0900, Paul Mundt wrote:
> On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
> > Im trying to port some drivers between 2.6.14 and 2.6.19
> > 
> > I find that irqdesc has changed completely. how do i port
> > the drivers between 2.6.14 and 2.6.19?
> > 
> > is there a porting guide available to port the drivers
> > which use irqdesc?.
> > 
> > my drivers use variables triggered, ... which dont exist in 2.6.19
> > irqdesc strcuture.
> > 
> Presumably you're talking about the struct hw_interrupt_type and the lack
> of an irq_desc[irq].handler? There's some migration helper glue in
> include/linux/irq.h that you can use, but you're better off converting
> completely. You can at least get it building again by changing to
> irq_desc[irq].chip, but you really want a proper irq_chip implementation
> to go along with this, rather than munging in the hw_interrupt_type.

It should be asked - why are drivers poking about in the irqdesc
structure?

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Paul Mundt
On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
> Im trying to port some drivers between 2.6.14 and 2.6.19
> 
> I find that irqdesc has changed completely. how do i port
> the drivers between 2.6.14 and 2.6.19?
> 
> is there a porting guide available to port the drivers
> which use irqdesc?.
> 
> my drivers use variables triggered, ... which dont exist in 2.6.19
> irqdesc strcuture.
> 
Presumably you're talking about the struct hw_interrupt_type and the lack
of an irq_desc[irq].handler? There's some migration helper glue in
include/linux/irq.h that you can use, but you're better off converting
completely. You can at least get it building again by changing to
irq_desc[irq].chip, but you really want a proper irq_chip implementation
to go along with this, rather than munging in the hw_interrupt_type.

You can easily compare before-and-after versions of most of the IRQ
controllers to identify the minimal changes required.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Paul Mundt
On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
 Im trying to port some drivers between 2.6.14 and 2.6.19
 
 I find that irqdesc has changed completely. how do i port
 the drivers between 2.6.14 and 2.6.19?
 
 is there a porting guide available to port the drivers
 which use irqdesc?.
 
 my drivers use variables triggered, ... which dont exist in 2.6.19
 irqdesc strcuture.
 
Presumably you're talking about the struct hw_interrupt_type and the lack
of an irq_desc[irq].handler? There's some migration helper glue in
include/linux/irq.h that you can use, but you're better off converting
completely. You can at least get it building again by changing to
irq_desc[irq].chip, but you really want a proper irq_chip implementation
to go along with this, rather than munging in the hw_interrupt_type.

You can easily compare before-and-after versions of most of the IRQ
controllers to identify the minimal changes required.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Russell King
On Thu, Feb 15, 2007 at 07:33:47PM +0900, Paul Mundt wrote:
 On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
  Im trying to port some drivers between 2.6.14 and 2.6.19
  
  I find that irqdesc has changed completely. how do i port
  the drivers between 2.6.14 and 2.6.19?
  
  is there a porting guide available to port the drivers
  which use irqdesc?.
  
  my drivers use variables triggered, ... which dont exist in 2.6.19
  irqdesc strcuture.
  
 Presumably you're talking about the struct hw_interrupt_type and the lack
 of an irq_desc[irq].handler? There's some migration helper glue in
 include/linux/irq.h that you can use, but you're better off converting
 completely. You can at least get it building again by changing to
 irq_desc[irq].chip, but you really want a proper irq_chip implementation
 to go along with this, rather than munging in the hw_interrupt_type.

It should be asked - why are drivers poking about in the irqdesc
structure?

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Maximus

Hi,
  My drivers in 2.6.14 use statements like
desc-triggered = 1;
  And desc also points to some members of irqdesc which arent in
2.6.19 but in 2.6.14.

  Im a newbie, What changes am i supposed to make to make it work in 2.6.19.
  Im not sure what changes are exactly needed.


 Please Advice,

 Regards,
  Jo



On 2/15/07, Russell King [EMAIL PROTECTED] wrote:

On Thu, Feb 15, 2007 at 07:33:47PM +0900, Paul Mundt wrote:
 On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote:
  Im trying to port some drivers between 2.6.14 and 2.6.19
 
  I find that irqdesc has changed completely. how do i port
  the drivers between 2.6.14 and 2.6.19?
 
  is there a porting guide available to port the drivers
  which use irqdesc?.
 
  my drivers use variables triggered, ... which dont exist in 2.6.19
  irqdesc strcuture.
 
 Presumably you're talking about the struct hw_interrupt_type and the lack
 of an irq_desc[irq].handler? There's some migration helper glue in
 include/linux/irq.h that you can use, but you're better off converting
 completely. You can at least get it building again by changing to
 irq_desc[irq].chip, but you really want a proper irq_chip implementation
 to go along with this, rather than munging in the hw_interrupt_type.

It should be asked - why are drivers poking about in the irqdesc
structure?

--
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Russell King
On Thu, Feb 15, 2007 at 06:41:25PM +0530, Maximus wrote:
 Hi,
   My drivers in 2.6.14 use statements like
 desc-triggered = 1;
   And desc also points to some members of irqdesc which arent in
 2.6.19 but in 2.6.14.

But why do you have code which accesses these members?  Can you show
your code?

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: irqdesc porting help

2007-02-15 Thread Arjan van de Ven
On Thu, 2007-02-15 at 18:41 +0530, Maximus wrote:
 Hi,
My drivers in 2.6.14 use statements like
  desc-triggered = 1;
And desc also points to some members of irqdesc which arent in
 2.6.19 but in 2.6.14.
 
Im a newbie, What changes am i supposed to make to make it work in 2.6.19.
Im not sure what changes are exactly needed.
 


can you just post your driver so that the people here see what you are
actually doing ?


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


irqdesc porting help

2007-02-14 Thread Maximus

Im trying to port some drivers between 2.6.14 and 2.6.19

I find that irqdesc has changed completely. how do i port
the drivers between 2.6.14 and 2.6.19?

is there a porting guide available to port the drivers
which use irqdesc?.

my drivers use variables triggered, ... which dont exist in 2.6.19
irqdesc strcuture.


Could anyone help me on this.

Regards,
Jo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


irqdesc porting help

2007-02-14 Thread Maximus

Im trying to port some drivers between 2.6.14 and 2.6.19

I find that irqdesc has changed completely. how do i port
the drivers between 2.6.14 and 2.6.19?

is there a porting guide available to port the drivers
which use irqdesc?.

my drivers use variables triggered, ... which dont exist in 2.6.19
irqdesc strcuture.


Could anyone help me on this.

Regards,
Jo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/