Re: libata: sysctl knob for enabling tpm/opal at runtime
On 05.06.19 21:23, Christoph Hellwig wrote: > On Wed, Jun 05, 2019 at 01:36:25PM +0200, Enrico Weigelt, metux IT consult > wrote: >> Hello folks, >> >> >> here's a patchset that allows enabling libata's tpm features (opal) >> at runtime. Until now we need to boot with special kernel parameter, >> in order to use OPAL - this patch also adds a sysctl knob for that. > > Or you can use the block/sed-opal.c code which doesn't require the > tweak, and really is the proper way forward to use OPAL. You're referring to the OPAL ioctl()s ? hmm, it seems that sed-util doesn't use them at all, but directly sends raw ata commands. Shall I use a different userland tool ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287
Re: libata: sysctl knob for enabling tpm/opal at runtime
On Wed, Jun 05, 2019 at 01:36:25PM +0200, Enrico Weigelt, metux IT consult wrote: > Hello folks, > > > here's a patchset that allows enabling libata's tpm features (opal) > at runtime. Until now we need to boot with special kernel parameter, > in order to use OPAL - this patch also adds a sysctl knob for that. Or you can use the block/sed-opal.c code which doesn't require the tweak, and really is the proper way forward to use OPAL. > The first patch just introduces a systcl subdir for libata, the > second one adds the actual knob. I had already sent these patches, > few weeks ago, along with some general build fixes. The latter > meanwhile went mainline, but haven't received any comments on > the two opal related ones yet. Independent of that new sysctls are deprecated.
libata: sysctl knob for enabling tpm/opal at runtime
Hello folks, here's a patchset that allows enabling libata's tpm features (opal) at runtime. Until now we need to boot with special kernel parameter, in order to use OPAL - this patch also adds a sysctl knob for that. It seems such a knob already had existed once (perhaps just in an wip patchset), as sed-util expects it. The first patch just introduces a systcl subdir for libata, the second one adds the actual knob. I had already sent these patches, few weeks ago, along with some general build fixes. The latter meanwhile went mainline, but haven't received any comments on the two opal related ones yet. Please let me know, whether there's anything wrong w/ it. have fun, --mtx
