linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP
frame")
Fixes tag
Fixes: 6788fa154546 ("veth: allow enabling NAPI even without XDP")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: d3256efd8e8b ("veth: allow enabling NAPI even without XDP")
--
Cheers,
Stephen Rothwell
pgpEC523gR0tU.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
d24f511b04b8 ("tcp: fix tcp_min_tso_segs sysctl")
Fixes tag
Fixes: 47996b489bdc ("tcp: convert elligible sysctls to u8")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 4ecc1baf362c ("tcp: convert elligible sysctls to u8")
--
Cheers,
Stephen Rothwell
pgpw38uCFAjHa.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
63c173ff7aa3 ("net: stmmac: Fix kernel panic due to NULL pointer dereference
of fpe_cfg")
Fixes tag
Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
pgp3LAExO6tiy.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
9f19306d1666 ("net: stmmac: use netif_tx_start|stop_all_queues() function")
Fixes tag
Fixes: c22a3f48 net: stmmac: adding multiple napi mechanism
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Also, please keep the commit message tags all together at the end of
the commit message and just use
git log -1 --format='Fixes: %h ("%s")'
to generate Fixes tag lines.
Since Dave does not rebase his tree, this is just for future reference.
--
Cheers,
Stephen Rothwell
pgpGFpM496eTk.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
On 6/2/2020 3:48 PM, Stephen Rothwell wrote:
Hi Ayush,
On Tue, 2 Jun 2020 13:01:09 +0530 Ayush Sawal wrote:
On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
In commit
055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
Fixes tag
Fixes: 567be3a5d227 ("crypto:
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
I am so sorry for this mistake.
Is there a way to fix this?
No, David does not rebase his tree. Just remember for next time.
Okay , i will keep this in mind. Thanks.
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi Ayush,
On Tue, 2 Jun 2020 13:01:09 +0530 Ayush Sawal wrote:
>
> On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
> >
> > In commit
> >
> >055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
> >
> > Fixes tag
> >
> >Fixes: 567be3a5d227 ("crypto:
> >
> > has these problem(s):
> >
> >- Subject has leading but no trailing parentheses
> >- Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
>
> I am so sorry for this mistake.
> Is there a way to fix this?
No, David does not rebase his tree. Just remember for next time.
--
Cheers,
Stephen Rothwell
pgpyIEETGPc4l.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi Stephen & David,
On 6/2/2020 4:42 AM, Stephen Rothwell wrote:
Hi all,
In commit
055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
Fixes tag
Fixes: 567be3a5d227 ("crypto:
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
I am so sorry for this mistake.
Is there a way to fix this?
Thanks,
Ayush
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
055be6865dea ("Crypto/chcr: Fixes a coccinile check error")
Fixes tag
Fixes: 567be3a5d227 ("crypto:
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
pgpR9BSCobfhg.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")
Fixes tag
Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")
has these problem(s):
- missing space between the SHA1 and the subject
Presumably:
Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")
--
Cheers,
Stephen Rothwell
pgpOWRUgdBiLb.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
7c5b42055964 ("tipc: reduce risk of wakeup queue starvation")
Fixes tag
Fixes: 365ad35 ("tipc: reduce risk of user starvation during link congestion")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpOiY3OVBak0.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
473d924d7d46 ("can: fix ioctl function removal")
Fixes tag
Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpsakMvhIvw9.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi Maciej, On Tue, 23 Jul 2019 09:46:29 +0900 Maciej Żenczykowski wrote: > > I'm afraid I'm currently travelling and due to an unplanned and f'ed up > office move I've lost (access to?) my dev workstation so I can't respin > this. Might be too late either way? Yeah, Dave doesn't rebase his trees, so just take this as a lesson for next time. :-) -- Cheers, Stephen Rothwell pgpvrIVOXXYTz.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
66b5f1c43984 ("net-ipv6-ndisc: add support for RFC7710 RA Captive Portal
Identifier")
Fixes tag
Fixes: e35f30c131a56
has these problem(s):
- missing subject
Did you mean
Fixes: e35f30c131a5 ("Treat ND option 31 as userland (DNSSL support)")
--
Cheers,
Stephen Rothwell
pgp1tE33pNpdU.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
d62962b37ceb ("loopback: fix lockdep splat")
Fixes tag
Fixes: 4de83b88c66 ("loopback: create blackhole net device similar to
loopack.")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpLmP4XFbXPS.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
18d219b783da ("net: hns3: fix a -Wformat-nonliteral compile warning")
Fixes tag
Fixes: 46a3df9f9718 ("Add HNS3 Acceleration Engine & Compatibility Layer
Support")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
pgphy8eeNaqPy.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commits
08e046c8966a ("tipc: fix a null pointer deref")
77d5ad4048fb ("tipc: fix use-after-free in tipc_sk_filter_rcv")
Fixes tag
Fixes: c55c8eda ("tipc: smooth change between replicast and broadcast")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpaniYRbpdEJ.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
On 2019/2/27 10:23, Stephen Rothwell wrote: Hi, On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong wrote: It is my mistake, so sorry about this. There is a redundant "net: hns3: " in the fixes tag. How could I fix it? Since Dave doesn't rebase his tree, there is no way to fix it (and it is not that important any in this case), just use this as a learning experience for next time :-) Thanks :)
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi, On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong wrote: > > It is my mistake, so sorry about this. There is a redundant "net: hns3: > " in the fixes tag. > > How could I fix it? Since Dave doesn't rebase his tree, there is no way to fix it (and it is not that important any in this case), just use this as a learning experience for next time :-) -- Cheers, Stephen Rothwell pgpuSa9mEurYl.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi Stephen & David,
It is my mistake, so sorry about this. There is a redundant "net: hns3:
" in the fixes tag.
How could I fix it?
Thanks.
On 2019/2/25 16:00, Stephen Rothwell wrote:
Hi all,
In commit
a638b1d8cc87 ("net: hns3: fix get VF RSS issue")
Fixes tag
Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration support
for VF")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h (%s)'
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
a638b1d8cc87 ("net: hns3: fix get VF RSS issue")
Fixes tag
Fixes: 374ad291762a ("net: hns3: net: hns3: Add RSS general configuration
support for VF")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h (%s)'
--
Cheers,
Stephen Rothwell
pgpDjhMWXFVX6.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
On 20-02-19, 20:59, Stefano Brivio wrote:
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller wrote:
>
> > From: Jiri Pirko
> > Date: Wed, 20 Feb 2019 09:36:11 +0100
> >
> > > Would be good to have some robot checking "Fixes" sanity...
> >
> > I want to add a script to my trees that locally do it for me but the
> > backlog for patch review for me is so huge that I never get to "fun"
> > tasks like that
>
> If it helps, this is what I use after being bitten once:
>
> #!/bin/sh
>
> [ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
> grep "^Fixes: " "${1}" | while read -r f; do
> sha="$(echo "${f}" | cut -d' ' -f2)"
> if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12
> --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
> echo "Bad tag: ${f}" && exit 1
> fi
> done
Awesome thanks, I am adding this into my patch commit script and well as
send script
--
~Vinod
Re: linux-next: Fixes tag needs some work in the net-next tree
From: Stefano Brivio Date: Wed, 20 Feb 2019 21:37:29 +0100 > On Wed, 20 Feb 2019 12:25:48 -0800 (PST) > David Miller wrote: > >> From: Stefano Brivio >> Date: Wed, 20 Feb 2019 20:59:10 +0100 >> >> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST) >> > David Miller wrote: >> > >> >> From: Jiri Pirko >> >> Date: Wed, 20 Feb 2019 09:36:11 +0100 >> >> >> >> > Would be good to have some robot checking "Fixes" sanity... >> >> >> >> I want to add a script to my trees that locally do it for me but the >> >> backlog for patch review for me is so huge that I never get to "fun" >> >> tasks like that >> > >> > If it helps, this is what I use after being bitten once: >> >> Awesome, thanks! You put this in as a pre-commit script? > > Nope, I use it before sending patches out with git send-email. > > But you can use this as .git/hooks/commit-msg, just skip taking the > tree as second argument, something like this (just quickly tested): Awesome, thank you!
Re: linux-next: Fixes tag needs some work in the net-next tree
On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller wrote:
> From: Stefano Brivio
> Date: Wed, 20 Feb 2019 20:59:10 +0100
>
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller wrote:
> >
> >> From: Jiri Pirko
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>
> >> > Would be good to have some robot checking "Fixes" sanity...
> >>
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that
> >
> > If it helps, this is what I use after being bitten once:
>
> Awesome, thanks! You put this in as a pre-commit script?
Nope, I use it before sending patches out with git send-email.
But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):
#!/bin/sh
grep "^Fixes: " "${1}" | while read -r f; do
sha="$(echo "${f}" | cut -d' ' -f2)"
if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12
--pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
echo "Bad tag: ${f}" && exit 1
fi
done
--
Stefano
Re: linux-next: Fixes tag needs some work in the net-next tree
Wed, Feb 20, 2019 at 09:25:22PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 20 Feb 2019 20:58:11 +0100 > >> Wed, Feb 20, 2019 at 08:02:01PM CET, da...@davemloft.net wrote: >>>From: Jiri Pirko >>>Date: Wed, 20 Feb 2019 09:36:11 +0100 >>> Would be good to have some robot checking "Fixes" sanity... >>> >>>I want to add a script to my trees that locally do it for me but the >> >> When it is in tree, it's already late. The robot has to check >> emails/patchwork. > >It's for me, on my computer, to abort things when I try to commit >with a bad fixes tag or missing signoff. Okay, but still, robot checking emails/patchwork would safe you some overhead.
Re: linux-next: Fixes tag needs some work in the net-next tree
From: Stefano Brivio Date: Wed, 20 Feb 2019 20:59:10 +0100 > On Wed, 20 Feb 2019 11:02:01 -0800 (PST) > David Miller wrote: > >> From: Jiri Pirko >> Date: Wed, 20 Feb 2019 09:36:11 +0100 >> >> > Would be good to have some robot checking "Fixes" sanity... >> >> I want to add a script to my trees that locally do it for me but the >> backlog for patch review for me is so huge that I never get to "fun" >> tasks like that > > If it helps, this is what I use after being bitten once: Awesome, thanks! You put this in as a pre-commit script?
Re: linux-next: Fixes tag needs some work in the net-next tree
From: Jiri Pirko Date: Wed, 20 Feb 2019 20:58:11 +0100 > Wed, Feb 20, 2019 at 08:02:01PM CET, da...@davemloft.net wrote: >>From: Jiri Pirko >>Date: Wed, 20 Feb 2019 09:36:11 +0100 >> >>> Would be good to have some robot checking "Fixes" sanity... >> >>I want to add a script to my trees that locally do it for me but the > > When it is in tree, it's already late. The robot has to check > emails/patchwork. It's for me, on my computer, to abort things when I try to commit with a bad fixes tag or missing signoff.
Re: linux-next: Fixes tag needs some work in the net-next tree
Wed, Feb 20, 2019 at 08:02:01PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 20 Feb 2019 09:36:11 +0100 > >> Would be good to have some robot checking "Fixes" sanity... > >I want to add a script to my trees that locally do it for me but the When it is in tree, it's already late. The robot has to check emails/patchwork. >backlog for patch review for me is so huge that I never get to "fun" >tasks like that > >This has been discussed before too.
Re: linux-next: Fixes tag needs some work in the net-next tree
On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
David Miller wrote:
> From: Jiri Pirko
> Date: Wed, 20 Feb 2019 09:36:11 +0100
>
> > Would be good to have some robot checking "Fixes" sanity...
>
> I want to add a script to my trees that locally do it for me but the
> backlog for patch review for me is so huge that I never get to "fun"
> tasks like that
If it helps, this is what I use after being bitten once:
#!/bin/sh
[ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
grep "^Fixes: " "${1}" | while read -r f; do
sha="$(echo "${f}" | cut -d' ' -f2)"
if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12
--pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
echo "Bad tag: ${f}" && exit 1
fi
done
--
Stefano
Re: linux-next: Fixes tag needs some work in the net-next tree
From: Jiri Pirko Date: Wed, 20 Feb 2019 09:36:11 +0100 > Would be good to have some robot checking "Fixes" sanity... I want to add a script to my trees that locally do it for me but the backlog for patch review for me is so huge that I never get to "fun" tasks like that This has been discussed before too.
Re: linux-next: Fixes tag needs some work in the net-next tree
Wed, Feb 20, 2019 at 07:48:13AM CET, da...@davemloft.net wrote:
>From: Vinod Koul
>Date: Wed, 20 Feb 2019 10:10:55 +0530
>
>> On 20-02-19, 09:31, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>>
>>> Fixes tag
>>>
>>> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>>
>>> has these problem(s):
>>>
>>> - Target SHA1 does not exist
>>>
>>> Did you mean:
>>>
>>> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>>
>> Yes looks like I messed up the commit id.. Not sure why :(
>>
>> Dave would you like to drop this and me sending updated patch or
>> something else..
>>
>> Sorry about the miss
>
>Doesn't work that way, something in my tree is there forever.
Would be good to have some robot checking "Fixes" sanity...
Re: linux-next: Fixes tag needs some work in the net-next tree
From: Vinod Koul
Date: Wed, 20 Feb 2019 10:10:55 +0530
> On 20-02-19, 09:31, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>
>> Fixes tag
>>
>> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>
>> has these problem(s):
>>
>> - Target SHA1 does not exist
>>
>> Did you mean:
>>
>> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>
> Yes looks like I messed up the commit id.. Not sure why :(
>
> Dave would you like to drop this and me sending updated patch or
> something else..
>
> Sorry about the miss
Doesn't work that way, something in my tree is there forever.
Re: linux-next: Fixes tag needs some work in the net-next tree
Hi Vinod, On Wed, 20 Feb 2019 10:10:55 +0530 Vinod Koul wrote: > > Dave would you like to drop this and me sending updated patch or > something else.. Dave doesn't rebase/reset net-next, so we will just have to use this as a learning experience :-) -- Cheers, Stephen Rothwell pgpUuF3aMJ8b1.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the net-next tree
On 20-02-19, 09:31, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>
> Fixes tag
>
> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean:
>
> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
Yes looks like I messed up the commit id.. Not sure why :(
Dave would you like to drop this and me sending updated patch or
something else..
Sorry about the miss
--
~Vinod
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
Fixes tag
Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
--
Cheers,
Stephen Rothwell
pgpAC7FzoZI45.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
cbd72b485214 ("net: dsa: microchip: add switch offload forwarding support")
Fixes tag
Fixes: c2e866911e254067 ("microchip: break KSZ9477 DSA driver into two files")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
pgpta4IVhe1bz.pgp
Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the net-next tree
Hi all,
In commit
9fc55413270f ("net: hns3: fix improper error handling in the
hclge_init_ae_dev()")
Fixes tag
Fixes: 288475b2ad01 ("{topost} net: hns3: refine umv space allocation")
has these problem(s):
- Target SHA1 does not exist
I can't even find it by simple searches for the subject ...
--
Cheers,
Stephen Rothwell
pgpliQhMSovjd.pgp
Description: OpenPGP digital signature
