linux-next: Fixes tag needs some work in the ntb tree
Hi all,
In commit
eb3eabb28cf2 ("ntb_tool: pass correct struct device to dma_alloc_coherent")
Fixes tag
Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
In commit
55480afb82bd ("ntb_perf: pass correct struct device to dma_alloc_coherent")
Fixes tag
Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
pgpB_idV2rUlZ.pgp
Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the ntb tree
On Thu, Mar 21, 2019 at 4:28 PM Stephen Rothwell wrote: > > Hi Jon, > > On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason wrote: > > > > Is there an existing set of tools/scripts I should run to prevent > > things like this from happening? > > I have attached the script I run over all new commits submitted for > linux-next. Fantastic! I'll add a variation of this to my git tree and hopefully prevent any future issues. Thanks, Jon > > -- > Cheers, > Stephen Rothwell
Re: linux-next: Fixes tag needs some work in the ntb tree
Hi Jon, On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason wrote: > > Is there an existing set of tools/scripts I should run to prevent > things like this from happening? I have attached the script I run over all new commits submitted for linux-next. -- Cheers, Stephen Rothwell check_fixes Description: application/shellscript pgpJd5wCxMSFE.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the ntb tree
On Wed, Mar 20, 2019 at 5:00 PM Logan Gunthorpe wrote:
>
>
>
> On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is
> > initaliazed")
> >
> > Fixes tag
> >
> > Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer
> > is mapped for TX DMA")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Did you mean:
> >
> > c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is
> > mapped for TX DMA")
>
> My fault. I sent the fix patch with the fixes tag before the original
> patch was merged upstream expecting them to be squashed. c59666bb32b9 is
> the correct hash in upstream now.
I've corrected the patch in my git branches and repushed.
Is there an existing set of tools/scripts I should run to prevent
things like this from happening?
Thanks,
Jon
>
> Logan
>
Re: linux-next: Fixes tag needs some work in the ntb tree
On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is
> initaliazed")
>
> Fixes tag
>
> Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is
> mapped for TX DMA")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean:
>
> c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped
> for TX DMA")
My fault. I sent the fix patch with the fixes tag before the original
patch was merged upstream expecting them to be squashed. c59666bb32b9 is
the correct hash in upstream now.
Logan
linux-next: Fixes tag needs some work in the ntb tree
Hi all,
In commit
f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
Fixes tag
Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is
mapped for TX DMA")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped
for TX DMA")
--
Cheers,
Stephen Rothwell
pgpBZibhp_j7X.pgp
Description: OpenPGP digital signature
