Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed - (a tmp branch was accidentally pushed)

On Thu, Apr 8, 2021 at 7:07 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   e67fcb31fb0e ("stuff")
>
> is missing a Signed-off-by from its author and comitter.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  e67fcb31fb0e ("stuff")

is missing a Signed-off-by from its author and comitter.

-- 
Cheers,
Stephen Rothwell


pgpjy3npdNnMZ.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  5d7d1f5dc626 ("cifs: Adjust key sizes and key generation routines for AES256 
encryption")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpivHRbs9far.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  f204a0ab8c4f ("cifs: update internal version number")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell


pgpuAzNQ0vXCs.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Wed, Feb 3, 2021 at 4:59 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   37595a5c8a51 ("smb3: fix crediting for compounding when only one request in 
> flight")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  37595a5c8a51 ("smb3: fix crediting for compounding when only one request in 
flight")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpGY3ohdy8Pm.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

I have now amended the patches to have the correct author and repushed

On Thu, Dec 17, 2020 at 11:57 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commits
>
>   ee04fe87f4d0 ("cifs: Re-indent cifs_swn_reconnect()")
>   2c6dd2f9742d ("cifs: Unlock on errors in cifs_swn_reconnect()")
>   fb2356b3739b ("cifs: Delete a stray unlock in cifs_swn_reconnect()")
>
> are missing a Signed-off-by from their author.
>
> This is the problem with the mailing list again :-(  The
> author has been recorded as
>
> "Dan Carpenter via samba-technical "
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commits

  ee04fe87f4d0 ("cifs: Re-indent cifs_swn_reconnect()")
  2c6dd2f9742d ("cifs: Unlock on errors in cifs_swn_reconnect()")
  fb2356b3739b ("cifs: Delete a stray unlock in cifs_swn_reconnect()")

are missing a Signed-off-by from their author.

This is the problem with the mailing list again :-(  The
author has been recorded as

"Dan Carpenter via samba-technical "

-- 
Cheers,
Stephen Rothwell


pgpGK4EriNRQm.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Mon, Dec 14, 2020 at 1:32 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commits
>
>   425f40482491 ("cifs: fix uninitialized variable in 
> smb3_fs_context_parse_param")
>   8cc9a66ea70e ("cifs: update mnt_cifs_flags during reconfigure")
>
> are missing a Signed-off-by from their committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commits

  425f40482491 ("cifs: fix uninitialized variable in 
smb3_fs_context_parse_param")
  8cc9a66ea70e ("cifs: update mnt_cifs_flags during reconfigure")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell


pgp_yCAq79gJ4.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed and repushed to cifs-2.6.git for-next

On Sun, Dec 13, 2020 at 4:14 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   3aa4e616197b ("cifs: Register generic netlink family")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  3aa4e616197b ("cifs: Register generic netlink family")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpeEQB7GcsLr.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed and repushed to cifs-2.6.git for-next

On Thu, Dec 10, 2020 at 4:45 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   7e9c48d305d5 ("cifs: remove the devname argument to 
> cifs_compose_mount_options")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  7e9c48d305d5 ("cifs: remove the devname argument to 
cifs_compose_mount_options")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpMFZNgmHTbV.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Tue, Sep 29, 2020 at 5:31 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   87505cefd88d ("Convert trailing spaces and periods in path components")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  87505cefd88d ("Convert trailing spaces and periods in path components")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpuYcglCoeZJ.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Dan Carpenter]

On Fri, Aug 07, 2020 at 08:33:42AM +1000, Stephen Rothwell wrote:
> Hi Steve,
> 
> Thanks for fixing this up.
> 
> On Thu, 6 Aug 2020 10:31:33 -0500 Steve French  wrote:
> >
> > I just fixed the Author tag in this patch to match your email address
> > but seems like the author email address gets mangled when sent through
> > some mailing lists.  Any ideas how to avoid this.
> 
> You may need to ask people to add an explicit From: line at the start
> of the body for patches sent via the samba.org mailing lists (since
> they mangle addresses to get around DKIM checks, I assume).
> 

I wonder why it affects me in particular and only now...

Steve, could you send me a copy of the patch that you recieved or
something?

regards,
dan carpenter

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi Steve,

Thanks for fixing this up.

On Thu, 6 Aug 2020 10:31:33 -0500 Steve French  wrote:
>
> I just fixed the Author tag in this patch to match your email address
> but seems like the author email address gets mangled when sent through
> some mailing lists.  Any ideas how to avoid this.

You may need to ask people to add an explicit From: line at the start
of the body for patches sent via the samba.org mailing lists (since
they mangle addresses to get around DKIM checks, I assume).

-- 
Cheers,
Stephen Rothwell


pgp4JBl4enluM.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Dan,
I just fixed the Author tag in this patch to match your email address
but seems like the author email address gets mangled when sent through
some mailing lists.  Any ideas how to avoid this.

On Thu, Aug 6, 2020 at 1:45 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   2676d210d2f4 ("cifs: Fix an error pointer dereference in cifs_mount()")
>
> is missing a Signed-off-by from its author.
>
> This is only pisked up by my script because of the mangling of the email
> sender address by the mailing list it passed through.  I guess a little
> more care is required to make sure the author attribution is correct in
> this case.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  2676d210d2f4 ("cifs: Fix an error pointer dereference in cifs_mount()")

is missing a Signed-off-by from its author.

This is only pisked up by my script because of the mangling of the email
sender address by the mailing list it passed through.  I guess a little
more care is required to make sure the author attribution is correct in
this case.

-- 
Cheers,
Stephen Rothwell


pgpNF0H63M8Ye.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed

On Thu, Aug 1, 2019 at 4:55 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   c3ab166ec798 ("SMB3: Kernel oops mounting a encryptData share with 
> CONFIG_DEBUG_VIRTUAL")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  c3ab166ec798 ("SMB3: Kernel oops mounting a encryptData share with 
CONFIG_DEBUG_VIRTUAL")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp39BYa5H8lS.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed

On Tue, Jun 25, 2019 at 6:08 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   c1ed2864526e ("smb3: minor cleanup of compound_send_recv")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  c1ed2864526e ("smb3: minor cleanup of compound_send_recv")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp_aNCaYj0tA.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Tue, May 7, 2019 at 4:32 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   b00c40f57bd5 ("cifs: fix strcat buffer overflow and reduce raciness in 
> smb21_set_oplock_level()")
>
> is missing a Signed-off-by from its author.
>
> Actually it looks like you were just tripped up by the mailing list's
> DMARC workaround.  :-(
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  b00c40f57bd5 ("cifs: fix strcat buffer overflow and reduce raciness in 
smb21_set_oplock_level()")

is missing a Signed-off-by from its author.

Actually it looks like you were just tripped up by the mailing list's
DMARC workaround.  :-(

-- 
Cheers,
Stephen Rothwell


pgpZZX6FNnHB4.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed - Updated author to match signed off line

On Tue, Apr 2, 2019 at 3:40 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   d0cb257cb7b0 ("Show locallease in /proc/mounts for cifs shares mounted with 
> locallease feature.")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  d0cb257cb7b0 ("Show locallease in /proc/mounts for cifs shares mounted with 
locallease feature.")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell


pgpQXtpOPW5lP.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Thu, Mar 21, 2019 at 1:47 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   828a8dfb7069 ("cifs: update internal module version number")
>
> is missing a Signed-off-by from its author and committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  828a8dfb7069 ("cifs: update internal module version number")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell


pgpNr2uKRMEgN.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  375808983c63 ("smb3: request more credits on tree connect")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell


pgpfgU8K4lhss.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed and remerged to cifs-2.6.git for-next

On Mon, Dec 24, 2018 at 5:45 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   87410161a381 ("cifs: check kzalloc return")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  87410161a381 ("cifs: check kzalloc return")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell


pgpkCRUe8DnoF.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  bf4d4ba7d970 ("cifs: update internal module version number for cifs.ko")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell


pgpwC0LnYhEkJ.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  bf4d4ba7d970 ("cifs: update internal module version number for cifs.ko")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell


pgpwC0LnYhEkJ.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed
On Mon, Aug 20, 2018 at 11:18 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   eacb610d8fc4 ("cifs: create a define for how many iovs we need for an 
> SMB2_open()")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed
On Mon, Aug 20, 2018 at 11:18 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   eacb610d8fc4 ("cifs: create a define for how many iovs we need for an 
> SMB2_open()")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  eacb610d8fc4 ("cifs: create a define for how many iovs we need for an 
SMB2_open()")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpol1tOxkm1O.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  eacb610d8fc4 ("cifs: create a define for how many iovs we need for an 
SMB2_open()")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpol1tOxkm1O.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed
On Wed, Aug 1, 2018 at 5:59 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commits
>
>   e0afb3ebfcf5 ("cifs: add compound_send_recv()")
>   1bc941970813 ("cifs: make smb_send_rqst take an array of requests")
>   095fe7367830 ("cifs: update init_sg, crypt_message to take an array of 
> rqst")
>
> are missing a Signed-off-by from their committers.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed
On Wed, Aug 1, 2018 at 5:59 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commits
>
>   e0afb3ebfcf5 ("cifs: add compound_send_recv()")
>   1bc941970813 ("cifs: make smb_send_rqst take an array of requests")
>   095fe7367830 ("cifs: update init_sg, crypt_message to take an array of 
> rqst")
>
> are missing a Signed-off-by from their committers.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commits

  e0afb3ebfcf5 ("cifs: add compound_send_recv()")
  1bc941970813 ("cifs: make smb_send_rqst take an array of requests")
  095fe7367830 ("cifs: update init_sg, crypt_message to take an array of rqst")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell


pgpN7kvYbUpmC.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commits

  e0afb3ebfcf5 ("cifs: add compound_send_recv()")
  1bc941970813 ("cifs: make smb_send_rqst take an array of requests")
  095fe7367830 ("cifs: update init_sg, crypt_message to take an array of rqst")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell


pgpN7kvYbUpmC.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Sat, Mar 31, 2018 at 8:38 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   7127583a1b4b ("cifs: add server->vals->header_preamble_size")
>
> is missing a Signed-off-by from its committer.
>
> [I am assuming that smfre...@gmail.com == stfre...@microsoft.com]
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

fixed

On Sat, Mar 31, 2018 at 8:38 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   7127583a1b4b ("cifs: add server->vals->header_preamble_size")
>
> is missing a Signed-off-by from its committer.
>
> [I am assuming that smfre...@gmail.com == stfre...@microsoft.com]
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  7127583a1b4b ("cifs: add server->vals->header_preamble_size")

is missing a Signed-off-by from its committer.

[I am assuming that smfre...@gmail.com == stfre...@microsoft.com]

-- 
Cheers,
Stephen Rothwell


pgpy4CkJRwVMX.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  7127583a1b4b ("cifs: add server->vals->header_preamble_size")

is missing a Signed-off-by from its committer.

[I am assuming that smfre...@gmail.com == stfre...@microsoft.com]

-- 
Cheers,
Stephen Rothwell


pgpy4CkJRwVMX.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  b8b14037d451 ("cifs: show 'soft' in the mount options for !hard mounts")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  b8b14037d451 ("cifs: show 'soft' in the mount options for !hard mounts")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed and repushed

On Mon, Sep 4, 2017 at 5:44 PM, Steve French  wrote:
> Ok. Will check what happened and repush
>
> On Sep 4, 2017 16:56, "Stephen Rothwell"  wrote:
>>
>> Hi all,
>>
>> Commit
>>
>>   84c9d65efa37 ("cifs: Check for timeout on Negotiate stage")
>>
>> is missing a Signed-off-by from its committer.
>>
>> --
>> Cheers,
>> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Signed-off-by missing for commit in the cifs tree

[Steve French]

Fixed and repushed

On Mon, Sep 4, 2017 at 5:44 PM, Steve French  wrote:
> Ok. Will check what happened and repush
>
> On Sep 4, 2017 16:56, "Stephen Rothwell"  wrote:
>>
>> Hi all,
>>
>> Commit
>>
>>   84c9d65efa37 ("cifs: Check for timeout on Negotiate stage")
>>
>> is missing a Signed-off-by from its committer.
>>
>> --
>> Cheers,
>> Stephen Rothwell



-- 
Thanks,

Steve

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  84c9d65efa37 ("cifs: Check for timeout on Negotiate stage")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the cifs tree

[Stephen Rothwell]

Hi all,

Commit

  84c9d65efa37 ("cifs: Check for timeout on Negotiate stage")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell