Re: linux-next: build failure after merge of the battery tree
Hi Sebastian, In case is not too late for you. Otherwise we will need to wait for next cycle. The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git tags/ib-chrome-psy-5.3 for you to fetch changes up to 0c0b7ea23aed0b55ef2f9803f13ddaae1943713d: platform/chrome: wilco_ec: Add property helper library (2019-05-20 10:18:09 +0200) Immutable branch between Power Supply and Chrome Platform due for the v5.3 merge window Nick Crews (1): platform/chrome: wilco_ec: Add property helper library drivers/platform/chrome/wilco_ec/Makefile | 2 +- drivers/platform/chrome/wilco_ec/properties.c | 132 ++ include/linux/platform_data/wilco-ec.h| 71 ++ 3 files changed, 204 insertions(+), 1 deletion(-) create mode 100644 drivers/platform/chrome/wilco_ec/properties.c On 29/6/19 2:33, Stephen Rothwell wrote: > Hi Enric, > > On Fri, 28 Jun 2019 18:56:56 +0200 Enric Balletbo i Serra > wrote: >> >> Hmm, I just applied this patch on top of linux-next and it build with >> allmodconfig on x86_64 >> >> I am wondering if the build was done without this commit, which is in >> chrome-platform for-next branch. Could be this the problem? >> >> commit 0c0b7ea23aed0b55ef2f9803f13ddaae1943713d >> Author: Nick Crews >> Date: Wed Apr 24 10:56:50 2019 -0600 >> >> platform/chrome: wilco_ec: Add property helper library > > Exactly since I merge the battery tree before the chrome-platform > tree ... Cross tree dependencies are a pain. > >> Anyway, I think the proper way to do it is create an immutable branch for >> Sebastian as the patch he picked depends on the above commit. I'll create >> one, >> sorry about that missing dependency. > > Thanks. >
Re: linux-next: build failure after merge of the battery tree
Hi Enric, On Fri, 28 Jun 2019 18:56:56 +0200 Enric Balletbo i Serra wrote: > > Hmm, I just applied this patch on top of linux-next and it build with > allmodconfig on x86_64 > > I am wondering if the build was done without this commit, which is in > chrome-platform for-next branch. Could be this the problem? > > commit 0c0b7ea23aed0b55ef2f9803f13ddaae1943713d > Author: Nick Crews > Date: Wed Apr 24 10:56:50 2019 -0600 > > platform/chrome: wilco_ec: Add property helper library Exactly since I merge the battery tree before the chrome-platform tree ... Cross tree dependencies are a pain. > Anyway, I think the proper way to do it is create an immutable branch for > Sebastian as the patch he picked depends on the above commit. I'll create one, > sorry about that missing dependency. Thanks. -- Cheers, Stephen Rothwell pgpD4BsCXfkVf.pgp Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the battery tree
Hi,
On 28/6/19 17:31, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Jun 28, 2019 at 02:03:04PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the battery tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/power/supply/wilco-charger.c: In function
>> 'wilco_charge_get_property':
>> drivers/power/supply/wilco-charger.c:104:8: error: implicit declaration of
>> function 'wilco_ec_get_byte_property'; did you mean
>> 'wilco_charge_get_property'? [-Werror=implicit-function-declaration]
>> ret = wilco_ec_get_byte_property(ec, property_id, &raw);
>> ^~
>> wilco_charge_get_property
>> drivers/power/supply/wilco-charger.c: In function
>> 'wilco_charge_set_property':
>> drivers/power/supply/wilco-charger.c:130:10: error: implicit declaration of
>> function 'wilco_ec_set_byte_property'; did you mean
>> 'wilco_charge_set_property'? [-Werror=implicit-function-declaration]
>>return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode);
>> ^~
>> wilco_charge_set_property
>>
>> Caused by commit
>>
>> 0736343e4c56 ("power_supply: wilco_ec: Add charging config driver")
>>
Hmm, I just applied this patch on top of linux-next and it build with
allmodconfig on x86_64
I am wondering if the build was done without this commit, which is in
chrome-platform for-next branch. Could be this the problem?
commit 0c0b7ea23aed0b55ef2f9803f13ddaae1943713d
Author: Nick Crews
Date: Wed Apr 24 10:56:50 2019 -0600
platform/chrome: wilco_ec: Add property helper library
Anyway, I think the proper way to do it is create an immutable branch for
Sebastian as the patch he picked depends on the above commit. I'll create one,
sorry about that missing dependency.
Thanks,
~ Enric
>> I have reverted that commit for today.
>
> Oops, thanks for the hint. I did not notice this with ARM
> allmodconfig. I dropped the patch for this cycle.
>
> -- Sebastian
>
Re: linux-next: build failure after merge of the battery tree
Hi,
On Fri, Jun 28, 2019 at 02:03:04PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_get_property':
> drivers/power/supply/wilco-charger.c:104:8: error: implicit declaration of
> function 'wilco_ec_get_byte_property'; did you mean
> 'wilco_charge_get_property'? [-Werror=implicit-function-declaration]
> ret = wilco_ec_get_byte_property(ec, property_id, &raw);
> ^~
> wilco_charge_get_property
> drivers/power/supply/wilco-charger.c: In function 'wilco_charge_set_property':
> drivers/power/supply/wilco-charger.c:130:10: error: implicit declaration of
> function 'wilco_ec_set_byte_property'; did you mean
> 'wilco_charge_set_property'? [-Werror=implicit-function-declaration]
>return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode);
> ^~
> wilco_charge_set_property
>
> Caused by commit
>
> 0736343e4c56 ("power_supply: wilco_ec: Add charging config driver")
>
> I have reverted that commit for today.
Oops, thanks for the hint. I did not notice this with ARM
allmodconfig. I dropped the patch for this cycle.
-- Sebastian
signature.asc
Description: PGP signature
linux-next: build failure after merge of the battery tree
Hi all,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/power/supply/wilco-charger.c: In function 'wilco_charge_get_property':
drivers/power/supply/wilco-charger.c:104:8: error: implicit declaration of
function 'wilco_ec_get_byte_property'; did you mean
'wilco_charge_get_property'? [-Werror=implicit-function-declaration]
ret = wilco_ec_get_byte_property(ec, property_id, &raw);
^~
wilco_charge_get_property
drivers/power/supply/wilco-charger.c: In function 'wilco_charge_set_property':
drivers/power/supply/wilco-charger.c:130:10: error: implicit declaration of
function 'wilco_ec_set_byte_property'; did you mean
'wilco_charge_set_property'? [-Werror=implicit-function-declaration]
return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode);
^~
wilco_charge_set_property
Caused by commit
0736343e4c56 ("power_supply: wilco_ec: Add charging config driver")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
pgp6wAJRU4s5I.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the battery tree
Adding Tony to CC
On Wed, Oct 21, 2015 at 12:32 AM, Stephen Rothwell
wrote:
> Hi Sebastian,
>
> On Fri, 16 Oct 2015 01:26:39 +1100 Stephen Rothwell
> wrote:
>>
>> On Thu, 8 Oct 2015 12:04:24 +1100 Stephen Rothwell
>> wrote:
>> >
>> > On Fri, 2 Oct 2015 11:49:32 +1000 Stephen Rothwell
>> > wrote:
>> > >
>> > > On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
>> > > wrote:
>> > > >
>> > > > After merging the battery tree, today's linux-next build (arm
>> > > > multi_v7_defconfig) failed like this:
>> > > >
>> > > > ERROR (phandle_references): Reference to non-existent node or label
>> > > > "twl4030_madc"
>> > > > ERROR: Input tree has errors, aborting (use -f to force output)
>> > > > scripts/Makefile.lib:293: recipe for target
>> > > > 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
>> > > >
>> > > > and many more ...
>> > > >
>> > > > Caused by commit
>> > > >
>> > > > af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci
>> > > > subnode")
>> > > >
>> > > > Presumably some updates to other files were missed.
>> > > >
>> > > > I have used the battery tree from next-20150925 fot today.
>> > >
>> > > I am still getting this error.
>> >
>> > Ping?
>>
>> I still got this error today ...
>
> And still ... This has been going on for 4 weeks now ... either revert
> the commit or get it fixed. Nothing added to the battery tree since
> September 25 has been able to be tested in linux-next.
I posted last week fix [0]. Tony can you please merge it? Thanks.
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
[0] - https://lkml.org/lkml/2015/10/13/816
BR,
marek
--
as simple and primitive as possible
-
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Sebastian,
On Fri, 16 Oct 2015 01:26:39 +1100 Stephen Rothwell
wrote:
>
> On Thu, 8 Oct 2015 12:04:24 +1100 Stephen Rothwell
> wrote:
> >
> > On Fri, 2 Oct 2015 11:49:32 +1000 Stephen Rothwell
> > wrote:
> > >
> > > On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
> > > wrote:
> > > >
> > > > After merging the battery tree, today's linux-next build (arm
> > > > multi_v7_defconfig) failed like this:
> > > >
> > > > ERROR (phandle_references): Reference to non-existent node or label
> > > > "twl4030_madc"
> > > > ERROR: Input tree has errors, aborting (use -f to force output)
> > > > scripts/Makefile.lib:293: recipe for target
> > > > 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
> > > >
> > > > and many more ...
> > > >
> > > > Caused by commit
> > > >
> > > > af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
> > > >
> > > > Presumably some updates to other files were missed.
> > > >
> > > > I have used the battery tree from next-20150925 fot today.
> > >
> > > I am still getting this error.
> >
> > Ping?
>
> I still got this error today ...
And still ... This has been going on for 4 weeks now ... either revert
the commit or get it fixed. Nothing added to the battery tree since
September 25 has been able to be tested in linux-next.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Sebastian,
On Thu, 8 Oct 2015 12:04:24 +1100 Stephen Rothwell
wrote:
>
> On Fri, 2 Oct 2015 11:49:32 +1000 Stephen Rothwell
> wrote:
> >
> > On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
> > wrote:
> > >
> > > After merging the battery tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > ERROR (phandle_references): Reference to non-existent node or label
> > > "twl4030_madc"
> > > ERROR: Input tree has errors, aborting (use -f to force output)
> > > scripts/Makefile.lib:293: recipe for target
> > > 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
> > >
> > > and many more ...
> > >
> > > Caused by commit
> > >
> > > af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
> > >
> > > Presumably some updates to other files were missed.
> > >
> > > I have used the battery tree from next-20150925 fot today.
> >
> > I am still getting this error.
>
> Ping?
I still got this error today ...
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Belisko,
On Thu, 8 Oct 2015 08:12:06 +0200 Belisko Marek wrote:
>
> I did test it and it builds fine (multi_v7_defconfig). My HEAD is on
> dad463bdcbb41dfd17c799a5653bb57f185f2c76
That is next-20151002 which does not contain the broken commit. I am
using the battery tree that was included in next-20150925 which is the
last time it worked for me. The head of the battery tree them was
3636859b280ca595da4556274a509223f47e9a39 ("power_supply: Add support
for tps65217-charger."), it is now
6169588f69f864c39f04e6d65cc620e58822aec5 ("Documentation: power:
bq24257: Document exported sysfs entries") (and has been for some
time). The bad commit is af19161aaed7 ("ARM: dts: twl4030: Add iio
properties for bci subnode").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Stephen,
On Thu, Oct 8, 2015 at 3:04 AM, Stephen Rothwell wrote:
> Hi Sebastian,
>
> On Fri, 2 Oct 2015 11:49:32 +1000 Stephen Rothwell
> wrote:
>>
>> On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
>> wrote:
>> >
>> > After merging the battery tree, today's linux-next build (arm
>> > multi_v7_defconfig) failed like this:
>> >
>> > ERROR (phandle_references): Reference to non-existent node or label
>> > "twl4030_madc"
>> > ERROR: Input tree has errors, aborting (use -f to force output)
>> > scripts/Makefile.lib:293: recipe for target
>> > 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
>> >
>> > and many more ...
>> >
>> > Caused by commit
>> >
>> > af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
>> >
>> > Presumably some updates to other files were missed.
>> >
>> > I have used the battery tree from next-20150925 fot today.
>>
>> I am still getting this error.
>
> Ping?
I did test it and it builds fine (multi_v7_defconfig). My HEAD is on
dad463bdcbb41dfd17c799a5653bb57f185f2c76
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
BR,
marek
--
as simple and primitive as possible
-
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Sebastian,
On Fri, 2 Oct 2015 11:49:32 +1000 Stephen Rothwell
wrote:
>
> On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the battery tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > ERROR (phandle_references): Reference to non-existent node or label
> > "twl4030_madc"
> > ERROR: Input tree has errors, aborting (use -f to force output)
> > scripts/Makefile.lib:293: recipe for target
> > 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
> >
> > and many more ...
> >
> > Caused by commit
> >
> > af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
> >
> > Presumably some updates to other files were missed.
> >
> > I have used the battery tree from next-20150925 fot today.
>
> I am still getting this error.
Ping?
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Sebastian,
On Tue, 29 Sep 2015 11:45:31 +1000 Stephen Rothwell
wrote:
>
> After merging the battery tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR (phandle_references): Reference to non-existent node or label
> "twl4030_madc"
> ERROR: Input tree has errors, aborting (use -f to force output)
> scripts/Makefile.lib:293: recipe for target
> 'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
>
> and many more ...
>
> Caused by commit
>
> af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
>
> Presumably some updates to other files were missed.
>
> I have used the battery tree from next-20150925 fot today.
I am still getting this error.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the battery tree
Hi Sebastian,
After merging the battery tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
ERROR (phandle_references): Reference to non-existent node or label
"twl4030_madc"
ERROR: Input tree has errors, aborting (use -f to force output)
scripts/Makefile.lib:293: recipe for target
'arch/arm/boot/dts/omap3-beagle-xm-ab.dtb' failed
and many more ...
Caused by commit
af19161aaed7 ("ARM: dts: twl4030: Add iio properties for bci subnode")
Presumably some updates to other files were missed.
I have used the battery tree from next-20150925 fot today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the battery tree
Hi Sebastian,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/power/reset/zx-reboot.c:21:26: fatal error: asm/proc-fns.h: No such
file or directory
#include
^
Caused by commit
dd9f1486ae20 ("power/reset: zx: Register restart handler")
I have used the battery tree from next-20150724 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the battery tree
Hi Stephen,
On 07/16/2012 01:09 PM, Stephen Rothwell wrote:
> Hi Anton,
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/built-in.o: In function `charger_manager_probe':
> charger-manager.c:(.text+0x11d61a): undefined reference to
> `extcon_register_interest'
> charger-manager.c:(.text+0x11d7b6): undefined reference to
> `extcon_unregister_interest'
> drivers/built-in.o: In function `charger_manager_remove':
> charger-manager.c:(.devexit.text+0x8f3): undefined reference to
> `extcon_unregister_interest'
>
> Caused by commit bee737bccb03 ("charger-manager: Use EXTCON Subsystem to
> detect charger cables for charging").
>
> I have used the battery tree from next-20120713 for today.
I'm so sorry, It is my mistake.
So, I resend below patch to fix build break of charger-manager.
- http://lkml.org/lkml/2012/7/16/5
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the battery tree
Hi Anton,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/built-in.o: In function `charger_manager_probe':
charger-manager.c:(.text+0x11d61a): undefined reference to
`extcon_register_interest'
charger-manager.c:(.text+0x11d7b6): undefined reference to
`extcon_unregister_interest'
drivers/built-in.o: In function `charger_manager_remove':
charger-manager.c:(.devexit.text+0x8f3): undefined reference to
`extcon_unregister_interest'
Caused by commit bee737bccb03 ("charger-manager: Use EXTCON Subsystem to
detect charger cables for charging").
I have used the battery tree from next-20120713 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgppC7zhMHw0I.pgp
Description: PGP signature
