Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

On Wed, 20 Jan 2021 10:57:15 +1100 Stephen Rothwell  
wrote:
>
> After merging the drm-intel tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpu/drm/msm/dp/dp_ctrl.c: In function 'dp_ctrl_use_fixed_nvid':
> drivers/gpu/drm/msm/dp/dp_ctrl.c:1425:16: error: implicit declaration of 
> function 'drm_dp_get_edid_quirks'; did you mean 'drm_do_get_edid'? 
> [-Werror=implicit-function-declaration]
>  1425 |  edid_quirks = drm_dp_get_edid_quirks(ctrl->panel->edid);
>   |^~
>   |drm_do_get_edid
> drivers/gpu/drm/msm/dp/dp_ctrl.c:1431:11: error: too many arguments to 
> function 'drm_dp_has_quirk'
>  1431 |   return (drm_dp_has_quirk(>panel->desc, edid_quirks,
>   |   ^~~~
> In file included from drivers/gpu/drm/msm/dp/dp_ctrl.c:15:
> include/drm/drm_dp_helper.h:2087:1: note: declared here
>  2087 | drm_dp_has_quirk(const struct drm_dp_desc *desc, enum drm_dp_quirk 
> quirk)
>   | ^~~~
> 
> Caused by commit
> 
>   7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based quirks"")
> 
> Since the drm-intel tree still has its other build failure, I used the
> version from next-20210108 again today.

I still get this failure, but not the one from the drm tree, so I have
used the drm-intel tree from next-20210119 for today.

-- 
Cheers,
Stephen Rothwell


pgpCeC4LqCyzk.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/drm/msm/dp/dp_ctrl.c: In function 'dp_ctrl_use_fixed_nvid':
drivers/gpu/drm/msm/dp/dp_ctrl.c:1425:16: error: implicit declaration of 
function 'drm_dp_get_edid_quirks'; did you mean 'drm_do_get_edid'? 
[-Werror=implicit-function-declaration]
 1425 |  edid_quirks = drm_dp_get_edid_quirks(ctrl->panel->edid);
  |^~
  |drm_do_get_edid
drivers/gpu/drm/msm/dp/dp_ctrl.c:1431:11: error: too many arguments to function 
'drm_dp_has_quirk'
 1431 |   return (drm_dp_has_quirk(>panel->desc, edid_quirks,
  |   ^~~~
In file included from drivers/gpu/drm/msm/dp/dp_ctrl.c:15:
include/drm/drm_dp_helper.h:2087:1: note: declared here
 2087 | drm_dp_has_quirk(const struct drm_dp_desc *desc, enum drm_dp_quirk 
quirk)
  | ^~~~

Caused by commit

  7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based quirks"")

Since the drm-intel tree still has its other build failure, I used the
version from next-20210108 again today.

-- 
Cheers,
Stephen Rothwell


pgpEqD5alvhKW.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (i386
defconfig) failed like this:

In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
 from drivers/gpu/drm/i915/intel_uc.h:27,
 from drivers/gpu/drm/i915/intel_uc.c:25:
drivers/gpu/drm/i915/intel_uncore.h: In function '__raw_uncore_read64':
drivers/gpu/drm/i915/intel_uncore.h:257:9: error: implicit declaration of 
function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
  return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
 ^
drivers/gpu/drm/i915/intel_uncore.h:269:1: note: in expansion of macro 
'__raw_read'
 __raw_read(64, q)
 ^~
drivers/gpu/drm/i915/intel_uncore.h: In function '__raw_uncore_write64':
drivers/gpu/drm/i915/intel_uncore.h:264:2: error: implicit declaration of 
function 'writeq'; did you mean 'writel'? 
[-Werror=implicit-function-declaration]
  write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
  ^
drivers/gpu/drm/i915/intel_uncore.h:274:1: note: in expansion of macro 
'__raw_write'
 __raw_write(64, q)
 ^~~

Caused by commit

  6cc5ca768825 ("drm/i915: rename raw reg access functions")

I have reverted that commit and the following ones in the tree up to

  9511cb6481af ("drm/i915: Adding missing '; ' to ENGINE_INSTANCES")

-- 
Cheers,
Stephen Rothwell


pgp5SPRlS_Vpq.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi Christoph,

On Wed, 9 May 2018 07:08:55 +0200 Christoph Hellwig  wrote:
>
> FYI, because the dma_configure change touch so much code and the author
> wants to base more work on it it actually is in a guranteed stable
> branch with just those patches:
> 
> git://git.infradead.org/users/hch/dma-mapping.git dma-configure
> 
> Gitweb:
> 
> 
> http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/dma-configure
>   
> Feel free to pull this into the drm tree.

Thanks for that.

-- 
Cheers,
Stephen Rothwell


pgpn_jyXCyabz.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi Christoph,

On Wed, 9 May 2018 07:08:55 +0200 Christoph Hellwig  wrote:
>
> FYI, because the dma_configure change touch so much code and the author
> wants to base more work on it it actually is in a guranteed stable
> branch with just those patches:
> 
> git://git.infradead.org/users/hch/dma-mapping.git dma-configure
> 
> Gitweb:
> 
> 
> http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/dma-configure
>   
> Feel free to pull this into the drm tree.

Thanks for that.

-- 
Cheers,
Stephen Rothwell


pgpn_jyXCyabz.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Christoph Hellwig]

On Wed, May 09, 2018 at 03:02:55PM +1000, Stephen Rothwell wrote:
> > -   ret = of_dma_configure(dev, NULL);
> > +   ret = of_dma_configure(dev, NULL, true);
> > if (ret < 0) {
> > DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
> > return ret;
> > -- 
> > 2.17.0
> 
> This is now needed for the merge of the drm and dma-mapping trees.

FYI, because the dma_configure change touch so much code and the author
wants to base more work on it it actually is in a guranteed stable
branch with just those patches:

git://git.infradead.org/users/hch/dma-mapping.git dma-configure

Gitweb:


http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/dma-configure
  
Feel free to pull this into the drm tree.

Re: linux-next: build failure after merge of the drm-intel tree

[Christoph Hellwig]

On Wed, May 09, 2018 at 03:02:55PM +1000, Stephen Rothwell wrote:
> > -   ret = of_dma_configure(dev, NULL);
> > +   ret = of_dma_configure(dev, NULL, true);
> > if (ret < 0) {
> > DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
> > return ret;
> > -- 
> > 2.17.0
> 
> This is now needed for the merge of the drm and dma-mapping trees.

FYI, because the dma_configure change touch so much code and the author
wants to base more work on it it actually is in a guranteed stable
branch with just those patches:

git://git.infradead.org/users/hch/dma-mapping.git dma-configure

Gitweb:


http://git.infradead.org/users/hch/dma-mapping.git/shortlog/refs/heads/dma-configure
  
Feel free to pull this into the drm tree.

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

On Tue, 8 May 2018 11:07:16 +1000 Stephen Rothwell  
wrote:
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
> drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
> member named 'force_dma'
>   dev->bus->force_dma = true;
>   ^~
> drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to 
> function 'of_dma_configure'
>   ret = of_dma_configure(dev, NULL);
> ^~~~
> In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
> include/linux/of_device.h:58:5: note: declared here
>  int of_dma_configure(struct device *dev,
>  ^~~~
> 
> Caused by commit
> 
>   c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
> 
> interacting with commit
> 
>   3d6ce86ee794 ("drivers: remove force dma flag from buses")
> 
> from the dma-mapping tree.
> 
> I have added the following merge fix patch:
> 
> From: Stephen Rothwell 
> Date: Tue, 8 May 2018 11:02:24 +1000
> Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag 
> from buses"
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
> b/drivers/gpu/drm/xen/xen_drm_front.c
> index 1b0ea9ac330e..0e486cb1c10c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
>* is not correct: to fix this call of_dma_configure() with a NULL
>* node to set default DMA ops.
>*/
> - dev->bus->force_dma = true;
>   dev->coherent_dma_mask = DMA_BIT_MASK(32);
> - ret = of_dma_configure(dev, NULL);
> + ret = of_dma_configure(dev, NULL, true);
>   if (ret < 0) {
>   DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
>   return ret;
> -- 
> 2.17.0

This is now needed for the merge of the drm and dma-mapping trees.
-- 
Cheers,
Stephen Rothwell


pgpN2sD4JHkM8.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

On Tue, 8 May 2018 11:07:16 +1000 Stephen Rothwell  
wrote:
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
> drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
> member named 'force_dma'
>   dev->bus->force_dma = true;
>   ^~
> drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to 
> function 'of_dma_configure'
>   ret = of_dma_configure(dev, NULL);
> ^~~~
> In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
> include/linux/of_device.h:58:5: note: declared here
>  int of_dma_configure(struct device *dev,
>  ^~~~
> 
> Caused by commit
> 
>   c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
> 
> interacting with commit
> 
>   3d6ce86ee794 ("drivers: remove force dma flag from buses")
> 
> from the dma-mapping tree.
> 
> I have added the following merge fix patch:
> 
> From: Stephen Rothwell 
> Date: Tue, 8 May 2018 11:02:24 +1000
> Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag 
> from buses"
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
> b/drivers/gpu/drm/xen/xen_drm_front.c
> index 1b0ea9ac330e..0e486cb1c10c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
>* is not correct: to fix this call of_dma_configure() with a NULL
>* node to set default DMA ops.
>*/
> - dev->bus->force_dma = true;
>   dev->coherent_dma_mask = DMA_BIT_MASK(32);
> - ret = of_dma_configure(dev, NULL);
> + ret = of_dma_configure(dev, NULL, true);
>   if (ret < 0) {
>   DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
>   return ret;
> -- 
> 2.17.0

This is now needed for the merge of the drm and dma-mapping trees.
-- 
Cheers,
Stephen Rothwell


pgpN2sD4JHkM8.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Oleksandr Andrushchenko]

On 05/08/2018 04:07 AM, Stephen Rothwell wrote:

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
member named 'force_dma'
   dev->bus->force_dma = true;
   ^~
drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to function 
'of_dma_configure'
   ret = of_dma_configure(dev, NULL);
 ^~~~
In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
include/linux/of_device.h:58:5: note: declared here
  int of_dma_configure(struct device *dev,
  ^~~~

Caused by commit

   c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")

interacting with commit

   3d6ce86ee794 ("drivers: remove force dma flag from buses")

from the dma-mapping tree.

I have added the following merge fix patch:

From: Stephen Rothwell 
Date: Tue, 8 May 2018 11:02:24 +1000
Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag from 
buses"

Signed-off-by: Stephen Rothwell 

Thank you,
Reviewed-by: Oleksandr Andrushchenko 

---
  drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..0e486cb1c10c 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
 * is not correct: to fix this call of_dma_configure() with a NULL
 * node to set default DMA ops.
 */
-   dev->bus->force_dma = true;
dev->coherent_dma_mask = DMA_BIT_MASK(32);
-   ret = of_dma_configure(dev, NULL);
+   ret = of_dma_configure(dev, NULL, true);
if (ret < 0) {
DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
return ret;


___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build failure after merge of the drm-intel tree

[Oleksandr Andrushchenko]

On 05/08/2018 04:07 AM, Stephen Rothwell wrote:

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
member named 'force_dma'
   dev->bus->force_dma = true;
   ^~
drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to function 
'of_dma_configure'
   ret = of_dma_configure(dev, NULL);
 ^~~~
In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
include/linux/of_device.h:58:5: note: declared here
  int of_dma_configure(struct device *dev,
  ^~~~

Caused by commit

   c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")

interacting with commit

   3d6ce86ee794 ("drivers: remove force dma flag from buses")

from the dma-mapping tree.

I have added the following merge fix patch:

From: Stephen Rothwell 
Date: Tue, 8 May 2018 11:02:24 +1000
Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag from 
buses"

Signed-off-by: Stephen Rothwell 

Thank you,
Reviewed-by: Oleksandr Andrushchenko 

---
  drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..0e486cb1c10c 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
 * is not correct: to fix this call of_dma_configure() with a NULL
 * node to set default DMA ops.
 */
-   dev->bus->force_dma = true;
dev->coherent_dma_mask = DMA_BIT_MASK(32);
-   ret = of_dma_configure(dev, NULL);
+   ret = of_dma_configure(dev, NULL, true);
if (ret < 0) {
DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
return ret;


___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
member named 'force_dma'
  dev->bus->force_dma = true;
  ^~
drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to function 
'of_dma_configure'
  ret = of_dma_configure(dev, NULL);
^~~~
In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
include/linux/of_device.h:58:5: note: declared here
 int of_dma_configure(struct device *dev,
 ^~~~

Caused by commit

  c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")

interacting with commit

  3d6ce86ee794 ("drivers: remove force dma flag from buses")

from the dma-mapping tree.

I have added the following merge fix patch:

From: Stephen Rothwell 
Date: Tue, 8 May 2018 11:02:24 +1000
Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag 
from buses"

Signed-off-by: Stephen Rothwell 
---
 drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..0e486cb1c10c 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
 * is not correct: to fix this call of_dma_configure() with a NULL
 * node to set default DMA ops.
 */
-   dev->bus->force_dma = true;
dev->coherent_dma_mask = DMA_BIT_MASK(32);
-   ret = of_dma_configure(dev, NULL);
+   ret = of_dma_configure(dev, NULL, true);
if (ret < 0) {
DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
return ret;
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell


pgpEXrY8MpGQP.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drv_probe':
drivers/gpu/drm/xen/xen_drm_front.c:740:10: error: 'struct bus_type' has no 
member named 'force_dma'
  dev->bus->force_dma = true;
  ^~
drivers/gpu/drm/xen/xen_drm_front.c:742:8: error: too few arguments to function 
'of_dma_configure'
  ret = of_dma_configure(dev, NULL);
^~~~
In file included from drivers/gpu/drm/xen/xen_drm_front.c:16:0:
include/linux/of_device.h:58:5: note: declared here
 int of_dma_configure(struct device *dev,
 ^~~~

Caused by commit

  c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")

interacting with commit

  3d6ce86ee794 ("drivers: remove force dma flag from buses")

from the dma-mapping tree.

I have added the following merge fix patch:

From: Stephen Rothwell 
Date: Tue, 8 May 2018 11:02:24 +1000
Subject: [PATCH] drm/xen-front: merge fix for "drivers: remove force dma flag 
from buses"

Signed-off-by: Stephen Rothwell 
---
 drivers/gpu/drm/xen/xen_drm_front.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c 
b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..0e486cb1c10c 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -737,9 +737,8 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
 * is not correct: to fix this call of_dma_configure() with a NULL
 * node to set default DMA ops.
 */
-   dev->bus->force_dma = true;
dev->coherent_dma_mask = DMA_BIT_MASK(32);
-   ret = of_dma_configure(dev, NULL);
+   ret = of_dma_configure(dev, NULL, true);
if (ret < 0) {
DRM_ERROR("Cannot setup DMA ops, ret %d", ret);
return ret;
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell


pgpEXrY8MpGQP.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Tue, Aug 23, 2016 at 11:56:14AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-intel tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> In file included from drivers/gpio/gpiolib-of.c:19:0:
> include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
> file or directory
> In file included from drivers/gpu/drm/nouveau/include/nvif/os.h:16:0,
>  from drivers/gpu/drm/nouveau/include/nvkm/core/os.h:3,
>  from drivers/gpu/drm/nouveau/include/nvkm/core/object.h:3,   
>  from drivers/gpu/drm/nouveau/include/nvkm/core/client.h:3,   
>  from drivers/gpu/drm/nouveau/nvkm/core/client.c:24:
> include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
> file or directory
> 
> and many more.
> 
> Caused by commit
> 
>   cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata about 
> the io-mapping")
> 
> I have used the drm-intel tree from next-20160822 for today.

Should be fixed now, thanks for reporting.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Tue, Aug 23, 2016 at 11:56:14AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-intel tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> In file included from drivers/gpio/gpiolib-of.c:19:0:
> include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
> file or directory
> In file included from drivers/gpu/drm/nouveau/include/nvif/os.h:16:0,
>  from drivers/gpu/drm/nouveau/include/nvkm/core/os.h:3,
>  from drivers/gpu/drm/nouveau/include/nvkm/core/object.h:3,   
>  from drivers/gpu/drm/nouveau/include/nvkm/core/client.h:3,   
>  from drivers/gpu/drm/nouveau/nvkm/core/client.c:24:
> include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
> file or directory
> 
> and many more.
> 
> Caused by commit
> 
>   cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata about 
> the io-mapping")
> 
> I have used the drm-intel tree from next-20160822 for today.

Should be fixed now, thanks for reporting.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from drivers/gpio/gpiolib-of.c:19:0:
include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
file or directory
In file included from drivers/gpu/drm/nouveau/include/nvif/os.h:16:0,
 from drivers/gpu/drm/nouveau/include/nvkm/core/os.h:3,
 from drivers/gpu/drm/nouveau/include/nvkm/core/object.h:3,   
 from drivers/gpu/drm/nouveau/include/nvkm/core/client.h:3,   
 from drivers/gpu/drm/nouveau/nvkm/core/client.c:24:
include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
file or directory

and many more.

Caused by commit

  cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata about the 
io-mapping")

I have used the drm-intel tree from next-20160822 for today.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from drivers/gpio/gpiolib-of.c:19:0:
include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
file or directory
In file included from drivers/gpu/drm/nouveau/include/nvif/os.h:16:0,
 from drivers/gpu/drm/nouveau/include/nvkm/core/os.h:3,
 from drivers/gpu/drm/nouveau/include/nvkm/core/object.h:3,   
 from drivers/gpu/drm/nouveau/include/nvkm/core/client.h:3,   
 from drivers/gpu/drm/nouveau/nvkm/core/client.c:24:
include/linux/io-mapping.h:115:31: fatal error: asm/pgtable_types.h: No such 
file or directory

and many more.

Caused by commit

  cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata about the 
io-mapping")

I have used the drm-intel tree from next-20160822 for today.

-- 
Cheers,
Stephen Rothwell

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Jani Nikula]

On Mon, 23 May 2016, Stephen Rothwell  wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
>  from drivers/gpu/drm/i915/i915_drv.h:2735,
>  from drivers/gpu/drm/i915/i915_drv.c:34:
> drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: 
> drm/drm_dp_dual_mode_helper.h: No such file or directory
>
> Caused by commit
>
>   8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")
>
> I have used the drm-intel tree from next-20160520 for today.

Hi Stephen, my bad, should be fixed now, sorry for the trouble.

(Note to self, don't even dream of doing this stuff when you're out
sick. Try to remember there was a reason you were out sick and not at
the office in the first place...)

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Jani Nikula]

On Mon, 23 May 2016, Stephen Rothwell  wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
>  from drivers/gpu/drm/i915/i915_drv.h:2735,
>  from drivers/gpu/drm/i915/i915_drv.c:34:
> drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: 
> drm/drm_dp_dual_mode_helper.h: No such file or directory
>
> Caused by commit
>
>   8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")
>
> I have used the drm-intel tree from next-20160520 for today.

Hi Stephen, my bad, should be fixed now, sorry for the trouble.

(Note to self, don't even dream of doing this stuff when you're out
sick. Try to remember there was a reason you were out sick and not at
the office in the first place...)

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
 from drivers/gpu/drm/i915/i915_drv.h:2735,
 from drivers/gpu/drm/i915/i915_drv.c:34:
drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: 
drm/drm_dp_dual_mode_helper.h: No such file or directory

Caused by commit

  8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")

I have used the drm-intel tree from next-20160520 for today.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
 from drivers/gpu/drm/i915/i915_drv.h:2735,
 from drivers/gpu/drm/i915/i915_drv.c:34:
drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: 
drm/drm_dp_dual_mode_helper.h: No such file or directory

Caused by commit

  8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")

I have used the drm-intel tree from next-20160520 for today.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/i915/intel_display.c: In function 'intel_alloc_plane_obj':
drivers/gpu/drm/i915/intel_display.c:2089:27: error: 'struct drm_crtc' has no 
member named 'fb'
   obj->stride = crtc->base.fb->pitches[0];
   ^
drivers/gpu/drm/i915/intel_display.c:2092:36: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.pixel_format = crtc->base.fb->pixel_format;
^
drivers/gpu/drm/i915/intel_display.c:2093:29: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.width = crtc->base.fb->width;
 ^
drivers/gpu/drm/i915/intel_display.c:2094:30: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.height = crtc->base.fb->height;
  ^
drivers/gpu/drm/i915/intel_display.c:2095:34: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.pitches[0] = crtc->base.fb->pitches[0];
  ^
In file included from arch/x86/include/asm/percpu.h:44:0,
 from arch/x86/include/asm/preempt.h:5,
 from include/linux/preempt.h:18,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/linux/stat.h:18,
 from include/linux/module.h:10,
 from drivers/gpu/drm/i915/intel_display.c:28:
drivers/gpu/drm/i915/intel_display.c:2099:65: error: 'struct drm_crtc' has no 
member named 'fb'
  if (intel_framebuffer_init(dev, to_intel_framebuffer(crtc->base.fb),
 ^
include/linux/kernel.h:833:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
 ^
drivers/gpu/drm/i915/intel_display.c:2099:34: note: in expansion of macro 
'to_intel_framebuffer'
  if (intel_framebuffer_init(dev, to_intel_framebuffer(crtc->base.fb),
  ^
drivers/gpu/drm/i915/intel_display.c: In function 'intel_find_plane_obj':
drivers/gpu/drm/i915/intel_display.c:2124:23: error: 'struct drm_crtc' has no 
member named 'fb'
  if (!intel_crtc->base.fb)
   ^
drivers/gpu/drm/i915/intel_display.c:2130:24: error: 'struct drm_crtc' has no 
member named 'fb'
  kfree(intel_crtc->base.fb);
^
drivers/gpu/drm/i915/intel_display.c:2131:18: error: 'struct drm_crtc' has no 
member named 'fb'
  intel_crtc->base.fb = NULL;
  ^
drivers/gpu/drm/i915/intel_display.c:2143:23: error: 'struct drm_crtc' has no 
member named 'fb'
   if (!i->active || !c->fb)
   ^
In file included from arch/x86/include/asm/percpu.h:44:0,
 from arch/x86/include/asm/preempt.h:5,
 from include/linux/preempt.h:18,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/linux/stat.h:18,
 from include/linux/module.h:10,
 from drivers/gpu/drm/i915/intel_display.c:28:
drivers/gpu/drm/i915/intel_display.c:2146:30: error: 'struct drm_crtc' has no 
member named 'fb'
   fb = to_intel_framebuffer(c->fb);
  ^
include/linux/kernel.h:833:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
 ^
drivers/gpu/drm/i915/intel_display.c:2146:8: note: in expansion of macro 
'to_intel_framebuffer'
   fb = to_intel_framebuffer(c->fb);
^
drivers/gpu/drm/i915/intel_display.c:2148:31: error: 'struct drm_crtc' has no 
member named 'fb'
drm_framebuffer_reference(c->fb);
   ^
drivers/gpu/drm/i915/intel_display.c:2149:20: error: 'struct drm_crtc' has no 
member named 'fb'
intel_crtc->base.fb = c->fb;
^
drivers/gpu/drm/i915/intel_display.c:2149:27: error: 'struct drm_crtc' has no 
member named 'fb'
intel_crtc->base.fb = c->fb;
   ^
drivers/gpu/drm/i915/intel_display.c: In function 'i9xx_get_plane_config':
drivers/gpu/drm/i915/intel_display.c:5745:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc->base.fb = kzalloc(sizeof(struct intel_framebuffer), GFP_KERNEL);
^
drivers/gpu/drm/i915/intel_display.c:5746:17: error: 'struct drm_crtc' has no 
member named 'fb'
  if (!crtc->base.fb) {
 ^
drivers/gpu/drm/i915/intel_display.c:5759:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc->base.fb->pixel_format = fourcc;
^
drivers/gpu/drm/i915/intel_display.c:5760:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc->base.fb->bits_per_pixel =
^

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/i915/intel_display.c: In function 'intel_alloc_plane_obj':
drivers/gpu/drm/i915/intel_display.c:2089:27: error: 'struct drm_crtc' has no 
member named 'fb'
   obj-stride = crtc-base.fb-pitches[0];
   ^
drivers/gpu/drm/i915/intel_display.c:2092:36: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.pixel_format = crtc-base.fb-pixel_format;
^
drivers/gpu/drm/i915/intel_display.c:2093:29: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.width = crtc-base.fb-width;
 ^
drivers/gpu/drm/i915/intel_display.c:2094:30: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.height = crtc-base.fb-height;
  ^
drivers/gpu/drm/i915/intel_display.c:2095:34: error: 'struct drm_crtc' has no 
member named 'fb'
  mode_cmd.pitches[0] = crtc-base.fb-pitches[0];
  ^
In file included from arch/x86/include/asm/percpu.h:44:0,
 from arch/x86/include/asm/preempt.h:5,
 from include/linux/preempt.h:18,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/linux/stat.h:18,
 from include/linux/module.h:10,
 from drivers/gpu/drm/i915/intel_display.c:28:
drivers/gpu/drm/i915/intel_display.c:2099:65: error: 'struct drm_crtc' has no 
member named 'fb'
  if (intel_framebuffer_init(dev, to_intel_framebuffer(crtc-base.fb),
 ^
include/linux/kernel.h:833:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)-member ) *__mptr = (ptr); \
 ^
drivers/gpu/drm/i915/intel_display.c:2099:34: note: in expansion of macro 
'to_intel_framebuffer'
  if (intel_framebuffer_init(dev, to_intel_framebuffer(crtc-base.fb),
  ^
drivers/gpu/drm/i915/intel_display.c: In function 'intel_find_plane_obj':
drivers/gpu/drm/i915/intel_display.c:2124:23: error: 'struct drm_crtc' has no 
member named 'fb'
  if (!intel_crtc-base.fb)
   ^
drivers/gpu/drm/i915/intel_display.c:2130:24: error: 'struct drm_crtc' has no 
member named 'fb'
  kfree(intel_crtc-base.fb);
^
drivers/gpu/drm/i915/intel_display.c:2131:18: error: 'struct drm_crtc' has no 
member named 'fb'
  intel_crtc-base.fb = NULL;
  ^
drivers/gpu/drm/i915/intel_display.c:2143:23: error: 'struct drm_crtc' has no 
member named 'fb'
   if (!i-active || !c-fb)
   ^
In file included from arch/x86/include/asm/percpu.h:44:0,
 from arch/x86/include/asm/preempt.h:5,
 from include/linux/preempt.h:18,
 from include/linux/spinlock.h:50,
 from include/linux/seqlock.h:35,
 from include/linux/time.h:5,
 from include/linux/stat.h:18,
 from include/linux/module.h:10,
 from drivers/gpu/drm/i915/intel_display.c:28:
drivers/gpu/drm/i915/intel_display.c:2146:30: error: 'struct drm_crtc' has no 
member named 'fb'
   fb = to_intel_framebuffer(c-fb);
  ^
include/linux/kernel.h:833:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)-member ) *__mptr = (ptr); \
 ^
drivers/gpu/drm/i915/intel_display.c:2146:8: note: in expansion of macro 
'to_intel_framebuffer'
   fb = to_intel_framebuffer(c-fb);
^
drivers/gpu/drm/i915/intel_display.c:2148:31: error: 'struct drm_crtc' has no 
member named 'fb'
drm_framebuffer_reference(c-fb);
   ^
drivers/gpu/drm/i915/intel_display.c:2149:20: error: 'struct drm_crtc' has no 
member named 'fb'
intel_crtc-base.fb = c-fb;
^
drivers/gpu/drm/i915/intel_display.c:2149:27: error: 'struct drm_crtc' has no 
member named 'fb'
intel_crtc-base.fb = c-fb;
   ^
drivers/gpu/drm/i915/intel_display.c: In function 'i9xx_get_plane_config':
drivers/gpu/drm/i915/intel_display.c:5745:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc-base.fb = kzalloc(sizeof(struct intel_framebuffer), GFP_KERNEL);
^
drivers/gpu/drm/i915/intel_display.c:5746:17: error: 'struct drm_crtc' has no 
member named 'fb'
  if (!crtc-base.fb) {
 ^
drivers/gpu/drm/i915/intel_display.c:5759:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc-base.fb-pixel_format = fourcc;
^
drivers/gpu/drm/i915/intel_display.c:5760:12: error: 'struct drm_crtc' has no 
member named 'fb'
  crtc-base.fb-bits_per_pixel =
^
drivers/gpu/drm/i915/intel_display.c:5775:12: error: 

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Wed, Mar 19, 2014 at 2:54 AM, Ben Widawsky  wrote:
> On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
>> On Wed, 19 Mar 2014 11:53:50 +1100
>> Stephen Rothwell  wrote:
>>
>>
>> > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
>> > from ring buffer in evict event").
>> >
>> > I have used the drm-intel tree from next-20140318 for today.
>> >
>>
>> Bah! I'm still suffering from jet lag (just came back from Linux-Tage
>> in Chemnitz).
>>
>> The next time I compile test a patch for a module, I'll make sure I have
>> that module's config option set :-(  The woe of using localmodconfig. I
>> should have picked the box with the i915. :-/
>>
>> Below is the fix. I'll repost a v2 of the original patch.
>>
>> Sorry about that.
>>
>
> I was about to send out the same fix when I saw this.
>
> Reviewed-by: Ben Widawsky 

Just fixed this this morning before starting to read mail - my
apologies the mess me pushing out a patch yesterday right before
rushing out caused, really shouldn't be doing that ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Wed, Mar 19, 2014 at 2:54 AM, Ben Widawsky b...@bwidawsk.net wrote:
 On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
 On Wed, 19 Mar 2014 11:53:50 +1100
 Stephen Rothwell s...@canb.auug.org.au wrote:


  Caused by commit a25ca17c1eac (drm/i915: Do not dereference pointers
  from ring buffer in evict event).
 
  I have used the drm-intel tree from next-20140318 for today.
 

 Bah! I'm still suffering from jet lag (just came back from Linux-Tage
 in Chemnitz).

 The next time I compile test a patch for a module, I'll make sure I have
 that module's config option set :-(  The woe of using localmodconfig. I
 should have picked the box with the i915. :-/

 Below is the fix. I'll repost a v2 of the original patch.

 Sorry about that.


 I was about to send out the same fix when I saw this.

 Reviewed-by: Ben Widawsky b...@bwidawsk.net

Just fixed this this morning before starting to read mail - my
apologies the mess me pushing out a patch yesterday right before
rushing out caused, really shouldn't be doing that ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Ben Widawsky]

On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
> On Wed, 19 Mar 2014 11:53:50 +1100
> Stephen Rothwell  wrote:
> 
> 
> > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
> > from ring buffer in evict event").
> > 
> > I have used the drm-intel tree from next-20140318 for today.
> > 
> 
> Bah! I'm still suffering from jet lag (just came back from Linux-Tage
> in Chemnitz).
> 
> The next time I compile test a patch for a module, I'll make sure I have
> that module's config option set :-(  The woe of using localmodconfig. I
> should have picked the box with the i915. :-/
> 
> Below is the fix. I'll repost a v2 of the original patch.
> 
> Sorry about that.
> 

I was about to send out the same fix when I saw this.

Reviewed-by: Ben Widawsky 

> -- Steve
> 
> diff --git a/drivers/gpu/drm/i915/i915_trace.h 
> b/drivers/gpu/drm/i915/i915_trace.h
> index f3e8a90..783ae08 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
>   ),
>  
>   TP_fast_assign(
> -__entry->dev = dev->primary->index;
> +__entry->dev = vm->dev->primary->index;
>  __entry->vm = vm;
> ),
>  
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Steven Rostedt]

On Wed, 19 Mar 2014 11:53:50 +1100
Stephen Rothwell  wrote:


> Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
> from ring buffer in evict event").
> 
> I have used the drm-intel tree from next-20140318 for today.
> 

Bah! I'm still suffering from jet lag (just came back from Linux-Tage
in Chemnitz).

The next time I compile test a patch for a module, I'll make sure I have
that module's config option set :-(  The woe of using localmodconfig. I
should have picked the box with the i915. :-/

Below is the fix. I'll repost a v2 of the original patch.

Sorry about that.

-- Steve

diff --git a/drivers/gpu/drm/i915/i915_trace.h 
b/drivers/gpu/drm/i915/i915_trace.h
index f3e8a90..783ae08 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
),
 
TP_fast_assign(
-  __entry->dev = dev->primary->index;
+  __entry->dev = vm->dev->primary->index;
   __entry->vm = vm;
  ),
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/trace/define_trace.h:90:0,
 from drivers/gpu/drm/i915/i915_trace.h:520,
 from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 
'ftrace_raw_event_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use 
in this function)
   __entry->dev = dev->primary->index;
  ^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^
drivers/gpu/drm/i915/./i915_trace.h:246:22: note: each undeclared identifier is 
reported only once for each function it appears in
   __entry->dev = dev->primary->index;
  ^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^
In file included from include/trace/define_trace.h:90:0,
 from drivers/gpu/drm/i915/i915_trace.h:520,
 from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 'perf_trace_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use 
in this function)
   __entry->dev = dev->primary->index;
  ^
include/trace/ftrace.h:708:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^

Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
from ring buffer in evict event").

I have used the drm-intel tree from next-20140318 for today.

-- 
Cheers,
Stephen Rothwell 


pgpVfa3HCVJ7H.pgp
Description: PGP signature

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/trace/define_trace.h:90:0,
 from drivers/gpu/drm/i915/i915_trace.h:520,
 from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 
'ftrace_raw_event_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use 
in this function)
   __entry-dev = dev-primary-index;
  ^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^
drivers/gpu/drm/i915/./i915_trace.h:246:22: note: each undeclared identifier is 
reported only once for each function it appears in
   __entry-dev = dev-primary-index;
  ^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^
In file included from include/trace/define_trace.h:90:0,
 from drivers/gpu/drm/i915/i915_trace.h:520,
 from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 'perf_trace_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use 
in this function)
   __entry-dev = dev-primary-index;
  ^
include/trace/ftrace.h:708:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }   \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
 PARAMS(assign), \
 ^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 
'TRACE_EVENT'
 TRACE_EVENT(i915_gem_evict_vm,
 ^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 
'TP_fast_assign'
  TP_fast_assign(
  ^

Caused by commit a25ca17c1eac (drm/i915: Do not dereference pointers
from ring buffer in evict event).

I have used the drm-intel tree from next-20140318 for today.

-- 
Cheers,
Stephen Rothwell s...@canb.auug.org.au


pgpVfa3HCVJ7H.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the drm-intel tree

[Steven Rostedt]

On Wed, 19 Mar 2014 11:53:50 +1100
Stephen Rothwell s...@canb.auug.org.au wrote:


 Caused by commit a25ca17c1eac (drm/i915: Do not dereference pointers
 from ring buffer in evict event).
 
 I have used the drm-intel tree from next-20140318 for today.
 

Bah! I'm still suffering from jet lag (just came back from Linux-Tage
in Chemnitz).

The next time I compile test a patch for a module, I'll make sure I have
that module's config option set :-(  The woe of using localmodconfig. I
should have picked the box with the i915. :-/

Below is the fix. I'll repost a v2 of the original patch.

Sorry about that.

-- Steve

diff --git a/drivers/gpu/drm/i915/i915_trace.h 
b/drivers/gpu/drm/i915/i915_trace.h
index f3e8a90..783ae08 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
),
 
TP_fast_assign(
-  __entry-dev = dev-primary-index;
+  __entry-dev = vm-dev-primary-index;
   __entry-vm = vm;
  ),
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

[Ben Widawsky]

On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
 On Wed, 19 Mar 2014 11:53:50 +1100
 Stephen Rothwell s...@canb.auug.org.au wrote:
 
 
  Caused by commit a25ca17c1eac (drm/i915: Do not dereference pointers
  from ring buffer in evict event).
  
  I have used the drm-intel tree from next-20140318 for today.
  
 
 Bah! I'm still suffering from jet lag (just came back from Linux-Tage
 in Chemnitz).
 
 The next time I compile test a patch for a module, I'll make sure I have
 that module's config option set :-(  The woe of using localmodconfig. I
 should have picked the box with the i915. :-/
 
 Below is the fix. I'll repost a v2 of the original patch.
 
 Sorry about that.
 

I was about to send out the same fix when I saw this.

Reviewed-by: Ben Widawsky b...@bwidawsk.net

 -- Steve
 
 diff --git a/drivers/gpu/drm/i915/i915_trace.h 
 b/drivers/gpu/drm/i915/i915_trace.h
 index f3e8a90..783ae08 100644
 --- a/drivers/gpu/drm/i915/i915_trace.h
 +++ b/drivers/gpu/drm/i915/i915_trace.h
 @@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
   ),
  
   TP_fast_assign(
 -__entry-dev = dev-primary-index;
 +__entry-dev = vm-dev-primary-index;
  __entry-vm = vm;
 ),
  
 ___
 Intel-gfx mailing list
 intel-...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Tue, Feb 19, 2013 at 3:01 AM, Stephen Rothwell  wrote:
> On Fri, 15 Feb 2013 08:16:26 -0800 Jesse Barnes  
> wrote:
>>
>> On Fri, 15 Feb 2013 10:30:16 +0100
>> Daniel Vetter  wrote:
>>
>> > On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell  
>> > wrote:
>> > >
>> > > After merging the drm-intel tree, today's linux-next build (x86_64
>> > > allmodconfig) failed like this:
>> > >
>> > > ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
>> > >
>> > > I have dropped the tree for today.
>> >
>> > Meh, that fail was already reported from Wu's kernel builder a few
>> > days ago, but no patch yet showed up to fix things. Since the i915
>> > side of that work isn't ready yet either I've dropped the offending
>> > patches.
>>
>> I sent a patch yesterday for this.  I'll bounce it over again.
>
> I am still getting that build failure.

Ok, should be really fixed now, my apologies for the mess.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Tue, Feb 19, 2013 at 3:01 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
 On Fri, 15 Feb 2013 08:16:26 -0800 Jesse Barnes jbar...@virtuousgeek.org 
 wrote:

 On Fri, 15 Feb 2013 10:30:16 +0100
 Daniel Vetter daniel.vet...@ffwll.ch wrote:

  On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell s...@canb.auug.org.au 
  wrote:
  
   After merging the drm-intel tree, today's linux-next build (x86_64
   allmodconfig) failed like this:
  
   ERROR: pm_vt_switch_unregister [drivers/video/fb.ko] undefined!
  
   I have dropped the tree for today.
 
  Meh, that fail was already reported from Wu's kernel builder a few
  days ago, but no patch yet showed up to fix things. Since the i915
  side of that work isn't ready yet either I've dropped the offending
  patches.

 I sent a patch yesterday for this.  I'll bounce it over again.

 I am still getting that build failure.

Ok, should be really fixed now, my apologies for the mess.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi Daniel,

On Fri, 15 Feb 2013 08:16:26 -0800 Jesse Barnes  
wrote:
>
> On Fri, 15 Feb 2013 10:30:16 +0100
> Daniel Vetter  wrote:
> 
> > On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell  
> > wrote:
> > >
> > > After merging the drm-intel tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
> > >
> > > I have dropped the tree for today.
> > 
> > Meh, that fail was already reported from Wu's kernel builder a few
> > days ago, but no patch yet showed up to fix things. Since the i915
> > side of that work isn't ready yet either I've dropped the offending
> > patches.
> 
> I sent a patch yesterday for this.  I'll bounce it over again.

I am still getting that build failure.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgptF3sDub_xA.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi Daniel,

On Fri, 15 Feb 2013 08:16:26 -0800 Jesse Barnes jbar...@virtuousgeek.org 
wrote:

 On Fri, 15 Feb 2013 10:30:16 +0100
 Daniel Vetter daniel.vet...@ffwll.ch wrote:
 
  On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell s...@canb.auug.org.au 
  wrote:
  
   After merging the drm-intel tree, today's linux-next build (x86_64
   allmodconfig) failed like this:
  
   ERROR: pm_vt_switch_unregister [drivers/video/fb.ko] undefined!
  
   I have dropped the tree for today.
  
  Meh, that fail was already reported from Wu's kernel builder a few
  days ago, but no patch yet showed up to fix things. Since the i915
  side of that work isn't ready yet either I've dropped the offending
  patches.
 
 I sent a patch yesterday for this.  I'll bounce it over again.

I am still getting that build failure.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgptF3sDub_xA.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the drm-intel tree

[Jesse Barnes]

On Fri, 15 Feb 2013 10:30:16 +0100
Daniel Vetter  wrote:

> On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell  
> wrote:
> > Hi all,
> >
> > After merging the drm-intel tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
> >
> > I have dropped the tree for today.
> 
> Meh, that fail was already reported from Wu's kernel builder a few
> days ago, but no patch yet showed up to fix things. Since the i915
> side of that work isn't ready yet either I've dropped the offending
> patches.

I sent a patch yesterday for this.  I'll bounce it over again.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell  wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!
>
> I have dropped the tree for today.

Meh, that fail was already reported from Wu's kernel builder a few
days ago, but no patch yet showed up to fix things. Since the i915
side of that work isn't ready yet either I've dropped the offending
patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Daniel Vetter]

On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi all,

 After merging the drm-intel tree, today's linux-next build (x86_64
 allmodconfig) failed like this:

 ERROR: pm_vt_switch_unregister [drivers/video/fb.ko] undefined!

 I have dropped the tree for today.

Meh, that fail was already reported from Wu's kernel builder a few
days ago, but no patch yet showed up to fix things. Since the i915
side of that work isn't ready yet either I've dropped the offending
patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the drm-intel tree

[Jesse Barnes]

On Fri, 15 Feb 2013 10:30:16 +0100
Daniel Vetter daniel.vet...@ffwll.ch wrote:

 On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell s...@canb.auug.org.au 
 wrote:
  Hi all,
 
  After merging the drm-intel tree, today's linux-next build (x86_64
  allmodconfig) failed like this:
 
  ERROR: pm_vt_switch_unregister [drivers/video/fb.ko] undefined!
 
  I have dropped the tree for today.
 
 Meh, that fail was already reported from Wu's kernel builder a few
 days ago, but no patch yet showed up to fix things. Since the i915
 side of that work isn't ready yet either I've dropped the offending
 patches.

I sent a patch yesterday for this.  I'll bounce it over again.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined!

I have dropped the tree for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpYalkFY222s.pgp
Description: PGP signature

linux-next: build failure after merge of the drm-intel tree

[Stephen Rothwell]

Hi all,

After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: pm_vt_switch_unregister [drivers/video/fb.ko] undefined!

I have dropped the tree for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpYalkFY222s.pgp
Description: PGP signature