Re: linux-next: build failure after merge of the phy-next tree
On 01-12-20, 07:45, Sergio Paracuellos wrote:
> Hi Stephen,
>
> On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell wrote:
> >
> > Hi all,
> >
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such
> > file or directory
> >17 | #include
> > | ^~
> >
> > Caused by commit
> >
> > d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
>
> This driver has two includes which are in
> "arch/mips/include/asm/mach-ralink" and are directly included in the
> driver:
> * mt7621.h
> * ralink_regs.h
>
> This is because this path is directly included in
> arch/mips/ralink/Platform for "ralink":
>
> #
> # Ralink SoC common stuff
> #
> cflags-$(CONFIG_RALINK) += -I$(srctree)/arch/mips/include/asm/mach-ralink
>
> and this driver directly depends on RALINK or COMPILE_TEST (which
> might be the problem here):
>
>
> and this driver directly depends
> on RALINK or COMPILE_TEST:
>
> config PHY_MT7621_PCI
> tristate "MediaTek MT7621 PCI PHY Driver"
> depends on (RALINK || COMPILE_TEST) && OF
> select GENERIC_PHY
> select REGMAP_MMIO
> help
> Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver
>
> >
> > I have reverted that commit for today.
>
> What is the correct way of fixing this? Include complete path for both
> of them like this?
>
> index db79088d5362..cebd53f5a797 100644
> --- a/drivers/phy/ralink/phy-mt7621-pci.c
> +++ b/drivers/phy/ralink/phy-mt7621-pci.c
> @@ -14,8 +14,8 @@
> #include
> #include
> #include
> -#include
> -#include
> +#include
> +#include
>
> Vinod, please let me know if you want me to send anything for fixing this.
Yes this makes sense. this will ensure it gets picked up and doesn't
depend in arch specific stuff
--
~Vinod
Re: linux-next: build failure after merge of the phy-next tree
Hi Stephen,
On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such
> file or directory
>17 | #include
> | ^~
>
> Caused by commit
>
> d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h
This is because this path is directly included in
arch/mips/ralink/Platform for "ralink":
#
# Ralink SoC common stuff
#
cflags-$(CONFIG_RALINK) += -I$(srctree)/arch/mips/include/asm/mach-ralink
and this driver directly depends on RALINK or COMPILE_TEST (which
might be the problem here):
and this driver directly depends
on RALINK or COMPILE_TEST:
config PHY_MT7621_PCI
tristate "MediaTek MT7621 PCI PHY Driver"
depends on (RALINK || COMPILE_TEST) && OF
select GENERIC_PHY
select REGMAP_MMIO
help
Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver
>
> I have reverted that commit for today.
What is the correct way of fixing this? Include complete path for both
of them like this?
index db79088d5362..cebd53f5a797 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -14,8 +14,8 @@
#include
#include
#include
-#include
-#include
+#include
+#include
Vinod, please let me know if you want me to send anything for fixing this.
>
> --
> Cheers,
> Stephen Rothwell
Best regards,
Sergio Paracuellos
linux-next: build failure after merge of the phy-next tree
Hi all,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file
or directory
17 | #include
| ^~
Caused by commit
d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
pgpGKECLV4LT1.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the phy-next tree
On 18-11-20, 13:56, Stephen Rothwell wrote:
> Hi Vinod,
>
> On Tue, 17 Nov 2020 15:30:56 +0530 Vinod Koul wrote:
> >
> > On 17-11-20, 13:40, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the phy-next tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > drivers/soc/amlogic/meson-ee-pwrc.c: In function
> > > 'meson_ee_pwrc_init_domain':
> > > drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before
> > > 'if'
> > > 416 | dom->rstc = devm_reset_control_array_get_exclusive(>dev)
> > > | ^
> > > | ;
> > > 417 | if (IS_ERR(dom->rstc))
> > > | ~~
> > >
> > > Caused by commit
> > >
> > > 3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
> > >
> > > I have used the phy-next tree from next-20201116 for today.
> >
> > I have reverted this commit
>
> Thanks, but forgot to push out?
Precisely :( Fixed now, sorry for the trouble
--
~Vinod
Re: linux-next: build failure after merge of the phy-next tree
Hi Vinod,
On Tue, 17 Nov 2020 15:30:56 +0530 Vinod Koul wrote:
>
> On 17-11-20, 13:40, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the phy-next tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/soc/amlogic/meson-ee-pwrc.c: In function
> > 'meson_ee_pwrc_init_domain':
> > drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
> > 416 | dom->rstc = devm_reset_control_array_get_exclusive(>dev)
> > | ^
> > | ;
> > 417 | if (IS_ERR(dom->rstc))
> > | ~~
> >
> > Caused by commit
> >
> > 3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
> >
> > I have used the phy-next tree from next-20201116 for today.
>
> I have reverted this commit
Thanks, but forgot to push out?
--
Cheers,
Stephen Rothwell
pgpEzxOlR4qtH.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the phy-next tree
Hello Stephen,
On 17-11-20, 13:40, Stephen Rothwell wrote:
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
> drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
> 416 | dom->rstc = devm_reset_control_array_get_exclusive(>dev)
> | ^
> | ;
> 417 | if (IS_ERR(dom->rstc))
> | ~~
>
> Caused by commit
>
> 3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
>
> I have used the phy-next tree from next-20201116 for today.
I have reverted this commit
Thanks for the report
--
~Vinod
linux-next: build failure after merge of the phy-next tree
Hi all,
After merging the phy-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
416 | dom->rstc = devm_reset_control_array_get_exclusive(>dev)
| ^
| ;
417 | if (IS_ERR(dom->rstc))
| ~~
Caused by commit
3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
I have used the phy-next tree from next-20201116 for today.
--
Cheers,
Stephen Rothwell
pgpOhJGoS3zxJ.pgp
Description: OpenPGP digital signature
linux-next: build failure after merge of the phy-next tree
Hi all,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: "__arm_smccc_smc" [drivers/phy/marvell/phy-mvebu-cp110-comphy.ko]
undefined!
Caused by commit
ccee80654309 ("phy: mvebu-cp110-comphy: Add SMC call support")
I have used the phy-next tree from next-20190826 for today.
--
Cheers,
Stephen Rothwell
pgpcsCZMbwn6u.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the phy-next tree
Hi,
On Thursday 30 March 2017 09:17 AM, Stephen Rothwell wrote:
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field
> 'phy_tuning' specified in initializer
>.phy_tuning = rk3328_usb2phy_tuning,
>^
> drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning'
> undeclared here (not in a function)
>.phy_tuning = rk3328_usb2phy_tuning,
> ^
>
> Caused by commit
>
> ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")
>
> I have used the phy-next tree from next-20170329 for today.
Thanks for reporting this. Will fix it in my tree.
-Kishon
Re: linux-next: build failure after merge of the phy-next tree
Hi,
On Thursday 30 March 2017 09:17 AM, Stephen Rothwell wrote:
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field
> 'phy_tuning' specified in initializer
>.phy_tuning = rk3328_usb2phy_tuning,
>^
> drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning'
> undeclared here (not in a function)
>.phy_tuning = rk3328_usb2phy_tuning,
> ^
>
> Caused by commit
>
> ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")
>
> I have used the phy-next tree from next-20170329 for today.
Thanks for reporting this. Will fix it in my tree.
-Kishon
linux-next: build failure after merge of the phy-next tree
Hi Kishon,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field 'phy_tuning'
specified in initializer
.phy_tuning = rk3328_usb2phy_tuning,
^
drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning'
undeclared here (not in a function)
.phy_tuning = rk3328_usb2phy_tuning,
^
Caused by commit
ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")
I have used the phy-next tree from next-20170329 for today.
--
Cheers,
Stephen Rothwell
linux-next: build failure after merge of the phy-next tree
Hi Kishon,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field 'phy_tuning'
specified in initializer
.phy_tuning = rk3328_usb2phy_tuning,
^
drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning'
undeclared here (not in a function)
.phy_tuning = rk3328_usb2phy_tuning,
^
Caused by commit
ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")
I have used the phy-next tree from next-20170329 for today.
--
Cheers,
Stephen Rothwell
