Re: linux-next: build failure after merge of the regulator tree

[Bartosz Golaszewski]

wt., 3 wrz 2019 o 06:26 Stephen Rothwell  napisał(a):
>
> Hi all,
>
> After merging the regulator tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: drivers/ata/ahci.o:(.opd+0x150): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/ata/ahci.o: in function `.regulator_bulk_set_supply_names':
> ahci.c:(.text+0x1780): multiple definition of 
> `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): 
> first defined here
> ld: drivers/ata/libahci.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x84a0): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/ata/libahci.o:(.opd+0x5d0): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/ata/sata_mv.o:(.opd+0x690): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/ata/sata_mv.o: in function `.regulator_bulk_set_supply_names':
> sata_mv.c:(.text+0xb9b0): multiple definition of 
> `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): 
> first defined here
> ld: drivers/usb/common/common.o: in function 
> `.regulator_bulk_set_supply_names':
> (.text+0x7d0): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/common/common.o:(.opd+0x120): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/usb.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x17d0): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/usb.o:(.opd+0x348): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/hub.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x2610): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/hub.o:(.opd+0x378): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/hcd.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x3020): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/hcd.o:(.opd+0x378): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/message.o: in function 
> `.regulator_bulk_set_supply_names':
> (.text+0x2350): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/message.o:(.opd+0x240): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/phy.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x700): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/phy.o:(.opd+0xc0): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/core/of.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x2f0): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/of.o:(.opd+0x48): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/phy/of.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x120): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/phy/of.o:(.opd+0x18): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/host/ehci-hcd.o: in function 
> `.regulator_bulk_set_supply_names':
> (.text+0x11830): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/host/ehci-hcd.o:(.opd+0x8d0): multiple definition of 
> `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
> defined here
> ld: drivers/usb/host/ohci-hcd.o: in function 
> `.regulator_bulk_set_supply_names':
> (.text+0xe8d0): multiple definition of `.regulator_bulk_set_supply_names'; 
> drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: 

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: drivers/ata/ahci.o:(.opd+0x150): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/ata/ahci.o: in function `.regulator_bulk_set_supply_names':
ahci.c:(.text+0x1780): multiple definition of 
`.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): 
first defined here
ld: drivers/ata/libahci.o: in function `.regulator_bulk_set_supply_names':
(.text+0x84a0): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/ata/libahci.o:(.opd+0x5d0): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/ata/sata_mv.o:(.opd+0x690): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/ata/sata_mv.o: in function `.regulator_bulk_set_supply_names':
sata_mv.c:(.text+0xb9b0): multiple definition of 
`.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): 
first defined here
ld: drivers/usb/common/common.o: in function `.regulator_bulk_set_supply_names':
(.text+0x7d0): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/common/common.o:(.opd+0x120): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/usb.o: in function `.regulator_bulk_set_supply_names':
(.text+0x17d0): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/usb.o:(.opd+0x348): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/hub.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2610): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/hub.o:(.opd+0x378): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0x3020): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/hcd.o:(.opd+0x378): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/message.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2350): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/message.o:(.opd+0x240): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/phy.o: in function `.regulator_bulk_set_supply_names':
(.text+0x700): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/phy.o:(.opd+0xc0): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/core/of.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2f0): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/of.o:(.opd+0x48): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/phy/of.o: in function `.regulator_bulk_set_supply_names':
(.text+0x120): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/phy/of.o:(.opd+0x18): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/host/ehci-hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0x11830): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/host/ehci-hcd.o:(.opd+0x8d0): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/usb/host/ohci-hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0xe8d0): multiple definition of `.regulator_bulk_set_supply_names'; 
drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/host/ohci-hcd.o:(.opd+0x570): multiple definition of 
`regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first 
defined here
ld: drivers/of/platform.o: in function `.regulator_bulk_set_supply_names':

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mt6358-regulator.c:5:10: fatal error: 
linux/mfd/mt6358/registers.h: No such file or directory
 #include 
  ^~

Caused by commit

  f67ff1bd58f0 ("regulator: mt6358: Add support for MT6358 regulator")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell


pgp9FNuSWoypW.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Dmitry Osipenko]

On 20.11.2018 3:49, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
> ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!
> 
> Caused by commit
> 
>   f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
> 
> I have used the regulator tree from next-20181119 for today.
> 

My bad, forgot to export these functions. That's the same issue that was 
reporter by the build robot earlier. Will send the fix, sorry for the 
inconvenience.

Re: linux-next: build failure after merge of the regulator tree

[Dmitry Osipenko]

On 20.11.2018 3:49, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
> ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!
> 
> Caused by commit
> 
>   f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
> 
> I have used the regulator tree from next-20181119 for today.
> 

My bad, forgot to export these functions. That's the same issue that was 
reporter by the build robot earlier. Will send the fix, sorry for the 
inconvenience.

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!

Caused by commit

  f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")

I have used the regulator tree from next-20181119 for today.

-- 
Cheers,
Stephen Rothwell


pgpT42Gw0sVkS.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!

Caused by commit

  f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")

I have used the regulator tree from next-20181119 for today.

-- 
Cheers,
Stephen Rothwell


pgpT42Gw0sVkS.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Fri, Feb 03, 2017 at 09:30:04AM +1100, Stephen Rothwell wrote:

> > Discarded that commit.

> The patch is still there ...

Only in the merge branch, it got dropped from the source branch but the
merge ended up not being rebuilt.


signature.asc
Description: PGP signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Fri, Feb 03, 2017 at 09:30:04AM +1100, Stephen Rothwell wrote:

> > Discarded that commit.

> The patch is still there ...

Only in the merge branch, it got dropped from the source branch but the
merge ended up not being rebuilt.


signature.asc
Description: PGP signature

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi Mark,

On Wed, 1 Feb 2017 10:03:43 + Mark Brown  wrote:
>
> On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:
> 
> > Caused by commit
> > 
> >   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops 
> > structure")
> > 
> > I can only assume that this patch has been rebased since it was tested.  
> 
> Discarded that commit.

The patch is still there ...

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi Mark,

On Wed, 1 Feb 2017 10:03:43 + Mark Brown  wrote:
>
> On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:
> 
> > Caused by commit
> > 
> >   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops 
> > structure")
> > 
> > I can only assume that this patch has been rebased since it was tested.  
> 
> Discarded that commit.

The patch is still there ...

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:

> Caused by commit
> 
>   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops 
> structure")
> 
> I can only assume that this patch has been rebased since it was tested.

Discarded that commit.


signature.asc
Description: PGP signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:

> Caused by commit
> 
>   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops 
> structure")
> 
> I can only assume that this patch has been rebased since it was tested.

Discarded that commit.


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:310:24: error: assignment of member 
'enable' in read-only object
anatop_rops.enable  = regulator_enable_regmap;
^
drivers/regulator/anatop-regulator.c:311:24: error: assignment of member 
'disable' in read-only object
anatop_rops.disable = regulator_disable_regmap;
^
drivers/regulator/anatop-regulator.c:312:27: error: assignment of member 
'is_enabled' in read-only object
anatop_rops.is_enabled = regulator_is_enabled_regmap;
   ^

Caused by commit

  524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops structure")

I can only assume that this patch has been rebased since it was tested.

I have used the regulator tree from next-20170131 for today.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:310:24: error: assignment of member 
'enable' in read-only object
anatop_rops.enable  = regulator_enable_regmap;
^
drivers/regulator/anatop-regulator.c:311:24: error: assignment of member 
'disable' in read-only object
anatop_rops.disable = regulator_disable_regmap;
^
drivers/regulator/anatop-regulator.c:312:27: error: assignment of member 
'is_enabled' in read-only object
anatop_rops.is_enabled = regulator_is_enabled_regmap;
   ^

Caused by commit

  524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops structure")

I can only assume that this patch has been rebased since it was tested.

I have used the regulator tree from next-20170131 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the regulator tree

[Dave Airlie]

On 14 April 2015 at 19:40, Mark Brown  wrote:
> On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
>> On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
>>  wrote:
>
>> > Your patch looks correct and should preferrably be added to the drm
>> > tree, or the last patch in my series that drops the API wrapper should
>> > be held back until rc1(?)
>
>> It needs to be sent to Linus as a merge fix when the drm tree is merged.
>
> Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
> specifically for this branch if you like?

I can just backmerge Linus's tree before I send it to him, and stick
this patch on top.

seems like the best answer.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
> On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
>  wrote:

> > Your patch looks correct and should preferrably be added to the drm
> > tree, or the last patch in my series that drops the API wrapper should
> > be held back until rc1(?)

> It needs to be sent to Linus as a merge fix when the drm tree is merged.

Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
specifically for this branch if you like?


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
 On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
 bjorn.anders...@sonymobile.com wrote:

  Your patch looks correct and should preferrably be added to the drm
  tree, or the last patch in my series that drops the API wrapper should
  be held back until rc1(?)

 It needs to be sent to Linus as a merge fix when the drm tree is merged.

Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
specifically for this branch if you like?


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Dave Airlie]

On 14 April 2015 at 19:40, Mark Brown broo...@kernel.org wrote:
 On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
 On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
 bjorn.anders...@sonymobile.com wrote:

  Your patch looks correct and should preferrably be added to the drm
  tree, or the last patch in my series that drops the API wrapper should
  be held back until rc1(?)

 It needs to be sent to Linus as a merge fix when the drm tree is merged.

 Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
 specifically for this branch if you like?

I can just backmerge Linus's tree before I send it to him, and stick
this patch on top.

seems like the best answer.

Dave.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi Bjorn,

On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
 wrote:
>
> What Mark mean is basically that there shouldn't be any users of
> regulator_set_optimum_mode() for various reasons and we introduced
> regulator_set_load() to solve these, before any users popped up.
> 
> Unfortunately we weren't fast enough and people got some code in that
> uses the API that isn't implemented for any Qualcomm platform today...

Ah, OK.

> Your patch looks correct and should preferrably be added to the drm
> tree, or the last patch in my series that drops the API wrapper should
> be held back until rc1(?)

It needs to be sent to Linus as a merge fix when the drm tree is merged.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpBZBQT2ttch.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Bjorn Andersson]

On Mon 13 Apr 16:44 PDT 2015, Stephen Rothwell wrote:

> Hi all,
> 
> On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown  wrote:
> >
> > On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
> > 
> > > After merging the regulator tree, today's linux-next build (arm 
> > > multi_v7_defconfig)
> > > failed like this:
> > 
> > > drivers/gpu/drm/msm/dsi/dsi_host.c: In function 
> > > 'dsi_host_regulator_disable':
> > > drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
> > > function 'regulator_set_optimum_mode' 
> > > [-Werror=implicit-function-declaration]
> > > regulator_set_optimum_mode(s[i].consumer,
> > > ^
> > 
> > > Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> > > support") from the drm tree interacting with commit ae6e808f1574
> > > ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> > > the regulator tree.
> > 
> > > This happens every time someone renames/changes an API :-(
> > 
> > It's *really* questionable if anyone should be using that API in the
> > first place, one of the reasons it's being removed is that it's really
> > unclear that anything would be able to successfully use it as-is.  The
> > easist thing might be to drop the new usage for the time being.
> 
> This fix up patch is now needed when the drm tree is merged with Linus'
> tree (the regulator part has been merged).
> 
> Mark, what did you above response mean?  Should the drm tree be using
> something different?
> 

What Mark mean is basically that there shouldn't be any users of
regulator_set_optimum_mode() for various reasons and we introduced
regulator_set_load() to solve these, before any users popped up.

Unfortunately we weren't fast enough and people got some code in that
uses the API that isn't implemented for any Qualcomm platform today...


Your patch looks correct and should preferrably be added to the drm
tree, or the last patch in my series that drops the API wrapper should
be held back until rc1(?)

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown  wrote:
>
> On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
> 
> > After merging the regulator tree, today's linux-next build (arm 
> > multi_v7_defconfig)
> > failed like this:
> 
> > drivers/gpu/drm/msm/dsi/dsi_host.c: In function 
> > 'dsi_host_regulator_disable':
> > drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
> > function 'regulator_set_optimum_mode' 
> > [-Werror=implicit-function-declaration]
> > regulator_set_optimum_mode(s[i].consumer,
> > ^
> 
> > Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> > support") from the drm tree interacting with commit ae6e808f1574
> > ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> > the regulator tree.
> 
> > This happens every time someone renames/changes an API :-(
> 
> It's *really* questionable if anyone should be using that API in the
> first place, one of the reasons it's being removed is that it's really
> unclear that anything would be able to successfully use it as-is.  The
> easist thing might be to drop the new usage for the time being.

This fix up patch is now needed when the drm tree is merged with Linus'
tree (the regulator part has been merged).

Mark, what did you above response mean?  Should the drm tree be using
something different?

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpYEHfgD4xh_.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown broo...@kernel.org wrote:

 On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
 
  After merging the regulator tree, today's linux-next build (arm 
  multi_v7_defconfig)
  failed like this:
 
  drivers/gpu/drm/msm/dsi/dsi_host.c: In function 
  'dsi_host_regulator_disable':
  drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
  function 'regulator_set_optimum_mode' 
  [-Werror=implicit-function-declaration]
  regulator_set_optimum_mode(s[i].consumer,
  ^
 
  Caused by commit a689554ba6ed (drm/msm: Initial add DSI connector
  support) from the drm tree interacting with commit ae6e808f1574
  (regulator: Drop temporary regulator_set_optimum_mode wrapper) from
  the regulator tree.
 
  This happens every time someone renames/changes an API :-(
 
 It's *really* questionable if anyone should be using that API in the
 first place, one of the reasons it's being removed is that it's really
 unclear that anything would be able to successfully use it as-is.  The
 easist thing might be to drop the new usage for the time being.

This fix up patch is now needed when the drm tree is merged with Linus'
tree (the regulator part has been merged).

Mark, what did you above response mean?  Should the drm tree be using
something different?

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpYEHfgD4xh_.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Bjorn Andersson]

On Mon 13 Apr 16:44 PDT 2015, Stephen Rothwell wrote:

 Hi all,
 
 On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown broo...@kernel.org wrote:
 
  On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
  
   After merging the regulator tree, today's linux-next build (arm 
   multi_v7_defconfig)
   failed like this:
  
   drivers/gpu/drm/msm/dsi/dsi_host.c: In function 
   'dsi_host_regulator_disable':
   drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
   function 'regulator_set_optimum_mode' 
   [-Werror=implicit-function-declaration]
   regulator_set_optimum_mode(s[i].consumer,
   ^
  
   Caused by commit a689554ba6ed (drm/msm: Initial add DSI connector
   support) from the drm tree interacting with commit ae6e808f1574
   (regulator: Drop temporary regulator_set_optimum_mode wrapper) from
   the regulator tree.
  
   This happens every time someone renames/changes an API :-(
  
  It's *really* questionable if anyone should be using that API in the
  first place, one of the reasons it's being removed is that it's really
  unclear that anything would be able to successfully use it as-is.  The
  easist thing might be to drop the new usage for the time being.
 
 This fix up patch is now needed when the drm tree is merged with Linus'
 tree (the regulator part has been merged).
 
 Mark, what did you above response mean?  Should the drm tree be using
 something different?
 

What Mark mean is basically that there shouldn't be any users of
regulator_set_optimum_mode() for various reasons and we introduced
regulator_set_load() to solve these, before any users popped up.

Unfortunately we weren't fast enough and people got some code in that
uses the API that isn't implemented for any Qualcomm platform today...


Your patch looks correct and should preferrably be added to the drm
tree, or the last patch in my series that drops the API wrapper should
be held back until rc1(?)

Regards,
Bjorn
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi Bjorn,

On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson 
bjorn.anders...@sonymobile.com wrote:

 What Mark mean is basically that there shouldn't be any users of
 regulator_set_optimum_mode() for various reasons and we introduced
 regulator_set_load() to solve these, before any users popped up.
 
 Unfortunately we weren't fast enough and people got some code in that
 uses the API that isn't implemented for any Qualcomm platform today...

Ah, OK.

 Your patch looks correct and should preferrably be added to the drm
 tree, or the last patch in my series that drops the API wrapper should
 be held back until rc1(?)

It needs to be sent to Linus as a merge fix when the drm tree is merged.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpBZBQT2ttch.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Rob Clark]

On Thu, Apr 9, 2015 at 12:33 AM, Stephen Rothwell  wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (arm 
> multi_v7_defconfig)
> failed like this:
>
> drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
> function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
> regulator_set_optimum_mode(s[i].consumer,
> ^
>
> Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> support") from the drm tree interacting with commit ae6e808f1574
> ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> the regulator tree.

Thanks.. btw, would it be possible to get my msm-next branch picked up
by linux-next?  That seems like it would help to catch these earlier..

 git://people.freedesktop.org/~robclark/linux msm-next

BR,
-R

> This happens every time someone renames/changes an API :-(
>
> I have applied the following merge fix patch.  Someone needs to make
> sure Linus finds out when the latter of these two trees is merged into
> his.
>
> From: Stephen Rothwell 
> Date: Thu, 9 Apr 2015 14:28:42 +1000
> Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change
>
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 9 -
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index fdc54e3eff55..962cf545d24c 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct 
> msm_dsi_host *msm_host)
> DBG("");
> for (i = num - 1; i >= 0; i--)
> if (regs[i].disable_load >= 0)
> -   regulator_set_optimum_mode(s[i].consumer,
> -   regs[i].disable_load);
> +   regulator_set_load(s[i].consumer, 
> regs[i].disable_load);
>
> regulator_bulk_disable(num, s);
>  }
> @@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
> *msm_host)
> DBG("");
> for (i = 0; i < num; i++) {
> if (regs[i].enable_load >= 0) {
> -   ret = regulator_set_optimum_mode(s[i].consumer,
> -   regs[i].enable_load);
> +   ret = regulator_set_load(s[i].consumer,
> +   regs[i].enable_load);
> if (ret < 0) {
> pr_err("regulator %d set op mode failed, 
> %d\n",
> i, ret);
> @@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
> *msm_host)
>
>  fail:
> for (i--; i >= 0; i--)
> -   regulator_set_optimum_mode(s[i].consumer, 
> regs[i].disable_load);
> +   regulator_set_load(s[i].consumer, regs[i].disable_load);
> return ret;
>  }
>
> --
> 2.1.4
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:

> After merging the regulator tree, today's linux-next build (arm 
> multi_v7_defconfig)
> failed like this:

> drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
> function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
> regulator_set_optimum_mode(s[i].consumer,
> ^

> Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> support") from the drm tree interacting with commit ae6e808f1574
> ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> the regulator tree.

> This happens every time someone renames/changes an API :-(

It's *really* questionable if anyone should be using that API in the
first place, one of the reasons it's being removed is that it's really
unclear that anything would be able to successfully use it as-is.  The
easist thing might be to drop the new usage for the time being.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Rob Clark]

On Thu, Apr 9, 2015 at 12:33 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi all,

 After merging the regulator tree, today's linux-next build (arm 
 multi_v7_defconfig)
 failed like this:

 drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
 drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
 function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
 regulator_set_optimum_mode(s[i].consumer,
 ^

 Caused by commit a689554ba6ed (drm/msm: Initial add DSI connector
 support) from the drm tree interacting with commit ae6e808f1574
 (regulator: Drop temporary regulator_set_optimum_mode wrapper) from
 the regulator tree.

Thanks.. btw, would it be possible to get my msm-next branch picked up
by linux-next?  That seems like it would help to catch these earlier..

 git://people.freedesktop.org/~robclark/linux msm-next

BR,
-R

 This happens every time someone renames/changes an API :-(

 I have applied the following merge fix patch.  Someone needs to make
 sure Linus finds out when the latter of these two trees is merged into
 his.

 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Thu, 9 Apr 2015 14:28:42 +1000
 Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change

 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  drivers/gpu/drm/msm/dsi/dsi_host.c | 9 -
  1 file changed, 4 insertions(+), 5 deletions(-)

 diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
 b/drivers/gpu/drm/msm/dsi/dsi_host.c
 index fdc54e3eff55..962cf545d24c 100644
 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
 +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
 @@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct 
 msm_dsi_host *msm_host)
 DBG();
 for (i = num - 1; i = 0; i--)
 if (regs[i].disable_load = 0)
 -   regulator_set_optimum_mode(s[i].consumer,
 -   regs[i].disable_load);
 +   regulator_set_load(s[i].consumer, 
 regs[i].disable_load);

 regulator_bulk_disable(num, s);
  }
 @@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
 *msm_host)
 DBG();
 for (i = 0; i  num; i++) {
 if (regs[i].enable_load = 0) {
 -   ret = regulator_set_optimum_mode(s[i].consumer,
 -   regs[i].enable_load);
 +   ret = regulator_set_load(s[i].consumer,
 +   regs[i].enable_load);
 if (ret  0) {
 pr_err(regulator %d set op mode failed, 
 %d\n,
 i, ret);
 @@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
 *msm_host)

  fail:
 for (i--; i = 0; i--)
 -   regulator_set_optimum_mode(s[i].consumer, 
 regs[i].disable_load);
 +   regulator_set_load(s[i].consumer, regs[i].disable_load);
 return ret;
  }

 --
 2.1.4

 --
 Cheers,
 Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:

 After merging the regulator tree, today's linux-next build (arm 
 multi_v7_defconfig)
 failed like this:

 drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
 drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
 function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
 regulator_set_optimum_mode(s[i].consumer,
 ^

 Caused by commit a689554ba6ed (drm/msm: Initial add DSI connector
 support) from the drm tree interacting with commit ae6e808f1574
 (regulator: Drop temporary regulator_set_optimum_mode wrapper) from
 the regulator tree.

 This happens every time someone renames/changes an API :-(

It's *really* questionable if anyone should be using that API in the
first place, one of the reasons it's being removed is that it's really
unclear that anything would be able to successfully use it as-is.  The
easist thing might be to drop the new usage for the time being.


signature.asc
Description: Digital signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm 
multi_v7_defconfig)
failed like this:

drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
regulator_set_optimum_mode(s[i].consumer,
^

Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
support") from the drm tree interacting with commit ae6e808f1574
("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
the regulator tree.

This happens every time someone renames/changes an API :-(

I have applied the following merge fix patch.  Someone needs to make
sure Linus finds out when the latter of these two trees is merged into
his.

From: Stephen Rothwell 
Date: Thu, 9 Apr 2015 14:28:42 +1000
Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell 
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index fdc54e3eff55..962cf545d24c 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct msm_dsi_host 
*msm_host)
DBG("");
for (i = num - 1; i >= 0; i--)
if (regs[i].disable_load >= 0)
-   regulator_set_optimum_mode(s[i].consumer,
-   regs[i].disable_load);
+   regulator_set_load(s[i].consumer, regs[i].disable_load);
 
regulator_bulk_disable(num, s);
 }
@@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
*msm_host)
DBG("");
for (i = 0; i < num; i++) {
if (regs[i].enable_load >= 0) {
-   ret = regulator_set_optimum_mode(s[i].consumer,
-   regs[i].enable_load);
+   ret = regulator_set_load(s[i].consumer,
+   regs[i].enable_load);
if (ret < 0) {
pr_err("regulator %d set op mode failed, %d\n",
i, ret);
@@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
*msm_host)
 
 fail:
for (i--; i >= 0; i--)
-   regulator_set_optimum_mode(s[i].consumer, regs[i].disable_load);
+   regulator_set_load(s[i].consumer, regs[i].disable_load);
return ret;
 }
 
-- 
2.1.4

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpVEvilIZ8dk.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm 
multi_v7_defconfig)
failed like this:

drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of 
function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
regulator_set_optimum_mode(s[i].consumer,
^

Caused by commit a689554ba6ed (drm/msm: Initial add DSI connector
support) from the drm tree interacting with commit ae6e808f1574
(regulator: Drop temporary regulator_set_optimum_mode wrapper) from
the regulator tree.

This happens every time someone renames/changes an API :-(

I have applied the following merge fix patch.  Someone needs to make
sure Linus finds out when the latter of these two trees is merged into
his.

From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 9 Apr 2015 14:28:42 +1000
Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c 
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index fdc54e3eff55..962cf545d24c 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct msm_dsi_host 
*msm_host)
DBG();
for (i = num - 1; i = 0; i--)
if (regs[i].disable_load = 0)
-   regulator_set_optimum_mode(s[i].consumer,
-   regs[i].disable_load);
+   regulator_set_load(s[i].consumer, regs[i].disable_load);
 
regulator_bulk_disable(num, s);
 }
@@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
*msm_host)
DBG();
for (i = 0; i  num; i++) {
if (regs[i].enable_load = 0) {
-   ret = regulator_set_optimum_mode(s[i].consumer,
-   regs[i].enable_load);
+   ret = regulator_set_load(s[i].consumer,
+   regs[i].enable_load);
if (ret  0) {
pr_err(regulator %d set op mode failed, %d\n,
i, ret);
@@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host 
*msm_host)
 
 fail:
for (i--; i = 0; i--)
-   regulator_set_optimum_mode(s[i].consumer, regs[i].disable_load);
+   regulator_set_load(s[i].consumer, regs[i].disable_load);
return ret;
 }
 
-- 
2.1.4

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpVEvilIZ8dk.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Tue, Mar 10, 2015 at 01:44:41PM +1100, Stephen Rothwell wrote:

> grep is your friend ...

Indeed :(

> This patch should be applied to your tree as it is based off v4.0-rc1
> already.

Applied, thanks.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Tue, Mar 10, 2015 at 01:44:41PM +1100, Stephen Rothwell wrote:

 grep is your friend ...

Indeed :(

 This patch should be applied to your tree as it is based off v4.0-rc1
 already.

Applied, thanks.


signature.asc
Description: Digital signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/drm/msm/edp/edp_ctrl.c: In function 'edp_regulator_enable':
drivers/gpu/drm/msm/edp/edp_ctrl.c:335:2: error: implicit declaration of 
function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
  ret = regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
  ^

Caused by commits e39ce48f5362 ("regulator: Rename
regulator_set_optimum_mode") and ae6e808f1574 ("regulator: Drop
temporary regulator_set_optimum_mode wrapper") interacting with commit
ab5b0107ccf3 ("drm/msm: Initial add eDP support in msm drm driver
(v5)") from Linus' tree (in v4.0-rc1) tree.

There was another use of regulator_set_optimum_mode() in
drivers/phy/phy-qcom-ufs.c (introduced by commit adaafaa393ef ("phy:
qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers") also
from v4.0-rc1) which I also fixed in the patch below.

grep is your friend ...

This patch should be applied to your tree as it is based off v4.0-rc1
already.

From: Stephen Rothwell 
Date: Tue, 10 Mar 2015 13:35:59 +1100
Subject: [PATCH] fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell 
---
 drivers/gpu/drm/msm/edp/edp_ctrl.c | 6 +++---
 drivers/phy/phy-qcom-ufs.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c 
b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 3e246210c46f..0ec5abdba5c4 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -332,7 +332,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
goto vdda_set_fail;
}
 
-   ret = regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
+   ret = regulator_set_load(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
if (ret < 0) {
pr_err("%s: vdda_vreg set regulator mode failed.\n", __func__);
goto vdda_set_fail;
@@ -356,7 +356,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
 lvl_enable_fail:
regulator_disable(ctrl->vdda_vreg);
 vdda_enable_fail:
-   regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
+   regulator_set_load(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
 vdda_set_fail:
return ret;
 }
@@ -365,7 +365,7 @@ static void edp_regulator_disable(struct edp_ctrl *ctrl)
 {
regulator_disable(ctrl->lvl_vreg);
regulator_disable(ctrl->vdda_vreg);
-   regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
+   regulator_set_load(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
 }
 
 static int edp_gpio_config(struct edp_ctrl *ctrl)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 44ee983d57fe..86665e9dc399 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -346,10 +346,10 @@ int ufs_qcom_phy_cfg_vreg(struct phy *phy,
goto out;
}
uA_load = on ? vreg->max_uA : 0;
-   ret = regulator_set_optimum_mode(reg, uA_load);
+   ret = regulator_set_load(reg, uA_load);
if (ret >= 0) {
/*
-* regulator_set_optimum_mode() returns new regulator
+* regulator_set_load() returns new regulator
 * mode upon success.
 */
ret = 0;
-- 
2.1.4
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp8YjRzbgxPF.pgp
Description: OpenPGP digital signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/drm/msm/edp/edp_ctrl.c: In function 'edp_regulator_enable':
drivers/gpu/drm/msm/edp/edp_ctrl.c:335:2: error: implicit declaration of 
function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
  ret = regulator_set_optimum_mode(ctrl-vdda_vreg, VDDA_UA_ON_LOAD);
  ^

Caused by commits e39ce48f5362 (regulator: Rename
regulator_set_optimum_mode) and ae6e808f1574 (regulator: Drop
temporary regulator_set_optimum_mode wrapper) interacting with commit
ab5b0107ccf3 (drm/msm: Initial add eDP support in msm drm driver
(v5)) from Linus' tree (in v4.0-rc1) tree.

There was another use of regulator_set_optimum_mode() in
drivers/phy/phy-qcom-ufs.c (introduced by commit adaafaa393ef (phy:
qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers) also
from v4.0-rc1) which I also fixed in the patch below.

grep is your friend ...

This patch should be applied to your tree as it is based off v4.0-rc1
already.

From: Stephen Rothwell s...@canb.auug.org.au
Date: Tue, 10 Mar 2015 13:35:59 +1100
Subject: [PATCH] fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
 drivers/gpu/drm/msm/edp/edp_ctrl.c | 6 +++---
 drivers/phy/phy-qcom-ufs.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c 
b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 3e246210c46f..0ec5abdba5c4 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -332,7 +332,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
goto vdda_set_fail;
}
 
-   ret = regulator_set_optimum_mode(ctrl-vdda_vreg, VDDA_UA_ON_LOAD);
+   ret = regulator_set_load(ctrl-vdda_vreg, VDDA_UA_ON_LOAD);
if (ret  0) {
pr_err(%s: vdda_vreg set regulator mode failed.\n, __func__);
goto vdda_set_fail;
@@ -356,7 +356,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
 lvl_enable_fail:
regulator_disable(ctrl-vdda_vreg);
 vdda_enable_fail:
-   regulator_set_optimum_mode(ctrl-vdda_vreg, VDDA_UA_OFF_LOAD);
+   regulator_set_load(ctrl-vdda_vreg, VDDA_UA_OFF_LOAD);
 vdda_set_fail:
return ret;
 }
@@ -365,7 +365,7 @@ static void edp_regulator_disable(struct edp_ctrl *ctrl)
 {
regulator_disable(ctrl-lvl_vreg);
regulator_disable(ctrl-vdda_vreg);
-   regulator_set_optimum_mode(ctrl-vdda_vreg, VDDA_UA_OFF_LOAD);
+   regulator_set_load(ctrl-vdda_vreg, VDDA_UA_OFF_LOAD);
 }
 
 static int edp_gpio_config(struct edp_ctrl *ctrl)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 44ee983d57fe..86665e9dc399 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -346,10 +346,10 @@ int ufs_qcom_phy_cfg_vreg(struct phy *phy,
goto out;
}
uA_load = on ? vreg-max_uA : 0;
-   ret = regulator_set_optimum_mode(reg, uA_load);
+   ret = regulator_set_load(reg, uA_load);
if (ret = 0) {
/*
-* regulator_set_optimum_mode() returns new regulator
+* regulator_set_load() returns new regulator
 * mode upon success.
 */
ret = 0;
-- 
2.1.4
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp8YjRzbgxPF.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Wed, Sep 10, 2014 at 10:33:16AM +0800, Chris Zhong wrote:

> Yes, I have modified the rk808.h, so rk808-regulator.c lacks some structure
> now.
> Please help me review the patch "[PATCH v10 3/3] regulator: RK808: Remove
> pdata from the regulator"
> It contains the corresponding changes.

...which you sent to me overnight.  It's applied now so -next should be
fine tomorrow, thanks.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Wed, Sep 10, 2014 at 10:33:16AM +0800, Chris Zhong wrote:

 Yes, I have modified the rk808.h, so rk808-regulator.c lacks some structure
 now.
 Please help me review the patch [PATCH v10 3/3] regulator: RK808: Remove
 pdata from the regulator
 It contains the corresponding changes.

...which you sent to me overnight.  It's applied now so -next should be
fine tomorrow, thanks.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Chris Zhong]

On 09/10/2014 06:39 AM, Mark Brown wrote:

On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:


drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
declared inside parameter list
struct rk808_board *pdata)

Chris, as previously requested please send me any changes needed to
update for the changes in the MFD driver.
Yes, I have modified the rk808.h, so rk808-regulator.c lacks some 
structure now.
Please help me review the patch "[PATCH v10 3/3] regulator: RK808: 
Remove pdata from the regulator"

It contains the corresponding changes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Doug Anderson]

Hi,

On Tue, Sep 9, 2014 at 3:39 PM, Mark Brown  wrote:
> On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:
>
>> drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
>> declared inside parameter list
>>struct rk808_board *pdata)
>
> Chris, as previously requested please send me any changes needed to
> update for the changes in the MFD driver.

See 

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:

> drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
> declared inside parameter list
>struct rk808_board *pdata)

Chris, as previously requested please send me any changes needed to
update for the changes in the MFD driver.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:

 drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
 declared inside parameter list
struct rk808_board *pdata)

Chris, as previously requested please send me any changes needed to
update for the changes in the MFD driver.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Doug Anderson]

Hi,

On Tue, Sep 9, 2014 at 3:39 PM, Mark Brown broo...@kernel.org wrote:
 On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:

 drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
 declared inside parameter list
struct rk808_board *pdata)

 Chris, as previously requested please send me any changes needed to
 update for the changes in the MFD driver.

See https://patchwork.kernel.org/patch/4873501/

-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Chris Zhong]

On 09/10/2014 06:39 AM, Mark Brown wrote:

On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:


drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
declared inside parameter list
struct rk808_board *pdata)

Chris, as previously requested please send me any changes needed to
update for the changes in the MFD driver.
Yes, I have modified the rk808.h, so rk808-regulator.c lacks some 
structure now.
Please help me review the patch [PATCH v10 3/3] regulator: RK808: 
Remove pdata from the regulator

It contains the corresponding changes.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
declared inside parameter list
   struct rk808_board *pdata)
  ^
drivers/regulator/rk808-regulator.c:312:18: warning: its scope is only this 
definition or declaration, which is probably not what you want
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dts':
drivers/regulator/rk808-regulator.c:340:8: error: dereferencing pointer to 
incomplete type
   pdata->rk808_init_data[i] = rk808_reg_matches[i].init_data;
^
drivers/regulator/rk808-regulator.c:341:8: error: dereferencing pointer to 
incomplete type
   pdata->of_node[i] = rk808_reg_matches[i].of_node;
^
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_probe':
drivers/regulator/rk808-regulator.c:359:43: error: dereferencing pointer to 
incomplete type
   pdata = devm_kzalloc(>dev, sizeof(*pdata), GFP_KERNEL);
   ^
drivers/regulator/rk808-regulator.c:364:8: warning: passing argument 2 of 
'rk808_regulator_dts' from incompatible pointer type
  ret = rk808_regulator_dts(client, pdata);
^
drivers/regulator/rk808-regulator.c:311:12: note: expected 'struct rk808_board 
*' but argument is of type 'struct rk808_board *'
 static int rk808_regulator_dts(struct i2c_client *client,
^
drivers/regulator/rk808-regulator.c:370:19: error: dereferencing pointer to 
incomplete type
   reg_data = pdata->rk808_init_data[i];
   ^
drivers/regulator/rk808-regulator.c:379:26: error: dereferencing pointer to 
incomplete type
config.of_node = pdata->of_node[i];
  ^

Caused by commit 2cd64ae3d57b ("regulator: RK808: Add regulator driver
for RK808").

I have reverted that commit and all the following ones in the regulator
tree that touch this file.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' 
declared inside parameter list
   struct rk808_board *pdata)
  ^
drivers/regulator/rk808-regulator.c:312:18: warning: its scope is only this 
definition or declaration, which is probably not what you want
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dts':
drivers/regulator/rk808-regulator.c:340:8: error: dereferencing pointer to 
incomplete type
   pdata-rk808_init_data[i] = rk808_reg_matches[i].init_data;
^
drivers/regulator/rk808-regulator.c:341:8: error: dereferencing pointer to 
incomplete type
   pdata-of_node[i] = rk808_reg_matches[i].of_node;
^
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_probe':
drivers/regulator/rk808-regulator.c:359:43: error: dereferencing pointer to 
incomplete type
   pdata = devm_kzalloc(pdev-dev, sizeof(*pdata), GFP_KERNEL);
   ^
drivers/regulator/rk808-regulator.c:364:8: warning: passing argument 2 of 
'rk808_regulator_dts' from incompatible pointer type
  ret = rk808_regulator_dts(client, pdata);
^
drivers/regulator/rk808-regulator.c:311:12: note: expected 'struct rk808_board 
*' but argument is of type 'struct rk808_board *'
 static int rk808_regulator_dts(struct i2c_client *client,
^
drivers/regulator/rk808-regulator.c:370:19: error: dereferencing pointer to 
incomplete type
   reg_data = pdata-rk808_init_data[i];
   ^
drivers/regulator/rk808-regulator.c:379:26: error: dereferencing pointer to 
incomplete type
config.of_node = pdata-of_node[i];
  ^

Caused by commit 2cd64ae3d57b (regulator: RK808: Add regulator driver
for RK808).

I have reverted that commit and all the following ones in the regulator
tree that touch this file.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mc13892-regulator.c: In function 'mc13892_regulator_probe':
drivers/regulator/mc13892-regulator.c:586:3: error: assignment of member 
'set_mode' in read-only object
   = mc13892_vcam_set_mode;
   ^
drivers/regulator/mc13892-regulator.c:588:3: error: assignment of member 
'get_mode' in read-only object
   = mc13892_vcam_get_mode;
   ^

Caused by commit 272e2315fac3 ("regulator: core: add const qualifier to
ops in struct regulator_desc").

I have used the regulator tree from next-20140815 for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mc13892-regulator.c: In function 'mc13892_regulator_probe':
drivers/regulator/mc13892-regulator.c:586:3: error: assignment of member 
'set_mode' in read-only object
   = mc13892_vcam_set_mode;
   ^
drivers/regulator/mc13892-regulator.c:588:3: error: assignment of member 
'get_mode' in read-only object
   = mc13892_vcam_get_mode;
   ^

Caused by commit 272e2315fac3 (regulator: core: add const qualifier to
ops in struct regulator_desc).

I have used the regulator tree from next-20140815 for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/act8865-regulator.c: In function 'act8865_pmic_probe':
drivers/regulator/act8865-regulator.c:291:13: error: 'act8846_matches' 
undeclared (first use in this function)
   matches = act8846_matches;
 ^
drivers/regulator/act8865-regulator.c:291:13: note: each undeclared identifier 
is reported only once for each function it appears in
drivers/regulator/act8865-regulator.c:296:13: error: 'act8865_matches' 
undeclared (first use in this function)
   matches = act8865_matches;
 ^
drivers/regulator/act8865-regulator.c:311:9: error: too many arguments to 
function 'act8865_pdata_from_dt'
   ret = act8865_pdata_from_dt(dev, of_node, _of, matches,
 ^
drivers/regulator/act8865-regulator.c:239:19: note: declared here
 static inline int act8865_pdata_from_dt(struct device *dev,
   ^

Caused by commit 7160912a8c55 ("regulator: act8865: add support for
act8846").

I have used the regulator tree from next-20140707 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/act8865-regulator.c: In function 'act8865_pmic_probe':
drivers/regulator/act8865-regulator.c:291:13: error: 'act8846_matches' 
undeclared (first use in this function)
   matches = act8846_matches;
 ^
drivers/regulator/act8865-regulator.c:291:13: note: each undeclared identifier 
is reported only once for each function it appears in
drivers/regulator/act8865-regulator.c:296:13: error: 'act8865_matches' 
undeclared (first use in this function)
   matches = act8865_matches;
 ^
drivers/regulator/act8865-regulator.c:311:9: error: too many arguments to 
function 'act8865_pdata_from_dt'
   ret = act8865_pdata_from_dt(dev, of_node, pdata_of, matches,
 ^
drivers/regulator/act8865-regulator.c:239:19: note: declared here
 static inline int act8865_pdata_from_dt(struct device *dev,
   ^

Caused by commit 7160912a8c55 (regulator: act8865: add support for
act8846).

I have used the regulator tree from next-20140707 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/built-in.o: In function `ltc3589_probe':
ltc3589.c:(.text+0xccf24): undefined reference to `devm_regmap_init_i2c'
drivers/built-in.o: In function `ltc3589_driver_init':
ltc3589.c:(.init.text+0x9ebc): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `ltc3589_driver_exit':
ltc3589.c:(.exit.text+0x2d1): undefined reference to `i2c_del_driver'

Caused by commit 3eb2c7ecb7ea ("regulator: Add LTC3589 support").

Clearly some dependencies are incorrect.  Presumably the required
interfaces are in modules for this build.

I have used the regulator tree from next-20140526 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/built-in.o: In function `ltc3589_probe':
ltc3589.c:(.text+0xccf24): undefined reference to `devm_regmap_init_i2c'
drivers/built-in.o: In function `ltc3589_driver_init':
ltc3589.c:(.init.text+0x9ebc): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `ltc3589_driver_exit':
ltc3589.c:(.exit.text+0x2d1): undefined reference to `i2c_del_driver'

Caused by commit 3eb2c7ecb7ea (regulator: Add LTC3589 support).

Clearly some dependencies are incorrect.  Presumably the required
interfaces are in modules for this build.

I have used the regulator tree from next-20140526 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from /scratch/sfr/next/include/linux/cache.h:4:0,
 from /scratch/sfr/next/include/linux/time.h:4,
 from /scratch/sfr/next/include/linux/stat.h:18,
 from /scratch/sfr/next/include/linux/module.h:10,
 from 
/scratch/sfr/next/drivers/regulator/act8865-regulator.c:18:
/scratch/sfr/next/drivers/regulator/act8865-regulator.c: In function 
'act8865_pmic_probe':
/scratch/sfr/next/drivers/regulator/act8865-regulator.c:306:29: error: 
'act8865_matches' undeclared (first use in this function)
  for (i = 0; i < ARRAY_SIZE(act8865_matches); i++) {
 ^

Caused by commit d04b75527368 ("regulator: act8865: register all
regulators regardless of how many are used").  This build does not have
CONFIG_OF set.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpboGqZBIDJE.pgp
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from /scratch/sfr/next/include/linux/cache.h:4:0,
 from /scratch/sfr/next/include/linux/time.h:4,
 from /scratch/sfr/next/include/linux/stat.h:18,
 from /scratch/sfr/next/include/linux/module.h:10,
 from 
/scratch/sfr/next/drivers/regulator/act8865-regulator.c:18:
/scratch/sfr/next/drivers/regulator/act8865-regulator.c: In function 
'act8865_pmic_probe':
/scratch/sfr/next/drivers/regulator/act8865-regulator.c:306:29: error: 
'act8865_matches' undeclared (first use in this function)
  for (i = 0; i  ARRAY_SIZE(act8865_matches); i++) {
 ^

Caused by commit d04b75527368 (regulator: act8865: register all
regulators regardless of how many are used).  This build does not have
CONFIG_OF set.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpboGqZBIDJE.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

On Monday 01 July 2013 02:13 PM, Mark Brown wrote:

On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:


commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
and I dint have that patch in my tree. Sorry, my bad.
Keerthy will send a fix for it.


Resubmit the patch, I've dropped it.


Ok. I'll resend the patch.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:

> commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used 
> PALMAS_REG_SMPS10
> and I dint have that patch in my tree. Sorry, my bad.
> Keerthy will send a fix for it.

Resubmit the patch, I've dropped it.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Jul 01, 2013 at 02:18:27PM +1000, Stephen Rothwell wrote:

> Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
> regulators").  Clearly not build tested at all :-(  Grep is your
> friend ...

That's odd, it's also not been caught by Fengguang's system which
generally gets this sort of stuff...


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

+Keerthy

On Monday 01 July 2013 09:48 AM, Stephen Rothwell wrote:

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' 
undeclared (first use in this function)
case PALMAS_REG_SMPS10:
 ^

Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
regulators").  Clearly not build tested at all :-(  Grep is your
friend ...


commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
and I dint have that patch in my tree. Sorry, my bad.
Keerthy will send a fix for it.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

+Keerthy

On Monday 01 July 2013 09:48 AM, Stephen Rothwell wrote:

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' 
undeclared (first use in this function)
case PALMAS_REG_SMPS10:
 ^

Caused by commit 07a02e0b1a4f (regulator: palmas: model SMPS10 as two
regulators).  Clearly not build tested at all :-(  Grep is your
friend ...


commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
and I dint have that patch in my tree. Sorry, my bad.
Keerthy will send a fix for it.

Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Jul 01, 2013 at 02:18:27PM +1000, Stephen Rothwell wrote:

 Caused by commit 07a02e0b1a4f (regulator: palmas: model SMPS10 as two
 regulators).  Clearly not build tested at all :-(  Grep is your
 friend ...

That's odd, it's also not been caught by Fengguang's system which
generally gets this sort of stuff...


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:

 commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used 
 PALMAS_REG_SMPS10
 and I dint have that patch in my tree. Sorry, my bad.
 Keerthy will send a fix for it.

Resubmit the patch, I've dropped it.


signature.asc
Description: Digital signature

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

On Monday 01 July 2013 02:13 PM, Mark Brown wrote:

On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:


commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
and I dint have that patch in my tree. Sorry, my bad.
Keerthy will send a fix for it.


Resubmit the patch, I've dropped it.


Ok. I'll resend the patch.

Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' 
undeclared (first use in this function)
   case PALMAS_REG_SMPS10:
^

Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
regulators").  Clearly not build tested at all :-(  Grep is your
friend ...

I have used the regulator tree from next-20130628 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdrk19yEBxO.pgp
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' 
undeclared (first use in this function)
   case PALMAS_REG_SMPS10:
^

Caused by commit 07a02e0b1a4f (regulator: palmas: model SMPS10 as two
regulators).  Clearly not build tested at all :-(  Grep is your
friend ...

I have used the regulator tree from next-20130628 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdrk19yEBxO.pgp
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regulator_allow_bypass" [drivers/extcon/extcon-arizona.ko] undefined!

Caused by commit e6647c416e4f ("extcon: arizona: Use bypass mode for MICVDD").

I have used the regulator tree from next-20120907 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpMkCqOspiYd.pgp
Description: PGP signature

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: regulator_allow_bypass [drivers/extcon/extcon-arizona.ko] undefined!

Caused by commit e6647c416e4f (extcon: arizona: Use bypass mode for MICVDD).

I have used the regulator tree from next-20120907 for today.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpMkCqOspiYd.pgp
Description: PGP signature