Re: linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Alex Deucher
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike  wrote:
>
> [AMD Public Use]
>
> > From: Stephen Rothwell 
> > Sent: Friday, April 16, 2021 12:09 PM
> > To: Liang, Prike 
> > Cc: Alex Deucher ; S-k, Shyam-sundar  > sundar@amd.com>; Linux Kernel Mailing List  > ker...@vger.kernel.org>; Linux Next Mailing List 
> > 
> > Subject: Re: linux-next: build warning after merge of the amdgpu tree
> >
> > Hi,
> >
> > On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike" 
> > wrote:
> > >
> > > Hi, Rothwell
> >
> > (Stephen, actually :-))
> >
> > > This fix solution hasn't locked down and still being discussed and roll-
> > updated in the NVMe mail group.
> > > Will update the patch once it refined done.
> >
> > In which case, this patch should not be in linux-next (or any branch that is
> > included by linux-next).
> >
> How about revert the patch temporally ? Once lock down the solution and will 
> land in the final latest patch.

I'll drop it for now.  I just have it in there temporarily while it
makes its way upstream because a lot of people use this branch and it
fixes an important bug.

Alex


RE: linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Liang, Prike
[AMD Public Use]

> From: Stephen Rothwell 
> Sent: Friday, April 16, 2021 12:09 PM
> To: Liang, Prike 
> Cc: Alex Deucher ; S-k, Shyam-sundar  sundar@amd.com>; Linux Kernel Mailing List  ker...@vger.kernel.org>; Linux Next Mailing List 
> Subject: Re: linux-next: build warning after merge of the amdgpu tree
>
> Hi,
>
> On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike" 
> wrote:
> >
> > Hi, Rothwell
>
> (Stephen, actually :-))
>
> > This fix solution hasn't locked down and still being discussed and roll-
> updated in the NVMe mail group.
> > Will update the patch once it refined done.
>
> In which case, this patch should not be in linux-next (or any branch that is
> included by linux-next).
>
How about revert the patch temporally ? Once lock down the solution and will 
land in the final latest patch.
> --
> Cheers,
> Stephen Rothwell


Re: linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Stephen Rothwell
Hi,

On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike"  wrote:
> 
> Hi, Rothwell

(Stephen, actually :-))

> This fix solution hasn't locked down and still being discussed and 
> roll-updated in the NVMe mail group.
> Will update the patch once it refined done.

In which case, this patch should not be in linux-next (or any branch
that is included by linux-next).

-- 
Cheers,
Stephen Rothwell


pgpe8OeiFcmwZ.pgp
Description: OpenPGP digital signature


RE: linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Liang, Prike
[AMD Public Use]

Hi, Rothwell

This fix solution hasn't locked down and still being discussed and roll-updated 
in the NVMe mail group.
Will update the patch once it refined done.

Thanks,
Prike
> -Original Message-
> From: Stephen Rothwell 
> Sent: Friday, April 16, 2021 10:41 AM
> To: Alex Deucher 
> Cc: Liang, Prike ; S-k, Shyam-sundar  sundar@amd.com>; Linux Kernel Mailing List  ker...@vger.kernel.org>; Linux Next Mailing List 
> Subject: linux-next: build warning after merge of the amdgpu tree
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-
> variable]
>   312 |  struct pci_dev *rdev;
>   |  ^~~~
>
> Introduced by commit
>
>   9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to
> simple suspend/resume path")
>
> --
> Cheers,
> Stephen Rothwell


linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
  312 |  struct pci_dev *rdev;
  |  ^~~~

Introduced by commit

  9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple 
suspend/resume path")

-- 
Cheers,
Stephen Rothwell


pgpI2syQttFk6.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-24 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:398: warning: Incorrect use 
of kernel-doc format:  * @crc_rd_wrk

Introduced by commit

  bbf514b0c626 ("drm/amd/display: Add kernel doc to crc_rd_wrk field")

It is missing a ':' after 'crc_rd_wrk'.

-- 
Cheers,
Stephen Rothwell


pgp5sMbR0RMBB.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-23 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:926:13: warning: 
'dm_dmub_trace_high_irq' defined but not used [-Wunused-function]
  926 | static void dm_dmub_trace_high_irq(void *interrupt_params)
  | ^~

Introduced by commit

  44a76bac327c ("drm/amd/display: Log DMCUB trace buffer events")

-- 
Cheers,
Stephen Rothwell


pgpvbEW5tZyee.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-22 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:405: warning: Function 
parameter or member 'dmcub_trace_event_en' not described in 
'amdgpu_display_manager'

Introduced by commit

  4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer 
events")

-- 
Cheers,
Stephen Rothwell


pgpVOWiRQN_TH.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-11 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function 
parameter or member 'list' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function 
parameter or member 'bo' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function 
parameter or member 'cpu_ptr' not described in 'dal_allocation'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function 
parameter or member 'gpu_addr' not described in 'dal_allocation'

Introduced by commit

  1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU 
memory")

-- 
Cheers,
Stephen Rothwell


pgp3b7D34Vke3.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-08 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:380: warning: Function 
parameter or member 'crc_rd_wrk' not described in 'amdgpu_display_manager'

Introduced by commit

  9a65df193108 ("drm/amd/display: Use PSP TA to read out crc")

-- 
Cheers,
Stephen Rothwell


pgpvnY62BQxWl.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-03-03 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c:86: warning: Function 
parameter or member 'work' not described in 'amdgpu_dm_irq_handler_data'

Introduced by commit

  b6f91fc183f7 ("drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt 
work")

-- 
Cheers,
Stephen Rothwell


pgp_ktJs9tA_C.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-02-23 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5439:33: warning: 
unused variable 'dm' [-Wunused-variable]
 5439 |  struct amdgpu_display_manager *dm = >dm;
  | ^~

Introduced by commit

  3cfd14b67b2c ("drm/amd/display: Fix system hang after multiple hotplugs (v2)")

-- 
Cheers,
Stephen Rothwell


pgpK6vZ3eWTWN.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-21 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher  wrote:
>
> On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell  
> > wrote:
> > >
> > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell 
> > >  wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In 
> > > > function 'dm_set_vblank':
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: 
> > > > warning: unused variable 'dm' [-Wunused-variable]
> > > >  5380 |  struct amdgpu_display_manager *dm = >dm;
> > > >   | ^~
> > > >
> > > > Caused by commit
> > > >
> > > >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> > >
> > > I am still getting this warning.
> >
> > I now get this warning from the drm tree merge.

Drat, I missed that when merging.

> Bhawan sent out the fix today:
> https://patchwork.freedesktop.org/patch/415092/

Applied directly to drm-next, thanks.
-Daniel

>
> Alex
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell  
> wrote:
> >
> > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell  
> > wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
> > > 'dm_set_vblank':
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: 
> > > warning: unused variable 'dm' [-Wunused-variable]
> > >  5380 |  struct amdgpu_display_manager *dm = >dm;
> > >   | ^~
> > >
> > > Caused by commit
> > >
> > >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> >
> > I am still getting this warning.
>
> I now get this warning from the drm tree merge.

Bhawan sent out the fix today:
https://patchwork.freedesktop.org/patch/415092/

Alex

>
> --
> Cheers,
> Stephen Rothwell


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-20 Thread Stephen Rothwell
Hi all,

On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell  
wrote:
>
> On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell  
> wrote:
> > 
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
> > 'dm_set_vblank':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: 
> > warning: unused variable 'dm' [-Wunused-variable]
> >  5380 |  struct amdgpu_display_manager *dm = >dm;
> >   | ^~
> > 
> > Caused by commit
> > 
> >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")  
> 
> I am still getting this warning.

I now get this warning from the drm tree merge.

-- 
Cheers,
Stephen Rothwell


pgp56mswBdrH8.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-19 Thread Stephen Rothwell
Hi all,

On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell  
wrote:
> 
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
> 'dm_set_vblank':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: 
> unused variable 'dm' [-Wunused-variable]
>  5380 |  struct amdgpu_display_manager *dm = >dm;
>   | ^~
> 
> Caused by commit
> 
>   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell


pgpX_3bvJD44e.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-18 Thread Huang Rui
On Mon, Jan 18, 2021 at 02:52:18PM +0800, Stephen Rothwell wrote:
> Hi Ray,
> 
> On Mon, 18 Jan 2021 05:56:20 + "Huang, Ray"  wrote:
> >
> > [AMD Public Use]
> > 
> > Thanks Setphen. Please check attached V2 patch.
> > (If you can share the config file to me, I can do the test in my side)
> 
> It looks good, but I did not try to build it.  I have attached the
> config (it is just a powerpc allyesconfig).
> -- 
> Cheers,
> Stephen Rothwell

Thanks Stephen.

Ray


Re: linux-next: build warning after merge of the amdgpu tree

2021-01-17 Thread Stephen Rothwell
Hi Ray,

On Mon, 18 Jan 2021 05:56:20 + "Huang, Ray"  wrote:
>
> [AMD Public Use]
> 
> Thanks Setphen. Please check attached V2 patch.
> (If you can share the config file to me, I can do the test in my side)

It looks good, but I did not try to build it.  I have attached the
config (it is just a powerpc allyesconfig).
-- 
Cheers,
Stephen Rothwell


powerpc_allyesconfig.gz
Description: application/gzip


pgpBicKJ8g5Fi.pgp
Description: OpenPGP digital signature


RE: linux-next: build warning after merge of the amdgpu tree

2021-01-17 Thread Huang, Ray
[AMD Public Use]

Thanks Setphen. Please check attached V2 patch.
(If you can share the config file to me, I can do the test in my side)

Best Regards,
Ray

-Original Message-
From: Stephen Rothwell  
Sent: Monday, January 18, 2021 1:29 PM
To: Alex Deucher 
Cc: Huang, Ray ; Linux Kernel Mailing List 
; Linux Next Mailing List 

Subject: linux-next: build warning after merge of the amdgpu tree

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) gave this warning:

drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 
'vangogh_init_smc_tables':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:338:5: warning: 
"CONFIG_X86" is not defined, evaluates to 0 [-Wundef]
  338 | #if CONFIG_X86
  | ^~

Caused by commit

  9dd19d5232a6 ("drm/amdgpu: fix build error without x86 kconfig")

-- 
Cheers,
Stephen Rothwell


0001-drm-amdgpu-fix-build-error-without-x86-kconfig-v2.patch
Description:  0001-drm-amdgpu-fix-build-error-without-x86-kconfig-v2.patch


linux-next: build warning after merge of the amdgpu tree

2021-01-17 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) gave this warning:

drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 
'vangogh_init_smc_tables':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:338:5: warning: 
"CONFIG_X86" is not defined, evaluates to 0 [-Wundef]
  338 | #if CONFIG_X86
  | ^~

Caused by commit

  9dd19d5232a6 ("drm/amdgpu: fix build error without x86 kconfig")

-- 
Cheers,
Stephen Rothwell


pgpcg8bXeAFCN.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2021-01-14 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 
'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: 
unused variable 'dm' [-Wunused-variable]
 5380 |  struct amdgpu_display_manager *dm = >dm;
  | ^~

Caused by commit

  98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")

-- 
Cheers,
Stephen Rothwell


pgp92B22sMCF2.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2020-12-14 Thread Stephen Rothwell
Hi all,

On Tue, 15 Dec 2020 06:56:08 +1100 Stephen Rothwell  
wrote:
>
> On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell  
> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> > parameter or member 'crc_win_x_start_property' not described in 
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> > parameter or member 'crc_win_y_start_property' not described in 
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> > parameter or member 'crc_win_x_end_property' not described in 
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> > parameter or member 'crc_win_y_end_property' not described in 
> > 'amdgpu_display_manager'
> > 
> > Introduced by commit
> > 
> >   c920888c604d ("drm/amd/display: Expose new CRC window property")  
> 
> I am still getting those warnings.  That commit is now in the drm tree.

These warnings are now from Linus' tree.

-- 
Cheers,
Stephen Rothwell


pgpkiZM3j6a9I.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2020-12-14 Thread Stephen Rothwell
Hi all,

On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell  
wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> parameter or member 'crc_win_x_start_property' not described in 
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> parameter or member 'crc_win_y_start_property' not described in 
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> parameter or member 'crc_win_x_end_property' not described in 
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
> parameter or member 'crc_win_y_end_property' not described in 
> 'amdgpu_display_manager'
> 
> Introduced by commit
> 
>   c920888c604d ("drm/amd/display: Expose new CRC window property")

I am still getting those warnings.  That commit is now in the drm tree.
-- 
Cheers,
Stephen Rothwell


pgpzO5X8gNz0Y.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2020-11-16 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
parameter or member 'crc_win_x_start_property' not described in 
'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
parameter or member 'crc_win_y_start_property' not described in 
'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
parameter or member 'crc_win_x_end_property' not described in 
'amdgpu_display_manager'
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function 
parameter or member 'crc_win_y_end_property' not described in 
'amdgpu_display_manager'

Introduced by commit

  c920888c604d ("drm/amd/display: Expose new CRC window property")

-- 
Cheers,
Stephen Rothwell


pgpBvvodYckZR.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2019-07-01 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodcnofig) produced this warning:

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c: In function 'kgd2kfd_probe':
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:490:6: warning: unused 
variable 'ret' [-Wunused-variable]
  int ret;
  ^~~

Introduced by commit

  aabf3a951c4e ("drm/amdkfd: remove duplicated PCIE atomics request")

-- 
Cheers,
Stephen Rothwell


pgp24WOcp41NI.pgp
Description: OpenPGP digital signature


Re: linux-next: build warning after merge of the amdgpu tree

2019-05-30 Thread Stephen Rothwell
Hi all,

On Fri, 10 May 2019 10:59:13 +1000 Stephen Rothwell  
wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from drivers/gpu/drm/amd/amdgpu/df_v3_6.c:23:
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start':
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:1010:29: warning: 'lo_val' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>  #define WREG32_PCIE(reg, v) adev->pcie_wreg(adev, (reg), (v))
>  ^~~~
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c:334:39: note: 'lo_val' was declared here
>   uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val;
>^~
> 
> Introduced by commit
> 
>   a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi")

I now get this warning after merging the drm tree ...

-- 
Cheers,
Stephen Rothwell


pgpsOnD4RGGfZ.pgp
Description: OpenPGP digital signature


linux-next: build warning after merge of the amdgpu tree

2019-05-09 Thread Stephen Rothwell
Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/gpu/drm/amd/amdgpu/df_v3_6.c:23:
drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start':
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1010:29: warning: 'lo_val' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
 #define WREG32_PCIE(reg, v) adev->pcie_wreg(adev, (reg), (v))
 ^~~~
drivers/gpu/drm/amd/amdgpu/df_v3_6.c:334:39: note: 'lo_val' was declared here
  uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val;
   ^~

Introduced by commit

  a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi")

-- 
Cheers,
Stephen Rothwell


pgpUS4aytPX8Y.pgp
Description: OpenPGP digital signature