linux-next: build warning after merge of the thermal tree
Hi all,
After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/thermal/gov_power_allocator.c: In function 'power_allocator_unbind':
drivers/thermal/gov_power_allocator.c:587:33: warning: unused variable 'params'
[-Wunused-variable]
587 | struct power_allocator_params *params = tz->governor_data;
| ^~
Introduced by commit
ee7e92c62370 ("drivers/thermal: Remove unnecessary structure members
allocated_tzp")
--
Cheers,
Stephen Rothwell
pgpbmpKvGR4Fe.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the thermal tree
Hi Amit, On Tue, 22 Oct 2019 15:20:00 +0530 Amit Kucheria wrote: > > What compiler version do you use? Any additional flags to make? I'm > not seeing this, even with W=1. $ x86_64-linux-gnu-gcc --version x86_64-linux-gnu-gcc (Debian 9.2.1-8) 9.2.1 20190909 No special flags to make. -- Cheers, Stephen Rothwell pgpMsLuQjGNoA.pgp Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the thermal tree
(Resending since Gmail mobile client converts email to HTML)
Hi Stephen,
On Tue, Oct 22, 2019 at 4:53 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the thermal tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/thermal/qcom/tsens-common.c:13:
> drivers/thermal/qcom/tsens-common.c: In function 'tsens_set_interrupt':
> include/linux/regmap.h:87:2: warning: 'index' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
>87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
> | ^
> drivers/thermal/qcom/tsens-common.c:183:6: note: 'index' was declared here
> 183 | u32 index;
> | ^
> In file included from drivers/thermal/qcom/tsens-common.c:13:
> include/linux/regmap.h:87:2: warning: 'index_clear' may be used uninitialized
> in this function [-Wmaybe-uninitialized]
>87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
> | ^
> drivers/thermal/qcom/tsens-common.c:199:18: note: 'index_clear' was declared
> here
> 199 | u32 index_mask, index_clear;
> | ^~~
> drivers/thermal/qcom/tsens-common.c:199:6: warning: 'index_mask' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> 199 | u32 index_mask, index_clear;
> | ^~
>
> Introduced by commit
>
> fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
>
What compiler version do you use? Any additional flags to make? I'm
not seeing this, even with W=1.
$ make -k -j`nproc` O=~/work/builds/build-x86/ allmodconfig
$ touch drivers/thermal/qcom/*
──• amit@matterhorn •───(~/.../sources/linux-amit.git) $ make -k
-j`nproc` O=~/work/builds/build-x86/
make[1]: Entering directory '/home/amit/work/builds/build-x86'
GEN Makefile
scripts/kconfig/conf --syncconfig Kconfig
GEN Makefile
DESCEND objtool
CALL/home/amit/work/sources/linux-amit.git/scripts/atomic/check-atomics.sh
CALL/home/amit/work/sources/linux-amit.git/scripts/checksyscalls.sh
CHK include/generated/compile.h
CHK kernel/kheaders_data.tar.xz
CC [M] drivers/thermal/qcom/tsens.o
CC [M] drivers/thermal/qcom/tsens-common.o
CC [M] drivers/thermal/qcom/tsens-v0_1.o
CC [M] drivers/thermal/qcom/tsens-8960.o
CC [M] drivers/thermal/qcom/tsens-v2.o
CC [M] drivers/thermal/qcom/tsens-v1.o
CC [M] drivers/thermal/qcom/qcom-spmi-temp-alarm.o
LD [M] drivers/thermal/qcom/qcom_tsens.o
Building modules, stage 2.
MODPOST 7437 modules
Kernel: arch/x86/boot/bzImage is ready (#3)
LD [M] drivers/thermal/qcom/qcom-spmi-temp-alarm.ko
LD [M] drivers/thermal/qcom/qcom_tsens.ko
make[1]: Leaving directory '/home/amit/work/builds/build-x86'
linux-next: build warning after merge of the thermal tree
Hi all,
After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from drivers/thermal/qcom/tsens-common.c:13:
drivers/thermal/qcom/tsens-common.c: In function 'tsens_set_interrupt':
include/linux/regmap.h:87:2: warning: 'index' may be used uninitialized in this
function [-Wmaybe-uninitialized]
87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
| ^
drivers/thermal/qcom/tsens-common.c:183:6: note: 'index' was declared here
183 | u32 index;
| ^
In file included from drivers/thermal/qcom/tsens-common.c:13:
include/linux/regmap.h:87:2: warning: 'index_clear' may be used uninitialized
in this function [-Wmaybe-uninitialized]
87 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
| ^
drivers/thermal/qcom/tsens-common.c:199:18: note: 'index_clear' was declared
here
199 | u32 index_mask, index_clear;
| ^~~
drivers/thermal/qcom/tsens-common.c:199:6: warning: 'index_mask' may be used
uninitialized in this function [-Wmaybe-uninitialized]
199 | u32 index_mask, index_clear;
| ^~
Introduced by commit
fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
--
Cheers,
Stephen Rothwell
pgpcXVsPbgYzl.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the thermal tree
Hi Zhang,
After merging the thermal tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
boolean symbol THERMAL tested for 'm'? test forced to 'n'
Introduced by commit
be33e4fbbea5 ("thermal/drivers/core: Remove the module Kconfig's option")
There is a test for =m in drivers/net/ethernet/mellanox/mlxsw/Kconfig.
--
Cheers,
Stephen Rothwell
pgppg10Zmo5Rl.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the thermal tree
Hi Zhang,
After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/thermal/int340x_thermal/int3406_thermal.c: In function
'int3406_thermal_get_limit':
drivers/thermal/int340x_thermal/int3406_thermal.c:116:6: warning: unused
variable 'index' [-Wunused-variable]
int index;
^
Introduced by commit
c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs I/F")
--
Cheers,
Stephen Rothwell
linux-next: build warning after merge of the thermal tree
Hi Zhang,
After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/thermal/int340x_thermal/int3406_thermal.c: In function
'int3406_thermal_get_limit':
drivers/thermal/int340x_thermal/int3406_thermal.c:116:6: warning: unused
variable 'index' [-Wunused-variable]
int index;
^
Introduced by commit
c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs I/F")
--
Cheers,
Stephen Rothwell
Re: linux-next: build warning after merge of the thermal tree
On 三, 2016-08-24 at 13:38 +1000, Stephen Rothwell wrote:
> Hi Zhang,
>
> After merging the thermal tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet
> direct dependencies (COMMON_CLK && COMMON_CLK_HI6220 && MAILBOX)
>
> Introduced by commit
>
> 5f63581ce68e ("thermal: hisilicon: Add dependency on the clock
> driver to allow frequency scaling")
>
> BTW: That commit message does not match the change (which adds a
> "select" not a "depends on".
>
Right, thanks for reporting the issue. Patch dropped from thermal -next
tree.
thanks,
rui
Re: linux-next: build warning after merge of the thermal tree
On 三, 2016-08-24 at 13:38 +1000, Stephen Rothwell wrote:
> Hi Zhang,
>
> After merging the thermal tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet
> direct dependencies (COMMON_CLK && COMMON_CLK_HI6220 && MAILBOX)
>
> Introduced by commit
>
> 5f63581ce68e ("thermal: hisilicon: Add dependency on the clock
> driver to allow frequency scaling")
>
> BTW: That commit message does not match the change (which adds a
> "select" not a "depends on".
>
Right, thanks for reporting the issue. Patch dropped from thermal -next
tree.
thanks,
rui
linux-next: build warning after merge of the thermal tree
Hi Zhang,
After merging the thermal tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet direct
dependencies (COMMON_CLK && COMMON_CLK_HI6220 && MAILBOX)
Introduced by commit
5f63581ce68e ("thermal: hisilicon: Add dependency on the clock driver to
allow frequency scaling")
BTW: That commit message does not match the change (which adds a
"select" not a "depends on".
--
Cheers,
Stephen Rothwell
linux-next: build warning after merge of the thermal tree
Hi Zhang,
After merging the thermal tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet direct
dependencies (COMMON_CLK && COMMON_CLK_HI6220 && MAILBOX)
Introduced by commit
5f63581ce68e ("thermal: hisilicon: Add dependency on the clock driver to
allow frequency scaling")
BTW: That commit message does not match the change (which adds a
"select" not a "depends on".
--
Cheers,
Stephen Rothwell
