Re: linux-next: build warnings in Linus' tree
Hi Josh, On Tue, 8 Sep 2020 08:14:39 -0500 Josh Poimboeuf wrote: > > On Tue, Sep 08, 2020 at 09:11:02AM +1000, Stephen Rothwell wrote: > > > > Building Linus' tree, today's linux-next build (x86_64 allmodconfig) > > produced these warnings: > > > > arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: > > unreachable instruction > > net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable > > instruction > > arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable > > instruction > > arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: > > unreachable instruction > > kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable > > instruction > > kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable > > instruction > > drivers/misc/sgi-gru/grukservices.o: warning: objtool: > > gru_wait_abort_proc()+0x97: unreachable instruction > > drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: > > unreachable instruction > > drivers/message/fusion/mptbase.o: warning: objtool: > > mpt_SoftResetHandler()+0x4a5: unreachable instruction > > drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: > > unreachable instruction > > drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: > > otx2_sq_append_tso()+0xab6: unreachable instruction > > fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: > > unreachable instruction > > fs/btrfs/backref.o: warning: objtool: > > btrfs_backref_finish_upper_links()+0x818: unreachable instruction > > fs/btrfs/relocation.o: warning: objtool: > > update_backref_cache.isra.0()+0x3bf: unreachable instruction > > drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: > > unreachable instruction > > I suspect these will all be fixed by this livepatching pull request: > > https://lkml.kernel.org/r/20200907082036.GC8084@alley Yep, all but the vmx_handle_exit_irqoff() one as Linus noted. Thanks. -- Cheers, Stephen Rothwell pgpKwAzu8iyGj.pgp Description: OpenPGP digital signature
Re: linux-next: build warnings in Linus' tree
On Tue, Sep 08, 2020 at 09:11:02AM +1000, Stephen Rothwell wrote: > Hi all, > > Building Linus' tree, today's linux-next build (x86_64 allmodconfig) > produced these warnings: > > arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: > unreachable instruction > net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable > instruction > arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable instruction > arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: > unreachable instruction > kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable > instruction > kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable > instruction > drivers/misc/sgi-gru/grukservices.o: warning: objtool: > gru_wait_abort_proc()+0x97: unreachable instruction > drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: > unreachable instruction > drivers/message/fusion/mptbase.o: warning: objtool: > mpt_SoftResetHandler()+0x4a5: unreachable instruction > drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: > unreachable instruction > drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: > otx2_sq_append_tso()+0xab6: unreachable instruction > fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: > unreachable instruction > fs/btrfs/backref.o: warning: objtool: > btrfs_backref_finish_upper_links()+0x818: unreachable instruction > fs/btrfs/relocation.o: warning: objtool: update_backref_cache.isra.0()+0x3bf: > unreachable instruction > drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: > unreachable instruction I suspect these will all be fixed by this livepatching pull request: https://lkml.kernel.org/r/20200907082036.GC8084@alley -- Josh
linux-next: build warnings in Linus' tree
Hi all, Building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3: unreachable instruction net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable instruction arch/x86/mm/mmio-mod.o: warning: objtool: pre()+0x21a: unreachable instruction arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: unreachable instruction kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x26: unreachable instruction kernel/cred.o: warning: objtool: get_task_cred.cold()+0x19: unreachable instruction drivers/misc/sgi-gru/grukservices.o: warning: objtool: gru_wait_abort_proc()+0x97: unreachable instruction drivers/scsi/pcmcia/aha152x_core.o: warning: objtool: is_complete()+0x6c6: unreachable instruction drivers/message/fusion/mptbase.o: warning: objtool: mpt_SoftResetHandler()+0x4a5: unreachable instruction drivers/scsi/aic7xxx/aic79xx_core.o: warning: objtool: ahd_intr()+0x2a9: unreachable instruction drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.o: warning: objtool: otx2_sq_append_tso()+0xab6: unreachable instruction fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit.cold()+0x12: unreachable instruction fs/btrfs/backref.o: warning: objtool: btrfs_backref_finish_upper_links()+0x818: unreachable instruction fs/btrfs/relocation.o: warning: objtool: update_backref_cache.isra.0()+0x3bf: unreachable instruction drivers/atm/horizon.o: warning: objtool: rx_data_av_handler()+0x452: unreachable instruction I have not idea what caused them. -- Cheers, Stephen Rothwell pgppQ0zxtFJBa.pgp Description: OpenPGP digital signature
Re: linux-next: build warnings in Linus' tree
On Mon, Nov 13, 2017 at 1:52 PM, Stephen Rothwell wrote: > Hi Linus, > > Today's linux-next build (x86_64 allmodconfig) produced these warnings: > > WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o ... Yes. Very much expected. Hopefully the involved modules will get fixed thanks to the warning. At worst, we'll just match up the files in the SPDX database and just add them before rc1. But I'd much rather see the actual maintainers react to this. Linus
linux-next: build warnings in Linus' tree
Hi Linus,
Today's linux-next build (x86_64 allmodconfig) produced these warnings:
WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o
WARNING: modpost: missing MODULE_LICENSE() in
sound/soc/codecs/snd-soc-pcm512x-spi.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-ath79.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-iop.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/accel/kxsd9-i2c.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/iio/adc/qcom-vadc-common.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/media/platform/mtk-vcodec/mtk-vcodec-common.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/media/platform/soc_camera/soc_scale_crop.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/denali_pci.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/net/phy/cortina.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/pinctrl/pxa/pinctrl-pxa2xx.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/rpmsg/qcom_glink_native.o
WARNING: modpost: missing MODULE_LICENSE() in
drivers/staging/comedi/drivers/ni_atmio.o
WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
WARNING: modpost: missing MODULE_LICENSE() in
sound/soc/codecs/snd-soc-pcm512x-spi.o
Introduced by commit
ba1029c9cbc5 ("modpost: detect modules without a MODULE_LICENSE")
--
Cheers,
Stephen Rothwell
RE: linux-next: build warnings in Linus' tree
Hello Stephen,
Thank you for reporting the error. I removed these variables from the debug
statement, because I didn't see that they were defined. It is possible that I
manually enabled the nes_debug and the #ifdef CONFIG_INFINIBAND_NES_DEBUG
statement these variables are enclosed in wasn't true, so I saw a compilation
issue.
Feel free to revert the commit bca1935ccdec ("RDMA/nes: Fix compilation error
when nes_debug is enabled") or I will submit a patch to address the issue next
week.
Regards,
Tatyana
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Wednesday, July 03, 2013 11:59 PM
To: Roland Dreier
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Nikolova, Tatyana
E
Subject: linux-next: build warnings in Linus' tree
Hi all,
Building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced
this warning (these have been around for a while):
drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str'
defined but not used [-Wunused-variable] static unsigned char
*nes_iwarp_state_str[] = {
^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined
but not used [-Wunused-variable] static unsigned char *nes_tcp_state_str[] = {
^
Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when
nes_debug is enabled").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warnings in Linus' tree
Hi all,
Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced this warning (these have been around for a while):
drivers/infiniband/hw/nes/nes_hw.c:81:23: warning: 'nes_iwarp_state_str'
defined but not used [-Wunused-variable]
static unsigned char *nes_iwarp_state_str[] = {
^
drivers/infiniband/hw/nes/nes_hw.c:92:23: warning: 'nes_tcp_state_str' defined
but not used [-Wunused-variable]
static unsigned char *nes_tcp_state_str[] = {
^
Introduced by commit bca1935ccdec ("RDMA/nes: Fix compilation error when
nes_debug is enabled").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpuVReEY4lT3.pgp
Description: PGP signature
