Re: memory leak in tls_init

2020-12-29 Thread Jakub Kicinski 
On Thu, 26 Sep 2019 18:19:09 -0700 syzbot wrote:
> 2019/09/26 13:11:21 executed programs: 23
> BUG: memory leak
> unreferenced object 0x88810e482a00 (size 512):
>comm "syz-executor.4", pid 6874, jiffies 4295090041 (age 14.090s)
>hex dump (first 32 bytes):
>  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
>  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
>backtrace:
>  [] kmemleak_alloc_recursive  
> include/linux/kmemleak.h:43 [inline]
>  [] slab_post_alloc_hook mm/slab.h:586 [inline]
>  [] slab_alloc mm/slab.c:3319 [inline]
>  [] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3548
>  [<268637bd>] kmalloc include/linux/slab.h:552 [inline]
>  [<268637bd>] kzalloc include/linux/slab.h:686 [inline]
>  [<268637bd>] create_ctx net/tls/tls_main.c:611 [inline]
>  [<268637bd>] tls_init net/tls/tls_main.c:794 [inline]
>  [<268637bd>] tls_init+0xbc/0x200 net/tls/tls_main.c:773
>  [] __tcp_set_ulp net/ipv4/tcp_ulp.c:139 [inline]
>  [] tcp_set_ulp+0xe2/0x190 net/ipv4/tcp_ulp.c:160
>  [<09cb49a0>] do_tcp_setsockopt.isra.0+0x1c1/0xe10  
> net/ipv4/tcp.c:2825
>  [] tcp_setsockopt+0x71/0x80 net/ipv4/tcp.c:3152
>  [<38a5546c>] sock_common_setsockopt+0x38/0x50  
> net/core/sock.c:3142
>  [] __sys_setsockopt+0x10f/0x220 net/socket.c:2084
>  [<3c3afaa0>] __do_sys_setsockopt net/socket.c:2100 [inline]
>  [<3c3afaa0>] __se_sys_setsockopt net/socket.c:2097 [inline]
>  [<3c3afaa0>] __x64_sys_setsockopt+0x26/0x30 net/socket.c:2097
>  [] do_syscall_64+0x73/0x1f0  
> arch/x86/entry/common.c:290
>  [] entry_SYSCALL_64_after_hwframe+0x44/0xa9

#syz invalid

This hasn't happened for over a year, so perhaps the TOE-related
restructuring accidentally fixed it, somehow.

memory leak in tls_init

2019-09-26 Thread syzbot 

Hello,

syzbot found the following crash on:

HEAD commit:f41def39 Merge tag 'ceph-for-5.4-rc1' of git://github.com/..
git tree:   upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=105b7ff960
kernel config:  https://syzkaller.appspot.com/x/.config?x=2e29707d7d1530b3
dashboard link: https://syzkaller.appspot.com/bug?extid=35bc8fe94c9f38db8320
compiler:   gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=145b341960

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+35bc8fe94c9f38db8...@syzkaller.appspotmail.com

2019/09/26 13:11:21 executed programs: 23
BUG: memory leak
unreferenced object 0x88810e482a00 (size 512):
  comm "syz-executor.4", pid 6874, jiffies 4295090041 (age 14.090s)
  hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
  backtrace:
[] kmemleak_alloc_recursive  
include/linux/kmemleak.h:43 [inline]

[] slab_post_alloc_hook mm/slab.h:586 [inline]
[] slab_alloc mm/slab.c:3319 [inline]
[] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3548
[<268637bd>] kmalloc include/linux/slab.h:552 [inline]
[<268637bd>] kzalloc include/linux/slab.h:686 [inline]
[<268637bd>] create_ctx net/tls/tls_main.c:611 [inline]
[<268637bd>] tls_init net/tls/tls_main.c:794 [inline]
[<268637bd>] tls_init+0xbc/0x200 net/tls/tls_main.c:773
[] __tcp_set_ulp net/ipv4/tcp_ulp.c:139 [inline]
[] tcp_set_ulp+0xe2/0x190 net/ipv4/tcp_ulp.c:160
[<09cb49a0>] do_tcp_setsockopt.isra.0+0x1c1/0xe10  
net/ipv4/tcp.c:2825

[] tcp_setsockopt+0x71/0x80 net/ipv4/tcp.c:3152
[<38a5546c>] sock_common_setsockopt+0x38/0x50  
net/core/sock.c:3142

[] __sys_setsockopt+0x10f/0x220 net/socket.c:2084
[<3c3afaa0>] __do_sys_setsockopt net/socket.c:2100 [inline]
[<3c3afaa0>] __se_sys_setsockopt net/socket.c:2097 [inline]
[<3c3afaa0>] __x64_sys_setsockopt+0x26/0x30 net/socket.c:2097
[] do_syscall_64+0x73/0x1f0  
arch/x86/entry/common.c:290

[] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0x88810e71e600 (size 512):
  comm "syz-executor.4", pid 6888, jiffies 4295090060 (age 13.900s)
  hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
  backtrace:
[] kmemleak_alloc_recursive  
include/linux/kmemleak.h:43 [inline]

[] slab_post_alloc_hook mm/slab.h:586 [inline]
[] slab_alloc mm/slab.c:3319 [inline]
[] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3548
[<268637bd>] kmalloc include/linux/slab.h:552 [inline]
[<268637bd>] kzalloc include/linux/slab.h:686 [inline]
[<268637bd>] create_ctx net/tls/tls_main.c:611 [inline]
[<268637bd>] tls_init net/tls/tls_main.c:794 [inline]
[<268637bd>] tls_init+0xbc/0x200 net/tls/tls_main.c:773
[] __tcp_set_ulp net/ipv4/tcp_ulp.c:139 [inline]
[] tcp_set_ulp+0xe2/0x190 net/ipv4/tcp_ulp.c:160
[<09cb49a0>] do_tcp_setsockopt.isra.0+0x1c1/0xe10  
net/ipv4/tcp.c:2825

[] tcp_setsockopt+0x71/0x80 net/ipv4/tcp.c:3152
[<38a5546c>] sock_common_setsockopt+0x38/0x50  
net/core/sock.c:3142

[] __sys_setsockopt+0x10f/0x220 net/socket.c:2084
[<3c3afaa0>] __do_sys_setsockopt net/socket.c:2100 [inline]
[<3c3afaa0>] __se_sys_setsockopt net/socket.c:2097 [inline]
[<3c3afaa0>] __x64_sys_setsockopt+0x26/0x30 net/socket.c:2097
[] do_syscall_64+0x73/0x1f0  
arch/x86/entry/common.c:290

[] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0x88810e356800 (size 512):
  comm "syz-executor.0", pid 6926, jiffies 4295090085 (age 13.650s)
  hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
  backtrace:
[] kmemleak_alloc_recursive  
include/linux/kmemleak.h:43 [inline]

[] slab_post_alloc_hook mm/slab.h:586 [inline]
[] slab_alloc mm/slab.c:3319 [inline]
[] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3548
[<268637bd>] kmalloc include/linux/slab.h:552 [inline]
[<268637bd>] kzalloc include/linux/slab.h:686 [inline]
[<268637bd>]