Re: net/ipv4/inetpeer.c stack warnings
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 14:48:59 +0200 > Gabriel C wrote: > > Hello , > > > > I noticed on current git this warning in net/ipv4/inetpeer.c > > Yeah, I have no idea why the gcc people thought that this was > something worth warning about. Especially since explicitly > checking for != NULL silences the warning again. Sigh, applied :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net/ipv4/inetpeer.c stack warnings
From: Gabriel C <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 14:29:53 +0200 > Hello , > > I noticed on current git this warning in net/ipv4/inetpeer.c > > ... > > CC net/ipv4/inetpeer.o > net/ipv4/inetpeer.c: In function 'unlink_from_pool': > net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always > evaluate as 'true' > net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always > evaluate as 'true' > net/ipv4/inetpeer.c: In function 'inet_getpeer': > net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always > evaluate as 'true' > net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always > evaluate as 'true' The compiler should not warn about that at all, the lookup() macro is called with "stack" set to NULL. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net/ipv4/inetpeer.c stack warnings
Patrick McHardy wrote: > Gabriel C wrote: > >> Hello , >> >> I noticed on current git this warning in net/ipv4/inetpeer.c >> > > Yeah, I have no idea why the gcc people thought that this was > something worth warning about. Especially since explicitly > checking for != NULL silences the warning again. > > > Thx , the patch fixes that for me. Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net/ipv4/inetpeer.c stack warnings
Gabriel C wrote:
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
Yeah, I have no idea why the gcc people thought that this was
something worth warning about. Especially since explicitly
checking for != NULL silences the warning again.
[IPV4]: Fix inetpeer gcc-4.2 warnings
CC net/ipv4/inetpeer.o
net/ipv4/inetpeer.c: In function 'unlink_from_pool':
net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always evaluate
as 'true'
net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always evaluate
as 'true'
net/ipv4/inetpeer.c: In function 'inet_getpeer':
net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always evaluate
as 'true'
net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always evaluate
as 'true'
"Fix" by checking for != NULL.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index 2f44e61..f725f9f 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -158,7 +158,7 @@ static void unlink_from_unused(struct inet_peer *p)
#define lookup(_daddr,_stack) \
({ \
struct inet_peer *u, **v; \
- if (_stack) { \
+ if (_stack != NULL) { \
stackptr = _stack; \
*stackptr++ = &peer_root; \
} \
@@ -169,7 +169,7 @@ static void unlink_from_unused(struct inet_peer *p)
v = &u->avl_left; \
else\
v = &u->avl_right; \
- if (_stack) \
+ if (_stack != NULL) \
*stackptr++ = v;\
u = *v; \
} \
net/ipv4/inetpeer.c stack warnings
Hello , I noticed on current git this warning in net/ipv4/inetpeer.c ... CC net/ipv4/inetpeer.o net/ipv4/inetpeer.c: In function 'unlink_from_pool': net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always evaluate as 'true' net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always evaluate as 'true' net/ipv4/inetpeer.c: In function 'inet_getpeer': net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always evaluate as 'true' net/ipv4/inetpeer.c:409: warning: the address of 'stack' will always evaluate as 'true' ... Regards, Gabriel C - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
