Re: net: ax25: %x specifier misuse in kernel?

2019-04-18 Thread Eric Dumazet 



On 04/18/2019 07:01 PM, PlusOneSecond wrote:
> In ax25_info_show of af_ax25.c:1891, linux-5.1.
> The pointer ax25 is cast to long type to print out.
> 
> Why it prints the a pointer 'ax25' use %8.8lx rather than %p?
> If it really want to print the value of ax25, it should use %px.

I guess nobody cared enough abut this security issue.

Please send a patch, thanks.

> 
> Also, I  scan the kernel code and notice that most of the pointers cast to 
> long or unsigned long type to print out are marked with __iomem.
> Is it a misuse of %x?
> 
> 
> Thanks.
>

net: ax25: %x specifier misuse in kernel?

2019-04-18 Thread PlusOneSecond 
In ax25_info_show of af_ax25.c:1891, linux-5.1.
The pointer ax25 is cast to long type to print out.

Why it prints the a pointer 'ax25' use %8.8lx rather than %p?
If it really want to print the value of ax25, it should use %px.

Also, I  scan the kernel code and notice that most of the pointers cast to long 
or unsigned long type to print out are marked with __iomem.
Is it a misuse of %x?


Thanks.