patch pci-increment-pos-before-looking-for-the-next-cap-in-__pci_find_next_ht_cap.patch added to gregkh-2.6 tree
This is a note to let you know that I've just added the patch titled Subject: PCI: increment pos before looking for the next cap in __pci_find_next_ht_cap to my gregkh-2.6 tree. Its filename is pci-increment-pos-before-looking-for-the-next-cap-in-__pci_find_next_ht_cap.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ >From [EMAIL PROTECTED] Fri Jan 5 15:01:21 2007 From: Brice Goglin <[EMAIL PROTECTED]> Date: Fri, 05 Jan 2007 23:52:14 +0100 Subject: PCI: increment pos before looking for the next cap in __pci_find_next_ht_cap To: Greg KH <[EMAIL PROTECTED]>, Michael Ellerman <[EMAIL PROTECTED]> Cc: LKML Message-ID: <[EMAIL PROTECTED]> While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we noticed that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT MSI capabilities anymore. It is actually caused by the MSI mapping on the root chipset being the 2nd HT capability in the chain. pci_find_ht_capability() does not seem to find anything but the first HT cap correctly, because it forgets to increment the position before looking for the next cap. The following patch seems to fix it. At least, this prooves that having a ttl is good idea since the machine would have been stucked in an infinite loop if we didn't have a ttl :) Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- drivers/pci/pci.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- gregkh-2.6.orig/drivers/pci/pci.c +++ gregkh-2.6/drivers/pci/pci.c @@ -254,7 +254,8 @@ static int __pci_find_next_ht_cap(struct if ((cap & mask) == ht_cap) return pos; - pos = __pci_find_next_cap_ttl(dev->bus, dev->devfn, pos, + pos = __pci_find_next_cap_ttl(dev->bus, dev->devfn, + pos + PCI_CAP_LIST_NEXT, PCI_CAP_ID_HT, ); } Patches currently in gregkh-2.6 which might be from [EMAIL PROTECTED] are - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
patch pci-increment-pos-before-looking-for-the-next-cap-in-__pci_find_next_ht_cap.patch added to gregkh-2.6 tree
This is a note to let you know that I've just added the patch titled Subject: PCI: increment pos before looking for the next cap in __pci_find_next_ht_cap to my gregkh-2.6 tree. Its filename is pci-increment-pos-before-looking-for-the-next-cap-in-__pci_find_next_ht_cap.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ From [EMAIL PROTECTED] Fri Jan 5 15:01:21 2007 From: Brice Goglin [EMAIL PROTECTED] Date: Fri, 05 Jan 2007 23:52:14 +0100 Subject: PCI: increment pos before looking for the next cap in __pci_find_next_ht_cap To: Greg KH [EMAIL PROTECTED], Michael Ellerman [EMAIL PROTECTED] Cc: LKML linux-kernel@vger.kernel.org Message-ID: [EMAIL PROTECTED] While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we noticed that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT MSI capabilities anymore. It is actually caused by the MSI mapping on the root chipset being the 2nd HT capability in the chain. pci_find_ht_capability() does not seem to find anything but the first HT cap correctly, because it forgets to increment the position before looking for the next cap. The following patch seems to fix it. At least, this prooves that having a ttl is good idea since the machine would have been stucked in an infinite loop if we didn't have a ttl :) Signed-off-by: Brice Goglin [EMAIL PROTECTED] Signed-off-by: Andrew J. Gallatin [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/pci/pci.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- gregkh-2.6.orig/drivers/pci/pci.c +++ gregkh-2.6/drivers/pci/pci.c @@ -254,7 +254,8 @@ static int __pci_find_next_ht_cap(struct if ((cap mask) == ht_cap) return pos; - pos = __pci_find_next_cap_ttl(dev-bus, dev-devfn, pos, + pos = __pci_find_next_cap_ttl(dev-bus, dev-devfn, + pos + PCI_CAP_LIST_NEXT, PCI_CAP_ID_HT, ttl); } Patches currently in gregkh-2.6 which might be from [EMAIL PROTECTED] are - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
