Re: Basic perf PMU support for Haswell v6
On Tue, Mar 12, 2013 at 2:58 PM, Ingo Molnar wrote: > > * Stephane Eranian wrote: > >> Hi, >> >> I am not seeing those patches in tip.git tree as of today. >> What is still wrong with those patches? I think they >> are good for providing the basic enablement for HSW. > > There were still problems with them so they didn't make it > into v3.9 - now that the development window is open I'll check > the latest iteration (v9), in a couple of days. > Ok, then. We need to move forward with HSW now. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Basic perf PMU support for Haswell v6
* Stephane Eranian wrote: > Hi, > > I am not seeing those patches in tip.git tree as of today. > What is still wrong with those patches? I think they > are good for providing the basic enablement for HSW. There were still problems with them so they didn't make it into v3.9 - now that the development window is open I'll check the latest iteration (v9), in a couple of days. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Basic perf PMU support for Haswell v6
Hi, I am not seeing those patches in tip.git tree as of today. What is still wrong with those patches? I think they are good for providing the basic enablement for HSW. On Tue, Feb 12, 2013 at 11:04 PM, Andi Kleen wrote: > > This is based on v7 of the full Haswell PMU support, but > ported to the latest perf/core and stripped down to the > bare bones > > Only for very extremly basic usage. > > Most interesting new features are not in this patchkit > (full version is > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git hsw/pmu5) > > Contains support for: > - Basic Haswell PMU and PEBS support > - Late unmasking of the PMI > - Support for wide counters > > v2: Addressed Stephane's feedback. See individual patches for details. > v3: now even more bite-sized. Qualifier constraints merged earlier. > v4: Rename some variables, add some comments and other minor changes. > Add some Reviewed/Tested-bys. > v5: Address some minor review feedback. Port to latest perf/core > v6: Add just some variable names, add comments, edit descriptions, some > more testing, rebased to latest perf/core > > -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Basic perf PMU support for Haswell v6
Hi, I am not seeing those patches in tip.git tree as of today. What is still wrong with those patches? I think they are good for providing the basic enablement for HSW. On Tue, Feb 12, 2013 at 11:04 PM, Andi Kleen a...@firstfloor.org wrote: This is based on v7 of the full Haswell PMU support, but ported to the latest perf/core and stripped down to the bare bones Only for very extremly basic usage. Most interesting new features are not in this patchkit (full version is git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git hsw/pmu5) Contains support for: - Basic Haswell PMU and PEBS support - Late unmasking of the PMI - Support for wide counters v2: Addressed Stephane's feedback. See individual patches for details. v3: now even more bite-sized. Qualifier constraints merged earlier. v4: Rename some variables, add some comments and other minor changes. Add some Reviewed/Tested-bys. v5: Address some minor review feedback. Port to latest perf/core v6: Add just some variable names, add comments, edit descriptions, some more testing, rebased to latest perf/core -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Basic perf PMU support for Haswell v6
* Stephane Eranian eran...@google.com wrote: Hi, I am not seeing those patches in tip.git tree as of today. What is still wrong with those patches? I think they are good for providing the basic enablement for HSW. There were still problems with them so they didn't make it into v3.9 - now that the development window is open I'll check the latest iteration (v9), in a couple of days. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Basic perf PMU support for Haswell v6
On Tue, Mar 12, 2013 at 2:58 PM, Ingo Molnar mi...@kernel.org wrote: * Stephane Eranian eran...@google.com wrote: Hi, I am not seeing those patches in tip.git tree as of today. What is still wrong with those patches? I think they are good for providing the basic enablement for HSW. There were still problems with them so they didn't make it into v3.9 - now that the development window is open I'll check the latest iteration (v9), in a couple of days. Ok, then. We need to move forward with HSW now. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Basic perf PMU support for Haswell v6
This is based on v7 of the full Haswell PMU support, but ported to the latest perf/core and stripped down to the bare bones Only for very extremly basic usage. Most interesting new features are not in this patchkit (full version is git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git hsw/pmu5) Contains support for: - Basic Haswell PMU and PEBS support - Late unmasking of the PMI - Support for wide counters v2: Addressed Stephane's feedback. See individual patches for details. v3: now even more bite-sized. Qualifier constraints merged earlier. v4: Rename some variables, add some comments and other minor changes. Add some Reviewed/Tested-bys. v5: Address some minor review feedback. Port to latest perf/core v6: Add just some variable names, add comments, edit descriptions, some more testing, rebased to latest perf/core -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Basic perf PMU support for Haswell v6
This is based on v7 of the full Haswell PMU support, but ported to the latest perf/core and stripped down to the bare bones Only for very extremly basic usage. Most interesting new features are not in this patchkit (full version is git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git hsw/pmu5) Contains support for: - Basic Haswell PMU and PEBS support - Late unmasking of the PMI - Support for wide counters v2: Addressed Stephane's feedback. See individual patches for details. v3: now even more bite-sized. Qualifier constraints merged earlier. v4: Rename some variables, add some comments and other minor changes. Add some Reviewed/Tested-bys. v5: Address some minor review feedback. Port to latest perf/core v6: Add just some variable names, add comments, edit descriptions, some more testing, rebased to latest perf/core -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf PMU support for Haswell v6
[Updated version for the latest master tree and various fixes, addressing review feedback. See end for details. This should be ready for merging now, just waiting for Peter] This adds perf PMU support for the upcoming Haswell core. The patchkit is fairly large, mainly due to various enhancement for TSX. TSX tuning relies heavily on the PMU, so I tried hard to make all facilities easily available. In addition it also has some other enhancements. This includes changes to the core perf code, to the x86 specific part, to the perf user land tools and to KVM Available at git://git.kernel.org/pub/scm/linux/kernel/ak/linux-misc.git hsw/pmu3 High level overview: - Basic Haswell PMU support - Easy high level TSX measurement in perf stat -T - Transaction events and attributes implemented with sysfs enumeration - Export arch perfmon events in sysfs - Generic weightend profiling for memory latency and transaction abort costs. - Support for address profiling - Support for filtering events inside/outside transactions - KVM support to do this from guests - Support for filtering/sorting/bucketing transaction abort types based on PEBS information - LBR support for transactions For more details on the Haswell PMU please see the SDM. For more details on TSX please see http://halobates.de/adding-lock-elision-to-linux.pdf Some of the added features could be added to older CPUs too. I plan to do this, but in separate patches. Review appreciated. v2: Removed generic transaction events and qualifiers and use sysfs enumeration. Also export arch perfmon, so that the qualifiers work. Fixed various issues this exposed. Don't use a special macro for the TSX constraints anymore. Address other review feedback. Added pdir event in sysfs. v3: Fix various bugs and address review comments. tx-aborts instead of cpu/tx-aborts/ works now (with some limitations) cpu/instructions,intx=1/ works now v4: Addressed all review feedback (I hope). See changelog in individual patches. KVM support now works again with more changes. Forbid some more flag combinations that don't work well. v5: Rebased on latest perf/core. New method for sysfs events. Obsolete patches dropped. Added one patch from Stephane. Fixed generic aliases inside cpu// Improved transaction flags decoding Addressed all review feedback (except for two minor items in perf tools from Namhyung) v6: Fix WERROR=1 build with latest fixes. Address KVM feedback. Improve transaction flags display. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf PMU support for Haswell v6
[Updated version for the latest master tree and various fixes, addressing review feedback. See end for details. This should be ready for merging now, just waiting for PeterIngo.] This adds perf PMU support for the upcoming Haswell core. The patchkit is fairly large, mainly due to various enhancement for TSX. TSX tuning relies heavily on the PMU, so I tried hard to make all facilities easily available. In addition it also has some other enhancements. This includes changes to the core perf code, to the x86 specific part, to the perf user land tools and to KVM Available at git://git.kernel.org/pub/scm/linux/kernel/ak/linux-misc.git hsw/pmu3 High level overview: - Basic Haswell PMU support - Easy high level TSX measurement in perf stat -T - Transaction events and attributes implemented with sysfs enumeration - Export arch perfmon events in sysfs - Generic weightend profiling for memory latency and transaction abort costs. - Support for address profiling - Support for filtering events inside/outside transactions - KVM support to do this from guests - Support for filtering/sorting/bucketing transaction abort types based on PEBS information - LBR support for transactions For more details on the Haswell PMU please see the SDM. For more details on TSX please see http://halobates.de/adding-lock-elision-to-linux.pdf Some of the added features could be added to older CPUs too. I plan to do this, but in separate patches. Review appreciated. v2: Removed generic transaction events and qualifiers and use sysfs enumeration. Also export arch perfmon, so that the qualifiers work. Fixed various issues this exposed. Don't use a special macro for the TSX constraints anymore. Address other review feedback. Added pdir event in sysfs. v3: Fix various bugs and address review comments. tx-aborts instead of cpu/tx-aborts/ works now (with some limitations) cpu/instructions,intx=1/ works now v4: Addressed all review feedback (I hope). See changelog in individual patches. KVM support now works again with more changes. Forbid some more flag combinations that don't work well. v5: Rebased on latest perf/core. New method for sysfs events. Obsolete patches dropped. Added one patch from Stephane. Fixed generic aliases inside cpu// Improved transaction flags decoding Addressed all review feedback (except for two minor items in perf tools from Namhyung) v6: Fix WERROR=1 build with latest fixes. Address KVM feedback. Improve transaction flags display. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
