Re: thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference
Hans, Pali, On Tue, Jan 05, 2016 at 12:44:54PM +0100, Hans de Goede wrote: > Hi all, > > On 05-01-16 09:17, Pali Rohár wrote: > >Hello, > > > >looks like this fault is in acpi video module, not in thinkpad. CCing > >Hans who introduced this acpi video brightness key change. > > > >Hans, can you look at this bug? > > Pali thanks for bringing this to my attention. > > Adrien Schildknecht has already posted a fix for this, I've added > all people receiving this mail to the Cc for my reply (my ack) > for Adrien's fix. > > Regards, > > Hans > [...] Thanks, that fixed the problem [1] :-) [1]: https://lkml.org/lkml/2016/1/4/704 -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference
Hi all, On 05-01-16 09:17, Pali Rohár wrote: Hello, looks like this fault is in acpi video module, not in thinkpad. CCing Hans who introduced this acpi video brightness key change. Hans, can you look at this bug? Pali thanks for bringing this to my attention. Adrien Schildknecht has already posted a fix for this, I've added all people receiving this mail to the Cc for my reply (my ack) for Adrien's fix. Regards, Hans On Monday 04 January 2016 18:33:47 Jeremiah Mahler wrote: all, Just tried linux-next 20160104 on a Lenovo Carbon X1 and I got a BUG message about a NULL pointer dereference. There is also a WARNING about a mutex (see below). It looks like it might be related to something in the thinkpad_acpi module. [...] [2.374627] thinkpad_acpi: ThinkPad ACPI Extras v0.25 [2.374630] thinkpad_acpi: http://ibm-acpi.sf.net/ [2.374632] thinkpad_acpi: ThinkPad BIOS G6ET59WW (2.03 ), EC unknown [2.374633] thinkpad_acpi: Lenovo ThinkPad X1 Carbon, model 3443CTO [2.375176] thinkpad_acpi: Unsupported brightness interface [2.375303] thinkpad_acpi: radio switch found; radios are enabled [2.375317] [ cut here ] [2.375384] WARNING: CPU: 1 PID: 303 at kernel/locking/mutex.c:526 __mutex_lock_slowpath+0x2d8/0x2f0() [2.375453] DEBUG_LOCKS_WARN_ON(l->magic != l) [2.375503] Modules linked in: [2.375592] battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal [2.377790] CPU: 1 PID: 303 Comm: systemd-udevd Not tainted 4.4.0-rc7-next-20160104+ #2 [2.377888] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 [2.377984] 81722534 812d0967 880035e07ae0 8106ad7d [2.378269] a0381360 880035e07b30 a0381368 8801181ef100 [2.378550] a03ea348 8106adfc 8172251c 0020 [2.378817] Call Trace: [2.378895] [] ? dump_stack+0x40/0x59 [2.378971] [] ? warn_slowpath_common+0x7d/0xb0 [2.379033] [] ? warn_slowpath_fmt+0x4c/0x50 [2.379109] [] ? kernfs_add_one+0x103/0x160 [2.379185] [] ? __mutex_lock_slowpath+0x2d8/0x2f0 [2.379262] [] ? mutex_lock+0x16/0x30 [2.379343] [] ? acpi_video_handles_brightness_key_presses+0x12/0x40 [video] [2.379427] [] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] [2.379502] [] ? thinkpad_acpi_module_init.part.32+0x5f6/0x925 [thinkpad_acpi] [2.379598] [] ? thinkpad_acpi_module_init.part.32+0x925/0x925 [thinkpad_acpi] [2.379693] [] ? thinkpad_acpi_module_init+0x352/0x8cf [thinkpad_acpi] [2.379799] [] ? free_pcppages_bulk+0xbb/0x480 [2.379871] [] ? do_one_initcall+0xb2/0x200 [2.379947] [] ? do_init_module+0x5b/0x1e0 [2.380012] [] ? load_module+0x220e/0x2810 [2.380079] [] ? __symbol_put+0x30/0x30 [2.380147] [] ? SyS_finit_module+0x90/0xc0 [2.380219] [] ? entry_SYSCALL_64_fastpath+0x16/0x71 [2.380296] ---[ end trace 60661306144c0866 ]--- [2.380374] BUG: unable to handle kernel NULL pointer dereference at (null) [2.380552] IP: [] __mutex_lock_slowpath+0xd5/0x2f0 [2.380682] PGD 0 [2.380795] Oops: 0002 [#1] SMP [2.380968] Modules linked in: battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal [2.383278] CPU: 1 PID: 303 Comm: systemd-udevd Tainted: GW 4.4.0-rc7-next-20160104+ #2 [2.383358] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 [2.383455] task: 8801181ef100 ti: 880035e04000 task.ti: 880035e04000 [2.383547] RIP: 0010:[] [] __mutex_lock_slowpath+0xd5/0x2f0 [2.383634] ACPI: Battery Slot [BAT0] (battery present) [2.383706] RSP: 0018:880035e07b40 EFLAGS: 00010002 [2.383761] RAX: RBX: a0381360 RCX: a0381380 [2.383820] RDX: RSI: 880035e07b50 RDI: a0381360 [2.383874] RBP: 880035e07ba0 R08: R09: 02c4 [2.383924] R10: 81a85600 R11: 02c4 R12: a0381368 [2.383975] R13: 8801181ef100 R14: R15: 0246 [2.384026] FS: 7f1c1743a8c0() GS:88011e28() knlGS: [2.384087] CS: 0010 DS: ES: CR0: 80050033 [2.384136] CR2: CR3: 35fa6000 CR4: 001406e0
Re: thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference
Hello, looks like this fault is in acpi video module, not in thinkpad. CCing Hans who introduced this acpi video brightness key change. Hans, can you look at this bug? On Monday 04 January 2016 18:33:47 Jeremiah Mahler wrote: > all, > > Just tried linux-next 20160104 on a Lenovo Carbon X1 and I got a BUG > message about a NULL pointer dereference. There is also a WARNING about > a mutex (see below). It looks like it might be related to something in > the thinkpad_acpi module. > > [...] > [2.374627] thinkpad_acpi: ThinkPad ACPI Extras v0.25 > [2.374630] thinkpad_acpi: http://ibm-acpi.sf.net/ > [2.374632] thinkpad_acpi: ThinkPad BIOS G6ET59WW (2.03 ), EC unknown > [2.374633] thinkpad_acpi: Lenovo ThinkPad X1 Carbon, model 3443CTO > [2.375176] thinkpad_acpi: Unsupported brightness interface > [2.375303] thinkpad_acpi: radio switch found; radios are enabled > [2.375317] [ cut here ] > [2.375384] WARNING: CPU: 1 PID: 303 at kernel/locking/mutex.c:526 > __mutex_lock_slowpath+0x2d8/0x2f0() > [2.375453] DEBUG_LOCKS_WARN_ON(l->magic != l) > [2.375503] Modules linked in: > [2.375592] battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei > video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core > i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 > autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci > sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal > [2.377790] CPU: 1 PID: 303 Comm: systemd-udevd Not tainted > 4.4.0-rc7-next-20160104+ #2 > [2.377888] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) > 09/11/2012 > [2.377984] 81722534 812d0967 880035e07ae0 > 8106ad7d > [2.378269] a0381360 880035e07b30 a0381368 > 8801181ef100 > [2.378550] a03ea348 8106adfc 8172251c > 0020 > [2.378817] Call Trace: > [2.378895] [] ? dump_stack+0x40/0x59 > [2.378971] [] ? warn_slowpath_common+0x7d/0xb0 > [2.379033] [] ? warn_slowpath_fmt+0x4c/0x50 > [2.379109] [] ? kernfs_add_one+0x103/0x160 > [2.379185] [] ? __mutex_lock_slowpath+0x2d8/0x2f0 > [2.379262] [] ? mutex_lock+0x16/0x30 > [2.379343] [] ? > acpi_video_handles_brightness_key_presses+0x12/0x40 [video] > [2.379427] [] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] > [2.379502] [] ? > thinkpad_acpi_module_init.part.32+0x5f6/0x925 [thinkpad_acpi] > [2.379598] [] ? > thinkpad_acpi_module_init.part.32+0x925/0x925 [thinkpad_acpi] > [2.379693] [] ? thinkpad_acpi_module_init+0x352/0x8cf > [thinkpad_acpi] > [2.379799] [] ? free_pcppages_bulk+0xbb/0x480 > [2.379871] [] ? do_one_initcall+0xb2/0x200 > [2.379947] [] ? do_init_module+0x5b/0x1e0 > [2.380012] [] ? load_module+0x220e/0x2810 > [2.380079] [] ? __symbol_put+0x30/0x30 > [2.380147] [] ? SyS_finit_module+0x90/0xc0 > [2.380219] [] ? entry_SYSCALL_64_fastpath+0x16/0x71 > [2.380296] ---[ end trace 60661306144c0866 ]--- > [2.380374] BUG: unable to handle kernel NULL pointer dereference at > (null) > [2.380552] IP: [] __mutex_lock_slowpath+0xd5/0x2f0 > [2.380682] PGD 0 > [2.380795] Oops: 0002 [#1] SMP > [2.380968] Modules linked in: battery thinkpad_acpi(+) mei_me snd_timer > nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich > tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill > loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod > sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore > usb_common thermal > [2.383278] CPU: 1 PID: 303 Comm: systemd-udevd Tainted: GW > 4.4.0-rc7-next-20160104+ #2 > [2.383358] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) > 09/11/2012 > [2.383455] task: 8801181ef100 ti: 880035e04000 task.ti: > 880035e04000 > [2.383547] RIP: 0010:[] [] > __mutex_lock_slowpath+0xd5/0x2f0 > [2.383634] ACPI: Battery Slot [BAT0] (battery present) > [2.383706] RSP: 0018:880035e07b40 EFLAGS: 00010002 > [2.383761] RAX: RBX: a0381360 RCX: > a0381380 > [2.383820] RDX: RSI: 880035e07b50 RDI: > a0381360 > [2.383874] RBP: 880035e07ba0 R08: R09: > 02c4 > [2.383924] R10: 81a85600 R11: 02c4 R12: > a0381368 > [2.383975] R13: 8801181ef100 R14: R15: > 0246 > [2.384026] FS: 7f1c1743a8c0() GS:88011e28() > knlGS: > [2.384087] CS: 0010 DS: ES: CR0: 80050033 > [2.384136] CR2: CR3: 35fa6000 CR4: > 001406e0 > [2.384186] Stack: > [2.384230] 8800c76612f8 a0
thinkpad_acpi: BUG: unable to handle kernel NULL pointer dereference
all, Just tried linux-next 20160104 on a Lenovo Carbon X1 and I got a BUG message about a NULL pointer dereference. There is also a WARNING about a mutex (see below). It looks like it might be related to something in the thinkpad_acpi module. [...] [2.374627] thinkpad_acpi: ThinkPad ACPI Extras v0.25 [2.374630] thinkpad_acpi: http://ibm-acpi.sf.net/ [2.374632] thinkpad_acpi: ThinkPad BIOS G6ET59WW (2.03 ), EC unknown [2.374633] thinkpad_acpi: Lenovo ThinkPad X1 Carbon, model 3443CTO [2.375176] thinkpad_acpi: Unsupported brightness interface [2.375303] thinkpad_acpi: radio switch found; radios are enabled [2.375317] [ cut here ] [2.375384] WARNING: CPU: 1 PID: 303 at kernel/locking/mutex.c:526 __mutex_lock_slowpath+0x2d8/0x2f0() [2.375453] DEBUG_LOCKS_WARN_ON(l->magic != l) [2.375503] Modules linked in: [2.375592] battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal [2.377790] CPU: 1 PID: 303 Comm: systemd-udevd Not tainted 4.4.0-rc7-next-20160104+ #2 [2.377888] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 [2.377984] 81722534 812d0967 880035e07ae0 8106ad7d [2.378269] a0381360 880035e07b30 a0381368 8801181ef100 [2.378550] a03ea348 8106adfc 8172251c 0020 [2.378817] Call Trace: [2.378895] [] ? dump_stack+0x40/0x59 [2.378971] [] ? warn_slowpath_common+0x7d/0xb0 [2.379033] [] ? warn_slowpath_fmt+0x4c/0x50 [2.379109] [] ? kernfs_add_one+0x103/0x160 [2.379185] [] ? __mutex_lock_slowpath+0x2d8/0x2f0 [2.379262] [] ? mutex_lock+0x16/0x30 [2.379343] [] ? acpi_video_handles_brightness_key_presses+0x12/0x40 [video] [2.379427] [] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] [2.379502] [] ? thinkpad_acpi_module_init.part.32+0x5f6/0x925 [thinkpad_acpi] [2.379598] [] ? thinkpad_acpi_module_init.part.32+0x925/0x925 [thinkpad_acpi] [2.379693] [] ? thinkpad_acpi_module_init+0x352/0x8cf [thinkpad_acpi] [2.379799] [] ? free_pcppages_bulk+0xbb/0x480 [2.379871] [] ? do_one_initcall+0xb2/0x200 [2.379947] [] ? do_init_module+0x5b/0x1e0 [2.380012] [] ? load_module+0x220e/0x2810 [2.380079] [] ? __symbol_put+0x30/0x30 [2.380147] [] ? SyS_finit_module+0x90/0xc0 [2.380219] [] ? entry_SYSCALL_64_fastpath+0x16/0x71 [2.380296] ---[ end trace 60661306144c0866 ]--- [2.380374] BUG: unable to handle kernel NULL pointer dereference at (null) [2.380552] IP: [] __mutex_lock_slowpath+0xd5/0x2f0 [2.380682] PGD 0 [2.380795] Oops: 0002 [#1] SMP [2.380968] Modules linked in: battery thinkpad_acpi(+) mei_me snd_timer nvram ac snd mei video button tpm_tis(+) i2c_i801 shpchp soundcore lpc_ich tpm mfd_core i2c_core intel_smartconnect btusb btbcm btintel bluetooth rfkill loop ipv6 autofs4 ext4 crc16 mbcache jbd2 sd_mod ahci libahci libata scsi_mod sdhci_pci sdhci xhci_pci mmc_core xhci_hcd ehci_pci ehci_hcd usbcore usb_common thermal [2.383278] CPU: 1 PID: 303 Comm: systemd-udevd Tainted: GW 4.4.0-rc7-next-20160104+ #2 [2.383358] Hardware name: LENOVO 3443CTO/3443CTO, BIOS G6ET59WW (2.03 ) 09/11/2012 [2.383455] task: 8801181ef100 ti: 880035e04000 task.ti: 880035e04000 [2.383547] RIP: 0010:[] [] __mutex_lock_slowpath+0xd5/0x2f0 [2.383634] ACPI: Battery Slot [BAT0] (battery present) [2.383706] RSP: 0018:880035e07b40 EFLAGS: 00010002 [2.383761] RAX: RBX: a0381360 RCX: a0381380 [2.383820] RDX: RSI: 880035e07b50 RDI: a0381360 [2.383874] RBP: 880035e07ba0 R08: R09: 02c4 [2.383924] R10: 81a85600 R11: 02c4 R12: a0381368 [2.383975] R13: 8801181ef100 R14: R15: 0246 [2.384026] FS: 7f1c1743a8c0() GS:88011e28() knlGS: [2.384087] CS: 0010 DS: ES: CR0: 80050033 [2.384136] CR2: CR3: 35fa6000 CR4: 001406e0 [2.384186] Stack: [2.384230] 8800c76612f8 a0381380 a0381380 [2.384419] 880035e07b50 8800c9ea1800 a0381360 [2.384607] 0001 0001 a03ea348 a03e1c60 [2.384799] Call Trace: [2.384846] [] ? mutex_lock+0x16/0x30 [2.384896] [] ? acpi_video_handles_brightness_key_presses+0x12/0x40 [video] [2.384961] [] ? hotkey_init+0x5aa/0x716 [thinkpad_acpi] [
