Re: [patch 4/8] irq code: Add coherence test for PREEMPT_ACTIVE

[Blaisorblade]

On Friday 27 May 2005 02:38, [EMAIL PROTECTED] wrote:
> After porting this fixlet to UML:
>
> http://linux.bkbits.net:8080/linux-2.5/[EMAIL PROTECTED]
>
> , I've also added a warning which should refuse compilation with insane
> values for PREEMPT_ACTIVE... maybe we should simply move PREEMPT_ACTIVE out
> of architectures using GENERIC_IRQS.
Ok, a grep shows that possible culprits (i.e. giving success to
grep GENERIC_HARDIRQS arch/*/Kconfig, and using 0x400 as PREEMPT_ACTIVE, 
as given by grep PREEMPT_ACTIVE include/asm-*/thread_info.h) are (at a first 
glance): frv, sh, sh64.

After a bit of checking, I also verified if they had overriden the value of 
HARDIRQ_BITS. Which they haven't (it seems it's defined exactly where 
CONFIG_HARDIRQS is not used, i.e. nobody is using the ability to override it 
currently).

This was not a very deep investigation, however, so feel free to verify this 
better.
-- 
Paolo Giarrusso, aka Blaisorblade
Skype user "PaoloGiarrusso"
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade





___ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it

Re: [patch 4/8] irq code: Add coherence test for PREEMPT_ACTIVE

[Paul Mundt]

On Fri, May 27, 2005 at 03:06:09AM +0200, Blaisorblade wrote:
> On Friday 27 May 2005 02:38, [EMAIL PROTECTED] wrote:
> > After porting this fixlet to UML:
> >
> > http://linux.bkbits.net:8080/linux-2.5/[EMAIL PROTECTED]
> >
> > , I've also added a warning which should refuse compilation with insane
> > values for PREEMPT_ACTIVE... maybe we should simply move PREEMPT_ACTIVE out
> > of architectures using GENERIC_IRQS.
> Ok, a grep shows that possible culprits (i.e. giving success to
> grep GENERIC_HARDIRQS arch/*/Kconfig, and using 0x400 as PREEMPT_ACTIVE, 
> as given by grep PREEMPT_ACTIVE include/asm-*/thread_info.h) are (at a first 
> glance): frv, sh, sh64.
> 
Yeah, that's bogus for sh and sh64 anyways, this should do it.

It would be nice to move PRREMPT_ACTIVE so it isn't per-arch anymore,
there's not many users that use a different value (at least for the ones
using generic hardirqs, ia64 seems to be the only one?).

Signed-off-by: Paul Mundt <[EMAIL PROTECTED]>

include/asm-sh/thread_info.h: needs update
include/asm-sh64/thread_info.h: needs update
Index: include/asm-sh/thread_info.h
===
--- 3ac9a34948049bff79a2b2ce49c0a3c84e35a748/include/asm-sh/thread_info.h  
(mode:100644)
+++ uncommitted/include/asm-sh/thread_info.h  (mode:100644)
@@ -27,7 +27,7 @@
 
 #endif
 
-#define PREEMPT_ACTIVE 0x400
+#define PREEMPT_ACTIVE 0x1000
 
 /*
  * macros/functions for gaining access to the thread information structure
Index: include/asm-sh64/thread_info.h
===
--- 3ac9a34948049bff79a2b2ce49c0a3c84e35a748/include/asm-sh64/thread_info.h  
(mode:100644)
+++ uncommitted/include/asm-sh64/thread_info.h  (mode:100644)
@@ -73,7 +73,7 @@
 
 #define THREAD_SIZE  8192
 
-#define PREEMPT_ACTIVE 0x400
+#define PREEMPT_ACTIVE 0x1000
 
 /* thread information flags */
 #define TIF_SYSCALL_TRACE  0   /* syscall trace active */


pgpJ62tfyRVlA.pgp
Description: PGP signature