Re: [v5 0/1] dax: enable dax fault handler to report VM_FAULT_HWPOISON
On Tue, Jun 27, 2023 at 08:08:19AM +0200, Markus Elfring wrote: > > The thought was to put descriptions unsuitable for commit header in the > > cover letter. > > How do you think about to put additional information below triple dashes > (or even into improved change descriptions)? > > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n686 Markus, Please go away. Your feedback is not helpful. Thank you.
Re: [v5 0/1] dax: enable dax fault handler to report VM_FAULT_HWPOISON
>> How do you think about to put additional information below triple dashes >> (or even into improved change descriptions)? >> >> See also: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n686 > > Markus, > > Please go away. Your feedback is not helpful. Would you insist on the usage of cover letters also for single patches? Regards, Markus
Re: [v5 0/1] dax: enable dax fault handler to report VM_FAULT_HWPOISON
On Tue, Jun 27, 2023 at 06:22:47PM +0200, Markus Elfring wrote: > >> How do you think about to put additional information below triple dashes > >> (or even into improved change descriptions)? > >> > >> See also: > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n686 > > > > Markus, > > > > Please go away. Your feedback is not helpful. > > Would you insist on the usage of cover letters also for single patches? I would neither insist on it, nor prohibit it. It simply does not make enough difference.
Re: [v5 0/1] dax: enable dax fault handler to report VM_FAULT_HWPOISON
>> Would you insist on the usage of cover letters also for single patches? > > I would neither insist on it, nor prohibit it. It seems that you can tolerate an extra message here. > It simply does not make enough difference. Can it occasionally be a bit nicer to receive all relevant information within a single patch instead of a combination of two messages? Regards, Markus
Re: [v5 0/1] dax: enable dax fault handler to report VM_FAULT_HWPOISON
Markus Elfring wrote: > >> Would you insist on the usage of cover letters also for single patches? > > > > I would neither insist on it, nor prohibit it. > > It seems that you can tolerate an extra message here. > > > > It simply does not make enough difference. > > Can it occasionally be a bit nicer to receive all relevant information within > a single patch > instead of a combination of two messages? No, I am the maintainer of this code and everything I needed to judge this patch was provided. This cover letter only included inter-version details and anything relevant for the kernel history is included in the patch itself. For any code I maintain inter-version details below the --- line or in a 0/1 cover letter are perfectly acceptable. Please, if the review feedback is arbitrary, as it is in this case, strongly consider not offering it.
