Re: Version number policy!
Eugene Krasnikov k.eugen...@gmail.com writes: Good point regarding timestamp. When it comes to feature bitmap do you have an example of such a bitmap from carl9170? Why not to rely always on major version? I'm with Christian here. In ath6kl we switched to firmware advertising feature capabilities and I have never looked back, it's so much easier. You don't need to do any mapping between firmware versions and features, you just deal one feature at a time. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath: changed kmalloc to kmemdup
Andrei Epure epure.and...@gmail.com writes:
Signed-off-by: Andrei Epure epure.and...@gmail.com
---
drivers/net/wireless/ath/ath6kl/usb.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/usb.c
b/drivers/net/wireless/ath/ath6kl/usb.c
index 5fcd342..ffa1daa 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -856,11 +856,9 @@ static int ath6kl_usb_submit_ctrl_out(struct ath6kl_usb
*ar_usb,
int ret;
if (size 0) {
- buf = kmalloc(size, GFP_KERNEL);
+ buf = kmemdup(data, size, GFP_KERNEL);
if (buf == NULL)
return -ENOMEM;
-
- memcpy(buf, data, size);
}
Thanks, applied to ath6kl.git.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath: changed kmalloc to kmemdup
Andrei Epure epure.and...@gmail.com writes: Signed-off-by: Andrei Epure epure.and...@gmail.com Thanks, I'll take this. But please prefix ath6kl patches with ath6kl: in the future. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/20] drivers/net/wireless/ath/ath6kl: remove depends on CONFIG_EXPERIMENTAL
Kees Cook keesc...@chromium.org writes: The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any depends on lines in Kconfigs. Do you want me to apply this to ath6kl.git (the normal route for ath6kl patches) or what's the plan? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable_scatter
On 09/03/2012 11:15 PM, Andi Kleen wrote:
gcc 4.8 warns
/backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:
In function 'ath6kl_sdio_enable_scatter':
/backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:748:16:
warning: 'ret' may be used uninitialized in this function
[-Wmaybe-uninitialized]
if (virt_scat || ret) {
^
The variable can indeed be uninitialized when the previous if branch is
skipped. I just set it to zero for now. I'm not fully sure the fix is
correct, maybe the || should be an ?
From a quick look || should be correct, but of course I might be missing
something. I think your patch is correct way to fix this.
Thanks, applied to ath6kl.git. I just added ath6kl: prefix to the title.
Kalle
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: Checking usb_register() return value
On 08/14/2012 11:11 AM, Marina Makienko wrote: ath6kl_usb_init() does not check usb_register() return value. As a result it may incorrectly report success of driver initialization. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Marina Makienko makie...@ispras.ru Thanks, applied to ath6kl.git. But I changed the title to use ath6kl: and made some cosmetic changes to the code. Kalle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/5] drivers/net/wireless/ath/ath6kl/main.c: introduce missing initialization
On 08/19/2012 12:25 AM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr The result of one call to a function is tested, and then at the second call to the same function, the previous result, and not the current result, is tested again. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression ret; identifier f; statement S1,S2; @@ *ret = f(...); if (\(ret != 0\|ret 0\|ret == NULL\)) S1 ... when any *f(...); if (\(ret != 0\|ret 0\|ret == NULL\)) S2 // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr Thanks, but this was already fixed in ath6kl.git by this commit: commit 3206209f231062170f060fdbae38faacff86ddbf Author: Pandiyarajan Pitchaimuthu c_ppi...@qca.qualcomm.com Date: Wed Jul 11 12:51:43 2012 +0530 ath6kl: Make use of return value from ath6kl_diag_read() In ath6kl_read_fwlogs(), return value from ath6kl_diag_read()is not used to bail out in case of any errors in reading fw log. No real issue is observed because of this, reported by source code analyzer. kvalo: fix a long line warning Signed-off-by: Pandiyarajan Pitchaimuthu c_ppi...@qca.qualcomm.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com Kalle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/5] ath6kl/wmi.c: eliminate possible double free
Hi Julia,
On 10/21/2012 01:52 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
This makes two changes. In ath6kl_wmi_cmd_send, a call to dev_kfree_skb on
the skb argument is added to the initial sanity check to more completely
establish the invariant that ath6kl_wmi_cmd_send owns its skb argument.
Then, in ath6kl_wmi_sync_point, on failure of the call to
ath6kl_wmi_cmd_send, the clearing of the local skb variable is moved up, so
that the error-handling code at the end of the function does not free it
again.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@r@
identifier f,free,a;
parameter list[n] ps;
type T;
expression e;
@@
f(ps,T a,...) {
... when any
when != a = e
if(...) { ... free(a); ... return ...; }
... when any
}
@@
identifier r.f,r.free;
expression x,a;
expression list[r.n] xs;
@@
* x = f(xs,a,...);
if (...) { ... free(a); ... return ...; }
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
I think this patch which is commited to ath6kl.git has fixed this.
commit 0616dc1f2bef563d7916c0dcedbb1bff7d9bd80b
Author: Vasanthakumar Thiagarajan vthia...@qca.qualcomm.com
Date: Tue Aug 14 10:10:33 2012 +0530
ath6kl: Fix potential skb double free in ath6kl_wmi_sync_point()
skb given to ath6kl_control_tx() is owned by ath6kl_control_tx().
Calling function should not free the skb for error cases.
This is found during code review.
kvalo: fix a checkpatch warning in ath6kl_wmi_cmd_send()
Signed-off-by: Vasanthakumar Thiagarajan vthia...@qca.qualcomm.com
Signed-off-by: Kalle Valo kv...@qca.qualcomm.com
https://github.com/kvalo/ath6kl/commit/0616dc1f2bef563d7916c0dcedbb1bff7d9bd80b
If you have the time, I would appreciate if you could take a look and
confirm.
Kalle
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8] drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON
On 11/03/2012 10:30 PM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr Thanks, applied to ath6kl.git. Kalle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 3.11-rc2 (acpi backlight, revert)
Rafael J. Wysocki r...@sisk.pl writes: James, Kamal, Steven, Jörg, Martin, Kalle, please check if the apppended patch fixes the backlight for you. I did three suspend-resume cycles and didn't notice anything wrong so this patch fixes the issue for me. I'll continue testing and will report if I spot any problems. Tested-by: Kalle Valo kv...@adurom.com -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices
Geert Uytterhoeven ge...@linux-m68k.org writes:
On Wed, 10 Jul 2013, Linux Kernel Mailing List wrote:
--- /dev/null
+++ b/drivers/net/wireless/ath/ath10k/hw.h
+#define SUPPORTED_FW_MAJOR 1
+#define SUPPORTED_FW_MINOR 0
+#define SUPPORTED_FW_RELEASE0
+#define SUPPORTED_FW_BUILD 629
+static int ath10k_check_fw_version(struct ath10k *ar)
+{
+char version[32];
+
+if (ar-fw_version_major = SUPPORTED_FW_MAJOR
+ar-fw_version_minor = SUPPORTED_FW_MINOR
+ar-fw_version_release = SUPPORTED_FW_RELEASE
+ar-fw_version_build = SUPPORTED_FW_BUILD)
+return 0;
My attention got triggered by:
drivers/net/wireless/ath/ath10k/core.c: In function ‘ath10k_check_fw_version’:
drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is always true
due to limited range of data type
I haven't seen this warning, I guess my compiler is too old.
as an u16 is always larger or equal than zero. Not much you can do to
silence that warning, though.
Too bad, I really would like to keep ath10k warning free. Easier to
maintain that way.
Does anyone have any nice trick in their sleeves to make this warning go
away? I guess one ugly option is to change u16 to int.
However, I don't think the version check is correct.
Shouldn't it stop checking later fields if an exact match is found in an
earlier field?
I.e.
if (ar-fw_version_major SUPPORTED_FW_MAJOR ||
(ar-fw_version_major == SUPPORTED_FW_MAJOR
ar-fw_version_minor SUPPORTED_FW_MINOR) ||
...) { ... }
Currently e.g. (major, minor) = (3, 0) is considered older than (2, 1).
Doh, that is indeed wrong. I'll fix that, thanks for spotting this.
Or perhaps minor is never reset to zero when major is increased? In that
case, the check is correct, but IMHO it's a bit silly to split the version
number in seperate fields.
No, the firmware engineers are supposed to reset minor version whenever
major changes.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ath10k: ATH10K should depend on HAS_DMA
Geert Uytterhoeven ge...@linux-m68k.org writes: If NO_DMA=y: drivers/built-in.o: In function `ath10k_skb_unmap': drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `ath10k_skb_map': drivers/net/wireless/ath/ath10k/core.h:83: undefined reference to `dma_map_single' drivers/net/wireless/ath/ath10k/core.h:86: undefined reference to `dma_mapping_error' drivers/built-in.o: In function `ath10k_htt_rx_ring_free': drivers/net/wireless/ath/ath10k/htt_rx.c:113: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `ath10k_htt_rx_amsdu_pop': drivers/net/wireless/ath/ath10k/htt_rx.c:296: undefined reference to `dma_unmap_single' drivers/net/wireless/ath/ath10k/htt_rx.c:389: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `__ath10k_htt_rx_ring_fill_n': drivers/net/wireless/ath/ath10k/htt_rx.c:146: undefined reference to `dma_map_single' drivers/net/wireless/ath/ath10k/htt_rx.c:150: undefined reference to `dma_mapping_error' drivers/built-in.o: In function `ath10k_htt_rx_attach': drivers/net/wireless/ath/ath10k/htt_rx.c:474: undefined reference to `dma_alloc_coherent' drivers/net/wireless/ath/ath10k/htt_rx.c:509: undefined reference to `dma_free_coherent' drivers/net/wireless/ath/ath10k/htt_rx.c:514: undefined reference to `dma_free_coherent' drivers/built-in.o: In function `ath10k_htt_rx_detach': drivers/net/wireless/ath/ath10k/htt_rx.c:220: undefined reference to `dma_unmap_single' drivers/net/wireless/ath/ath10k/htt_rx.c:228: undefined reference to `dma_free_coherent' drivers/built-in.o: In function `ath10k_skb_map': drivers/net/wireless/ath/ath10k/core.h:83: undefined reference to `dma_map_single' drivers/net/wireless/ath/ath10k/core.h:86: undefined reference to `dma_mapping_error' drivers/built-in.o: In function `ath10k_skb_unmap': drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `ath10k_skb_map': drivers/net/wireless/ath/ath10k/core.h:83: undefined reference to `dma_map_single' drivers/net/wireless/ath/ath10k/core.h:86: undefined reference to `dma_mapping_error' drivers/net/wireless/ath/ath10k/core.h:83: undefined reference to `dma_map_single' drivers/net/wireless/ath/ath10k/core.h:86: undefined reference to `dma_mapping_error' drivers/built-in.o: In function `ath10k_skb_unmap': drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' drivers/net/wireless/ath/ath10k/core.h:98: undefined reference to `dma_unmap_single' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: linux-wirel...@vger.kernel.org Thanks, I'll take this and send forward. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Ksummit-2013-discuss] KS Topic request: Handling the Stable kernel, let's dump the cc: stable tag
John W. Linville linvi...@tuxdriver.com writes: Is having a flood of fixes in x.y.1 any worse than having to got to an -rc8 or an -rc9? I think it's better to send less fixes to -rc8 or -rc9 and focus more on testing. That way there should be less regressions in later stages of -rc releases and especially in the final x.y.0 release. Most of the time I don't even consider updating to the stable releases, I just wait for the next .0 release from Linus. For this kind of workflow there is a clear advantage of slowing down patch flow before the release, better chances of not needing to update the kernel that often. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon
Joe Perches j...@perches.com writes: have a second round of convincing ath guys to change printing code. How does that sound? Luis? Kalle? Other Qualcomm/Atheros folk? I didn't quite get what you are asking from me. But for me most important is that the current debugging facilities from user's point of view don't change. I don't care if the code is in ath10k.ko or ath.ko, we are talking about ~100 lines of code anyway. One of the nominal benefits of separating the ath_level macros by subsystem was perf/tracing. Nominal? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath6kl: sdio: fix system panic when doing wifi stress test
Hi Jason,
Jason Liu r64...@freescale.com writes:
When did the wifi iperf test, meet one following kernel panic:
command: iperf -c $TARGET_IP -i 5 -t 50 -w 1M
Unable to handle kernel paging request at virtual address 1a48
pgd = 80004000
[1a48] *pgd=
Internal error: Oops: 805 [#1] SMP ARM
[...]
The kernel panic is caused by the sg_buf is not set correctly with the
following code when compiled with Yocto GCC 4.8.1:
drivers/net/wireless/ath/ath6kl/hif.h:
struct hif_scatter_req {
struct list_head list;
/* address for the read/write operation */
u32 addr;
...
/* bounce buffer for upper layers to copy to/from */
u8 *virt_dma_buf;
struct hif_scatter_item scat_list[1];
u32 scat_q_depth;
};
(Note: the scat_req.scat_list[] will dynamiclly grow with run-time)
There's actually a major bug right there, scat_list can corrupt scat_q_depth.
The GCC 4.8.1 compiler will not do the for-loop till scat_entries, instead,
it only run one round loop. This may be caused by that the GCC 4.8.1 thought
that the scat_list only have one item and then no need to do full iteration,
but this is simply wrong by looking at the assebly code. This will cause the
sg buffer not get set when scat_entries 1 and thus lead to kernel panic.
This patch is a workaround to the GCC 4.8.1 complier issue by passing the
entry address of the scat_req-scat_list to the for-loop and interate it,
then, GCC 4.8.1 will do the full for-loop correctly.
(Note: This issue not observed with GCC 4.7.2, only found on the GCC 4.8.1)
This patch does not change any function logic and no any performance
downgrade.
[...]
+ scat_list = scat_req-scat_list[0];
+
/* assemble SG list */
- for (i = 0; i scat_req-scat_entries; i++, sg++) {
+ for (i = 0; i scat_req-scat_entries; i++, sg++, scat_list++) {
ath6kl_dbg(ATH6KL_DBG_SCATTER, %d: addr:0x%p, len:%d\n,
-i, scat_req-scat_list[i].buf,
-scat_req-scat_list[i].len);
+i, scat_list-buf, scat_list-len);
- sg_set_buf(sg, scat_req-scat_list[i].buf,
-scat_req-scat_list[i].len);
+ sg_set_buf(sg, scat_list-buf, scat_list-len);
}
Working around the problem by adding a temporary variable makes me a bit
worried, I would rather fix the root cause. Is the root cause by that we
define the field with scat_list[1]?
Does the patch below help? It would also fix the corruption with
scat_q_depth. Please note that I have only compile tested it. And I
might have also missed something important, so please review it
carefully.
--- a/drivers/net/wireless/ath/ath6kl/hif.h
+++ b/drivers/net/wireless/ath/ath6kl/hif.h
@@ -197,9 +197,9 @@ struct hif_scatter_req {
/* bounce buffer for upper layers to copy to/from */
u8 *virt_dma_buf;
- struct hif_scatter_item scat_list[1];
-
u32 scat_q_depth;
+
+ struct hif_scatter_item scat_list[0];
};
struct ath6kl_irq_proc_registers {
diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c
b/drivers/net/wireless/ath/ath6kl/sdio.c
index 7126bdd..6bf15a3 100644
--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -348,7 +348,7 @@ static int ath6kl_sdio_alloc_prep_scat_req(struct
ath6kl_sdio *ar_sdio,
int i, scat_req_sz, scat_list_sz, size;
u8 *virt_buf;
- scat_list_sz = (n_scat_entry - 1) * sizeof(struct hif_scatter_item);
+ scat_list_sz = n_scat_entry * sizeof(struct hif_scatter_item);
scat_req_sz = sizeof(*s_req) + scat_list_sz;
if (!virt_scat)
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ath10k: add firmware files
Luis R. Rodriguez mcg...@do-not-panic.com writes: On Fri, Mar 14, 2014 at 1:45 AM, Kalle Valo kv...@qca.qualcomm.com wrote: + NO LICENSES OR OTHER RIGHTS, +WHETHER EXPRESS, IMPLIED, BASED ON ESTOPPEL OR OTHERWISE, ARE GRANTED +TO ANY PARTY'S PATENTS, PATENT APPLICATIONS, OR PATENTABLE INVENTIONS +BY VIRTUE OF THIS LICENSE OR THE DELIVERY OR PROVISION BY QUALCOMM +ATHEROS, INC. OF THE SOFTWARE. This -- however is new to linux-firmware -- and I hereby raise a big red fucking flag. All other licenses on linux-firmware provide at the very least a limited patent grant. What makes Qualcomm special ? Well, I was just told to use this license with our firmware, I didn't write this. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BISECTED] ssh - Received disconnect from x.x.x.x: 2: Bad packet length 3149594624
Will Deacon will.dea...@arm.com writes: Well, we probably need a bit more to go on, because I doubt that this code is to blame. More likely, the issue is in the caller. Looking at drivers/net/wireless/ti/wl1251/rx.c:182 /* The actual length doesn't include the target's alignment */ skb-len = desc-length - PLCP_HEADER_LENGTH; fc = (u16 *)skb-data; if ((*fc IEEE80211_FCTL_STYPE) == IEEE80211_STYPE_BEACON) beacon = 1; wl1251_rx_status(wl, desc, status, beacon); wl1251_debug(DEBUG_RX, rx skb 0x%p: %d B %s, skb, skb-len, beacon ? beacon : ); memcpy(IEEE80211_SKB_RXCB(skb), status, sizeof(status)); ieee80211_rx_ni(wl-hw, skb); I wonder whether that first line (with the comment about alignment) is assuming some behaviour from the mac80211 layer. You could try putting back the UNALIGNED_ACCESS in net/mac80211/rx.c and commenting out the skb-len = desc-length - PLCP_HEADER_LENGTH; line above. Adding the original author (I think) and John Linville, since I'm well out of my depth in this code! I haven't touched wl1251 for years. You should send questions to linux-wireless list and CC people who have worked on it recently. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ath6kl: set NET_NAME_USER for P2P ifs
David Herrmann dh.herrm...@gmail.com writes: P2P netdevs and other devices that are created via nl80211 from user-space have a name provided by user-space. Therefore, set NET_NAME_USER so this is correctly shown in sysfs. Cc: Kalle Valo kv...@qca.qualcomm.com Signed-off-by: David Herrmann dh.herrm...@gmail.com Looks good to me. Acked-by: Kalle Valo kv...@qca.qualcomm.com Can I take this to my ath.git tree? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/4] ath6kl: set NET_NAME_USER for P2P ifs
Kalle Valo kv...@qca.qualcomm.com writes: David Herrmann dh.herrm...@gmail.com writes: P2P netdevs and other devices that are created via nl80211 from user-space have a name provided by user-space. Therefore, set NET_NAME_USER so this is correctly shown in sysfs. Cc: Kalle Valo kv...@qca.qualcomm.com Signed-off-by: David Herrmann dh.herrm...@gmail.com Looks good to me. Acked-by: Kalle Valo kv...@qca.qualcomm.com Can I take this to my ath.git tree? Nevermind, I saw the first patch now. Just CCing random patches like this is confusing for the recipients, better to CC the full patchset. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath6kl: sdio: fix system panic when doing wifi stress test
Hi Steffen, Steffen Trumtrar s.trumt...@pengutronix.de writes: Does the patch below help? It would also fix the corruption with scat_q_depth. Please note that I have only compile tested it. And I might have also missed something important, so please review it carefully. Yes, Firstly, I have looked at the asm code and the compiler(gcc 4.8.1) works correctly after applying the following patch. Secondly, I have tested the patch with compiler(gcc 4.8.1) on the real HW, and it works fine too. Without the patch, the kernel crash will happen 100%. Thus, for the patch: Acked-by: Jason Liu r64...@freescale.com Tested-by: Jason Liu r64...@freescale.com [...] What happend with this? If I look in mainline, I don't find it. At least the reording of the struct fields looks as if one definitely wants to have that. It seems that I forgot to submit this properly, sorry about that. I did it now: http://lists.infradead.org/pipermail/ath6kl/2014-March/00.html -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Bjorn Helgaas bhelg...@google.com writes: On Wed, Feb 12, 2014 at 2:30 PM, Kalle Valo kv...@qca.qualcomm.com wrote: Bjorn Helgaas bhelg...@google.com writes: Well, as this series is small I thought it could quickly go thru your tree. But since ipr had conflicts, there is no point routing all patches altogether, so up to you guys. The wil6210 patch is already in your pci/msi branch though. It's in pci/msi, but that's not in my -next branch yet, so I can easily drop it. Do drivers/net/wireless patches normally follow a different path than the other drivers/net patches? The wil6210 and ath10k patches look just like the others in the 34-patch series (bnx2, bnx2x, tg3, bna, cxgb3, etc.), so I thought it would make more sense to include them there. ath10k patches normally go through my ath.git tree to Linville and then to David Miller. To avoid conflicts I would prefer to take ath10k patches to my tree whenever possible. OK, I won't do anything with ath10k (I haven't applied it anywhere). I have now taken the ath10k patches to my pending branch, will apply them soon. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Alexander Gordeev agord...@redhat.com writes: Signed-off-by: Alexander Gordeev agord...@redhat.com Thanks, all three patches applied to my ath.git tree. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Bjorn Helgaas bhelg...@google.com writes: Well, as this series is small I thought it could quickly go thru your tree. But since ipr had conflicts, there is no point routing all patches altogether, so up to you guys. The wil6210 patch is already in your pci/msi branch though. It's in pci/msi, but that's not in my -next branch yet, so I can easily drop it. Do drivers/net/wireless patches normally follow a different path than the other drivers/net patches? The wil6210 and ath10k patches look just like the others in the 34-patch series (bnx2, bnx2x, tg3, bna, cxgb3, etc.), so I thought it would make more sense to include them there. ath10k patches normally go through my ath.git tree to Linville and then to David Miller. To avoid conflicts I would prefer to take ath10k patches to my tree whenever possible. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates
Johannes Berg johan...@sipsolutions.net writes: Now the subject should no longer say mac80211: :) It did have a change to mac80211.h as well, but IMHO that should be in a separate patch. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath6kl: Unify sg_sz and buf_sz in ath6kl_sdio_alloc_prep_scat_req()
Geert Uytterhoeven ge...@linux-m68k.org writes: sg_sz and buf_sz are initialized and used in a mutual exclusive way. However, some versions of gcc are not smart enough to see this: drivers/net/wireless/ath/ath6kl/sdio.c: In function ‘ath6kl_sdio_alloc_prep_scat_req’: drivers/net/wireless/ath/ath6kl/sdio.c:338: warning: ‘sg_sz’ may be used uninitialized in this function Unify the sg_sz and buf_sz variables into a single size variable to kill the compiler warning. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Thanks, applied. Sorry for taking so long. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/16] wl1251: add sysfs interface for bluetooth coexistence mode configuration
Luca Coelho l...@coelho.fi writes: On Mon, 2013-10-28 at 23:39 +, Ben Hutchings wrote: On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: From: David Gnedt david.gn...@davizone.at Port the bt_coex_mode sysfs interface from wl1251 driver version included in the Maemo Fremantle kernel to allow bt-coexistence mode configuration. This enables userspace applications to set one of the modes WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO. The default mode is WL1251_BT_COEX_OFF. It should be noted that this driver always enabled bt-coexistence before and enabled bt-coexistence directly affects the receiving performance, rendering it unusable in some low-signal situations. Especially monitor mode is affected very badly with bt-coexistence enabled. [...] This should be implemented consistently with other drivers: drivers/net/wireless/ath/ath9k/htc_drv_init.c:module_param_named(btcoex_enable, ath9k_htc_btcoex_enable, int, 0444); drivers/net/wireless/ath/ath9k/init.c:module_param_named(btcoex_enable, ath9k_btcoex_enable, int, 0444); drivers/net/wireless/b43/main.c:module_param_named(btcoex, modparam_btcoex, int, 0444); drivers/net/wireless/ipw2x00/ipw2200.c:module_param(bt_coexist, int, 0444); drivers/net/wireless/iwlegacy/common.c:module_param(bt_coex_active, bool, S_IRUGO); drivers/net/wireless/iwlwifi/iwl-drv.c:module_param_named(bt_coex_active, iwlwifi_mod_params.bt_coex_active, drivers/net/wireless/ti/wlcore/sysfs.c:static DEVICE_ATTR(bt_coex_state, S_IRUGO | S_IWUSR, Oh, hmm, I see a problem here. With so many drivers doing the same thing, isn't it about time to add this to nl80211? Yes, this really needs to be in nl80211. I even suggested this years ago but was turned down at the time. Can't remember the reason anymore. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/16] mac80211: fix TX device statistics for monitor interfaces
Pali Rohár pali.ro...@gmail.com writes: From: David Gnedt david.gn...@davizone.at Count TX packets and bytes also for monitor interfaces. Signed-of-by: David Gnedt david.gn...@davizone.at You should send mac80211 patches separately, not inside a wl1251 patchset. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add WLI-UC-G300HP's Product ID.
Masami Ichikawa masami...@gmail.com writes: Support Bufallo WLI-UC-G300HP. Signed-off-by: Masami Ichikawa masami...@gmail.com Please add rt2x00: prefix to the commit title. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ath10k mailing list and new git tree
Sedat Dilek sedat.di...@gmail.com writes: On Mon, Jul 8, 2013 at 4:17 PM, Kalle Valo kv...@qca.qualcomm.com wrote: Hi, we have a new mailing list for ath10k, please use that in the future instead of ath9k-devel: http://lists.infradead.org/mailman/listinfo/ath10k As ath10k is now in wireless-next please use the new git tree which is for both ath6kl and ath10k: https://github.com/kvalo/ath I have also updated the wiki accordingly: http://wireless.kernel.org/en/users/Drivers/ath10k You have sent these new informations for MAINTAINERS file to upstream? Good point. Actually MAINTAINERS entry for ath10k is completely missing, I'll send a patch for that. Thanks. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/19] wireless: Change variable type to bool
Peter Senna Tschudin peter.se...@gmail.com writes: The variable continual is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\) Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/net/wireless/rtlwifi/efuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Please prefix the patch title with rtlwifi:. We use wireless: for changes to net/wireless. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 04/11] ath: Remove extern from function prototypes
Joe Perches j...@perches.com writes: There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes. Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/wireless/ath/ath10k/debug.h | 8 drivers/net/wireless/ath/ath6kl/common.h | 3 +-- drivers/net/wireless/ath/ath6kl/debug.h | 9 - drivers/net/wireless/ath/ath9k/ath9k.h | 2 +- 4 files changed, 10 insertions(+), 12 deletions(-) For the ath10k and ath6kl changes: Acked-by: Kalle Valo kv...@qca.qualcomm.com -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 3.11-rc2
Rafael J. Wysocki r...@sisk.pl writes: Well, please try to revert commits efaa14c and 8c5bd7a (in this order) and see if that helps. On 3.11-rc2-wl (from wireless-testing.git) my Thinkpad X230 display went really dark every time during resume and I had to blindly write to sysfs to be able to see anything. With 3.10-wl I didn't see this. Reverting the commits above fixed the issue for me. I'm using Ubuntu 12.04 64 bit. More info about my laptop: thinkpad_acpi: ThinkPad ACPI Extras v0.24 thinkpad_acpi: http://ibm-acpi.sf.net/ thinkpad_acpi: ThinkPad BIOS G2ET82WW (2.02 ), EC unknown thinkpad_acpi: Lenovo ThinkPad X230, model 2324JB2 thinkpad_acpi: detected a 8-level brightness capable ThinkPad thinkpad_acpi: radio switch found; radios are enabled thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver thinkpad_acpi: Disabling thinkpad-acpi brightness events by default... thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is unblocked thinkpad_acpi: rfkill switch tpacpi_wwan_sw: radio is unblocked thinkpad_acpi: Standard ACPI backlight interface available, not loading native one thinkpad_acpi: Console audio control enabled, mode: monitor (read only) input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input5 -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
video: X sets brightness to zero after resume
Hi Aaron, after your commit 0e9f81d3b7c (ACPI / video: Add systems that should favour native backlight interface) I have had an regression that every time after resume the display brightness has been set to zero and I need to manually set it to non-zero to see something again. Finally I started to investigate this more closely and it seems that X sets it to zero for some reason. I added a WARN_ON() and few printks to brightness_store() in drivers/video/backlight/backlight.c and this is what I see during resume: [ 49.228221] [ cut here ] [ 49.228229] WARNING: CPU: 1 PID: 1133 at drivers/video/backlight/backlight.c:173 brightness_store+0x3c/0x120( ) [ 49.228230] Modules linked in: ctr ccm uvcvideo videobuf2_core videodev videobuf2_vmalloc videobuf2_memops fu se arc4 iwldvm sha256_generic kvm_intel kvm mac80211 snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_gene ric iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 snd_hda_intel snd_hda_controller nf_nat_ipv4 nf_nat snd_hda_cod ec nf_conntrack snd_hwdep snd_pcm_oss iwlwifi snd_mixer_oss snd_pcm ip_tables x_tables thinkpad_acpi snd_seq_dum my snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq cfg80211 snd_timer snd_seq_device snd bnep rfcomm bluetooth psmouse soundcore nvram ehci_pci ehci_hcd rfkill wmi binfmt_misc ext4 jbd2 mbcache sd_mod fbcon tileblit font bitblit softcursor i915 drm_kms_helper drm cfbcopyarea i2c_algo_bit intel_gtt agpgart i2c_core video xhci_hcd cfbimgblt cfbfillrect e1000e sdhci_pci sdhci ptp pps_core mmc_core ahci libahci [ 49.228281] CPU: 1 PID: 1133 Comm: Xorg Tainted: GW 3.15.0-rc7-wl-ath+ #259 [ 49.228282] Hardware name: LENOVO 2324JB2/2324JB2, BIOS G2ET82WW (2.02 ) 09/11/2012 [ 49.228283] 817e4000 814cbee3 [ 49.228285] 810493bc 88020e2d1c98 880213bc9f10 0002 [ 49.228287] 8800c5dfc198 88020d7cbf50 81290a1c 88020e792800 [ 49.228288] Call Trace: [ 49.228293] [814cbee3] ? dump_stack+0x41/0x51 [ 49.228296] [810493bc] ? warn_slowpath_common+0x8c/0xc0 [ 49.228298] [81290a1c] ? brightness_store+0x3c/0x120 [ 49.228301] [811d7242] ? kernfs_fop_write+0x112/0x170 [ 49.228304] [8116791b] ? vfs_write+0xcb/0x1f0 [ 49.228306] [81167e20] ? SyS_write+0x50/0xb0 [ 49.228308] [814dd312] ? system_call_fastpath+0x16/0x1b [ 49.228309] ---[ end trace a1f60d12df64bdbe ]--- [ 49.228310] brightness=0 [ 49.228310] set brightness to 0 And this is PID 1133: root 1133 0.7 0.2 131504 20192 tty7 Ss+ 15:16 0:00 /usr/bin/X :0 -auth /var/run/lightdm/root/:0 -nolisten tcp vt7 -novtswitch -background none If I set video.use_native_backlight=0 in kernel command line the problem goes away. Or if I revert your commit 0e9f81d3b7c the problem also goes away. Any ideas? My setup is: Thinkpad X230 Ubuntu 12.04 64-bit i3 window manager xserver-xorg 1:7.6+12ubuntu2 -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Intel-gfx] video: X sets brightness to zero after resume
Hans de Goede hdego...@redhat.com writes: If I set video.use_native_backlight=0 in kernel command line the problem goes away. Or if I revert your commit 0e9f81d3b7c the problem also goes away. Any ideas? Not really... I've added i915 people maybe they have an idea. This is a known issue in xf86-video-intel, which gets exposed due to the video.use_native_backlight=1 option. This should be fixed in the latest 2.99.912 xf86-video-intel release. Ok, thanks. As Ubuntu 12.04 doesn't have that I'll continue to use video.use_native_backlight=0 until I update my distro. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -next 13/26] ath: Use dma_zalloc_coherent
Joe Perches j...@perches.com writes: Use the zeroing function instead of dma_alloc_coherent memset(,0,) Signed-off-by: Joe Perches j...@perches.com For ath10k: Acked-by: Kalle Valo kv...@qca.qualcomm.com -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Alexander Gordeev agord...@redhat.com writes: Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/net/wireless/ath/ath10k/pci.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 29fd197..6525e1f 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2414,8 +2414,6 @@ static int ath10k_pci_init_irq(struct ath10k *ar) ret = pci_enable_msi_block(ar_pci-pdev, ar_pci-num_msi_intrs); if (ret == 0) return 0; - if (ret 0) - pci_disable_msi(ar_pci-pdev); I don't understand how this is superfluous. When I read the documentation for pci_enable_msi_block() it states that if it can't allocate all requests, it will return the number requests it could allocate. And in that case we want to fall back other modes. Am I missing something? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Alexander Gordeev agord...@redhat.com writes: On Tue, Feb 04, 2014 at 08:32:12PM +0200, Kalle Valo wrote: Alexander Gordeev agord...@redhat.com writes: I don't understand how this is superfluous. When I read the documentation for pci_enable_msi_block() it states that if it can't allocate all requests, it will return the number requests it could allocate. And in that case we want to fall back other modes. Am I missing something? Yep. The documentation states 'could have been allocated', not 'could allocate'. IOW, MSIs are *not* enabled if a positive value returned. The code I changed tries to disable MSIs in such case, although it is not necessary, nor required. Just superfluous. Ah, thanks for explaining that. I added this to the commit log (I hate empty commit logs anyway): ath10k: Get rid of superfluous call to pci_disable_msi() The documentation states that pci_enable_msi_block() returns the number of requests 'could have been allocated', not 'could allocate'. IOW, MSIs are *not* enabled if a positive value returned. kvalo: add commit log based on Alexander's email Signed-off-by: Alexander Gordeev agord...@redhat.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com Is it ok for me to take these patches to my ath.git tree or would you prefer to route them some other way? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
Alexander Gordeev agord...@redhat.com writes: On Wed, Feb 05, 2014 at 10:21:28AM +0200, Kalle Valo wrote: Is it ok for me to take these patches to my ath.git tree or would you prefer to route them some other way? Yeah, Bjorn has indicated he would pull it to his tree. Ok, I'll drop these from my pending branch then. I just think it would have been easier if I would take these, smaller chance of conflicts that way. I get it you are fine with 2/3 and 3/3? Yes, with the addition of the commit log to 1/3 I'll give: Acked-by: Kalle Valo kv...@qca.qualcomm.com -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/7] ath10k: Use new interfaces for MSI enablement
Alexander Gordeev agord...@redhat.com writes: This update also fixes a stylistic (naming and messaging only) confusion of MSI-X vs multiple MSIs which are not the same. Signed-off-by: Alexander Gordeev agord...@redhat.com Looks good to me. Acked-by: Kalle Valo kv...@qca.qualcomm.com Do you want me to take this patch to my ath.git tree or how were you planning to handle it? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/7] ath10k: Use new interfaces for MSI enablement
Alexander Gordeev agord...@redhat.com writes: On Wed, Jan 08, 2014 at 10:23:18AM +0200, Kalle Valo wrote: Do you want me to take this patch to my ath.git tree or how were you planning to handle it? I see no option other than pushing it thru pci.git tree at this stage. Thanks, I'll then just drop it from my queue. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 02/16] wl1251: add sysfs interface for bluetooth coexistence mode configuration
Pali Rohár pali.ro...@gmail.com writes: From: David Gnedt david.gn...@davizone.at Port the bt_coex_mode sysfs interface from wl1251 driver version included in the Maemo Fremantle kernel to allow bt-coexistence mode configuration. This enables userspace applications to set one of the modes WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO. The default mode is WL1251_BT_COEX_OFF. It should be noted that this driver always enabled bt-coexistence before and enabled bt-coexistence directly affects the receiving performance, rendering it unusable in some low-signal situations. Especially monitor mode is affected very badly with bt-coexistence enabled. Signed-off-by: David Gnedt david.gn...@davizone.at Signed-off-by: Pali Rohár pali.ro...@gmail.com I think this is also what I wrote a long time. And also this sysfs hack should not go to upstream. Over the years there has been some talk about solving the BT coex properly, but I haven't seen any patches. I guess the proper solution would be that BT subsystem in kernel would notify wireless drivers about BT use? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 15/16] wl1251: Add sysfs file address for setting permanent mac address
Pali Rohár pali.ro...@gmail.com writes: Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac address by userspace helper program. Patch is needed for devices which do not store mac address in internal wl1251 eeprom. Signed-off-by: Pali Rohár pali.ro...@gmail.com We have ioctl() command for setting the mac address. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 01/16] wl1251: fix scan behaviour while not associated
Pavel Machek pa...@ucw.cz writes: ssids can have \0s in them... and what is worse, they may not be 0 terminated AFAICT. Potential solution is at http://www.spinics.net/lists/linux-wireless/msg98640.html . I just use print_hex_dump_bytes() to print SSIDs. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 14/16] wl1251: Add sysfs file tx_mgmt_frm_rate for setting rate
Pali Rohár pali.ro...@gmail.com writes: This patch adds support for configuring reg domains. Patch was extracted from Maemo 2.6.28 kernel. Signed-off-by: Pali Rohár pali.ro...@gmail.com [...] + /* FIXME: what's the maximum length of buf? page size?*/ + len = 500; Based on the comment here I'm guessing that I wrote this horrible hack :) I can't recall anymore why it was needed, maybe something for BT coex? But this code should never go upstream. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 14/30] ath6kl: remove unnecessary break after return
Fabian Frederick f...@skynet.be writes: Signed-off-by: Fabian Frederick f...@skynet.be Acked-by: Kalle Valo kv...@qca.qualcomm.com Who is taking this patch? Please let me know if I should apply it to my tree. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] checkpatch.pl: Remove --file option
Borislav Petkov b...@alien8.de writes: No, checkpatch should only check patches and not whole file. It is wrong. Fullstop. Please don't remove --file, I use it all the time when maintaining ath6kl and ath10k. It's a lot easier in my workflow to test the whole driver in one go than start testing individual patches. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes
Johannes Berg johan...@sipsolutions.net writes: On Wed, 2014-02-05 at 19:44 -0600, Calvin Owens wrote: Create a function to return a descriptive string for each reason code, and print that instead of the numeric value in the kernel log. These codes are easily found on popular search engines, but one is generally not able to access the internet when dealing with wireless connectivity issues. I believe both iw and wpa_supplicant already have the reason code printout, and if you're diagnosing connectivity issues then you're probably using those anyway (e.g. iw event -t), so I don't really see much point in adding this to the kernel? FWIW I find this useful. When I have connection problems I rarely look at wpasupplicant, mostly I'm so lazy that I just check from the kernel log what's happening. Just my 0.02 EUR. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes
Luca Coelho l...@coelho.fi writes: Forum, and there we are lucky if we get dmesg output. When we do and it contains a deauthentication reason, I always need to bring up a web page to interpret the output. With this change, one step could be skipped. But is it worth putting this parsing in the *kernel*? I mean, if anyone is interested enough in the problem, a simple google query is not that hard, right? Sure, it's not hard to find it. My and Larry's point is more about convenience and user friendliness. On the other hand I do understand that kernel is getting bloated all the time, for example openwrt is suffering from that. So not really sure what is the best. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT] Networking
John W. Linville linvi...@tuxdriver.com writes: On Tue, Jul 15, 2014 at 11:46:14AM -0700, David Miller wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Tue, 15 Jul 2014 08:52:33 -0700 And if David actually asks for these, my apologies.. I didn't ask for these :-) Just trying to be helpful, for those times when there are non-trivial merge conflicts. I can stop. Just out of curiosity, what is the best way to send a proposal how to fix a merge conflict? For example, if I send a pull request to John which I know will issue a conflict it would be nice to include instructions (or some sort of patch) how I think it should be resolved. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers: net: wireless: Add include guards
Rasmus Villemoes li...@rasmusvillemoes.dk writes: The files ray_cs.h and rayctl.h both contain two thirds of what appears to be an include guard using the macro name RAYLINK_H (both lack the #define). Since RAYLINK_H is not defined anywhere, the guards using different macro names. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/net/wireless/ray_cs.h | 5 +++-- drivers/net/wireless/rayctl.h | 5 +++-- As this a change to ray_cs driver, please use prefix ray_cs: and drop that drivers: net: wireless:. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] ath6kl: fix %d confusingly prefixed with 0x in format strings
Hans Wennborg h...@hanshq.net writes: Signed-off-by: Hans Wennborg h...@hanshq.net Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath6kl: convert a driver to use module_usb_driver()
Himangi Saraogi himangi...@gmail.com writes: This converts a driver in drivers/net/* to use the module_usb_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers/net/wireless: Remove typedef local_info_t
Himangi Saraogi himangi...@gmail.com writes: The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for local_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. [...] Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/atmel_cs.c | 22 +++--- You should prefix the patch with atmel_cs:, not drivers/net/wireless. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings
Hans Wennborg h...@hanshq.net writes:
Signed-off-by: Hans Wennborg h...@hanshq.net
---
drivers/net/wireless/ath/ath6kl/init.c | 2 +-
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/init.c
b/drivers/net/wireless/ath/ath6kl/init.c
index fffd523..91af845 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar,
const char *name)
ar-hw.reserved_ram_size = le32_to_cpup(val);
ath6kl_dbg(ATH6KL_DBG_BOOT,
-found reserved ram size ie 0x%d\n,
+found reserved ram size ie 0x%x\n,
ar-hw.reserved_ram_size);
Actually the original intent here was to use %d.
diff --git a/drivers/net/wireless/ath/ath6kl/main.c
b/drivers/net/wireless/ath/ath6kl/main.c
index 21516bc..933aef0 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address,
__le32 value)
ret = ath6kl_hif_diag_write32(ar, address, value);
if (ret) {
- ath6kl_err(failed to write 0x%x during diagnose window to
0x%d\n,
+ ath6kl_err(failed to write 0x%x during diagnose window to
0x%x\n,
address, value);
This is ok.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: checkpatch: CHECK: No space is necessary after a cast
Joe Perches j...@perches.com writes:
On Mon, 2014-09-29 at 14:49 +0300, Kalle Valo wrote:
Hi Joe,
I have a problem with checkpatch. On ath10k we have this function:
static inline struct ath10k_skb_cb *ATH10K_SKB_CB(struct sk_buff *skb)
{
BUILD_BUG_ON(sizeof(struct ath10k_skb_cb)
IEEE80211_TX_INFO_DRIVER_DATA_SIZE);
return (struct ath10k_skb_cb *)IEEE80211_SKB_CB(skb)-driver_data;
}
And the BUILD_BUG_ON triggers this warning:
drivers/net/wireless/ath/ath10k/core.h:85: CHECK: No space is necessary
after a cast
Any advice how to handle that?
It's a checkpatch false positive that could be fixed.
It needs something like another test to look for
sizeof(type) as not a cast and more arithmetic/comparison
uses.
Maybe you can test this?
It works, thank you!
Tested-by: Kalle Valo kv...@qca.qualcomm.com
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath: change logging functions to return void
Joe Perches j...@perches.com writes: The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Signed-off-by: Joe Perches j...@perches.com --- This change is associated to a desire to eventually change printk to return void. drivers/net/wireless/ath/ath10k/debug.c| 18 +- drivers/net/wireless/ath/ath10k/debug.h| 6 +++--- drivers/net/wireless/ath/ath6kl/common.h | 2 +- drivers/net/wireless/ath/ath6kl/debug.c| 28 drivers/net/wireless/ath/ath6kl/debug.h| 13 ++--- For ath6kl and ath10k: Acked-by: Kalle Valo kv...@qca.qualcomm.com drivers/net/wireless/ath/wil6210/debug.c | 14 -- drivers/net/wireless/ath/wil6210/wil6210.h | 7 +-- 7 files changed, 32 insertions(+), 56 deletions(-) John, as this patch also contains a wil6210 change how do you want to handle this? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX ME locking is implemented?
nick xerofo...@gmail.com writes:
I am wondering why the fix me in the code below still exists as this
code is clearly being locked properly with a spin lock on the lock
related to the created linked list in this code.
It would be nice to mention what driver and file you are referring to.
So this is from ath6kl_tx_queue_full() in
drivers/net/wireless/ath/ath6kl/txrx.c.
/* FIXME: Locking */
spin_lock_bh(ar-list_lock);
list_for_each_entry(vif, ar-vif_list, list) {
if (vif-nw_type == ADHOC_NETWORK ||
action != HTC_SEND_FULL_DROP) {
spin_unlock_bh(ar-list_lock);
set_bit(NETQ_STOPPED, vif-flags);
netif_stop_queue(vif-ndev);
return action;
}
}
spin_unlock_bh(ar-list_lock);
Most probably someone just forgot to update the comment, patches welcome :)
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath: change logging functions to return void
Joe Perches j...@perches.com writes: The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Signed-off-by: Joe Perches j...@perches.com Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath: change logging functions to return void
John W. Linville linvi...@tuxdriver.com writes: On Tue, Sep 23, 2014 at 07:20:53AM +0300, Kalle Valo wrote: Joe Perches j...@perches.com writes: drivers/net/wireless/ath/wil6210/debug.c | 14 -- drivers/net/wireless/ath/wil6210/wil6210.h | 7 +-- 7 files changed, 32 insertions(+), 56 deletions(-) John, as this patch also contains a wil6210 change how do you want to handle this? I had presumed that you would merge it through the ath tree, so I deleted it... That's a clear case then, I'll take it :) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. I think the last sentence is a bit misleading (this isn't a compilation error, right?) and I would like to clarify it like this: So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again. Does that look ok? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote: Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. I think the last sentence is a bit misleading (this isn't a compilation error, right?) No, it's not a compilation error. The reasoning here is that all code hidden behind a Kconfig symbol that cannot be set will, in practice, never be built. Sure, there are hoops one can jump through to try to bypass the generated .config, but no one should have to do that. and I would like to clarify it like this: So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again. Does that look ok? I understand the confusion my text might cause, so I'm fine with your amendment. Thanks for checking. I'll modify the commit log and apply it to wireless-drivers.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Johannes Berg johan...@sipsolutions.net writes: On Mon, 2014-12-22 at 19:10 +0100, Paul Bolle wrote: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Johannes, Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again. (A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.) Yeah, config HERMES needs the same change. Kalle, do you want to take those through your tree, or should I fix it seeing that I introduced the bug in a sense? To keep things simple I would prefer to take this through wireless-drivers.git, if it's ok for you. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] brcmfmac: Do not crash if platform data is not populated
Arend van Spriel ar...@broadcom.com writes: On 12/23/14 16:47, Mika Westerberg wrote: On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata-oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case we crash the kernel because of NULL pointer dereference. Thanks, Mika However, this was already reported by Dan Carpenter and I submitted a patch for that a couple of days ago: [PATCH 02/10] brcmfmac: Fix possible dereference of NULL pointer. [1]. Regards, Arend [1] http://mid.gmane.org/1419162233-19492-3-git-send-email-ar...@broadcom.com Oh, good. I didn't notice that one. Thanks for fixing it :) BTW, that patch seems to miss brcmf_ops_sdio_resume(), perhaps it is fixed in another patch? Aargh, a nice BTW this is as there is no other patch for the resume code. Maybe I should ask Kalle to apply your patch instead of ours. If it did not already got applied. I have been waiting for net-next to open so I haven't applied any -next patches yet. So if you want I can take Mika's patch as well. Just send a reply to your patch I should drop. And should this patch go to 3.19? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.
Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com --- drivers/bcma/driver_chipcommon.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Just to handle the bureaucracy before v2 is submitted: To which tree should this go to? I see that earlier John has applied patches to drivers/bcma/, but what about now? Should I take these? John, any suggestions? Oscar, the patchwork entry for this patch looked odd. I'm guessing it was because your time (or timezone) is wrong: https://patchwork.kernel.org/patch/5535751/ -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Paul Bolle pebo...@tiscali.nl writes: Commit 24a0aa212ee2 (cfg80211: make WEXT compatibility unselectable) made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.) So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again. Signed-off-by: Paul Bolle pebo...@tiscali.nl Thanks, applied to wireless-drivers.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] brcmfmac: Do not crash if platform data is not populated
Mika Westerberg mika.westerb...@linux.intel.com writes: The driver looks for pdata-oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case we crash the kernel because of NULL pointer dereference. Fixes: 330b4e4be937 (brcmfmac: Add wowl support for SDIO devices.) Reported-by: Christophe Prigent christophe.prig...@intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Thanks, applied to wireless-drivers.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: rtlwifi: rtl8192de: fw.c: Remove unused function
Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Remove the function rtl92d_set_fw_pwrmode_cmd() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Thanks, applied to wireless-drivers-next.git. But in the future, to make my work easier, please simplify your patch titles. You do not have to put the full directory structure there. I now manually changed it to: commit 18e0c0bf3a5ea0f54384149570274d535341dc06 Author: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Date: Sun Dec 7 23:00:13 2014 +0100 rtlwifi: rtl8192de: fw.c: Remove unused function Most important is that the title begins with the name of the driver (rtlwifi, iwlwifi, ath9k and so on) and is not too long. That way it's a lot easier for me and Johannes to manage the wireless patches in patchwork. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] rsi: fix memory leak in rsi_load_ta_instructions()
Alexey Khoroshilov khoroshi...@ispras.ru writes: Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked. But duplication of firmware data here is useless, so the patch removes kmemdup() at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru Thanks, applied to wireless-drivers-next.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function
Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Remove the function rtl92ee_get_available_desc() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Thanks, applied to wireless-drivers-next.git. But I simplified the patch title: commit 9898b77536b8569be2704964d3c519ef070e4a27 Author: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Date: Sat Dec 20 13:48:14 2014 +0100 rtlwifi: rtl8192ee: trx.c: Remove unused function -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: wireless: rtlwifi: rtl8723be: phy.c: Remove unused function
Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Remove the function rtl8723be_phy_get_txpower_level() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Thanks, applied to wireless-drivers-next.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
pull-request: wireless-drivers 2014-12-26
Hi Dave, here's my first wireless-drivers pull request after John's retirement. I'll start this with few fixes for 3.19, changelog below. I used a signed tag to create this pull request, I hope that's ok. Please let me know if there are any problems. Kalle The following changes since commit 02d6a746c3f0cdd6f8aad0afd0b32d4646d6525e: Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth (2014-12-19 15:47:32 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2014-12-26 for you to fetch changes up to 8975842bed0840f314281c9fbf021a1d29537cf0: brcmfmac: Do not crash if platform data is not populated (2014-12-24 15:26:46 +0200) o Paul made a Kconfig dependency fix to ipw2200, it was not possible to enable that driver because Wireless Extensions is now disabled by default. o Mika fixed brcmfmac not to crash when platform data is not populated o Emmanuel provided few fixes to iwlwifi, he says: I have here new device IDs and a fix for double free bug I introduced. I also fix an issue with the RFKILL interrupt - the HW needs us to ACK the interrupt again after we reset it. Liad fixes an issue with the firmware debugging infrastructure. While working on torture scenarios of firmware restarts, Eliad found an issue which he fixed. Eliad Peller (1): iwlwifi: mvm: clear IN_HW_RESTART flag on stop() Emmanuel Grumbach (3): iwlwifi: pcie: re-ACK all interrupts after device reset iwlwifi: don't double free a pointer if no FW was found iwlwifi: add new device IDs for 3165 Kalle Valo (1): Merge tag 'iwlwifi-fixes-for-kalle-2014-12-18' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: pcie: limit fw chunk sizes given to fh Mika Westerberg (1): brcmfmac: Do not crash if platform data is not populated Paul Bolle (1): ipw2200: select CFG80211_WEXT drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |4 ++-- drivers/net/wireless/ipw2x00/Kconfig |3 ++- drivers/net/wireless/iwlwifi/iwl-drv.c |2 +- drivers/net/wireless/iwlwifi/iwl-fh.h|1 + drivers/net/wireless/iwlwifi/mvm/mac80211.c | 15 +-- drivers/net/wireless/iwlwifi/pcie/drv.c |4 drivers/net/wireless/iwlwifi/pcie/trans.c| 17 +++-- 7 files changed, 34 insertions(+), 12 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line
Rafał Miłecki zaj...@gmail.com writes: On 27 December 2014 at 20:24, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com Acked-by: Rafał Miłecki zaj...@gmail.com Kalle: will you pick this patch? Most likely yes, but let's wait first for John's opinion about how to handle bcma patches. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath6kl: remove incorrect reset_resume handler
Alexey Khoroshilov khoroshi...@ispras.ru writes: Existing implementation of reset_resume handler just calls ath6kl_usb_remove() that deallocates all resources. It can lead to double free, etc. on disconnect. The patch removes reset_resume handler, so usb core could conservatively reset the driver. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 2/4] Documentation/SubmitChecklist: Remind submitters to check the merge window
Kevin Cernekee cerne...@gmail.com writes: +27: For patches which are not urgent fixes for bugs in the current tree, +double-check https://www.kernel.org/ to make sure the merge window is +CLOSED (mainline: showing an -rc kernel) before sending. For more +information on the release cycle, see Documentation/development-process/. Maybe the crystal ball should be extended to show if the merge is open or closed? And if it's closed, an estimate when the next merge window starts would be nice (Merge window is closed, estimate for it to open: 21 days). http://phb-crystal-ball.org/ I'm sure Johannes would be happy to take patches. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation
Fu, Zhonghui zhonghui...@linux.intel.com writes: From 04d3fa673897ca4ccbea6c76836d0092dba2484a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu zhonghui...@linux.intel.com Date: Tue, 20 Jan 2015 11:14:13 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel ar...@broadcom.com Acked-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Kalle Valo kv...@codeaurora.org Signed-off-by: Zhonghui Fu zhonghui...@linux.intel.com I don't remember giving Acked-by to this (or for matter to anything for a long time). What about Sergei or Arend? Please do not add Acked-by, Signed-off-by or any other tags unless explicitly specified by the person in question. I'm dropping this, please resend with real Acked-by lines. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [1/1] MAINTAINERS: remove ath5k mailing list
The list is in the process of closing. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Nick Kossifidis mickfl...@gmail.com Cc: Luis R. Rodriguez mcg...@do-not-panic.com Cc: linux-wirel...@vger.kernel.org Cc: Michael Renzmann mrenzm...@madwifi-project.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND, 1/2] wlcore: fix copy-paste bug: assign from src struct not dest
Signed-off-by: Giel van Schijndel m...@mortis.eu Reported-at: http://www.viva64.com/en/b/0299/ Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: rtlwifi/rtl8192de: remove redundant else if check
From: Colin Ian King colin.k...@canonical.com
The else if check condition checks for the opposite of the
if check, hence the else if check is redundant and can be
replaced with a simple else:
if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {
..
} else if (rtlpriv-rtlhal.macphymode != SINGLEMAC_SINGLEPHY) {
..
}
replaced with:
if (rtlpriv-rtlhal.macphymode == SINGLEMAC_SINGLEPHY) {
..
} else {
..
}
Signed-off-by: Colin Ian King colin.k...@canonical.com
Acked-by: Larry Finger larry.fin...@lwfinger.net
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: wireless: p54: add handling of the signal case
if(!wait_for_completion_interruptible_timeout(...)) only handles the timeout case - this patch adds handling the signal case the same as timeout. Signed-off-by: Nicholas Mc Guire der.h...@hofr.at Acked-by: Christian Lamparter chunk...@googlemail.com Thanks, applied to wireless-drivers-next.git but I removed wireless: from the title. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [v2] atmel: Remove open-coded and wrong strcasecmp
The kernel's string library does in fact have strcasecmp, at least since ded220bd8f08 ([STRING]: Move strcasecmp/strncasecmp to lib/string.c). Moreover, this open-coded version is in fact wrong: If the strings only differ in their last character, a and b have already been incremented to point to the terminating NUL bytes, so they would wrongly be treated as equal. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Thanks, applied to wireless-drivers-next.git. I just remove the useless net: wireless: from the title. People, PLEASE stop using that. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: p54pci: add handling of signal case
if(!wait_for_completion_interruptible_timeout(...)) only handles the timeout case - this patch adds handling the signal case the same as timeout. Signed-off-by: Nicholas Mc Guire der.h...@hofr.at Acked-by: Christian Lamparter chunk...@googlemail.com Thanks, applied to wireless-drivers-next.git. I remove the useless wireless: from the title. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation
Fu, Zhonghui zhonghui...@linux.intel.com writes: From ff39ed4af9f1c50358fe92ec4c8eaac9db183e00 Mon Sep 17 00:00:00 2001 From: Zhonghui Fu zhonghui...@linux.intel.com Date: Mon, 26 Jan 2015 10:13:21 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Sprielar...@broadcom.com Signed-off-by: Zhonghui Fu zhonghui...@linux.intel.com This doesn't apply: Applying: brcmfmac: avoid duplicated suspend/resume operation Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c CONFLICT (content): Merge conflict in drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c Failed to merge in the changes. Patch failed at 0001 brcmfmac: avoid duplicated suspend/resume operation BTW, when you resend a patch please use [PATCH v2] (or v3, v4...) in the Subject field. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: cw1200: use msecs_to_jiffies for conversion
This is only an API consolidation to make things more readable. Instances of HZ / CONST are replaced by appropriate msecs_to_jiffies(). Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [1/3] orinoco: orinoco_plx use msecs_to_jiffies for conversion
This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, 3 patches applied to wireless-drivers-next.git: ab458cc85fa2 orinoco: orinoco_plx use msecs_to_jiffies for conversion 3427da4597ae orinoco: orinoco_pci use msecs_to_jiffies for conversion c1f1f6663b3c orinoco: orinoco_tmd use msecs_to_jiffies for conversion Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: orinoco: Delete an unnecessary check before the function call kfree
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 19:53:11 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: hostap: Delete an unnecessary check before the function call kfree
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 20:06:39 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: brcm80211: Delete unnecessary checks before two function calls
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 20:28:49 +0100 The functions brcmu_pkt_buf_free_skb() and usb_free_urb() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [1/2] cw1200: Delete an unnecessary check before the function call release_firmware
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 16:32:15 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, 2 patches applied to wireless-drivers-next.git: df970d39b90e cw1200: Delete an unnecessary check before the function call release_firmware ee4ddad82356 cw1200: Less function calls in cw1200_load_firmware_cw1200() after error detection Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ath9k: Delete an unnecessary check before the function callrelay_close
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 18:48:28 +0100 The relay_close() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode
yuweizh...@139.com writes:
From: Yuwei Zheng yuweizh...@139.com
In the environment with heavy wifi traffic, set the ar9271 into monitor mode,
will
trigger a deadloop panic.
The ath9k_hif_usb_rx_cb function excute on the interrupt context, and
ath9k_rx_tasklet excute
on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more
chance to excute than
ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive list is
always full,
and the do {}while(true) loop will not be break. The kernel get a soft lockup
panic.
The word wrapping is still wrong, please limit the width to 72 chars or
so. But no need to wrap log snippets, they can exceed the limit.
Signed-off-by: Yuwei Zheng zhengyu...@360.cn
Signed-off-by: Yuwei Zheng yuweizh...@139.com
Why two of these? Please use just one Signed-off-by line. Unless these
are two different persons with the same name :)
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
pull-request: wireless-drivers 2015-01-20
Hi Dave, more fixes for 3.19, I hope these are still appropriate. Please let me know if there are any issues. Kalle The following changes since commit 16dde0d6ac159531a5e03cd3f8bc8a401d9f3fb6: be2net: Allow GRE to work concurrently while a VxLAN tunnel is configured (2015-01-15 01:55:05 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-01-20 for you to fetch changes up to e3f31175a3eeb492a6ab788e4fa136c19b43aab4: ath9k: fix race condition in irq processing during hardware reset (2015-01-19 14:32:29 +0200) ath9k: * fix an IRQ storm caused by commit 872b5d814f99 iwlwifi: * A fix for scan that fixes a firmware assertion * A fix that improves roaming behavior. Same fix has been tested for a while in iwldvm. This is a bit of a work around, but the real fix should be in mac80211 and will come later. * A fix for BARs that avoids a WARNING. * one fix for rfkill while scheduled scan is running. Linus's system hit this issue. WiFi would be unavailable after this has happpened because of bad state in cfg80211. David Spinadel (1): iwlwifi: mvm: fix EBS on single scan Emmanuel Grumbach (2): iwlwifi: mvm: drop non VO frames when flushing iwlwifi: mvm: abort scheduled scan upon RFKILL Eyal Shapira (1): iwlwifi: mvm: set the tx cmd tid for BAR frame correctly Felix Fietkau (1): ath9k: fix race condition in irq processing during hardware reset Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2015-01-13' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2015-01-15' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/ath/ath9k/main.c |7 ++-- drivers/net/wireless/iwlwifi/iwl-fw-file.h |2 + drivers/net/wireless/iwlwifi/mvm/fw-api-scan.h |7 +++- drivers/net/wireless/iwlwifi/mvm/mac80211.c| 20 - drivers/net/wireless/iwlwifi/mvm/scan.c| 53 ++-- drivers/net/wireless/iwlwifi/mvm/tx.c | 11 - 6 files changed, 69 insertions(+), 31 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line
Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com Thanks, applied to wireless-drivers-next.git. Hopefully I took the correct version this time :) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation
Arend van Spriel ar...@broadcom.com writes: On 01/12/15 07:41, Fu, Zhonghui wrote: From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 From: Zhonghui Fuzhonghui...@linux.intel.com Date: Mon, 12 Jan 2015 14:25:46 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Sprielar...@broadcom.com Acked-by: Sergei Shtylyovsergei.shtyl...@cogentembedded.com Signed-off-by: Zhonghui Fuzhonghui...@linux.intel.com This patch needs to be rebased. Kalle, Please drop this one. Ok, dropped. I'll wait for the rebase. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/8] adm8211: fix error return code
Julia Lawall julia.law...@lip6.fr writes:
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Thanks, applied to wireless-drivers-next.git.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block
Eliad Peller el...@wizery.com writes: On Fri, Jan 9, 2015 at 7:03 PM, Kalle Valo kv...@codeaurora.org wrote: Giel van Schijndel m...@mortis.eu writes: This highlights the differences (e.g. the bug fixed in the previous commit). Signed-off-by: Giel van Schijndel m...@mortis.eu --- drivers/net/wireless/ti/wlcore/acx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c index f28fa3b..93a2fa8 100644 --- a/drivers/net/wireless/ti/wlcore/acx.c +++ b/drivers/net/wireless/ti/wlcore/acx.c @@ -1715,17 +1715,17 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl) goto out; } - acx-recover_time = cpu_to_le32(conf-recover_time); - acx-hangover_period = conf-hangover_period; - acx-dynamic_mode = conf-dynamic_mode; - acx-early_termination_mode = conf-early_termination_mode; - acx-max_period = conf-max_period; - acx-min_period = conf-min_period; - acx-increase_delta = conf-increase_delta; - acx-decrease_delta = conf-decrease_delta; - acx-quiet_time = conf-quiet_time; - acx-increase_time = conf-increase_time; - acx-window_size = conf-window_size; + acx-recover_time = cpu_to_le32(conf-recover_time); + acx-hangover_period= conf-hangover_period; + acx-dynamic_mode = conf-dynamic_mode; + acx-early_termination_mode = conf-early_termination_mode; + acx-max_period = conf-max_period; + acx-min_period = conf-min_period; + acx-increase_delta = conf-increase_delta; + acx-decrease_delta = conf-decrease_delta; + acx-quiet_time = conf-quiet_time; + acx-increase_time = conf-increase_time; + acx-window_size= conf-window_size; I would like to get an ACK from one of the wlcore developers if I should apply this (or not). I don't have a strong opinion here. However, it looks pretty much redundant to take a random blob (which was just fixed by a correct patch) and re-indent it. The rest of the file doesn't follow this style, so i don't see a good reason to apply it here. Yeah, this should be a driver decision and not just a single change in one function. Hence I'm dropping patch 2. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] rtlwifi: btcoexist: Remove some unused functions
Larry Finger larry.fin...@lwfinger.net writes: On 01/10/2015 10:24 AM, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: ex_halbtc8821a1ant_periodical() ex_halbtc8821a1ant_pnp_notify() ex_halbtc8821a1ant_halt_notify() ex_halbtc8821a1ant_bt_info_notify() ex_halbtc8821a1ant_special_packet_notify() ex_halbtc8821a1ant_connect_notify() ex_halbtc8821a1ant_scan_notify() ex_halbtc8821a1ant_lps_notify() ex_halbtc8821a1ant_ips_notify() ex_halbtc8821a1ant_display_coex_info() ex_halbtc8821a1ant_init_coex_dm() ex_halbtc8821a1ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se NACK! I told you to stay away from these routines until I finish my update. Not only might you remove some functions that I will be needing later, but you run the risk of merge complications. Kalle: Please ignore EVERYTHING from this person. Obviously, he is incapable of understanding even the simplest instructions. Yeah, I have to agree with that. I think he is just too fixated creating the patches automatically. I have dropped the patches. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
pull-request: wireless-drivers 2015-02-11
Hi Dave, here's one rtlwifi fix for 3.20. We have had two reports of this issue already, so it would be good to get this to -rc1 or -rc2. I rebased wireless-drivers on top of net-next, so this patch applies to net-next. I hope that's ok. Kalle The following changes since commit b0f9ca53cbb103e9240a29a974e0b6085e58f9f7: ipv4: Namespecify TCP PMTU mechanism (2015-02-09 18:45:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-02-11 for you to fetch changes up to aeb2d2a4c0ae1739a6e1782bd8c1c96aee8db4e1: rtlwifi: Remove logging statement that is no longer needed (2015-02-10 16:09:11 +0200) rtlwifi: * remove superfluous warning message which is not needed anymore Larry Finger (1): rtlwifi: Remove logging statement that is no longer needed drivers/net/wireless/rtlwifi/pci.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation
Arend van Spriel ar...@broadcom.com writes: On 02/15/15 04:27, Pat Erley wrote: On 02/14/2015 08:40 PM, Fu, Zhonghui wrote: Any comments to this patch? Can it be accepted? I assume that patches are queued up until after the merge window that we are currently in. That's right. In the future I will most likely apply patches also during the merge window, but as I'm still a greenhorn I'll be on the safe and wait for the merge window to end. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-drivers-next tree
Stephen Rothwell s...@canb.auug.org.au writes: After merging the wireless-drivers-next tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x29d0): multiple definition of `led_blink' drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x1654): first defined here Caused by commit 3a939a671225 (ath9k_htc: Add a module parameter to disable blink). I have reverted that commit for today. Sorry about that, we have a patch pending to fix it: https://patchwork.kernel.org/patch/5699001/ -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND] ssb: Fix Sparse error in main
This change fixes below sparse error: drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' was not declared. Should it be static? Acked-by: Michael Buesch m...@bues.ch Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
