Re: quilt 0.60 does not include CCed email without name

[Martin Quinson]

On Thu, Dec 05, 2013 at 08:58:37PM +, Christoph Lameter wrote:
> > > You say this in the commit, but the linux-parisc list isn't cc'd on the
> > > email ...
> >
> > Weird my testoutput before the patchset was sent out shows that it
> > was included then :
> 
> Ok while the test output was done with quilt 0.50 the patch was actually
> send with quilt 0.60 from another system. quilt 0.60 skips all Cc:s that
> do not have a full name.
> 
> So Helge was included since it had a name
> 
> > Cc: Helge Deller 
> 
> but
> 
> > Cc: linux-par...@vger.kernel.org
> 
> did not because no name was available.
> 
> Martin?

I'm sorry, I never use the quilt mail command myself. After a quick
investiguation of the git history, this bug seems to be caused by:
http://git.savannah.gnu.org/cgit/quilt.git/commit/?id=02f15444278eb3a854acae0192124153e0c6d9d4

I think that the last lines should be changed as follows (and same for
the one before):
- -e 's/^\('"$*"'\):\(.*<.*@.*>\)/Recipient-Cc:\2/Ip' \
+ -e 's/^\('"$*"'\):\(.*@.*\)/Recipient-Cc:\2/Ip' \

I'm CCing Andreas so that he can comment, and if nobody complains I'll
commit it to our git.

Many thanks for the detailed bug report,
Mt.

-- 
Simplicity does not precede complexity, but follows it.
   -- "Epigrams in Programming", by Alan J. Perlis of Yale University.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: quilt 0.60 does not include CCed email without name

[Martin Quinson]

On Sun, Dec 08, 2013 at 10:19:31AM +0100, Andreas Gruenbacher wrote:
> Martin,
> 
> > [...] bug seems to be caused by:
> > http://git.savannah.gnu.org/cgit/quilt.git/commit/?id=02f15444278eb3a854acae0192124153e0c6d9d4
> > 
> > I think that the last lines should be changed as follows (and same for
> > the one before):
> > - -e 's/^\('"$*"'\):\(.*<.*@.*>\)/Recipient-Cc:\2/Ip' \
> > + -e 's/^\('"$*"'\):\(.*@.*\)/Recipient-Cc:\2/Ip' \
> 
> or something similar like .\+@.\+ for the email address part, yes. 

Done. This will be part of quilt 0.61.

Thanks, Mt.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/