Re: [PATCH] arch/sparc: Use kzalloc_node
On Sat, Nov 3, 2018 at 10:54 AM Sabyasachi Gupta wrote: > > Replaced kmalloc_node + memset with kzalloc_node > > Signed-off-by: Sabyasachi Gupta Any comment on this patch? > --- > arch/sparc/kernel/iommu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/sparc/kernel/iommu.c b/arch/sparc/kernel/iommu.c > index 40d008b..05eb016 100644 > --- a/arch/sparc/kernel/iommu.c > +++ b/arch/sparc/kernel/iommu.c > @@ -108,10 +108,9 @@ int iommu_table_init(struct iommu *iommu, int tsbsize, > /* Allocate and initialize the free area map. */ > sz = num_tsb_entries / 8; > sz = (sz + 7UL) & ~7UL; > - iommu->tbl.map = kmalloc_node(sz, GFP_KERNEL, numa_node); > + iommu->tbl.map = kzalloc_node(sz, GFP_KERNEL, numa_node); > if (!iommu->tbl.map) > return -ENOMEM; > - memset(iommu->tbl.map, 0, sz); > > iommu_tbl_pool_init(&iommu->tbl, num_tsb_entries, IO_PAGE_SHIFT, > (tlb_type != hypervisor ? iommu_flushall : NULL), > -- > 2.7.4 >
Re: [PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc_coherent
On Sat, Nov 10, 2018 at 11:57 AM Souptick Joarder wrote: > > On Fri, Nov 9, 2018 at 8:08 PM Sabyasachi Gupta > wrote: > > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > There are few other places in this file where same is applicable. > Can we get those changes in same patch ? > > as all the changes are now in linux-next I am going to drop this patch > > Signed-off-by: Sabyasachi Gupta > > --- > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > index a4c62ae..c9966ec 100644 > > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > @@ -4972,13 +4972,12 @@ static int hns_roce_mhop_alloc_eq(struct > > hns_roce_dev *hr_dev, > > eqe_alloc = i * (buf_chk_sz / eq->eqe_size); > > size = (eq->entries - eqe_alloc) * > > eq->eqe_size; > > } > > - eq->buf[i] = dma_alloc_coherent(dev, size, > > + eq->buf[i] = dma_zalloc_coherent(dev, size, > > &(eq->buf_dma[i]), > > GFP_KERNEL); > > if (!eq->buf[i]) > > goto err_dma_alloc_buf; > > > > - memset(eq->buf[i], 0, size); > > *(eq->bt_l0 + i) = eq->buf_dma[i]; > > > > eq_buf_cnt++; > > -- > > 2.7.4 > >
[PATCH] infiniband/hw/cxgb4/qp.c: Use dma_zalloc_coherent
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/infiniband/hw/cxgb4/qp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 13478f3..5a8030b 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -2564,13 +2564,12 @@ static int alloc_srq_queue(struct c4iw_srq *srq, struct c4iw_dev_ucontext *uctx, wq->rqt_abs_idx = (wq->rqt_hwaddr - rdev->lldi.vr->rq.start) >> T4_RQT_ENTRY_SHIFT; - wq->queue = dma_alloc_coherent(&rdev->lldi.pdev->dev, + wq->queue = dma_zalloc_coherent(&rdev->lldi.pdev->dev, wq->memsize, &wq->dma_addr, GFP_KERNEL); if (!wq->queue) goto err_free_rqtpool; - memset(wq->queue, 0, wq->memsize); dma_unmap_addr_set(wq, mapping, wq->dma_addr); wq->bar2_va = c4iw_bar2_addrs(rdev, wq->qid, CXGB4_BAR2_QTYPE_EGRESS, -- 2.7.4
[PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc_coherent
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index a4c62ae..c9966ec 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -4972,13 +4972,12 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev, eqe_alloc = i * (buf_chk_sz / eq->eqe_size); size = (eq->entries - eqe_alloc) * eq->eqe_size; } - eq->buf[i] = dma_alloc_coherent(dev, size, + eq->buf[i] = dma_zalloc_coherent(dev, size, &(eq->buf_dma[i]), GFP_KERNEL); if (!eq->buf[i]) goto err_dma_alloc_buf; - memset(eq->buf[i], 0, size); *(eq->bt_l0 + i) = eq->buf_dma[i]; eq_buf_cnt++; -- 2.7.4
[PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent Signed-off-by: Sabyasachi Gupta --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c index dcb4bba..df4f7a3 100644 --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c @@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain, if (!wq->sq) goto err3; - wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev), + wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev), depth * sizeof(union t3_wr), &(wq->dma_addr), GFP_KERNEL); if (!wq->queue) goto err4; - memset(wq->queue, 0, depth * sizeof(union t3_wr)); dma_unmap_addr_set(wq, mapping, wq->dma_addr); wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr; if (!kernel_domain) -- 2.7.4
Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta
wrote:
>
> On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta
> wrote:
> >
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> >
> > Signed-off-by: Sabyasachi Gupta
>
> Any comment on this patch?
Any comment on this patch?
>
> > ---
> > drivers/scsi/dpt_i2o.c | 12
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > index 37de8fb..056383a 100644
> > --- a/drivers/scsi/dpt_i2o.c
> > +++ b/drivers/scsi/dpt_i2o.c
> > @@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
> > schedule_timeout_uninterruptible(1);
> > } while (m == EMPTY_QUEUE);
> >
> > - status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > + status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr,
> > GFP_KERNEL);
> > if(status == NULL) {
> > adpt_send_nop(pHba, m);
> > printk(KERN_ERR"IOP reset failed - no free memory.\n");
> > return -ENOMEM;
> > }
> > - memset(status,0,4);
> >
> > msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
> > msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
> > @@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> >
> > msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
> >
> > - status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr, GFP_KERNEL);
> > + status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr,
> > GFP_KERNEL);
> > if (!status) {
> > adpt_send_nop(pHba, m);
> > printk(KERN_WARNING"%s: IOP reset failed - no free
> > memory.\n",
> > pHba->name);
> > return -ENOMEM;
> > }
> > - memset(status, 0, 4);
> >
> > writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
> > writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID,
> > &msg[1]);
> > @@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
> > pHba->reply_pool, pHba->reply_pool_pa);
> > }
> >
> > - pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
> > + pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
> > pHba->reply_fifo_size * REPLY_FRAME_SIZE *
> > 4,
> > &pHba->reply_pool_pa, GFP_KERNEL);
> > if (!pHba->reply_pool) {
> > printk(KERN_ERR "%s: Could not allocate reply pool\n",
> > pHba->name);
> > return -ENOMEM;
> > }
> > - memset(pHba->reply_pool, 0 , pHba->reply_fifo_size *
> > REPLY_FRAME_SIZE * 4);
> >
> > for(i = 0; i < pHba->reply_fifo_size; i++) {
> > writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
> > @@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
> > sys_tbl_len = sizeof(struct i2o_sys_tbl) + // Header + IOPs
> > (hba_count) * sizeof(struct
> > i2o_sys_tbl_entry);
> >
> > - sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
> > + sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
> > sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
> > if (!sys_tbl) {
> > printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");
> > return -ENOMEM;
> > }
> > - memset(sys_tbl, 0, sys_tbl_len);
> >
> > sys_tbl->num_entries = hba_count;
> > sys_tbl->version = I2OVERSION;
> > --
> > 2.7.4
> >
Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent
On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta wrote: > > On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > wrote: > > > > Replace dma_alloc_coherent + memset with dma_zalloc_coherent > > > > Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? Any comment on this patch? > > > --- > > drivers/scsi/mvsas/mv_init.c | 12 > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > > index 3ac3437..495bddb 100644 > > --- a/drivers/scsi/mvsas/mv_init.c > > +++ b/drivers/scsi/mvsas/mv_init.c > > @@ -253,33 +253,29 @@ static int mvs_alloc(struct mvs_info *mvi, struct > > Scsi_Host *shost) > > /* > > * alloc and init our DMA areas > > */ > > - mvi->tx = dma_alloc_coherent(mvi->dev, > > + mvi->tx = dma_zalloc_coherent(mvi->dev, > > sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ, > > &mvi->tx_dma, GFP_KERNEL); > > if (!mvi->tx) > > goto err_out; > > - memset(mvi->tx, 0, sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ); > > - mvi->rx_fis = dma_alloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > > + mvi->rx_fis = dma_zalloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > > &mvi->rx_fis_dma, GFP_KERNEL); > > if (!mvi->rx_fis) > > goto err_out; > > - memset(mvi->rx_fis, 0, MVS_RX_FISL_SZ); > > > > - mvi->rx = dma_alloc_coherent(mvi->dev, > > + mvi->rx = dma_zalloc_coherent(mvi->dev, > > sizeof(*mvi->rx) * (MVS_RX_RING_SZ + > > 1), > > &mvi->rx_dma, GFP_KERNEL); > > if (!mvi->rx) > > goto err_out; > > - memset(mvi->rx, 0, sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1)); > > mvi->rx[0] = cpu_to_le32(0xfff); > > mvi->rx_cons = 0xfff; > > > > - mvi->slot = dma_alloc_coherent(mvi->dev, > > + mvi->slot = dma_zalloc_coherent(mvi->dev, > >sizeof(*mvi->slot) * slot_nr, > >&mvi->slot_dma, GFP_KERNEL); > > if (!mvi->slot) > > goto err_out; > > - memset(mvi->slot, 0, sizeof(*mvi->slot) * slot_nr); > > > > mvi->bulk_buffer = dma_alloc_coherent(mvi->dev, > >TRASH_BUCKET_SIZE, > > -- > > 2.7.4 > >
Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent
On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: > > On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > wrote: > > > > On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > > wrote: > > > > > > Replace dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by: Sabyasachi Gupta > > > > Any comment on this patch? > > Any comment on this patch? Any comment on this patch? > > > > > > --- > > > drivers/scsi/mvsas/mv_init.c | 12 > > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > > > index 3ac3437..495bddb 100644 > > > --- a/drivers/scsi/mvsas/mv_init.c > > > +++ b/drivers/scsi/mvsas/mv_init.c > > > @@ -253,33 +253,29 @@ static int mvs_alloc(struct mvs_info *mvi, struct > > > Scsi_Host *shost) > > > /* > > > * alloc and init our DMA areas > > > */ > > > - mvi->tx = dma_alloc_coherent(mvi->dev, > > > + mvi->tx = dma_zalloc_coherent(mvi->dev, > > > sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ, > > > &mvi->tx_dma, GFP_KERNEL); > > > if (!mvi->tx) > > > goto err_out; > > > - memset(mvi->tx, 0, sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ); > > > - mvi->rx_fis = dma_alloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > > > + mvi->rx_fis = dma_zalloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > > > &mvi->rx_fis_dma, GFP_KERNEL); > > > if (!mvi->rx_fis) > > > goto err_out; > > > - memset(mvi->rx_fis, 0, MVS_RX_FISL_SZ); > > > > > > - mvi->rx = dma_alloc_coherent(mvi->dev, > > > + mvi->rx = dma_zalloc_coherent(mvi->dev, > > > sizeof(*mvi->rx) * (MVS_RX_RING_SZ + > > > 1), > > > &mvi->rx_dma, GFP_KERNEL); > > > if (!mvi->rx) > > > goto err_out; > > > - memset(mvi->rx, 0, sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1)); > > > mvi->rx[0] = cpu_to_le32(0xfff); > > > mvi->rx_cons = 0xfff; > > > > > > - mvi->slot = dma_alloc_coherent(mvi->dev, > > > + mvi->slot = dma_zalloc_coherent(mvi->dev, > > >sizeof(*mvi->slot) * slot_nr, > > >&mvi->slot_dma, GFP_KERNEL); > > > if (!mvi->slot) > > > goto err_out; > > > - memset(mvi->slot, 0, sizeof(*mvi->slot) * slot_nr); > > > > > > mvi->bulk_buffer = dma_alloc_coherent(mvi->dev, > > >TRASH_BUCKET_SIZE, > > > -- > > > 2.7.4 > > >
Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent
On Wed, Dec 19, 2018 at 6:41 PM Sabyasachi Gupta
wrote:
>
> On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta
> wrote:
> >
> > On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta
> > wrote:
> > >
> > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
> > >
> > > Signed-off-by: Sabyasachi Gupta
> >
> > Any comment on this patch?
>
> Any comment on this patch?
>
Any comment on this patch?
> >
> > > ---
> > > drivers/scsi/dpt_i2o.c | 12
> > > 1 file changed, 4 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > > index 37de8fb..056383a 100644
> > > --- a/drivers/scsi/dpt_i2o.c
> > > +++ b/drivers/scsi/dpt_i2o.c
> > > @@ -1370,13 +1370,12 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
> > > schedule_timeout_uninterruptible(1);
> > > } while (m == EMPTY_QUEUE);
> > >
> > > - status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr,
> > > GFP_KERNEL);
> > > + status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr,
> > > GFP_KERNEL);
> > > if(status == NULL) {
> > > adpt_send_nop(pHba, m);
> > > printk(KERN_ERR"IOP reset failed - no free memory.\n");
> > > return -ENOMEM;
> > > }
> > > - memset(status,0,4);
> > >
> > > msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
> > > msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
> > > @@ -2836,14 +2835,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba*
> > > pHba)
> > >
> > > msg=(u32 __iomem *)(pHba->msg_addr_virt+m);
> > >
> > > - status = dma_alloc_coherent(&pHba->pDev->dev, 4, &addr,
> > > GFP_KERNEL);
> > > + status = dma_zalloc_coherent(&pHba->pDev->dev, 4, &addr,
> > > GFP_KERNEL);
> > > if (!status) {
> > > adpt_send_nop(pHba, m);
> > > printk(KERN_WARNING"%s: IOP reset failed - no free
> > > memory.\n",
> > > pHba->name);
> > > return -ENOMEM;
> > > }
> > > - memset(status, 0, 4);
> > >
> > > writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
> > > writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID,
> > > &msg[1]);
> > > @@ -2890,14 +2888,13 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba*
> > > pHba)
> > > pHba->reply_pool, pHba->reply_pool_pa);
> > > }
> > >
> > > - pHba->reply_pool = dma_alloc_coherent(&pHba->pDev->dev,
> > > + pHba->reply_pool = dma_zalloc_coherent(&pHba->pDev->dev,
> > > pHba->reply_fifo_size * REPLY_FRAME_SIZE
> > > * 4,
> > > &pHba->reply_pool_pa, GFP_KERNEL);
> > > if (!pHba->reply_pool) {
> > > printk(KERN_ERR "%s: Could not allocate reply pool\n",
> > > pHba->name);
> > > return -ENOMEM;
> > > }
> > > - memset(pHba->reply_pool, 0 , pHba->reply_fifo_size *
> > > REPLY_FRAME_SIZE * 4);
> > >
> > > for(i = 0; i < pHba->reply_fifo_size; i++) {
> > > writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
> > > @@ -3126,13 +3123,12 @@ static int adpt_i2o_build_sys_table(void)
> > > sys_tbl_len = sizeof(struct i2o_sys_tbl) + // Header + IOPs
> > > (hba_count) * sizeof(struct
> > > i2o_sys_tbl_entry);
> > >
> > > - sys_tbl = dma_alloc_coherent(&pHba->pDev->dev,
> > > + sys_tbl = dma_zalloc_coherent(&pHba->pDev->dev,
> > > sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
> > > if (!sys_tbl) {
> > > printk(KERN_WARNING "SysTab Set failed. Out of
> > > memory.\n");
> > > return -ENOMEM;
> > > }
> > > - memset(sys_tbl, 0, sys_tbl_len);
> > >
> > > sys_tbl->num_entries = hba_count;
> > > sys_tbl->version = I2OVERSION;
> > > --
> > > 2.7.4
> > >
Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent
On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: > > On 04/01/2019 12:48, Sabyasachi Gupta wrote: > > On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta > > wrote: > >> > >> On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > >> wrote: > >>> > >>> On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > >>> wrote: > >>>> > >>>> Replace dma_alloc_coherent + memset with dma_zalloc_coherent > >>>> > > If you're going to make this change, then how about change these to the > managed version, so that we can avoid the explicit free'ing at driver > removal? I can't get it > > >>>> Signed-off-by: Sabyasachi Gupta > >>> > >>> Any comment on this patch? > >> > >> Any comment on this patch? > > > > Any comment on this patch? > > > >> > >>> > >>>> --- > >>>> drivers/scsi/mvsas/mv_init.c | 12 > >>>> 1 file changed, 4 insertions(+), 8 deletions(-) > >>>> > >>>> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > >>>> index 3ac3437..495bddb 100644 > >>>> --- a/drivers/scsi/mvsas/mv_init.c > >>>> +++ b/drivers/scsi/mvsas/mv_init.c > >>>> @@ -253,33 +253,29 @@ static int mvs_alloc(struct mvs_info *mvi, struct > >>>> Scsi_Host *shost) > >>>> /* > >>>> * alloc and init our DMA areas > >>>> */ > >>>> - mvi->tx = dma_alloc_coherent(mvi->dev, > >>>> + mvi->tx = dma_zalloc_coherent(mvi->dev, > >>>> sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ, > >>>> &mvi->tx_dma, GFP_KERNEL); > > I'm guessing that this does not pass checkpatch with --strict option. > > Thanks, > John I have not not checked with --strict option > > >>>> if (!mvi->tx) > >>>> goto err_out; > >>>> - memset(mvi->tx, 0, sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ); > >>>> - mvi->rx_fis = dma_alloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > >>>> + mvi->rx_fis = dma_zalloc_coherent(mvi->dev, MVS_RX_FISL_SZ, > >>>> &mvi->rx_fis_dma, GFP_KERNEL); > >>>> if (!mvi->rx_fis) > >>>> goto err_out; > >>>> - memset(mvi->rx_fis, 0, MVS_RX_FISL_SZ); > >>>> > >>>> - mvi->rx = dma_alloc_coherent(mvi->dev, > >>>> + mvi->rx = dma_zalloc_coherent(mvi->dev, > >>>> sizeof(*mvi->rx) * (MVS_RX_RING_SZ > >>>> + 1), > >>>> &mvi->rx_dma, GFP_KERNEL); > >>>> if (!mvi->rx) > >>>> goto err_out; > >>>> - memset(mvi->rx, 0, sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1)); > >>>> mvi->rx[0] = cpu_to_le32(0xfff); > >>>> mvi->rx_cons = 0xfff; > >>>> > >>>> - mvi->slot = dma_alloc_coherent(mvi->dev, > >>>> + mvi->slot = dma_zalloc_coherent(mvi->dev, > >>>>sizeof(*mvi->slot) * slot_nr, > >>>>&mvi->slot_dma, GFP_KERNEL); > >>>> if (!mvi->slot) > >>>> goto err_out; > >>>> - memset(mvi->slot, 0, sizeof(*mvi->slot) * slot_nr); > >>>> > >>>> mvi->bulk_buffer = dma_alloc_coherent(mvi->dev, > >>>>TRASH_BUCKET_SIZE, > >>>> -- > >>>> 2.7.4 > >>>> > > > > . > > > >
[PATCH] arch/sh/mm/consistent.c: Use dma_zalloc_coherent
Replaced dma_alloc_coherent + memset with dma_zalloc_coherant
Signed-off-by: Sabyasachi Gupta
---
arch/sh/mm/consistent.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
index 792f361..fc8d235 100644
--- a/arch/sh/mm/consistent.c
+++ b/arch/sh/mm/consistent.c
@@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct
platform_device *pdev,
if (!memsize)
return 0;
- buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
+ buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
if (!buf) {
pr_warning("%s: unable to allocate memory\n", name);
return -ENOMEM;
}
- memset(buf, 0, memsize);
r->flags = IORESOURCE_MEM;
r->start = dma_handle;
--
2.7.4
[PATCH] arch/sparc: Use kzalloc_node
Replaced kmalloc_node + memset with kzalloc_node Signed-off-by: Sabyasachi Gupta --- arch/sparc/kernel/iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sparc/kernel/iommu.c b/arch/sparc/kernel/iommu.c index 40d008b..05eb016 100644 --- a/arch/sparc/kernel/iommu.c +++ b/arch/sparc/kernel/iommu.c @@ -108,10 +108,9 @@ int iommu_table_init(struct iommu *iommu, int tsbsize, /* Allocate and initialize the free area map. */ sz = num_tsb_entries / 8; sz = (sz + 7UL) & ~7UL; - iommu->tbl.map = kmalloc_node(sz, GFP_KERNEL, numa_node); + iommu->tbl.map = kzalloc_node(sz, GFP_KERNEL, numa_node); if (!iommu->tbl.map) return -ENOMEM; - memset(iommu->tbl.map, 0, sz); iommu_tbl_pool_init(&iommu->tbl, num_tsb_entries, IO_PAGE_SHIFT, (tlb_type != hypervisor ? iommu_flushall : NULL), -- 2.7.4
Re: [PATCH] fs/block_dev.c: Remove duplicate header
On Wed, Jan 16, 2019 at 5:46 PM Souptick Joarder wrote: > > On Thu, Jan 10, 2019 at 8:55 PM Sabyasachi Gupta > wrote: > > > > Remove linux/dax.h which is included more than once. > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > fs/block_dev.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/block_dev.c b/fs/block_dev.c > > index cdda48f..8abcdb6 100644 > > --- a/fs/block_dev.c > > +++ b/fs/block_dev.c > > @@ -29,7 +29,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > -- > > 2.7.4 > >
Re: [PATCH] fs/cachefiles/namei.c: Remove duplicate header
On Mon, Jan 14, 2019 at 1:34 PM Souptick Joarder wrote: > > On Fri, Jan 11, 2019 at 12:12 PM Sabyasachi Gupta > wrote: > > > > Remove linux/xattr.h which is included more than once > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > fs/cachefiles/namei.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c > > index 95983c7..edecb7f 100644 > > --- a/fs/cachefiles/namei.c > > +++ b/fs/cachefiles/namei.c > > @@ -20,7 +20,6 @@ > > #include > > #include > > #include > > -#include > > #include "internal.h" > > > > #define CACHEFILES_KEYBUF_SIZE 512 > > -- > > 2.7.4 > >
Re: [PATCH] fs/coda/psdev.c: Remove duplicate header
On Mon, Jan 14, 2019 at 1:40 PM Souptick Joarder wrote: > > On Fri, Jan 11, 2019 at 8:59 PM Sabyasachi Gupta > wrote: > > > > Remove linux/poll.h which is included more than once > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > fs/coda/psdev.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c > > index c5234c2..f2bb798 100644 > > --- a/fs/coda/psdev.c > > +++ b/fs/coda/psdev.c > > @@ -39,7 +39,6 @@ > > #include > > #include > > #include > > -#include > > #include > > > > #include > > -- > > 2.7.4 > >
Re: [PATCH] sh: Remove duplicate header
On Thu, Jan 17, 2019 at 11:11 PM Souptick Joarder wrote: > > On Thu, Jan 17, 2019 at 9:57 PM Sabyasachi Gupta > wrote: > > > > Remove linux/irq.h which is included more than once. > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > arch/sh/boards/mach-dreamcast/irq.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/sh/boards/mach-dreamcast/irq.c > > b/arch/sh/boards/mach-dreamcast/irq.c > > index 2789647..69fa91c 100644 > > --- a/arch/sh/boards/mach-dreamcast/irq.c > > +++ b/arch/sh/boards/mach-dreamcast/irq.c > > @@ -10,7 +10,6 @@ > > */ > > #include > > #include > > -#include > > #include > > #include > > #include > > -- > > 2.7.4 > >
Re: [PATCH] powerpc/powernv: Remove duplicate header
On Fri, Jan 18, 2019 at 3:34 PM Souptick Joarder wrote: > > On Thu, Jan 17, 2019 at 9:40 PM Sabyasachi Gupta > wrote: > > > > Remove linux/printk.h which is included more than once. > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > arch/powerpc/platforms/powernv/opal.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/powernv/opal.c > > b/arch/powerpc/platforms/powernv/opal.c > > index beed86f..802de0d 100644 > > --- a/arch/powerpc/platforms/powernv/opal.c > > +++ b/arch/powerpc/platforms/powernv/opal.c > > @@ -26,7 +26,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > -- > > 2.7.4 > >
Re: [PATCH] powerpc/cell: Remove duplicate header
On Thu, Jan 17, 2019 at 11:13 PM Souptick Joarder wrote: > > On Thu, Jan 17, 2019 at 9:49 PM Sabyasachi Gupta > wrote: > > > > Remove linux/syscalls.h which is included more than once > > > > Signed-off-by: Sabyasachi Gupta > > Acked-by: Souptick Joarder > If no further comment, can we get this patch in queue for 5.1 ? > > --- > > arch/powerpc/platforms/cell/spu_syscalls.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/cell/spu_syscalls.c > > b/arch/powerpc/platforms/cell/spu_syscalls.c > > index 263413a..b95d6af 100644 > > --- a/arch/powerpc/platforms/cell/spu_syscalls.c > > +++ b/arch/powerpc/platforms/cell/spu_syscalls.c > > @@ -26,7 +26,6 @@ > > #include > > #include > > #include > > -#include > > > > #include > > > > -- > > 2.7.4 > >
[PATCH] powerpc/powernv: Remove duplicate header
Remove linux/printk.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- arch/powerpc/platforms/powernv/opal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index beed86f..802de0d 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include -- 2.7.4
[PATCH] powerpc/cell: Remove duplicate header
Remove linux/syscalls.h which is included more than once Signed-off-by: Sabyasachi Gupta --- arch/powerpc/platforms/cell/spu_syscalls.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/cell/spu_syscalls.c b/arch/powerpc/platforms/cell/spu_syscalls.c index 263413a..b95d6af 100644 --- a/arch/powerpc/platforms/cell/spu_syscalls.c +++ b/arch/powerpc/platforms/cell/spu_syscalls.c @@ -26,7 +26,6 @@ #include #include #include -#include #include -- 2.7.4
[PATCH] sh: Remove duplicate header
Remove linux/irq.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- arch/sh/boards/mach-dreamcast/irq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sh/boards/mach-dreamcast/irq.c b/arch/sh/boards/mach-dreamcast/irq.c index 2789647..69fa91c 100644 --- a/arch/sh/boards/mach-dreamcast/irq.c +++ b/arch/sh/boards/mach-dreamcast/irq.c @@ -10,7 +10,6 @@ */ #include #include -#include #include #include #include -- 2.7.4
[PATCH] tools/testing/selftests/x86/unwind_vdso.c: Remove duplicate header
Remove sys/ucontext.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- tools/testing/selftests/x86/unwind_vdso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/x86/unwind_vdso.c b/tools/testing/selftests/x86/unwind_vdso.c index 00a26a8..9731133 100644 --- a/tools/testing/selftests/x86/unwind_vdso.c +++ b/tools/testing/selftests/x86/unwind_vdso.c @@ -44,7 +44,6 @@ int main() #include #include #include -#include #include #include #include -- 2.7.4
[PATCH] um: Remove duplicate headers
Remove sys/socket.h and sys/uio.h which are included more than once Signed-off-by: Sabyasachi Gupta --- arch/um/drivers/vector_user.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c index d2c17dd..c863921 100644 --- a/arch/um/drivers/vector_user.c +++ b/arch/um/drivers/vector_user.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -31,7 +30,6 @@ #include #include #include -#include #include "vector_user.h" #define ID_GRE 0 -- 2.7.4
[PATCH] mm: Remove duplicate header
Remove linux/ptrace.h which is included more than once Signed-off-by: Sabyasachi Gupta --- arch/nios2/mm/fault.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/nios2/mm/fault.c b/arch/nios2/mm/fault.c index 24fd84c..eb65f17 100644 --- a/arch/nios2/mm/fault.c +++ b/arch/nios2/mm/fault.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include -- 2.7.4
[PATCH] mm: Remove duplicate headers
Remove asm/sections.h and asm/fixmap.h which are included more than once Signed-off-by: Sabyasachi Gupta --- arch/arm/mm/mmu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index fcded2c..29035f4 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -36,7 +35,6 @@ #include #include #include -#include #include "fault.h" #include "mm.h" -- 2.7.4
[PATCH] ARM: Remove duplicate header
Remove linux/tty.h which is included more than once Signed-off-by: Sabyasachi Gupta --- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c index 643d5f2..0016d25 100644 --- a/arch/arm/mach-sa1100/hackkit.c +++ b/arch/arm/mach-sa1100/hackkit.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include -- 2.7.4
[PATCH] drivers/usb/storage/cypress_atacb.c: Remove duplicate header
Remove unusual_cypress.h which is included more than once.
Signed-off-by: Sabyasachi Gupta
---
drivers/usb/storage/cypress_atacb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/storage/cypress_atacb.c
b/drivers/usb/storage/cypress_atacb.c
index 4825902..be2e346 100644
--- a/drivers/usb/storage/cypress_atacb.c
+++ b/drivers/usb/storage/cypress_atacb.c
@@ -55,7 +55,6 @@ MODULE_DEVICE_TABLE(usb, cypress_usb_ids);
}
static struct us_unusual_dev cypress_unusual_dev_list[] = {
-# include "unusual_cypress.h"
{ } /* Terminating entry */
};
--
2.7.4
[PATCH] drivers/usb/storage: Remove duplicate headers
Remove duplicate headers which are included more than once.
Signed-off-by: Sabyasachi Gupta
---
drivers/usb/storage/datafab.c| 1 -
drivers/usb/storage/ene_ub6250.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
index 09353be..4b1bd56 100644
--- a/drivers/usb/storage/datafab.c
+++ b/drivers/usb/storage/datafab.c
@@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
}
static struct us_unusual_dev datafab_unusual_dev_list[] = {
-# include "unusual_datafab.h"
{ } /* Terminating entry */
};
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 4d261e4..79a07bf 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -65,7 +65,6 @@ MODULE_DEVICE_TABLE(usb, ene_ub6250_usb_ids);
}
static struct us_unusual_dev ene_ub6250_unusual_dev_list[] = {
-# include "unusual_ene_ub6250.h"
{ } /* Terminating entry */
};
--
2.7.4
[PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header
Remove unusual_jumpshot.h which is included more than once.
Signed-off-by: Sabyasachi Gupta
---
drivers/usb/storage/jumpshot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
index 917f170..06e46c6 100644
--- a/drivers/usb/storage/jumpshot.c
+++ b/drivers/usb/storage/jumpshot.c
@@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
}
static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
-# include "unusual_jumpshot.h"
{ } /* Terminating entry */
};
--
2.7.4
[PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header
Remove unusual_sddr55.h which is included more than once
Signed-off-by: Sabyasachi Gupta
---
drivers/usb/storage/sddr55.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
index b8527c5..96bf7ee 100644
--- a/drivers/usb/storage/sddr55.c
+++ b/drivers/usb/storage/sddr55.c
@@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids);
}
static struct us_unusual_dev sddr55_unusual_dev_list[] = {
-# include "unusual_sddr55.h"
{ } /* Terminating entry */
};
--
2.7.4
[PATCH] fs/block_dev.c: Remove duplicate header
Remove linux/dax.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- fs/block_dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index cdda48f..8abcdb6 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include -- 2.7.4
[PATCH] arch/sh/boards/mach-dreamcast/irq.c: Remove duplicate header
Remove linux/irq.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- arch/sh/boards/mach-dreamcast/irq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sh/boards/mach-dreamcast/irq.c b/arch/sh/boards/mach-dreamcast/irq.c index 2789647..69fa91c 100644 --- a/arch/sh/boards/mach-dreamcast/irq.c +++ b/arch/sh/boards/mach-dreamcast/irq.c @@ -10,7 +10,6 @@ */ #include #include -#include #include #include #include -- 2.7.4
Re: [PATCH] fs/block_dev.c: Remove duplicate header
On Wed, Jan 30, 2019 at 7:56 AM Sabyasachi Gupta wrote: > > On Wed, Jan 16, 2019 at 5:46 PM Souptick Joarder wrote: > > > > On Thu, Jan 10, 2019 at 8:55 PM Sabyasachi Gupta > > wrote: > > > > > > Remove linux/dax.h which is included more than once. > > > > > > Signed-off-by: Sabyasachi Gupta > > > > Acked-by: Souptick Joarder > > > If no further comment, can we get this patch in queue for 5.1 ? If no further comment, can we get this patch in queue for 5.1 ? > > > --- > > > fs/block_dev.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/fs/block_dev.c b/fs/block_dev.c > > > index cdda48f..8abcdb6 100644 > > > --- a/fs/block_dev.c > > > +++ b/fs/block_dev.c > > > @@ -29,7 +29,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > #include > > > #include > > > #include > > > -- > > > 2.7.4 > > >
Re: [PATCH] fs/cachefiles/namei.c: Remove duplicate header
On Wed, Jan 30, 2019 at 7:59 AM Sabyasachi Gupta wrote: > > On Mon, Jan 14, 2019 at 1:34 PM Souptick Joarder wrote: > > > > On Fri, Jan 11, 2019 at 12:12 PM Sabyasachi Gupta > > wrote: > > > > > > Remove linux/xattr.h which is included more than once > > > > > > Signed-off-by: Sabyasachi Gupta > > > > Acked-by: Souptick Joarder > > > If no further comment, can we get this patch in queue for 5.1 ? If no further comment, can we get this patch in queue for 5.1 ? > > > --- > > > fs/cachefiles/namei.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c > > > index 95983c7..edecb7f 100644 > > > --- a/fs/cachefiles/namei.c > > > +++ b/fs/cachefiles/namei.c > > > @@ -20,7 +20,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > #include "internal.h" > > > > > > #define CACHEFILES_KEYBUF_SIZE 512 > > > -- > > > 2.7.4 > > >
Re: [PATCH] fs/coda/psdev.c: Remove duplicate header
On Wed, Jan 30, 2019 at 8:01 AM Sabyasachi Gupta wrote: > > On Mon, Jan 14, 2019 at 1:40 PM Souptick Joarder wrote: > > > > On Fri, Jan 11, 2019 at 8:59 PM Sabyasachi Gupta > > wrote: > > > > > > Remove linux/poll.h which is included more than once > > > > > > Signed-off-by: Sabyasachi Gupta > > > > Acked-by: Souptick Joarder > > > If no further comment, can we get this patch in queue for 5.1 ? If no further comment, can we get this patch in queue for 5.1 ? > > > --- > > > fs/coda/psdev.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c > > > index c5234c2..f2bb798 100644 > > > --- a/fs/coda/psdev.c > > > +++ b/fs/coda/psdev.c > > > @@ -39,7 +39,6 @@ > > > #include > > > #include > > > #include > > > -#include > > > #include > > > > > > #include > > > -- > > > 2.7.4 > > >
Re: [PATCH] sh: Remove duplicate header
On Wed, Jan 30, 2019 at 8:04 AM Sabyasachi Gupta wrote: > > On Thu, Jan 17, 2019 at 11:11 PM Souptick Joarder > wrote: > > > > On Thu, Jan 17, 2019 at 9:57 PM Sabyasachi Gupta > > wrote: > > > > > > Remove linux/irq.h which is included more than once. > > > > > > Signed-off-by: Sabyasachi Gupta > > > > Acked-by: Souptick Joarder > > > If no further comment, can we get this patch in queue for 5.1 ? If no further comment, can we get this patch in queue for 5.1 ? > > > --- > > > arch/sh/boards/mach-dreamcast/irq.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/sh/boards/mach-dreamcast/irq.c > > > b/arch/sh/boards/mach-dreamcast/irq.c > > > index 2789647..69fa91c 100644 > > > --- a/arch/sh/boards/mach-dreamcast/irq.c > > > +++ b/arch/sh/boards/mach-dreamcast/irq.c > > > @@ -10,7 +10,6 @@ > > > */ > > > #include > > > #include > > > -#include > > > #include > > > #include > > > #include > > > -- > > > 2.7.4 > > >
[PATCH] fs/block_dev.c: Remove duplicate header
Remove linux/dax.h which is included more than once. Signed-off-by: Sabyasachi Gupta --- fs/block_dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index cdda48f..8abcdb6 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include -- 2.7.4
[PATCH] fs/cachefiles/namei.c: Remove duplicate header
Remove linux/xattr.h which is included more than once Signed-off-by: Sabyasachi Gupta --- fs/cachefiles/namei.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index 95983c7..edecb7f 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c @@ -20,7 +20,6 @@ #include #include #include -#include #include "internal.h" #define CACHEFILES_KEYBUF_SIZE 512 -- 2.7.4
[PATCH] fs/coda/psdev.c: Remove duplicate header
Remove linux/poll.h which is included more than once Signed-off-by: Sabyasachi Gupta --- fs/coda/psdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index c5234c2..f2bb798 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -39,7 +39,6 @@ #include #include #include -#include #include #include -- 2.7.4
